Add PMIC support to MediaTek MT7622 SoC
v2 cover Add PMIC support to MediaTek MT7622 SoC
From: Sean Wang <[email protected]>
Changes since v1:
- enhnace MT6380 regulator dt-binding document following suggestions in the v1.
- revise pwrap_init with slave programing options
- remove mt6380_get_status() and relevant accessed members
- remove debug code in mt6380_regulator_set_mode()
- make regulator driver should never modify constraints
- revise mode mapping between REGULATOR_MODE_NORMAL and MT6380_REGULATOR_MODE
By default, the relevant board with MediaTek MT7622 SoC is equipped with MediaTek MT6380 PMIC. So the series enables related driver allows the MT6380 can be accessed and controlled through MediaTek PMIC wrapper by those function drivers on MT7622 SoC.
Patch 1-2: Update dt-binding document for PMIC Wrapper and MT6380 regulator. Patch 3: Add a new driver for MT6380 regulator. Patch 4-7: Update operations in PMIC Wrapper in order to adapt into MT6380. Patch 8: Add support of MT7622 platform for PMIC Wrapper Patch 9: Fix warning complained from checkpatch.pl.
Chenglin Xu (2):
regulator: mt6380: Add support for MT6380
soc: mediatek: pwrap: add support for MT7622 SoC
Sean Wang (7):
dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc
dt-bindings: regulator: Add document for MediaTek MT6380 regulator
soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode
soc: mediatek: pwrap: add pwrap_write32 for writing in 32-bit mode
soc: mediatek: pwrap: update pwrap_init without slave programming
soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap
soc: mediatek: pwrap: fixup warnings from coding style
.../bindings/regulator/mt6380-regulator.txt | 90 +++++ .../devicetree/bindings/soc/mediatek/pwrap.txt | 4 + drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6380-regulator.c | 359 ++++++++++++++++++ drivers/soc/mediatek/mtk-pmic-wrap.c | 416 ++++++++++++++++++--- include/linux/regulator/mt6380-regulator.h | 32 ++ 7 files changed, 856 insertions(+), 55 deletions(-) create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt create mode 100644 drivers/regulator/mt6380-regulator.c create mode 100644 include/linux/regulator/mt6380-regulator.h
Signature · 1 line
2.7.4
PATCH v2 1/9 dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc
From: Sean Wang <[email protected]>
--- Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt +4 -0
@@ -35,6 +35,10 @@ Required properties in pwrap device node. "wrap": Main module clock - clocks: Must contain an entry for each entry in clock-names. +Required properties in pwrap device node +- compatible: + "mediatek,mt7622-pwrap" for MT7622 SoCs + Optional properities: - pmic: Mediatek PMIC MFD is the child device of pwrap See the following for child node definitions:
Signature · 1 line
2.7.4
PATCH v2 2/9 dt-bindings: regulator: Add document for MediaTek MT6380 regulator
In reply to [email protected]From: Sean Wang <[email protected]>
add dt-binding document for MediaTek MT6380 PMIC
--- .../bindings/regulator/mt6380-regulator.txt | 90 ++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +90 -0
@@ -0,0 +1,90 @@ +MediaTek MT6380 Regulator Driver + +All voltage regulators are defined as subnodes of the regulators node. A list +of regulators provided by this controller are defined as subnodes of the +PMIC's node. Each regulator is named according to its regulator type, +buck-<name> and ldo-<name>. The definition for each of these nodes is defined +using the standard binding for regulators at +Documentation/devicetree/bindings/regulator/regulator.txt. + +The valid names for regulators are: +BUCK: + buck-core1, buck-vcore, buck-vrf +LDO: + ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt + +Example: + + regulators { + compatible = "mediatek,mt6380-regulator"; + + mt6380_vcpu_reg: buck-vcore1 { + regulator-name = "vcore1"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1393750>; + regulator-ramp-delay = <6250>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vcore_reg: buck-vcore { + regulator-name = "vcore"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1393750>; + regulator-ramp-delay = <6250>; + }; + + mt6380_vrf_reg: buck-vrf { + regulator-name = "vrf"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1575000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vm_reg: ldo-vm { + regulator-name = "vm"; + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1400000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_va_reg: ldo-va { + regulator-name = "va"; + regulator-min-microvolt = <2200000>; + regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vphy_reg: ldo-vphy { + regulator-name = "vphy"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vddr_reg: ldo-vddr { + regulator-name = "vddr"; + regulator-min-microvolt = <1240000>; + regulator-max-microvolt = <1840000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vt_reg: ldo-vt { + regulator-name = "vt"; + regulator-min-microvolt = <2200000>; + regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + };
Signature · 1 line
2.7.4
PATCH v2 3/9 regulator: mt6380: Add support for MT6380
In reply to [email protected]From: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/[email protected]>
The MT6380 is a regulator found those boards with MediaTek MT7622 SoC It is connected as a slave to the SoC using MediaTek PMIC wrapper which is the common interface connecting with Mediatek made various PMICs.
--- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6380-regulator.c | 359 +++++++++++++++++++++++++++++ include/linux/regulator/mt6380-regulator.h | 32 +++ 4 files changed, 401 insertions(+) create mode 100644 drivers/regulator/mt6380-regulator.c create mode 100644 include/linux/regulator/mt6380-regulator.h
drivers/regulator/Kconfig +9 -0
@@ -541,6 +541,15 @@ config REGULATOR_MT6323 This driver supports the control of different power rails of device through regulator interface. +config REGULATOR_MT6380 + tristate "MediaTek MT6380 PMIC" + depends on MTK_PMIC_WRAP + help + Say y here to select this option to enable the power regulator of + MediaTek MT6380 PMIC. + This driver supports the control of different power rails of device + through regulator interface. + config REGULATOR_MT6397 tristate "MediaTek MT6397 PMIC" depends on MFD_MT6397
drivers/regulator/Makefile +1 -0
@@ -70,6 +70,7 @@ obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o obj-$(CONFIG_REGULATOR_MC13XXX_CORE) += mc13xxx-regulator-core.o obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o +obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o
drivers/regulator/mt6380-regulator.c new file +359 -0
359 lines not on this page · raw message
include/linux/regulator/mt6380-regulator.h new file +32 -0
@@ -0,0 +1,32 @@ +/* +* Copyright (c) 2017 MediaTek Inc. +* Author: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +#ifndef __LINUX_REGULATOR_mt6380_H +#define __LINUX_REGULATOR_mt6380_H + +enum { +MT6380_ID_VCPU =0 , +MT6380_ID_VCORE , +MT6380_ID_VRF , +MT6380_ID_VMLDO , +MT6380_ID_VALDO , +MT6380_ID_VPHYLDO , +MT6380_ID_VDDRLDO , +MT6380_ID_VTLDO , +MT6380_ID_RG_MAX , +}; + +#define MT6380_MAX_REGULATOR MT6380_ID_RG_MAX + +#endif /* __LINUX_REGULATOR_mt6380_H */
Signature · 6 lines
2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 4/9 soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode
In reply to [email protected]From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]>
Some regulators such as MediaTek MT6380 has to be read in 32-bit mode. So the patch adds pwrap_read32, rename old pwrap_read into pwrap_read16 and one function pointer is introduced for increasing flexibility allowing the determination which mode is used by the pwrap slave detection through device tree.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 54 +++++++++++++++++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +53 -1
@@ -487,6 +487,7 @@ static int mt8135_regs[] = {enum pmic_type {PMIC_MT6323 , +PMIC_MT6380 ,PMIC_MT6397 , };
@@ -496,9 +497,15 @@ enum pwrap_type { PWRAP_MT8173, }; +struct pmic_wrapper ;struct pwrap_slv_type {const u32 *dew_regs;enum pmic_type type; +/* pwrap operations are highly associated with the PMIC types, +* so the pointers added increases flexibility allowing determination +* which type is used by the detection through device tree. +*/ +int (*pwrap_read)(struct pmic_wrapper *wrp,u32 adr,u32 *rdata); };struct pmic_wrapper {
@@ -609,7 +616,7 @@ static int pwrap_write(struct pmic_wrapper *wrp, u32 adr, u32 wdata)return 0 ; } -static int pwrap_read (struct pmic_wrapper *wrp,u32 adr,u32 *rdata) +static int pwrap_read16 (struct pmic_wrapper *wrp,u32 adr,u32 *rdata) {int ret;
@@ -632,6 +639,39 @@ static int pwrap_read(struct pmic_wrapper *wrp, u32 adr, u32 *rdata)return 0 ; } +static int pwrap_read32 (struct pmic_wrapper *wrp,u32 adr,u32 *rdata) +{ +int ret, msb; + + *rdata =0 ; +for (msb =0 ; msb <2 ; msb++) { + ret =pwrap_wait_for_state (wrp, pwrap_is_fsm_idle); +if (ret) { +pwrap_leave_fsm_vldclr (wrp); +return ret; + } + +pwrap_writel (wrp, ((msb <<30 ) | (adr <<16 )), +PWRAP_WACS2_CMD ); + + ret =pwrap_wait_for_state (wrp, pwrap_is_fsm_vldclr); +if (ret) +return ret; + + *rdata += (PWRAP_GET_WACS_RDATA (pwrap_readl (wrp, +PWRAP_WACS2_RDATA )) << (16 * msb)); + +pwrap_writel (wrp,1 ,PWRAP_WACS2_VLDCLR ); + } + +return 0 ; +} + +static int pwrap_read (struct pmic_wrapper *wrp,u32 adr,u32 *rdata) +{ +return wrp->slave->pwrap_read (wrp, adr, rdata); +} +static int pwrap_regmap_read (void *context,u32 adr,u32 *rdata) {return pwrap_read (context, adr, rdata);
@@ -752,6 +792,8 @@ static int pwrap_mt2701_init_reg_clock(struct pmic_wrapper *wrp)pwrap_writel (wrp,0x2 ,PWRAP_CSLEXT_START );pwrap_writel (wrp,0x2 ,PWRAP_CSLEXT_END );break ; +default : +break ; }return 0 ;
@@ -815,6 +857,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)pwrap_write (wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_EN ],0x1 );break ; +default : +break ; }/* wait for cipher data ready@AP */
@@ -1035,11 +1079,19 @@ static const struct regmap_config pwrap_regmap_config = {static const struct pwrap_slv_type pmic_mt6323 = { .dew_regs = mt6323_regs, .type =PMIC_MT6323 , + .pwrap_read = pwrap_read16, +}; + +static const struct pwrap_slv_type pmic_mt6380 = { + .dew_regs =NULL , + .type =PMIC_MT6380 , + .pwrap_read = pwrap_read32, };static const struct pwrap_slv_type pmic_mt6397 = { .dew_regs = mt6397_regs, .type =PMIC_MT6397 , + .pwrap_read = pwrap_read16, };static const struct of_device_id of_slave_match_tbl[] = {
Signature · 6 lines
2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 5/9 soc: mediatek: pwrap: add pwrap_write32 for writing in 32-bit mode
In reply to [email protected]From: Sean Wang <[email protected]>
Some regulators such as MediaTek MT6380 also has to be written in 32-bit mode. So the patch adds pwrap_write32, rename old pwrap_write into pwrap_write16 and one additional function pointer is introduced for increasing flexibility allowing the determination which mode is used by the pwrap slave detection through device tree.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 63 +++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 16 deletions(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +47 -16
@@ -506,6 +506,7 @@ struct pwrap_slv_type {* which type is used by the detection through device tree. */ int (*pwrap_read)(struct pmic_wrapper *wrp,u32 adr,u32 *rdata); +int (*pwrap_write)(struct pmic_wrapper *wrp,u32 adr,u32 wdata); };struct pmic_wrapper {
@@ -600,22 +601,6 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp, }while (1 ); } -static int pwrap_write (struct pmic_wrapper *wrp,u32 adr,u32 wdata) -{ -int ret; - - ret =pwrap_wait_for_state (wrp, pwrap_is_fsm_idle); -if (ret) { -pwrap_leave_fsm_vldclr (wrp); -return ret; - } - -pwrap_writel (wrp, (1 <<31 ) | ((adr >>1 ) <<16 ) | wdata, -PWRAP_WACS2_CMD ); - -return 0 ; -} -static int pwrap_read16 (struct pmic_wrapper *wrp,u32 adr,u32 *rdata) {int ret;
@@ -672,6 +657,49 @@ static int pwrap_read(struct pmic_wrapper *wrp, u32 adr, u32 *rdata)return wrp->slave->pwrap_read (wrp, adr, rdata); } +static int pwrap_write16 (struct pmic_wrapper *wrp,u32 adr,u32 wdata) +{ +int ret; + + ret =pwrap_wait_for_state (wrp, pwrap_is_fsm_idle); +if (ret) { +pwrap_leave_fsm_vldclr (wrp); +return ret; + } + +pwrap_writel (wrp, (1 <<31 ) | ((adr >>1 ) <<16 ) | wdata, +PWRAP_WACS2_CMD ); + +return 0 ; +} + +static int pwrap_write32 (struct pmic_wrapper *wrp,u32 adr,u32 wdata) +{ +int ret, msb, rdata; + +for (msb =0 ; msb <2 ; msb++) { + ret =pwrap_wait_for_state (wrp, pwrap_is_fsm_idle); +if (ret) { +pwrap_leave_fsm_vldclr (wrp); +return ret; + } + +pwrap_writel (wrp, (1 <<31 ) | (msb <<30 ) | (adr <<16 ) | + ((wdata >> (msb *16 )) &0xffff ), +PWRAP_WACS2_CMD ); + +if (!msb) +pwrap_read (wrp, adr, &rdata); + } + +return 0 ; +} + +static int pwrap_write (struct pmic_wrapper *wrp,u32 adr,u32 wdata) +{ +return wrp->slave->pwrap_write (wrp, adr, wdata); +} +static int pwrap_regmap_read (void *context,u32 adr,u32 *rdata) {return pwrap_read (context, adr, rdata);
@@ -1080,18 +1108,21 @@ static const struct pwrap_slv_type pmic_mt6323 = { .dew_regs = mt6323_regs, .type = PMIC_MT6323, .pwrap_read = pwrap_read16, + .pwrap_write = pwrap_write16, };static const struct pwrap_slv_type pmic_mt6380 = { .dew_regs =NULL , .type =PMIC_MT6380 , .pwrap_read = pwrap_read32, + .pwrap_write = pwrap_write32, };static const struct pwrap_slv_type pmic_mt6397 = { .dew_regs = mt6397_regs, .type =PMIC_MT6397 , .pwrap_read = pwrap_read16, + .pwrap_write = pwrap_write16, };static const struct of_device_id of_slave_match_tbl[] = {
Signature · 1 line
2.7.4
PATCH v2 6/9 soc: mediatek: pwrap: update pwrap_init without slave programming
In reply to [email protected]From: Sean Wang <[email protected]>
pwrap initialization is highly associated with the base SoC, so update here for allowing pwrap_init without slave program which would be used to those PMICs without extra encryption on bus such as MT6380.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 91 +++++++++++++++++++++--------------- 1 file changed, 54 insertions(+), 37 deletions(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +54 -37
@@ -531,6 +531,7 @@ struct pmic_wrapper_type {u32 spi_w;u32 wdt_src; int has_bridge:1; + int slv_program:1;int (*init_reg_clock)(struct pmic_wrapper *wrp);int (*init_soc_specific)(struct pmic_wrapper *wrp); };
@@ -999,9 +1000,12 @@ static int pwrap_init(struct pmic_wrapper *wrp) }/* Reset SPI slave */ - ret =pwrap_reset_spislave (wrp); -if (ret) -return ret; + +if (wrp->master->slv_program) { + ret =pwrap_reset_spislave (wrp); +if (ret) +return ret; + }pwrap_writel (wrp,1 ,PWRAP_WRAP_EN );
@@ -1013,45 +1017,52 @@ static int pwrap_init(struct pmic_wrapper *wrp)if (ret)return ret; -/* Setup serial input delay */ - ret =pwrap_init_sidly (wrp); -if (ret) -return ret; +if (wrp->master->slv_program) { +/* Setup serial input delay */ + ret =pwrap_init_sidly (wrp); +if (ret) +return ret; -/* Enable dual IO mode */ -pwrap_write (wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN ],1 ); +/* Enable dual IO mode */ +pwrap_write (wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN ],1 ); -/* Check IDLE & INIT_DONE in advance */ - ret =pwrap_wait_for_state (wrp, pwrap_is_fsm_idle_and_sync_idle); -if (ret) { -dev_err (wrp->dev,"%s fail, ret=%d\n" , __func__, ret); -return ret; - } +/* Check IDLE & INIT_DONE in advance */ + ret =pwrap_wait_for_state (wrp, + pwrap_is_fsm_idle_and_sync_idle); +if (ret) { +dev_err (wrp->dev,"%s fail, ret=%d\n" , __func__, ret); +return ret; + } -pwrap_writel (wrp,1 ,PWRAP_DIO_EN ); +pwrap_writel (wrp,1 ,PWRAP_DIO_EN ); -/* Read Test */ -pwrap_read (wrp, wrp->slave->dew_regs[PWRAP_DEW_READ_TEST ], &rdata); -if (rdata !=PWRAP_DEW_READ_TEST_VAL ) { -dev_err (wrp->dev,"Read test failed after switch to DIO mode: 0x%04x != 0x%04x\n" , +/* Read Test */ +pwrap_read (wrp, + wrp->slave->dew_regs[PWRAP_DEW_READ_TEST ], &rdata); +if (rdata !=PWRAP_DEW_READ_TEST_VAL ) { +dev_err (wrp->dev, +"Read failed on DIO mode: 0x%04x!=0x%04x\n" ,PWRAP_DEW_READ_TEST_VAL , rdata); -return -EFAULT ; - } - -/* Enable encryption */ - ret =pwrap_init_cipher (wrp); -if (ret) -return ret; +return -EFAULT ; + } -/* Signature checking - using CRC */ -if (pwrap_write (wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_EN ],0x1 )) -return -EFAULT ; +/* Enable encryption */ + ret =pwrap_init_cipher (wrp); +if (ret) +return ret; -pwrap_writel (wrp,0x1 ,PWRAP_CRC_EN ); -pwrap_writel (wrp,0x0 ,PWRAP_SIG_MODE ); -pwrap_writel (wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL ], -PWRAP_SIG_ADR ); -pwrap_writel (wrp, wrp->master->arb_en_all,PWRAP_HIPRIO_ARB_EN ); +/* Signature checking - using CRC */ +if (pwrap_write (wrp, + wrp->slave->dew_regs[PWRAP_DEW_CRC_EN ],0x1 )) +return -EFAULT ; + +pwrap_writel (wrp,0x1 ,PWRAP_CRC_EN ); +pwrap_writel (wrp,0x0 ,PWRAP_SIG_MODE ); +pwrap_writel (wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL ], +PWRAP_SIG_ADR ); +pwrap_writel (wrp, + wrp->master->arb_en_all,PWRAP_HIPRIO_ARB_EN ); + }if (wrp->master->type ==PWRAP_MT8135 )pwrap_writel (wrp,0x7 ,PWRAP_RRARB_EN );
@@ -1059,8 +1070,11 @@ static int pwrap_init(struct pmic_wrapper *wrp)pwrap_writel (wrp,0x1 ,PWRAP_WACS0_EN );pwrap_writel (wrp,0x1 ,PWRAP_WACS1_EN );pwrap_writel (wrp,0x1 ,PWRAP_WACS2_EN ); -pwrap_writel (wrp,0x5 ,PWRAP_STAUPD_PRD ); -pwrap_writel (wrp,0xff ,PWRAP_STAUPD_GRPEN ); + +if (wrp->master->slv_program) { +pwrap_writel (wrp,0x5 ,PWRAP_STAUPD_PRD ); +pwrap_writel (wrp,0xff ,PWRAP_STAUPD_GRPEN ); + }if (wrp->master->init_soc_specific) { ret = wrp->master->init_soc_specific (wrp);
@@ -1146,6 +1160,7 @@ static const struct pmic_wrapper_type pwrap_mt2701 = { .spi_w = PWRAP_MAN_CMD_SPI_WRITE_NEW, .wdt_src = PWRAP_WDT_SRC_MASK_ALL, .has_bridge = 0, + .slv_program = 1, .init_reg_clock = pwrap_mt2701_init_reg_clock, .init_soc_specific = pwrap_mt2701_init_soc_specific, };
@@ -1158,6 +1173,7 @@ static struct pmic_wrapper_type pwrap_mt8135 = { .spi_w = PWRAP_MAN_CMD_SPI_WRITE, .wdt_src = PWRAP_WDT_SRC_MASK_ALL, .has_bridge = 1, + .slv_program = 1, .init_reg_clock = pwrap_mt8135_init_reg_clock, .init_soc_specific = pwrap_mt8135_init_soc_specific, };
@@ -1170,6 +1186,7 @@ static struct pmic_wrapper_type pwrap_mt8173 = { .spi_w = PWRAP_MAN_CMD_SPI_WRITE, .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD, .has_bridge = 0, + .slv_program = 1, .init_reg_clock = pwrap_mt8173_init_reg_clock, .init_soc_specific = pwrap_mt8173_init_soc_specific, };
Signature · 1 line
2.7.4
PATCH v2 7/9 soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap
In reply to [email protected]From: Sean Wang <[email protected]>
Add MediaTek MT6380 regulator becoming one of PMIC wrapper slave and also add extra new regmap_config of 32-bit mode for MT6380 since old regmap_config of 16-bit mode can't be fit into the need.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +22 -2
@@ -501,6 +501,7 @@ struct pmic_wrapper;struct pwrap_slv_type {const u32 *dew_regs;enum pmic_type type; +const struct regmap_config *regmap;/* pwrap operations are highly associated with the PMIC types, * so the pointers added increases flexibility allowing determination * which type is used by the detection through device tree.
@@ -1109,7 +1110,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id)return IRQ_HANDLED ; } -static const struct regmap_config pwrap_regmap_config = { +static const struct regmap_config pwrap_regmap_config16 = { .reg_bits =16 , .val_bits =16 , .reg_stride =2 ,
@@ -1118,9 +1119,19 @@ static const struct regmap_config pwrap_regmap_config = { .max_register = 0xffff, }; +static const struct regmap_config pwrap_regmap_config32 = { + .reg_bits =32 , + .val_bits =32 , + .reg_stride =4 , + .reg_read = pwrap_regmap_read, + .reg_write = pwrap_regmap_write, + .max_register =0xffff , +}; +static const struct pwrap_slv_type pmic_mt6323 = { .dew_regs = mt6323_regs, .type =PMIC_MT6323 , + .regmap = &pwrap_regmap_config16, .pwrap_read = pwrap_read16, .pwrap_write = pwrap_write16, };
@@ -1128,6 +1139,7 @@ static const struct pwrap_slv_type pmic_mt6323 = {static const struct pwrap_slv_type pmic_mt6380 = { .dew_regs =NULL , .type =PMIC_MT6380 , + .regmap = &pwrap_regmap_config32, .pwrap_read = pwrap_read32, .pwrap_write = pwrap_write32, };
@@ -1135,6 +1147,7 @@ static const struct pwrap_slv_type pmic_mt6380 = {static const struct pwrap_slv_type pmic_mt6397 = { .dew_regs = mt6397_regs, .type =PMIC_MT6397 , + .regmap = &pwrap_regmap_config16, .pwrap_read = pwrap_read16, .pwrap_write = pwrap_write16, };
@@ -1147,6 +1160,13 @@ static const struct of_device_id of_slave_match_tbl[] = { .compatible = "mediatek,mt6397", .data = &pmic_mt6397, }, { +/* The MT6380 slave device is directly pointed to regulator +* device which is different from the cases MT6323 and MT6397 +* since they're one kind of MFDs. +*/ + .compatible = "mediatek,mt6380-regulator", + .data = &pmic_mt6380, + }, {/* sentinel */ } };
@@ -1319,7 +1339,7 @@ static int pwrap_probe(struct platform_device *pdev)if (ret) goto err_out2; - wrp->regmap =devm_regmap_init (wrp->dev,NULL , wrp, &pwrap_regmap_config); + wrp->regmap =devm_regmap_init (wrp->dev,NULL , wrp, wrp->slave->regmap);if (IS_ERR (wrp->regmap))return PTR_ERR (wrp->regmap);
Signature · 1 line
2.7.4
PATCH v2 8/9 soc: mediatek: pwrap: add support for MT7622 SoC
In reply to [email protected]From: Chenglin Xu <[email protected]>
Add the registers, callbacks and data structures required to make the PMIC wrapper work on MT7622.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 180 +++++++++++++++++++++++++++++++++++ 1 file changed, 180 insertions(+)
drivers/soc/mediatek/mtk-pmic-wrap.c +180 -0
@@ -242,6 +242,36 @@ enum pwrap_regs {PWRAP_DVFS_WDATA7 ,PWRAP_SPMINF_STA ,PWRAP_CIPHER_EN , + +/* MT7622 only regs */ +PWRAP_EINT_STA0_ADR , +PWRAP_EINT_STA1_ADR , +PWRAP_STA , +PWRAP_CLR , +PWRAP_DVFS_ADR8 , +PWRAP_DVFS_WDATA8 , +PWRAP_DVFS_ADR9 , +PWRAP_DVFS_WDATA9 , +PWRAP_DVFS_ADR10 , +PWRAP_DVFS_WDATA10 , +PWRAP_DVFS_ADR11 , +PWRAP_DVFS_WDATA11 , +PWRAP_DVFS_ADR12 , +PWRAP_DVFS_WDATA12 , +PWRAP_DVFS_ADR13 , +PWRAP_DVFS_WDATA13 , +PWRAP_DVFS_ADR14 , +PWRAP_DVFS_WDATA14 , +PWRAP_DVFS_ADR15 , +PWRAP_DVFS_WDATA15 , +PWRAP_EXT_CK , +PWRAP_ADC_RDATA_ADDR , +PWRAP_GPS_STA , +PWRAP_SW_RST , +PWRAP_DVFS_STEP_CTRL0 , +PWRAP_DVFS_STEP_CTRL1 , +PWRAP_DVFS_STEP_CTRL2 , + PWRAP_SPI2_CTRL, }; static int mt2701_regs[] = {
@@ -485,6 +515,118 @@ static int mt8135_regs[] = { [PWRAP_DCM_DBC_PRD] = 0x160, }; +static int mt7622_regs[] = { + [PWRAP_MUX_SEL ] =0x0 , + [PWRAP_WRAP_EN ] =0x4 , + [PWRAP_DIO_EN ] =0x8 , + [PWRAP_SIDLY ] =0xC , + [PWRAP_RDDMY ] =0x10 , + [PWRAP_SI_CK_CON ] =0x14 , + [PWRAP_CSHEXT_WRITE ] =0x18 , + [PWRAP_CSHEXT_READ ] =0x1C , + [PWRAP_CSLEXT_START ] =0x20 , + [PWRAP_CSLEXT_END ] =0x24 , + [PWRAP_STAUPD_PRD ] =0x28 , + [PWRAP_STAUPD_GRPEN ] =0x2C , + [PWRAP_EINT_STA0_ADR ] =0x30 , + [PWRAP_EINT_STA1_ADR ] =0x34 , + [PWRAP_STA ] =0x38 , + [PWRAP_CLR ] =0x3C , + [PWRAP_STAUPD_MAN_TRIG ] =0x40 , + [PWRAP_STAUPD_STA ] =0x44 , + [PWRAP_WRAP_STA ] =0x48 , + [PWRAP_HARB_INIT ] =0x4C , + [PWRAP_HARB_HPRIO ] =0x50 , + [PWRAP_HIPRIO_ARB_EN ] =0x54 , + [PWRAP_HARB_STA0 ] =0x58 , + [PWRAP_HARB_STA1 ] =0x5C , + [PWRAP_MAN_EN ] =0x60 , + [PWRAP_MAN_CMD ] =0x64 , + [PWRAP_MAN_RDATA ] =0x68 , + [PWRAP_MAN_VLDCLR ] =0x6C , + [PWRAP_WACS0_EN ] =0x70 , + [PWRAP_INIT_DONE0 ] =0x74 , + [PWRAP_WACS0_CMD ] =0x78 , + [PWRAP_WACS0_RDATA ] =0x7C , + [PWRAP_WACS0_VLDCLR ] =0x80 , + [PWRAP_WACS1_EN ] =0x84 , + [PWRAP_INIT_DONE1 ] =0x88 , + [PWRAP_WACS1_CMD ] =0x8C , + [PWRAP_WACS1_RDATA ] =0x90 , + [PWRAP_WACS1_VLDCLR ] =0x94 , + [PWRAP_WACS2_EN ] =0x98 , + [PWRAP_INIT_DONE2 ] =0x9C , + [PWRAP_WACS2_CMD ] =0xA0 , + [PWRAP_WACS2_RDATA ] =0xA4 , + [PWRAP_WACS2_VLDCLR ] =0xA8 , + [PWRAP_INT_EN ] =0xAC , + [PWRAP_INT_FLG_RAW ] =0xB0 , + [PWRAP_INT_FLG ] =0xB4 , + [PWRAP_INT_CLR ] =0xB8 , + [PWRAP_SIG_ADR ] =0xBC , + [PWRAP_SIG_MODE ] =0xC0 , + [PWRAP_SIG_VALUE ] =0xC4 , + [PWRAP_SIG_ERRVAL ] =0xC8 , + [PWRAP_CRC_EN ] =0xCC , + [PWRAP_TIMER_EN ] =0xD0 , + [PWRAP_TIMER_STA ] =0xD4 , + [PWRAP_WDT_UNIT ] =0xD8 , + [PWRAP_WDT_SRC_EN ] =0xDC , + [PWRAP_WDT_FLG ] =0xE0 , + [PWRAP_DEBUG_INT_SEL ] =0xE4 , + [PWRAP_DVFS_ADR0 ] =0xE8 , + [PWRAP_DVFS_WDATA0 ] =0xEC , + [PWRAP_DVFS_ADR1 ] =0xF0 , + [PWRAP_DVFS_WDATA1 ] =0xF4 , + [PWRAP_DVFS_ADR2 ] =0xF8 , + [PWRAP_DVFS_WDATA2 ] =0xFC , + [PWRAP_DVFS_ADR3 ] =0x100 , + [PWRAP_DVFS_WDATA3 ] =0x104 , + [PWRAP_DVFS_ADR4 ] =0x108 , + [PWRAP_DVFS_WDATA4 ] =0x10C , + [PWRAP_DVFS_ADR5 ] =0x110 , + [PWRAP_DVFS_WDATA5 ] =0x114 , + [PWRAP_DVFS_ADR6 ] =0x118 , + [PWRAP_DVFS_WDATA6 ] =0x11C , + [PWRAP_DVFS_ADR7 ] =0x120 , + [PWRAP_DVFS_WDATA7 ] =0x124 , + [PWRAP_DVFS_ADR8 ] =0x128 , + [PWRAP_DVFS_WDATA8 ] =0x12C , + [PWRAP_DVFS_ADR9 ] =0x130 , + [PWRAP_DVFS_WDATA9 ] =0x134 , + [PWRAP_DVFS_ADR10 ] =0x138 , + [PWRAP_DVFS_WDATA10 ] =0x13C , + [PWRAP_DVFS_ADR11 ] =0x140 , + [PWRAP_DVFS_WDATA11 ] =0x144 , + [PWRAP_DVFS_ADR12 ] =0x148 , + [PWRAP_DVFS_WDATA12 ] =0x14C , + [PWRAP_DVFS_ADR13 ] =0x150 , + [PWRAP_DVFS_WDATA13 ] =0x154 , + [PWRAP_DVFS_ADR14 ] =0x158 , + [PWRAP_DVFS_WDATA14 ] =0x15C , + [PWRAP_DVFS_ADR15 ] =0x160 , + [PWRAP_DVFS_WDATA15 ] =0x164 , + [PWRAP_SPMINF_STA ] =0x168 , + [PWRAP_CIPHER_KEY_SEL ] =0x16C , + [PWRAP_CIPHER_IV_SEL ] =0x170 , + [PWRAP_CIPHER_EN ] =0x174 , + [PWRAP_CIPHER_RDY ] =0x178 , + [PWRAP_CIPHER_MODE ] =0x17C , + [PWRAP_CIPHER_SWRST ] =0x180 , + [PWRAP_DCM_EN ] =0x184 , + [PWRAP_DCM_DBC_PRD ] =0x188 , + [PWRAP_EXT_CK ] =0x18C , + [PWRAP_ADC_CMD_ADDR ] =0x190 , + [PWRAP_PWRAP_ADC_CMD ] =0x194 , + [PWRAP_ADC_RDATA_ADDR ] =0x198 , + [PWRAP_GPS_STA ] =0x19C , + [PWRAP_SW_RST ] =0x1A0 , + [PWRAP_DVFS_STEP_CTRL0 ] =0x238 , + [PWRAP_DVFS_STEP_CTRL1 ] =0x23C , + [PWRAP_DVFS_STEP_CTRL2 ] =0x240 , + [PWRAP_SPI2_CTRL ] =0x244 , +}; +enum pmic_type {PMIC_MT6323 ,PMIC_MT6380 ,
@@ -493,6 +635,7 @@ enum pmic_type {enum pwrap_type {PWRAP_MT2701 , +PWRAP_MT7622 ,PWRAP_MT8135 ,PWRAP_MT8173 , };
@@ -829,6 +972,16 @@ static int pwrap_mt2701_init_reg_clock(struct pmic_wrapper *wrp)return 0 ; } +static int pwrap_mt7622_init_reg_clock (struct pmic_wrapper *wrp) +{ +pwrap_writel (wrp,0x0 ,PWRAP_CSHEXT_WRITE ); +pwrap_writel (wrp,0x4 ,PWRAP_CSHEXT_READ ); +pwrap_writel (wrp,0x2 ,PWRAP_CSLEXT_START ); +pwrap_writel (wrp,0x2 ,PWRAP_CSLEXT_END ); + +return 0 ; +} +static bool pwrap_is_cipher_ready (struct pmic_wrapper *wrp) {return pwrap_readl (wrp,PWRAP_CIPHER_RDY ) &1 ;
@@ -866,6 +1019,9 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)case PWRAP_MT8173 :pwrap_writel (wrp,1 ,PWRAP_CIPHER_EN );break ; +case PWRAP_MT7622 : +pwrap_writel (wrp,0 ,PWRAP_CIPHER_EN ); +break ; }/* Config cipher mode @PMIC */
@@ -985,6 +1141,15 @@ static int pwrap_mt2701_init_soc_specific(struct pmic_wrapper *wrp)return 0 ; } +static int pwrap_mt7622_init_soc_specific (struct pmic_wrapper *wrp) +{ +pwrap_writel (wrp,0 ,PWRAP_STAUPD_PRD ); +/*enable 2wire SPI master*/ +pwrap_writel (wrp,0x8000000 ,PWRAP_SPI2_CTRL ); + +return 0 ; +} +static int pwrap_init (struct pmic_wrapper *wrp) {int ret;
@@ -1211,6 +1376,18 @@ static struct pmic_wrapper_type pwrap_mt8173 = { .init_soc_specific = pwrap_mt8173_init_soc_specific, }; +static struct pmic_wrapper_type pwrap_mt7622 = { + .regs = mt7622_regs, + .type =PWRAP_MT7622 , + .arb_en_all =0xff , + .int_en_all = ~(u32 )BIT (31 ), + .spi_w =PWRAP_MAN_CMD_SPI_WRITE , + .wdt_src =PWRAP_WDT_SRC_MASK_ALL , + .has_bridge =0 , + .init_reg_clock = pwrap_mt7622_init_reg_clock, + .init_soc_specific = pwrap_mt7622_init_soc_specific, +}; +static struct of_device_id of_pwrap_match_tbl[] = { { .compatible ="mediatek,mt2701-pwrap" ,
@@ -1222,6 +1399,9 @@ static struct of_device_id of_pwrap_match_tbl[] = { .compatible = "mediatek,mt8173-pwrap", .data = &pwrap_mt8173, }, { + .compatible = "mediatek,mt7622-pwrap", + .data = &pwrap_mt7622, + }, {/* sentinel */ } };
Signature · 1 line
2.7.4
PATCH v2 9/9 soc: mediatek: pwrap: fixup warnings from coding style
In reply to [email protected]From: Sean Wang <[email protected]>
fixup those warnings such as lines over 80 words and parenthesis alignment which would be complained by checkpatch.pl.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)
drivers/soc/mediatek/mtk-pmic-wrap.c +13 -7
@@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)/* wait for cipher data ready@PMIC */ ret =pwrap_wait_for_state (wrp, pwrap_is_pmic_cipher_ready);if (ret) { -dev_err (wrp->dev,"timeout waiting for cipher data ready@PMIC\n" ); +dev_err (wrp->dev, +"timeout waiting for cipher data ready@PMIC\n" );return ret; }
@@ -1454,23 +1455,27 @@ static int pwrap_probe(struct platform_device *pdev)if (IS_ERR (wrp->bridge_base))return PTR_ERR (wrp->bridge_base); - wrp->rstc_bridge =devm_reset_control_get (wrp->dev,"pwrap-bridge" ); + wrp->rstc_bridge =devm_reset_control_get (wrp->dev, +"pwrap-bridge" );if (IS_ERR (wrp->rstc_bridge)) { ret =PTR_ERR (wrp->rstc_bridge); -dev_dbg (wrp->dev,"cannot get pwrap-bridge reset: %d\n" , ret); +dev_dbg (wrp->dev, +"cannot get pwrap-bridge reset: %d\n" , ret);return ret; } } wrp->clk_spi =devm_clk_get (wrp->dev,"spi" );if (IS_ERR (wrp->clk_spi)) { -dev_dbg (wrp->dev,"failed to get clock: %ld\n" ,PTR_ERR (wrp->clk_spi)); +dev_dbg (wrp->dev,"failed to get clock: %ld\n" , +PTR_ERR (wrp->clk_spi));return PTR_ERR (wrp->clk_spi); } wrp->clk_wrap =devm_clk_get (wrp->dev,"wrap" );if (IS_ERR (wrp->clk_wrap)) { -dev_dbg (wrp->dev,"failed to get clock: %ld\n" ,PTR_ERR (wrp->clk_wrap)); +dev_dbg (wrp->dev,"failed to get clock: %ld\n" , +PTR_ERR (wrp->clk_wrap));return PTR_ERR (wrp->clk_wrap); }
@@ -1514,8 +1519,9 @@ static int pwrap_probe(struct platform_device *pdev)pwrap_writel (wrp, wrp->master->int_en_all,PWRAP_INT_EN ); irq =platform_get_irq (pdev,0 ); - ret =devm_request_irq (wrp->dev, irq, pwrap_interrupt,IRQF_TRIGGER_HIGH , -"mt-pmic-pwrap" , wrp); + ret =devm_request_irq (wrp->dev, irq, pwrap_interrupt, +IRQF_TRIGGER_HIGH , +"mt-pmic-pwrap" , wrp);if (ret) goto err_out2;
Signature · 1 line
2.7.4
Mark Brown
maintainerRe: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380
In reply to [email protected]drivers/regulator/mt6380-regulator.c line 197
Quoted 5 lines · On Tue, Jul 18, 2017 at 05:49:23PM +0800…
drivers/regulator/mt6380-regulator.c new file +5
-0+if (!info->modeset_mask) { +dev_err (&rdev->dev,"regulator %s doesn't support set_mode\n" , + info->desc.name); +return -EINVAL ; + }
This is mostly fine but the mode operations all have this code - if the regulator doesn't have modesetting facilities it just shouldn't have the ops so the core can handle things in a standard fashion. It'd mean defining a separate set of operations for those regulators but that's fine.
Re: [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc
In reply to [email protected]Quoted 14 lines · On Tue, 2017-07-18 at 17:49 +0800, [email protected] wrote:
From: Sean Wang <[email protected]>
Signed-off-by Chenglin Xu <[email protected]>Signed-off-by Sean Wang <[email protected]>Acked-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 4 ++++ 1 file changed, 4 insertions(+)Documentation/devicetree/bindings/soc/mediatek/pwrap.txt +0
-0
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt Required properties in pwrap device node. · line 41
Quoted 7 lines
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt +4
-0@@ -35,6 +35,10 @@ Required properties in pwrap device node. "wrap": Main module clock - clocks: Must contain an entry for each entry in clock-names. +Required properties in pwrap device node +- compatible: + "mediatek,mt7622-pwrap" for MT7622 SoCs +
Sean,
Why mt7622 need to be separated from others?
Joe.C
Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style
In reply to [email protected]Quoted 15 lines · On Tue, 2017-07-18 at 17:49 +0800, [email protected] wrote:
From: Sean Wang <[email protected]>
fixup those warnings such as lines over 80 words and parenthesis alignment which would be complained by checkpatch.pl.
Signed-off-by Sean Wang <[email protected]>--- drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)drivers/soc/mediatek/mtk-pmic-wrap.c +0
-0
drivers/soc/mediatek/mtk-pmic-wrap.c static int pwrap_init_cipher(struct pmic_wrapper *wrp) · line 1061
Quoted 6 lines
drivers/soc/mediatek/mtk-pmic-wrap.c +2
-1@@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)/* wait for cipher data ready@PMIC */ ret =pwrap_wait_for_state (wrp, pwrap_is_pmic_cipher_ready);if (ret) { -dev_err (wrp->dev,"timeout waiting for cipher data ready@PMIC\n" ); +dev_err (wrp->dev, +"timeout waiting for cipher data ready@PMIC\n" );
Sean,
I think the old code is easier to read. When the line is only slightly over the 80 chars limit, some maintainers will even ask to keep it in one line to make it easier to read.
So if it is OK with Matthias, I think we should just keep it as is.
Joe.C
Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style
In reply to [email protected][Resend due to bad mail format, sorry about the noise if you got two]
Quoted 15 lines · On Tue, 2017-07-18 at 17:49 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]…
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]>
fixup those warnings such as lines over 80 words and parenthesis alignment which would be complained by checkpatch.pl.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)drivers/soc/mediatek/mtk-pmic-wrap.c +0
-0
drivers/soc/mediatek/mtk-pmic-wrap.c static int pwrap_init_cipher(struct pmic_wrapper *wrp) · line 1061
Quoted 6 lines
drivers/soc/mediatek/mtk-pmic-wrap.c +2
-1@@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)/* wait for cipher data ready@PMIC */ ret =pwrap_wait_for_state (wrp, pwrap_is_pmic_cipher_ready);if (ret) { -dev_err (wrp->dev,"timeout waiting for cipher data ready@PMIC\n" ); +dev_err (wrp->dev, +"timeout waiting for cipher data ready@PMIC\n" );
Sean,
I think the old code is easier to read. When the line is only slightly over the 80 chars limit, some maintainers will even ask to keep it in one line to make it easier to read.
So if it is OK with Matthias, I think we should just keep it as is.
Joe.C
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style
Quoted 28 lines · Yingjoe Chen
[Resend due to bad mail format, sorry about the noise if you got two]
Quoted 15 lines · On Tue, 2017-07-18 at 17:49 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]…
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]>
fixup those warnings such as lines over 80 words and parenthesis alignment which would be complained by checkpatch.pl.
--- drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)drivers/soc/mediatek/mtk-pmic-wrap.c +0
-0drivers/soc/mediatek/mtk-pmic-wrap.c static int pwrap_init_cipher(struct pmic_wrapper *wrp) · line 1061
Quoted 6 lines
drivers/soc/mediatek/mtk-pmic-wrap.c +2
-1@@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)/* wait for cipher data ready@PMIC */ ret =pwrap_wait_for_state (wrp, pwrap_is_pmic_cipher_ready);if (ret) { -dev_err (wrp->dev,"timeout waiting for cipher data ready@PMIC\n" ); +dev_err (wrp->dev, +"timeout waiting for cipher data ready@PMIC\n" );Sean,
Quoted 5 lines
I think the old code is easier to read. When the line is only slightly over the 80 chars limit, some maintainers will even ask to keep it in one line to make it easier to read.
So if it is OK with Matthias, I think we should just keep it as is.
checkpatch doesn't complain about this line.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc
In reply to Yingjoe ChenQuoted 25 lines · Yingjoe Chen
Quoted 14 lines · On Tue, 2017-07-18 at 17:49 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]…
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]>
Acked-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 4 ++++ 1 file changed, 4 insertions(+)Documentation/devicetree/bindings/soc/mediatek/pwrap.txt +0
-0Documentation/devicetree/bindings/soc/mediatek/pwrap.txt Required properties in pwrap device node. · line 41
Quoted 7 lines
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt +4
-0@@ -35,6 +35,10 @@ Required properties in pwrap device node. "wrap": Main module clock - clocks: Must contain an entry for each entry in clock-names. +Required properties in pwrap device node +- compatible: + "mediatek,mt7622-pwrap" for MT7622 SoCs +Sean,
Quoted 5 lines
Why mt7622 need to be separated from others?
Joe.C
Hi, Joe.C
many thanks
It should be one of copy-n-past error, it will be fixed up with moving up to the existing group of compatible string.
Sean
Quoted 1 line
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Rob Herring
maintainerRe: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator
In reply to [email protected]Quoted 17 lines · On Tue, Jul 18, 2017 at 05:49:22PM +0800…
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]>
add dt-binding document for MediaTek MT6380 PMIC
--- .../bindings/regulator/mt6380-regulator.txt | 90 ++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txtDocumentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +0
-0
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt line 1
Quoted 1 line
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +1
-0@@ -0,0 +1,90 @@ +MediaTek MT6380 Regulator Driver
Bindings don't describe drivers.
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt line 3
Quoted 2 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +2
-0+ +All voltage regulators are defined as subnodes of the regulators node. A list
What's the regulators node a child of?
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt line 14
Quoted 11 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +11
-0+of regulators provided by this controller are defined as subnodes of the +PMIC's node. Each regulator is named according to its regulator type, +buck-<name> and ldo-<name>. The definition for each of these nodes is defined +using the standard binding for regulators at +Documentation/devicetree/bindings/regulator/regulator.txt. + +The valid names for regulators are: +BUCK: + buck-core1, buck-vcore, buck-vrf +LDO: + ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Matthias
Except for patch 1, 2 and 3; the others are entirely related to pmic-wrapper driver all belonged to mtk soc code and
are they all good enough to be ready going through your tree?
Sean
Quoted 47 lines · On Tue, 2017-07-18 at 17:49 +0800, [email protected] wrote:
From: Sean Wang <[email protected]>
Changes since v1:
- enhnace MT6380 regulator dt-binding document following suggestions in the v1.
- revisepwrap_initwith slave programing options
- removemt6380_get_status()and relevant accessed members
- remove debug code inmt6380_regulator_set_mode()
- make regulator driver should never modify constraints
- revise mode mapping betweenREGULATOR_MODE_NORMALandMT6380_REGULATOR_MODEBy default, the relevant board with MediaTek MT7622 SoC is equipped with MediaTek MT6380 PMIC. So the series enables related driver allows the MT6380 can be accessed and controlled through MediaTek PMIC wrapper by those function drivers on MT7622 SoC.
Patch 1-2: Update dt-binding document for PMIC Wrapper and MT6380 regulator. Patch 3: Add a new driver for MT6380 regulator. Patch 4-7: Update operations in PMIC Wrapper in order to adapt into MT6380. Patch 8: Add support of MT7622 platform for PMIC Wrapper Patch 9: Fix warning complained from checkpatch.pl.Chenglin Xu (2):
regulator: mt6380: Add support for MT6380
soc: mediatek: pwrap: add support for MT7622 SoCSean Wang (7):
dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc
dt-bindings: regulator: Add document for MediaTek MT6380 regulator
soc: mediatek: pwrap: addpwrap_read32for reading in 32-bit mode
soc: mediatek: pwrap: addpwrap_write32for writing in 32-bit mode
soc: mediatek: pwrap: updatepwrap_initwithout slave programming
soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap
soc: mediatek: pwrap: fixup warnings from coding style.../bindings/regulator/mt6380-regulator.txt | 90 +++++ .../devicetree/bindings/soc/mediatek/pwrap.txt | 4 + drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6380-regulator.c | 359 ++++++++++++++++++ drivers/soc/mediatek/mtk-pmic-wrap.c | 416 ++++++++++++++++++--- include/linux/regulator/mt6380-regulator.h | 32 ++ 7 files changed, 856 insertions(+), 55 deletions(-) create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt create mode 100644 drivers/regulator/mt6380-regulator.c create mode 100644 include/linux/regulator/mt6380-regulator.h
Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380
In reply to [email protected]Quoted 54 lines · On Tue, 2017-07-18 at 17:49 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]…
From: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/[email protected]>
The MT6380 is a regulator found those boards with MediaTek MT7622 SoC It is connected as a slave to the SoC using MediaTek PMIC wrapper which is the common interface connecting with Mediatek made various PMICs.
--- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6380-regulator.c | 359 +++++++++++++++++++++++++++++ include/linux/regulator/mt6380-regulator.h | 32 +++ 4 files changed, 401 insertions(+) create mode 100644 drivers/regulator/mt6380-regulator.c create mode 100644 include/linux/regulator/mt6380-regulator.hdrivers/regulator/Kconfig +9
-0@@ -541,6 +541,15 @@ config REGULATOR_MT6323 This driver supports the control of different power rails of device through regulator interface. +config REGULATOR_MT6380 + tristate "MediaTek MT6380 PMIC" + depends on MTK_PMIC_WRAP + help + Say y here to select this option to enable the power regulator of + MediaTek MT6380 PMIC. + This driver supports the control of different power rails of device + through regulator interface. + config REGULATOR_MT6397 tristate "MediaTek MT6397 PMIC" depends on MFD_MT6397drivers/regulator/Makefile +1
-0@@ -70,6 +70,7 @@ obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o obj-$(CONFIG_REGULATOR_MC13XXX_CORE) += mc13xxx-regulator-core.o obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o +obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.odrivers/regulator/mt6380-regulator.c new file +0
-0
<...>
Quoted 17 lines
drivers/regulator/mt6380-regulator.c new file +17
-0+static struct regulator_ops mt6380_volt_range_ops = { + .list_voltage = regulator_list_voltage_linear_range, + .map_voltage = regulator_map_voltage_linear_range, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_time_sel = regulator_set_voltage_time_sel, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .is_enabled = regulator_is_enabled_regmap, + .set_mode = mt6380_regulator_set_mode, + .get_mode = mt6380_regulator_get_mode, +}; + +static struct regulator_ops mt6380_volt_table_ops = { + .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_iterate, + .set_voltage_sel = regulator_set_voltage_sel_regmap,
drivers/regulator/mt6380-regulator.c line 278
Quoted 10 lines
drivers/regulator/mt6380-regulator.c new file +10
-0+ .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_time_sel = regulator_set_voltage_time_sel, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .is_enabled = regulator_is_enabled_regmap, + .set_mode = mt6380_regulator_set_mode, + .get_mode = mt6380_regulator_get_mode, +}; + +static struct regulator_ops mt6380_volt_fixed_ops = {
this should be const.
Joe.C
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380
In reply to Mark BrownQuoted 13 lines · Mark Brown
drivers/regulator/mt6380-regulator.c line 197
Quoted 5 lines · On Tue, Jul 18, 2017 at 05:49:23PM +0800…
drivers/regulator/mt6380-regulator.c new file +5
-0+if (!info->modeset_mask) { +dev_err (&rdev->dev,"regulator %s doesn't support set_mode\n" , + info->desc.name); +return -EINVAL ; + }This is mostly fine but the mode operations all have this code - if the regulator doesn't have modesetting facilities it just shouldn't have the ops so the core can handle things in a standard fashion. It'd mean defining a separate set of operations for those regulators but that's fine.
Hi, Mark
it is really bad for those calls with certain regulator always returning -EINVAL, that doesn't make sense.
we'll follow your suggestion and add them into the next version.
thanks for your help!
Sean
Quoted 4 lines
_______________________________________________
Linux-mediatek mailing list [email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380
In reply to Yingjoe ChenQuoted 88 lines · Yingjoe Chen
Quoted 54 lines · On Tue, 2017-07-18 at 17:49 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]…
From: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/[email protected]>
The MT6380 is a regulator found those boards with MediaTek MT7622 SoC It is connected as a slave to the SoC using MediaTek PMIC wrapper which is the common interface connecting with Mediatek made various PMICs.
--- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6380-regulator.c | 359 +++++++++++++++++++++++++++++ include/linux/regulator/mt6380-regulator.h | 32 +++ 4 files changed, 401 insertions(+) create mode 100644 drivers/regulator/mt6380-regulator.c create mode 100644 include/linux/regulator/mt6380-regulator.hdrivers/regulator/Kconfig +9
-0@@ -541,6 +541,15 @@ config REGULATOR_MT6323 This driver supports the control of different power rails of device through regulator interface. +config REGULATOR_MT6380 + tristate "MediaTek MT6380 PMIC" + depends on MTK_PMIC_WRAP + help + Say y here to select this option to enable the power regulator of + MediaTek MT6380 PMIC. + This driver supports the control of different power rails of device + through regulator interface. + config REGULATOR_MT6397 tristate "MediaTek MT6397 PMIC" depends on MFD_MT6397drivers/regulator/Makefile +1
-0@@ -70,6 +70,7 @@ obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o obj-$(CONFIG_REGULATOR_MC13XXX_CORE) += mc13xxx-regulator-core.o obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o +obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.odrivers/regulator/mt6380-regulator.c new file +0
-0<...>
Quoted 17 lines
drivers/regulator/mt6380-regulator.c new file +17
-0+static struct regulator_ops mt6380_volt_range_ops = { + .list_voltage = regulator_list_voltage_linear_range, + .map_voltage = regulator_map_voltage_linear_range, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_time_sel = regulator_set_voltage_time_sel, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .is_enabled = regulator_is_enabled_regmap, + .set_mode = mt6380_regulator_set_mode, + .get_mode = mt6380_regulator_get_mode, +}; + +static struct regulator_ops mt6380_volt_table_ops = { + .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_iterate, + .set_voltage_sel = regulator_set_voltage_sel_regmap,drivers/regulator/mt6380-regulator.c line 278
Quoted 10 lines
drivers/regulator/mt6380-regulator.c new file +10
-0+ .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_time_sel = regulator_set_voltage_time_sel, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .is_enabled = regulator_is_enabled_regmap, + .set_mode = mt6380_regulator_set_mode, + .get_mode = mt6380_regulator_get_mode, +}; + +static struct regulator_ops mt6380_volt_fixed_ops = {this should be const.
Quoted 1 line
Joe.C
Hi, Joe.C
nice catch. also will be included in the next version
Sean
Quoted 2 lines
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator
In reply to Rob HerringQuoted 12 lines · Rob Herring
Quoted 11 lines · On Tue, Jul 18, 2017 at 05:49:22PM +0800…
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/[email protected]>
add dt-binding document for MediaTek MT6380 PMIC
--- .../bindings/regulator/mt6380-regulator.txt | 90 ++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
Quoted 10 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt line 1
Quoted 7 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +1
-0@@ -0,0 +1,90 @@ +MediaTek MT6380 Regulator DriverBindings don't describe drivers.
will fix it.
Quoted 5 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt line 3
Quoted 2 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +2
-0+ +All voltage regulators are defined as subnodes of the regulators node. A listWhat's the regulators node a child of?
this two line i felt are a little confusion, i will change them into " all voltage regulators provided by the MT6380 PMIC are described as the subnodes of the mt6380regulators node "
Quoted 11 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt line 14
Quoted 11 lines
Documentation/devicetree/bindings/regulator/mt6380-regulator.txt new file +11
-0+of regulators provided by this controller are defined as subnodes of the +PMIC's node. Each regulator is named according to its regulator type, +buck-<name> and ldo-<name>. The definition for each of these nodes is defined +using the standard binding for regulators at +Documentation/devicetree/bindings/regulator/regulator.txt. + +The valid names for regulators are: +BUCK: + buck-core1, buck-vcore, buck-vrf +LDO: + ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html