Skip to contentSkip to conversation

multipath-tools/python3-pykickstart/xmlrpc-c: fix file-rdeps QA issues

PATCH In review Hongxu Jia 2 participants 6 messages Aug 21, 2017

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

cover multipath-tools/python3-pykickstart/xmlrpc-c: fix file-rdeps QA issues

The following changes since commit ac2a6d2b5d69937577effcb8bb2149651bac0176:

json-spirit: Add -latomic to LDFLAGS (2017-08-13 13:21:04 +0200)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib hongxu/fix-qa-issue
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=hongxu/fix-qa-issue

Hongxu Jia (3):
multipath-tools: add bash to RDEPENDS
python3-pykickstart: tweak shebang to python3
xmlrpc-c: add perl to RDEPENDS

 .../recipes-devtools/xmlrpc-c/xmlrpc-c_1.31.0.bb   |  2 +-
 .../multipath-tools/multipath-tools_0.7.1.bb       |  2 +-
 .../files/0005-tweak-shebang-to-python3.patch      | 25 ++++++++++++++++++++++
 .../python-pykickstart/python3-pykickstart_2.35.bb |  1 +
 4 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 meta-python/recipes-extended/python-pykickstart/files/0005-tweak-shebang-to-python3.patch
Signature · 1 line
2.8.1
author
#1 lore raw

PATCH 1/3 multipath-tools: add bash to RDEPENDS

Fix the following file-rdeps QA issue:
...
|ERROR: multipath-tools-0.7.1-r0 do_package_qa: QA Issue: /sbin/mpathconf contained in package multipath-tools requires /bin/bash, but no providers found in RDEPENDS_multipath-tools? [file-rdeps]
...

---
 meta-oe/recipes-support/multipath-tools/multipath-tools_0.7.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-support/multipath-tools/multipath-tools_0.7.1.bb +1 -1
index 610ba7a..a13efbe 100644
@@ -97,7 +97,7 @@ FILES_${PN}-dbg += "${base_libdir}/multipath/.debug"
 PACKAGES =+ "${PN}-libs"
 FILES_${PN}-libs = "${base_libdir}/lib*.so.* \
                     ${base_libdir}/multipath/lib*.so*"
-RDEPENDS_${PN} += "${PN}-libs"
+RDEPENDS_${PN} += "${PN}-libs bash"
 
 PROVIDES += "device-mapper-multipath"
 RPROVIDES_${PN} += "device-mapper-multipath"
Signature · 1 line
2.8.1
author
#2 lore raw

PATCH 2/3 python3-pykickstart: tweak shebang to python3

In reply to Hongxu Jia

Fix the following file-rdeps QA issue:
...
|ERROR: python3-pykickstart-2.35-r0 do_package_qa: QA Issue:
/usr/bin/ksvalidator contained in package python3-pykickstart requires /usr/bin/python, but no providers found in RDEPENDS_python3-pykickstart? [file-rdeps]
...

---
 .../files/0005-tweak-shebang-to-python3.patch      | 25 ++++++++++++++++++++++
 .../python-pykickstart/python3-pykickstart_2.35.bb |  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta-python/recipes-extended/python-pykickstart/files/0005-tweak-shebang-to-python3.patch
meta-python/recipes-extended/python-pykickstart/files/0005-tweak-shebang-to-python3.patch new file +25 -0
new file mode 100644
index 0000000..3d61495
@@ -0,0 +1,25 @@
+From 8a1f598223bd4cbcc877eb2aba3f5586c75c9d14 Mon Sep 17 00:00:00 2001
+From: Hongxu Jia <[email protected]>
+Date: Mon, 21 Aug 2017 10:05:06 +0800
+Subject: [PATCH] tweak shebang to python3
+
+Upstream-Status: Pending
+
+Signed-off-by: Hongxu Jia <[email protected]>
+---
+ tools/ksvalidator.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/ksvalidator.py b/tools/ksvalidator.py
+index d6051d5..c3682e8 100755
+--- a/tools/ksvalidator.py
++++ b/tools/ksvalidator.py
+@@ -1,4 +1,4 @@
+-#!/usr/bin/python
++#!/usr/bin/python3
+ #
+ # Chris Lumens <[email protected]>
+ #
+-- 
+1.8.3.1
+
meta-python/recipes-extended/python-pykickstart/python3-pykickstart_2.35.bb +1 -0
index e96af43..2a2840f 100644
@@ -17,6 +17,7 @@ SRC_URI = "git://github.com/rhinstaller/pykickstart.git;protocol=https;branch=py
            file://0002-pykickstart-parser.py-add-lock-for-readKickstart-and.patch \
            file://0003-comment-out-sections-shutdown-and-environment-in-gen.patch \
            file://0004-load.py-retry-to-invoke-request-with-timeout.patch \
+           file://0005-tweak-shebang-to-python3.patch \
            "
 SRCREV = "b2787a818540e678c2f9c5dca0c6bbd65b8b55e5"
 
Signature · 1 line
2.8.1
author
#3 lore raw

PATCH 3/3 xmlrpc-c: add perl to RDEPENDS

In reply to Hongxu Jia

Fix the following file-rdeps QA issue:
...
|ERROR: xmlrpc-c-1.31.0-r0 do_package_qa: QA Issue:
/usr/bin/xml-rpc-api2txt contained in package xmlrpc-c requires /usr/bin/perl, but no providers found in RDEPENDS_xmlrpc-c? [file-rdeps]
...

---
 meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.31.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/xmlrpc-c/xmlrpc-c_1.31.0.bb +1 -1
index 70bd9e8..efa58f1 100644
@@ -13,7 +13,7 @@ SRCREV = "81443a9dc234cc275449dbc17867ad77ae189124"
 S = "${WORKDIR}/git"
 
 DEPENDS = "curl libxml2"
-RDEPENDS_${PN} = "curl"
+RDEPENDS_${PN} = "curl perl"
 
 inherit cmake
 
Signature · 1 line
2.8.1
#4 lore raw
In reply to Hongxu Jia

Do you know why so many do_package_qa failures were detected now?

I was reading oe-core commits added since last world build and I don't see where this QA check was fixed or why it reports so many issues now.

Is it thanks to this change?
http://git.openembedded.org/openembedded-core/commit/?id=bf017930036f19b3d6df8e5b50d9979ee7045c5c

Quoted 29 lines · Hongxu Jia

The following changes since commit ac2a6d2b5d69937577effcb8bb2149 651bac0176:

json-spirit: Add -latomic to LDFLAGS (2017-08-13 13:21:04 +0200)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib hongxu/fix-qa-issue
http://cgit.openembedded.org/openembedded-core-contrib/log/
?h=hongxu/fix-qa-issue

Hongxu Jia (3):
multipath-tools: add bash to RDEPENDS
python3-pykickstart: tweak shebang to python3
xmlrpc-c: add perl to RDEPENDS

 .../recipes-devtools/xmlrpc-c/xmlrpc-c_1.31.0.bb   |  2 +-
 .../multipath-tools/multipath-tools_0.7.1.bb       |  2 +-
 .../files/0005-tweak-shebang-to-python3.patch      | 25
++++++++++++++++++++++
 .../python-pykickstart/python3-pykickstart_2.35.bb |  1 +
 4 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 meta-python/recipes-extended/

python-pykickstart/files/0005-tweak-shebang-to-python3.patch

--
2.8.1

author
#5 lore raw
Quoted 7 lines · Martin Jansa

Do you know why so many do_package_qa failures were detected now?

I was reading oe-core commits added since last world build and I don't see where this QA check was fixed or why it reports so many issues now.

Is it thanks to this change?
http://git.openembedded.org/openembedded-core/commit/?id=bf017930036f19b3d6df8e5b50d9979ee7045c5c

I think so, I sync oe-core to latest and found these QA issue.

Here is the original repo:

http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/rpm_regressions2

And some improvement in

https://www.mail-archive.com/[email protected]/msg100243.html

//Hongxu

Quoted 36 lines · On Mon, Aug 21, 2017 at 8:00 AM, Hongxu Jia <[email protected]…
    The following changes since commit
    ac2a6d2b5d69937577effcb8bb2149651bac0176:

      json-spirit: Add -latomic to LDFLAGS (2017-08-13 13:21:04 +0200)

    are available in the git repository at:

      git://git.openembedded.org/openembedded-core-contrib
    <http://git.openembedded.org/openembedded-core-contrib>
    hongxu/fix-qa-issue
    http://cgit.openembedded.org/openembedded-core-contrib/log/?h=hongxu/fix-qa-issue
    <http://cgit.openembedded.org/openembedded-core-contrib/log/?h=hongxu/fix-qa-issue>

    Hongxu Jia (3):
      multipath-tools: add bash to RDEPENDS
      python3-pykickstart: tweak shebang to python3
      xmlrpc-c: add perl to RDEPENDS

     .../recipes-devtools/xmlrpc-c/xmlrpc-c_1.31.0.bb
    <http://xmlrpc-c_1.31.0.bb>  |  2 +-
     .../multipath-tools/multipath-tools_0.7.1.bb
    <http://multipath-tools_0.7.1.bb>      |  2 +-
     .../files/0005-tweak-shebang-to-python3.patch      | 25
    ++++++++++++++++++++++
     .../python-pykickstart/python3-pykickstart_2.35.bb
    <http://python3-pykickstart_2.35.bb> |  1 +
     4 files changed, 28 insertions(+), 2 deletions(-)
     create mode 100644
    meta-python/recipes-extended/python-pykickstart/files/0005-tweak-shebang-to-python3.patch

    --
    2.8.1