toaster: cummulative 30082017 patch
cover toaster: cummulative 30082017 patch
From: David Reyna <[email protected]>
Cummulative Toaster patches. No new files.
The following changes since commit ee5bce2d11e783c0921df47b629025a6b67c44bf:
kernel-dev: Removed bad reference for creating patches. (2017-09-02 00:52:49 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib dreyna/submit/dreyna/toaster/cummulative_300817_patch
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=dreyna/submit/dreyna/toaster/cummulative_300817_patch
Awais Belal (1):
toaster: Order column in Tasks selectable
David Reyna (1):
toaster: display error when the fstype select is empty
Olaf Mandel (2):
toaster: debug message for lists layers missing separators
toaster: set default pokydirname if no external layers
lib/toaster/bldcontrol/localhostbecontroller.py | 6 +++++- lib/toaster/toastergui/buildtables.py | 3 +++ lib/toaster/toastergui/templates/projectconf.html | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
PATCH 1/4 toaster: display error when the fstype select is empty
From: David Reyna <[email protected]>
There must be at least one FSTYPE selected in the Toaster bitbake variable editor page. When the user deselects all the "Save" button gets disabled, but the error message is missing.
[YOCTO #8126]
--- lib/toaster/toastergui/templates/projectconf.html | 3 +++ 1 file changed, 3 insertions(+)
lib/toaster/toastergui/templates/projectconf.html +3 -0
@@ -63,6 +63,7 @@ <button id="cancel-change-image_fstypes" type="button" class="btn btn-link">Cancel</button> </div> <p class="help-block text-danger" style="display:none;" id="hintError-image-fs_type">A valid image type cannot include underscores</p> + <p class="help-block text-danger" style="display:none;" id="fstypes-error-message">You must select at least one image type</p> <label>Or choose from known image types:</label> <input id="filter-image_fstypes" type="text" placeholder="Search image types" class="form-control"> <div id="all-image_fstypes" class="scrolling"></div>
@@ -716,8 +717,10 @@ $(document).ready(function() { } if ($('#new-imagefs_types').val().length === 0) { $("#apply-change-image_fstypes").prop("disabled", true); + $('#fstypes-error-message').show(); } else { $("#apply-change-image_fstypes").prop("disabled", false); + $('#fstypes-error-message').hide(); } });
Signature · 1 line
1.9.1
PATCH 2/4 toaster: Order column in Tasks selectable
In reply to David ReynaFrom: Awais Belal <[email protected]>
The build page provides tables related to performance that cover build time, CPU time and disk IO. The "Edit columns" drop down does not allow selection of the Order column and makes it hidden as well which is not accurate from user interaction point of view.
This patch enables the hideable property for the Order column so it is hidden by default but the user can enable it through the drop down if need be.
[YOCTO #11040]
--- lib/toaster/toastergui/buildtables.py | 3 +++ 1 file changed, 3 insertions(+)
lib/toaster/toastergui/buildtables.py +3 -0
@@ -571,6 +571,7 @@ class BuildTimeTable(BuildTasksTable): super(BuildTimeTable, self).setup_columns(**kwargs) self.columns[self.toggle_columns['order']]['hidden'] = True + self.columns[self.toggle_columns['order']]['hideable'] = True self.columns[self.toggle_columns['sstate_result']]['hidden'] = True self.columns[self.toggle_columns['elapsed_time']]['hidden'] = False
@@ -586,6 +587,7 @@ class BuildCPUTimeTable(BuildTasksTable): super(BuildCPUTimeTable, self).setup_columns(**kwargs) self.columns[self.toggle_columns['order']]['hidden'] = True + self.columns[self.toggle_columns['order']]['hideable'] = True self.columns[self.toggle_columns['sstate_result']]['hidden'] = True self.columns[self.toggle_columns['cpu_time_sys']]['hidden'] = False self.columns[self.toggle_columns['cpu_time_user']]['hidden'] = False
@@ -602,5 +604,6 @@ class BuildIOTable(BuildTasksTable): super(BuildIOTable, self).setup_columns(**kwargs) self.columns[self.toggle_columns['order']]['hidden'] = True + self.columns[self.toggle_columns['order']]['hideable'] = True self.columns[self.toggle_columns['sstate_result']]['hidden'] = True self.columns[self.toggle_columns['disk_io']]['hidden'] = False
Signature · 1 line
1.9.1
PATCH 3/4 toaster: debug message for lists layers missing separators
In reply to David ReynaFrom: Olaf Mandel <[email protected]>
One of the debug messages during build contains a list of all layers but without spaces or other separators between them. Use pformat instead.
[YOCTO #12014]
--- lib/toaster/bldcontrol/localhostbecontroller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/toaster/bldcontrol/localhostbecontroller.py +1 -1
@@ -230,7 +230,7 @@ class LocalhostBEController(BuildEnvironmentController): continue # not a custom recipe, skip layerlist.extend(nongitlayerlist) - logger.debug("\n\nset layers gives this list \n %s" % ''.join(layerlist)) + logger.debug("\n\nset layers gives this list %s" % pformat(layerlist)) self.islayerset = True return layerlist
Signature · 1 line
1.9.1
PATCH 4/4 toaster: set default pokydirname if no external layers
In reply to David ReynaFrom: Olaf Mandel <[email protected]>
If no external layers are defined, pokydirname is not set. Rectify this by taking the 'be.sourcedir' as the pokydirname.
[YOCTO #12015]
--- lib/toaster/bldcontrol/localhostbecontroller.py | 4 ++++ 1 file changed, 4 insertions(+)
lib/toaster/bldcontrol/localhostbecontroller.py +4 -0
@@ -213,6 +213,10 @@ class LocalhostBEController(BuildEnvironmentController): self.setCloneStatus(bitbake,'complete',clone_total,clone_count) logger.debug("localhostbecontroller: current layer list %s " % pformat(layerlist)) + if self.pokydirname is None and os.path.exists(os.path.join(self.be.sourcedir, "oe-init-build-env")): + logger.debug("localhostbecontroller: selected poky dir name %s" % self.be.sourcedir) + self.pokydirname = self.be.sourcedir + # 5. create custom layer and add custom recipes to it for target in targets: try:
Signature · 1 line
1.9.1