Remove unused variables in structure definition

PATCH Superseded Srishti Sharma 2 participants 4 messages Sep 16, 2017 Staging

lore

Share & tools

lore

Srishti Sharma

author

2017-09-16 14:34 UTC #0 lore raw

cover Remove unused variables in structure definition

This patch series attempts to remove unused variables in structure variables and the comments associated with them.

Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure

 drivers/staging/dgnc/dgnc_driver.h | 15 ---------------
 1 file changed, 15 deletions(-)

Signature · 1 line

2.7.4

Srishti Sharma

author

2017-09-16 14:35 UTC #1 lore raw

PATCH 1/2 Staging: dgnc: Remove unused variables in struct dgnc_board

Remove unused variables and comments associated with them in the structure definition.

Signed-off-by Srishti Sharma <[email protected]>

---
 drivers/staging/dgnc/dgnc_driver.h | 9 ---------
 1 file changed, 9 deletions(-)

drivers/staging/dgnc/dgnc_driver.h +0 -9

index 764d6fe..5d2566e 100644
@@ -104,7 +104,6 @@ struct board_ops {
  * struct dgnc_board - Per board information.
  * @boardnum: Board number (0 - 32).
  *
- * @type: Type of board.
  * @name: Product name.
  * @pdev: Pointer to the pci_dev structure.
  * @bd_flags: Board flags.

@@ -140,13 +139,9 @@ struct board_ops {
  * @dpastatus: Board status as defined by DPA.
  * @bd_dividend: Board/UART's specific dividend.
  * @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
  */
 struct dgnc_board {
 	int		boardnum;
-
-	int		type;
 	char		*name;
 	struct pci_dev	*pdev;
 	unsigned long	bd_flags;

@@ -200,10 +195,6 @@ struct dgnc_board {
 	uint		bd_dividend;
 
 	struct board_ops *bd_ops;
-
-	struct proc_dir_entry *proc_entry_pointer;
-	struct dgnc_proc_entry *dgnc_board_table;
-
 };
 
 /* Unit flag definitions for un_flags. */

Signature · 1 line

2.7.4

Srishti Sharma

author

2017-09-16 14:35 UTC #2 lore raw

PATCH 2/2 Staging: dgnc: Remove unused variable in struct channel_t

In reply to Srishti Sharma

Eliminate the variables that are not used and the comments associated with them.

Signed-off-by Srishti Sharma <[email protected]>

---
 drivers/staging/dgnc/dgnc_driver.h | 6 ------
 1 file changed, 6 deletions(-)

drivers/staging/dgnc/dgnc_driver.h +0 -6

index 5d2566e..082d659 100644
@@ -312,8 +312,6 @@ struct un_t {
  * @ch_err_overrun: Count of overruns on channel.
  * @ch_xon_sends: Count of xons transmitted.
  * @ch_xoff_sends: Count of xoffs transmitted.
- * @proc_entry_pointer: Proc/<board>/<channel> entry.
- * @dgnc_channel_table: Proc/<board>/<channel> entry.
  */
 struct channel_t {
 	struct dgnc_board *ch_bd;

@@ -382,10 +380,6 @@ struct channel_t {
 
 	ulong		ch_xon_sends;
 	ulong		ch_xoff_sends;
-
-	struct proc_dir_entry *proc_entry_pointer;
-	struct dgnc_proc_entry *dgnc_channel_table;
-
 };
 
 extern uint		dgnc_major;		/* Our driver/mgmt major */

Signature · 1 line

2.7.4

Julia Lawall

2017-09-16 15:28 UTC #3 lore raw

In reply to Srishti Sharma

Quoted 2 lines · Srishti Sharma

This patch series attempts to remove unused variables in structure variables and the comments associated with them.

Actually, I would say that a structure has fields, not variables.

julia

Quoted 18 lines

Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
 drivers/staging/dgnc/dgnc_driver.h | 15 ---------------
 1 file changed, 15 deletions(-)
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1505572018.git.srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.