Skip to contentSkip to conversation

gcc: backport patch to fix miscompilation problem on mips64

PATCH New Chen Qi 1 participant 3 messages Nov 8, 2017

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover gcc: backport patch to fix miscompilation problem on mips64

The following changes since commit 2e1eb9ab12802d52465e6ae636c3f6a40ffb098c:

bitbake: tests/fetch: Add ftp test url (2017-11-07 15:02:19 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/bug12266
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/bug12266

Chen Qi (2):
systemd: remove useless options for mips64
gcc: backport patch to fix miscompilation on mips64

 meta/recipes-core/systemd/systemd_234.bb           |  3 --
 meta/recipes-devtools/gcc/gcc-7.2.inc              |  1 +
 .../gcc-7.2/0001-PR-rtl-optimization-81803.patch   | 52 ++++++++++++++++++++++
 3 files changed, 53 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-devtools/gcc/gcc-7.2/0001-PR-rtl-optimization-81803.patch
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/2 systemd: remove useless options for mips64

Looking back the history, we had problem with systemd on qemumips64 which is also related to compilation flags. We solved that by using tweaking FULL_OPTIMIZATION for mips64 to have "-fno-tree-switch-conversion -fno-tree-tail-merge".

Now systemd has been upgraded to 234, and we don't have the above problem any more, thus removing these flags.

---
 meta/recipes-core/systemd/systemd_234.bb | 3 ---
 1 file changed, 3 deletions(-)
meta/recipes-core/systemd/systemd_234.bb +0 -3
index 36fd3f8..971226f 100644
@@ -158,9 +158,6 @@ CFLAGS .= "${@bb.utils.contains('PACKAGECONFIG', 'valgrind', ' -DVALGRIND=1', ''
 # disable problematic GCC 5.2 optimizations [YOCTO #8291]
 FULL_OPTIMIZATION_append_arm = " -fno-schedule-insns -fno-schedule-insns2"
 
-# Avoid login failure on qemumips64 when pam is enabled
-FULL_OPTIMIZATION_append_mips64 = " -fno-tree-switch-conversion -fno-tree-tail-merge"
-
 COMPILER_NM ?= "${HOST_PREFIX}gcc-nm"
 COMPILER_AR ?= "${HOST_PREFIX}gcc-ar"
 COMPILER_RANLIB ?= "${HOST_PREFIX}gcc-ranlib"
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 2/2 gcc: backport patch to fix miscompilation on mips64

In reply to Chen Qi

Backport a patch to fix miscompilation on mips64.

We've observed strange behaviour of systemctl status <xxx> on qemumips64. The output of the command is like systemctl show <xxx>', which is incorrect.

The problem is due to the miscompilation of gcc for mips64 platform, thus backporting patch from upstream to fix this problem.

[YOCTO #12266]

---
 meta/recipes-devtools/gcc/gcc-7.2.inc              |  1 +
 .../gcc-7.2/0001-PR-rtl-optimization-81803.patch   | 52 ++++++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc-7.2/0001-PR-rtl-optimization-81803.patch
meta/recipes-devtools/gcc/gcc-7.2.inc +1 -0
index 5883bc6..ebed5b9 100644
@@ -78,6 +78,7 @@ SRC_URI = "\
            ${BACKPORTS} \
 "
 BACKPORTS = "\
+           file://0001-PR-rtl-optimization-81803.patch \
 "
 SRC_URI[md5sum] = "ff370482573133a7fcdd96cd2f552292"
 SRC_URI[sha256sum] = "1cf7adf8ff4b5aa49041c8734bbcf1ad18cc4c94d0029aae0f4e48841088479a"
meta/recipes-devtools/gcc/gcc-7.2/0001-PR-rtl-optimization-81803.patch new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
1.9.1