Misc fixes predominantly for musl

PATCH In review Khem Raj 3 participants 12 messages Nov 9, 2017 – Feb 9, 2018

Share & tools

Khem Raj

author

2017-11-09 01:58 UTC #0 lore raw

cover Misc fixes predominantly for musl

upgrade musl past 1.1.18 release
fix armv5 codegen issue seen with gcc7 while compiling kernel fix systemd for musl/64-bit
make binutils SRC_URI overridable
Fix go with PIE/musl

The following changes since commit 3717c76eb24217c14a22f72fdd8732923729dee8:

gcc: fix miscompilation on mips64 (2017-11-08 22:23:45 +0000)

are available in the Git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/pu
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=kraj/pu

Khem Raj (5):
binutils: Convert SRC_URI and SRCREV to weak defines
go: Fix build with PIE on musl
systemd: Fix build with musl/mips64
musl: Update to 1.1.18
gcc7/gcc6: Fix unaligned STRD issue on ARM

 meta/recipes-core/musl/musl_git.bb                 |   4 +-
 .../0001-Use-uintmax_t-for-handling-rlim_t.patch   |  89 ++++++++++
 meta/recipes-core/systemd/systemd_234.bb           |   1 +
 meta/recipes-devtools/binutils/binutils-2.29.inc   |   5 +-
 meta/recipes-devtools/gcc/gcc-6.4.inc              |   1 +
 ...5-suppress-32-bit-aligned-ldrd-strd-peeph.patch | 194 +++++++++++++++++++++
 meta/recipes-devtools/gcc/gcc-7.2.inc              |   1 +
 ...5-suppress-32-bit-aligned-ldrd-strd-peeph.patch | 194 +++++++++++++++++++++
 meta/recipes-devtools/go/go-1.9.inc                |   3 +
 .../go/go-1.9/default-buildmode-pie.patch          |  18 ++
 .../go/go-1.9/set-external-linker.patch            | 111 ++++++++++++
 11 files changed, 617 insertions(+), 4 deletions(-)
 create mode 100644 meta/recipes-core/systemd/systemd/0001-Use-uintmax_t-for-handling-rlim_t.patch
 create mode 100644 meta/recipes-devtools/gcc/gcc-6.4/0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch
 create mode 100644 meta/recipes-devtools/gcc/gcc-7.2/0051-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch
 create mode 100644 meta/recipes-devtools/go/go-1.9/default-buildmode-pie.patch
 create mode 100644 meta/recipes-devtools/go/go-1.9/set-external-linker.patch

Signature · 1 line

2.15.0

Khem Raj

author

2017-11-09 01:58 UTC #1 lore raw

PATCH 1/5 binutils: Convert SRC_URI and SRCREV to weak defines

This makes it easy to override them in bbappends

Signed-off-by Khem Raj <[email protected]>

---
 meta/recipes-devtools/binutils/binutils-2.29.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

meta/recipes-devtools/binutils/binutils-2.29.inc +3 -2

index 27d46eb088..35f76cba6d 100644
@@ -18,9 +18,10 @@ BINUPV = "${@binutils_branch_version(d)}"
 
 UPSTREAM_CHECK_GITTAGREGEX = "binutils-(?P<pver>\d+_(\d_?)*)"
 
-SRCREV = "37e991bb143ca2106330bcdc625590d53838b7a1"
+SRCREV ?= "37e991bb143ca2106330bcdc625590d53838b7a1"
+BINUTILS_GIT_URI ?= "git://sourceware.org/git/binutils-gdb.git;branch=binutils-${BINUPV}-branch;protocol=git"
 SRC_URI = "\
-     git://sourceware.org/git/binutils-gdb.git;branch=binutils-${BINUPV}-branch;protocol=git \
+     ${BINUTILS_GIT_URI} \
      file://0003-configure-widen-the-regexp-for-SH-architectures.patch \
      file://0004-Point-scripts-location-to-libdir.patch \
      file://0005-Only-generate-an-RPATH-entry-if-LD_RUN_PATH-is-not-e.patch \

Signature · 1 line

2.15.0

Khem Raj

author

2017-11-09 01:59 UTC #4 lore raw

PATCH 2/5 go: Fix build with PIE on musl

In reply to Khem Raj

Signed-off-by Khem Raj <[email protected]>

---
 meta/recipes-devtools/go/go-1.9.inc                |   3 +
 .../go/go-1.9/default-buildmode-pie.patch          |  18 ++++
 .../go/go-1.9/set-external-linker.patch            | 111 +++++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go-1.9/default-buildmode-pie.patch
 create mode 100644 meta/recipes-devtools/go/go-1.9/set-external-linker.patch

meta/recipes-devtools/go/go-1.9.inc +3 -0

index 65adaa8d72..f52abb5735 100644
@@ -15,6 +15,9 @@ SRC_URI += "\
         file://0007-ld-add-soname-to-shareable-objects.patch \
         file://0008-make.bash-add-GOHOSTxx-indirection-for-cross-canadia.patch \
         file://0009-cmd-go-buildmode-pie-forces-external-linking-mode-on.patch \
+        file://default-buildmode-pie.patch \
 "
+SRC_URI_append_libc-musl = " file://set-external-linker.patch"
+
 SRC_URI[main.md5sum] = "da2d44ea384076efec43ee1f8b7d45d2"
 SRC_URI[main.sha256sum] = "a4ab229028ed167ba1986825751463605264e44868362ca8e7accc8be057e993"

meta/recipes-devtools/go/go-1.9/default-buildmode-pie.patch new file +18 -0

new file mode 100644
index 0000000000..a7933bd39e
@@ -0,0 +1,18 @@
+Default to PIE on linux platforms
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <[email protected]>
+
+diff -upr src/go.orig/src/cmd/go/internal/work/build.go src/go/src/cmd/go/internal/work/build.go
+--- go.orig/src/cmd/go/internal/work/build.go	2017-08-27 17:38:26.354750979 +0200
++++ go/src/cmd/go/internal/work/build.go	2017-08-27 17:40:27.555130105 +0200
+@@ -304,7 +304,8 @@ func BuildModeInit() {
+ 		ldBuildmode = "c-shared"
+ 	case "default":
+ 		switch platform {
+-		case "android/arm", "android/arm64", "android/amd64", "android/386":
++		case "linux/386", "linux/amd64", "linux/arm", "linux/arm64", "linux/ppc64le", "linux/s390x",
++			"android/arm", "android/arm64", "android/amd64", "android/386":
+ 			codegenArg = "-shared"
+ 			ldBuildmode = "pie"
+ 		case "darwin/arm", "darwin/arm64":

meta/recipes-devtools/go/go-1.9/set-external-linker.patch new file +111 -0

111 lines not on this page · raw message

Signature · 1 line

2.15.0

Khem Raj

author

2017-11-09 01:59 UTC #5 lore raw

PATCH 3/5 systemd: Fix build with musl/mips64

In reply to Khem Raj

Signed-off-by Khem Raj <[email protected]>

---
 .../0001-Use-uintmax_t-for-handling-rlim_t.patch   | 89 ++++++++++++++++++++++
 meta/recipes-core/systemd/systemd_234.bb           |  1 +
 2 files changed, 90 insertions(+)
 create mode 100644 meta/recipes-core/systemd/systemd/0001-Use-uintmax_t-for-handling-rlim_t.patch

meta/recipes-core/systemd/systemd/0001-Use-uintmax_t-for-handling-rlim_t.patch new file +89 -0

new file mode 100644
index 0000000000..779dc78fd3
@@ -0,0 +1,89 @@
+From b2d4171c6e521cf1e70331fb769234d63a4a6d44 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Fri, 27 Oct 2017 13:00:41 -0700
+Subject: [PATCH] Use uintmax_t for handling rlim_t
+
+PRIu{32,64} is not right format to represent rlim_t type
+therefore use %ju and typecast the rlim_t variables to
+uintmax_t.
+
+Fixes portablility errors like
+
+execute.c:3446:36: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'rlim_t {aka long long unsigned int}' [-Werror=format=]
+|                          fprintf(f, "%s%s: " RLIM_FMT "\n",
+|                                     ^~~~~~~~
+|                                  prefix, rlimit_to_string(i), c->rlimit[i]->rlim_max);
+|                                                               ~~~~~~~~~~~~~~~~~~~~~~
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+Upstream-Status: Submitted [https://github.com/systemd/systemd/pull/7199]
+
+ src/basic/format-util.h | 8 --------
+ src/basic/rlimit-util.c | 8 ++++----
+ src/core/execute.c      | 8 ++++----
+ 3 files changed, 8 insertions(+), 16 deletions(-)
+
+diff --git a/src/basic/format-util.h b/src/basic/format-util.h
+index ae42a8f89..144249cd6 100644
+--- a/src/basic/format-util.h
++++ b/src/basic/format-util.h
+@@ -60,14 +60,6 @@
+ #  define PRI_TIMEX "li"
+ #endif
+ 
+-#if SIZEOF_RLIM_T == 8
+-#  define RLIM_FMT "%" PRIu64
+-#elif SIZEOF_RLIM_T == 4
+-#  define RLIM_FMT "%" PRIu32
+-#else
+-#  error Unknown rlim_t size
+-#endif
+-
+ #if SIZEOF_DEV_T == 8
+ #  define DEV_FMT "%" PRIu64
+ #elif SIZEOF_DEV_T == 4
+diff --git a/src/basic/rlimit-util.c b/src/basic/rlimit-util.c
+index ca834df62..41fcebb74 100644
+--- a/src/basic/rlimit-util.c
++++ b/src/basic/rlimit-util.c
+@@ -284,13 +284,13 @@ int rlimit_format(const struct rlimit *rl, char **ret) {
+         if (rl->rlim_cur >= RLIM_INFINITY && rl->rlim_max >= RLIM_INFINITY)
+                 s = strdup("infinity");
+         else if (rl->rlim_cur >= RLIM_INFINITY)
+-                (void) asprintf(&s, "infinity:" RLIM_FMT, rl->rlim_max);
++                (void) asprintf(&s, "infinity:%ju", (uintmax_t)rl->rlim_max);
+         else if (rl->rlim_max >= RLIM_INFINITY)
+-                (void) asprintf(&s, RLIM_FMT ":infinity", rl->rlim_cur);
++                (void) asprintf(&s, "%ju:infinity", (uintmax_t)rl->rlim_cur);
+         else if (rl->rlim_cur == rl->rlim_max)
+-                (void) asprintf(&s, RLIM_FMT, rl->rlim_cur);
++                (void) asprintf(&s, "%ju", (uintmax_t)rl->rlim_cur);
+         else
+-                (void) asprintf(&s, RLIM_FMT ":" RLIM_FMT, rl->rlim_cur, rl->rlim_max);
++                (void) asprintf(&s, "%ju:%ju", (uintmax_t)rl->rlim_cur, (uintmax_t)rl->rlim_max);
+ 
+         if (!s)
+                 return -ENOMEM;
+diff --git a/src/core/execute.c b/src/core/execute.c
+index d72e5bf08..d38946002 100644
+--- a/src/core/execute.c
++++ b/src/core/execute.c
+@@ -3443,10 +3443,10 @@ void exec_context_dump(ExecContext *c, FILE* f, const char *prefix) {
+ 
+         for (i = 0; i < RLIM_NLIMITS; i++)
+                 if (c->rlimit[i]) {
+-                        fprintf(f, "%s%s: " RLIM_FMT "\n",
+-                                prefix, rlimit_to_string(i), c->rlimit[i]->rlim_max);
+-                        fprintf(f, "%s%sSoft: " RLIM_FMT "\n",
+-                                prefix, rlimit_to_string(i), c->rlimit[i]->rlim_cur);
++                        fprintf(f, "%s%s: %ju\n",
++                                prefix, rlimit_to_string(i), (uintmax_t)c->rlimit[i]->rlim_max);
++                        fprintf(f, "%s%sSoft: %ju\n",
++                                prefix, rlimit_to_string(i), (uintmax_t)c->rlimit[i]->rlim_cur);
+                 }
+ 
+         if (c->ioprio_set) {
+-- 
+2.14.3
+

meta/recipes-core/systemd/systemd_234.bb +1 -0

index bcb683f10a..6b8745b93f 100644
@@ -40,6 +40,7 @@ SRC_URI = "git://github.com/systemd/systemd.git;protocol=git \
            file://0012-don-t-pass-AT_SYMLINK_NOFOLLOW-flag-to-faccessat.patch \
            file://0013-comparison_fn_t-is-glibc-specific-use-raw-signature-.patch \
            file://0001-Define-_PATH_WTMPX-and-_PATH_UTMPX-if-not-defined.patch \
+           file://0001-Use-uintmax_t-for-handling-rlim_t.patch \
            "
 SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"

Signature · 1 line

2.15.0

Khem Raj

author

2017-11-09 01:59 UTC #6 lore raw

PATCH 4/5 musl: Update to 1.1.18

In reply to Khem Raj

Rich Felker (9):
fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach
fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17
fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18

Szabolcs Nagy (1):
math: rewrite fma with mostly int arithmetics

Will Dietz (1):
posix_spawn: use larger stack to cover worst-case in execvpe

Signed-off-by Khem Raj <[email protected]>

---
 meta/recipes-core/musl/musl_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

meta/recipes-core/musl/musl_git.bb +2 -2

index 671de326fb..932c9a27a0 100644
@@ -3,9 +3,9 @@
 
 require musl.inc
 
-SRCREV = "48be5b6313d7b827acf555769e93b389fa9f6307"
+SRCREV = "eb03bde2f24582874cb72b56c7811bf51da0c817"
 
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"
 
 # mirror is at git://github.com/kraj/musl.git

Signature · 1 line

2.15.0

Khem Raj

author

2017-11-09 01:59 UTC #11 lore raw

PATCH 5/5 gcc7/gcc6: Fix unaligned STRD issue on ARM

In reply to Khem Raj

Backport
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82445

Fixes [YOCTO 12297]

Signed-off-by Khem Raj <[email protected]>

---
 meta/recipes-devtools/gcc/gcc-6.4.inc              |   1 +
 ...5-suppress-32-bit-aligned-ldrd-strd-peeph.patch | 194 +++++++++++++++++++++
 meta/recipes-devtools/gcc/gcc-7.2.inc              |   1 +
 ...5-suppress-32-bit-aligned-ldrd-strd-peeph.patch | 194 +++++++++++++++++++++
 4 files changed, 390 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc-6.4/0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch
 create mode 100644 meta/recipes-devtools/gcc/gcc-7.2/0051-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch

meta/recipes-devtools/gcc/gcc-6.4.inc +1 -0

index a42b7d83ca..37e996afb7 100644
@@ -80,6 +80,7 @@ SRC_URI = "\
 "
 BACKPORTS = "\
            file://CVE-2016-6131.patch \
+           file://0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch \
 "
 SRC_URI[md5sum] = "11ba51a0cfb8471927f387c8895fe232"
 SRC_URI[sha256sum] = "850bf21eafdfe5cd5f6827148184c08c4a0852a37ccf36ce69855334d2c914d4"

meta/recipes-devtools/gcc/gcc-6.4/0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch new file +194 -0

194 lines not on this page · raw message

meta/recipes-devtools/gcc/gcc-7.2.inc +1 -0

index 04edad77cb..02b8e03482 100644
@@ -79,6 +79,7 @@ SRC_URI = "\
            ${BACKPORTS} \
 "
 BACKPORTS = "\
+           file://0051-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch \
 "
 SRC_URI[md5sum] = "ff370482573133a7fcdd96cd2f552292"
 SRC_URI[sha256sum] = "1cf7adf8ff4b5aa49041c8734bbcf1ad18cc4c94d0029aae0f4e48841088479a"

meta/recipes-devtools/gcc/gcc-7.2/0051-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch new file +194 -0

194 lines not on this page · raw message

Signature · 1 line

2.15.0

Burton, Ross

2017-11-09 20:54 UTC #2 lore raw

Re: [PATCH 1/5] binutils: Convert SRC_URI and SRCREV to weak defines

In reply to Khem Raj

How does this help? A bbappend is parsed after the bb so it can just assign to SRCREV.

Also is it actually useful to change the git url but apply the same patches?

Ross

Quoted 37 lines · Khem Raj

This makes it easy to override them in bbappends
Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-devtools/binutils/binutils-2.29.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-devtools/binutils/binutils-2.29.inc +2 -1
index 27d46eb088..35f76cba6d 100644
@@ -18,9 +18,10 @@ BINUPV = "${@binutils_branch_version(d)}"
 
 UPSTREAM_CHECK_GITTAGREGEX = "binutils-(?P<pver>\d+_(\d_?)*)"
 
-SRCREV = "37e991bb143ca2106330bcdc625590d53838b7a1"
+SRCREV ?= "37e991bb143ca2106330bcdc625590d53838b7a1"
+BINUTILS_GIT_URI ?= "git://sourceware.org/git/binutils-gdb.git;branch=
binutils-${BINUPV}-branch;protocol=git"
SRC_URI = "\
- git://sourceware.org/git/binutils-gdb.git;branch=
binutils-${BINUPV}-branch;protocol=git \
+     ${BINUTILS_GIT_URI} \
      file://0003-configure-widen-the-regexp-for-SH-architectures.patch \
      file://0004-Point-scripts-location-to-libdir.patch \
      file://0005-Only-generate-an-RPATH-entry-if-LD_RUN_PATH-is-not-e.patch
\
--
2.15.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Khem Raj

author

2017-11-09 22:50 UTC #3 lore raw

Re: [PATCH 1/5] binutils: Convert SRC_URI and SRCREV to weak defines

Quoted 5 lines · Ross

How does this help? A bbappend is parsed after the bb so it can just assign to SRCREV.
Also is it actually useful to change the git url but apply the same patches?

yes, this helps with using local forks of upstream and at the same time apply the
patches from OE-Core being on same version. Especially for new archirectures where all support may not be upstream.

Quoted 43 lines

Ross
Quoted 38 lines · Khem Raj
This makes it easy to override them in bbappends
Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-devtools/binutils/binutils-2.29.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-devtools/binutils/binutils-2.29.inc +2 -1
index 27d46eb088..35f76cba6d 100644
@@ -18,9 +18,10 @@ BINUPV = "${@binutils_branch_version(d)}"
 
 UPSTREAM_CHECK_GITTAGREGEX = "binutils-(?P<pver>\d+_(\d_?)*)"
 
-SRCREV = "37e991bb143ca2106330bcdc625590d53838b7a1"
+SRCREV ?= "37e991bb143ca2106330bcdc625590d53838b7a1"
+BINUTILS_GIT_URI ?=
"git://sourceware.org/git/binutils-gdb.git;branch=binutils-${BINUPV}-branch;protocol=git"
SRC_URI = "\
-
git://sourceware.org/git/binutils-gdb.git;branch=binutils-${BINUPV}-branch;protocol=git
\
+     ${BINUTILS_GIT_URI} \
      file://0003-configure-widen-the-regexp-for-SH-architectures.patch \
      file://0004-Point-scripts-location-to-libdir.patch \
file://0005-Only-generate-an-RPATH-entry-if-LD_RUN_PATH-is-not-e.patch \
--
2.15.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Andre McCurdy

2017-12-02 00:31 UTC #7 lore raw

Re: [PATCH 4/5] musl: Update to 1.1.18

In reply to Khem Raj

Quoted 11 lines · Khem Raj

Rich Felker (9):
fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach
fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17
fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18

Quoted 5 lines

Szabolcs Nagy (1):
math: rewrite fma with mostly int arithmetics
Will Dietz (1):
posix_spawn: use larger stack to cover worst-case in execvpe

With the version of musl currently included in rocko, various apps (including bash) segfault at startup when compiled as Thumb2. The "fix access by setjmp and longjmp to __hwcap on arm built as thumb2" commit from musl 1.1.18 fixes that.

However the other changes in musl 1.1.18 look pretty useful too, so unless there's strong objection, I'd like to suggest aligning rocko with the musl 1.1.18 release. ie cherry-picking the following two commits from oe-core master to rocko:

c3f0a70 musl: Update to 1.1.18
3953c54 musl: Update to latest

Quoted 29 lines

Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-core/musl/musl_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/musl/musl_git.bb +2 -3
index 671de326fb..932c9a27a0 100644
@@ -3,9 +3,9 @@
 
 require musl.inc
 
-SRCREV = "48be5b6313d7b827acf555769e93b389fa9f6307"
+SRCREV = "eb03bde2f24582874cb72b56c7811bf51da0c817"
 
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"
 
 # mirror is at git://github.com/kraj/musl.git
 
--
2.15.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Khem Raj

author

2017-12-02 00:38 UTC #8 lore raw

Re: [PATCH 4/5] musl: Update to 1.1.18

Quoted 23 lines · Andre McCurdy

Quoted 11 lines · Khem Raj
Rich Felker (9):
fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach
fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17
fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18
Quoted 5 lines
Szabolcs Nagy (1):
math: rewrite fma with mostly int arithmetics
Will Dietz (1):
posix_spawn: use larger stack to cover worst-case in execvpe
With the version of musl currently included in rocko, various apps (including bash) segfault at startup when compiled as Thumb2. The "fix access by setjmp and longjmp to __hwcap on arm built as thumb2" commit from musl 1.1.18 fixes that.

Quoted 8 lines

However the other changes in musl 1.1.18 look pretty useful too, so unless there's strong objection, I'd like to suggest aligning rocko with the musl 1.1.18 release. ie cherry-picking the following two commits from oe-core master to rocko:
c3f0a70 musl: Update to 1.1.18
3953c54 musl: Update to latest

It seems good to me. Please send a pull and CC Armin

Quoted 30 lines

Quoted 30 lines
Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-core/musl/musl_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/musl/musl_git.bb +2 -3
index 671de326fb..932c9a27a0 100644
@@ -3,9 +3,9 @@
 
 require musl.inc
 
-SRCREV = "48be5b6313d7b827acf555769e93b389fa9f6307"
+SRCREV = "eb03bde2f24582874cb72b56c7811bf51da0c817"
 
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"
 
 # mirror is at git://github.com/kraj/musl.git
 
--
2.15.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Andre McCurdy

2017-12-02 00:41 UTC #9 lore raw

Re: [PATCH 4/5] musl: Update to 1.1.18

Quoted 29 lines · Khem Raj

Quoted 28 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Rich Felker (9):
fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach
fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17
fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18
Quoted 5 lines
Szabolcs Nagy (1):
math: rewrite fma with mostly int arithmetics
Will Dietz (1):
posix_spawn: use larger stack to cover worst-case in execvpe
With the version of musl currently included in rocko, various apps (including bash) segfault at startup when compiled as Thumb2. The "fix access by setjmp and longjmp to __hwcap on arm built as thumb2" commit from musl 1.1.18 fixes that.
However the other changes in musl 1.1.18 look pretty useful too, so unless there's strong objection, I'd like to suggest aligning rocko with the musl 1.1.18 release. ie cherry-picking the following two commits from oe-core master to rocko:

Quoted 4 lines

Quoted 2 lines
c3f0a70 musl: Update to 1.1.18
3953c54 musl: Update to latest
It seems good to me. Please send a pull and CC Armin

Armin, please consider the following two commits for rocko:

c3f0a70 musl: Update to 1.1.18
3953c54 musl: Update to latest

Quoted 30 lines

Quoted 30 lines
Quoted 30 lines
Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-core/musl/musl_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/musl/musl_git.bb +2 -3
index 671de326fb..932c9a27a0 100644
@@ -3,9 +3,9 @@
 
 require musl.inc
 
-SRCREV = "48be5b6313d7b827acf555769e93b389fa9f6307"
+SRCREV = "eb03bde2f24582874cb72b56c7811bf51da0c817"
 
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"
 
 # mirror is at git://github.com/kraj/musl.git
 
--
2.15.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Andre McCurdy

2018-02-09 19:52 UTC #10 lore raw

Re: [PATCH 4/5] musl: Update to 1.1.18

Quoted 33 lines · Andre McCurdy

Quoted 32 lines · Khem Raj
Quoted 30 lines · Andre McCurdy
Quoted 11 lines · Khem Raj
Rich Felker (9):
fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach
fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17
fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18
Quoted 5 lines
Szabolcs Nagy (1):
math: rewrite fma with mostly int arithmetics
Will Dietz (1):
posix_spawn: use larger stack to cover worst-case in execvpe
With the version of musl currently included in rocko, various apps (including bash) segfault at startup when compiled as Thumb2. The "fix access by setjmp and longjmp to __hwcap on arm built as thumb2" commit from musl 1.1.18 fixes that.
However the other changes in musl 1.1.18 look pretty useful too, so unless there's strong objection, I'd like to suggest aligning rocko with the musl 1.1.18 release. ie cherry-picking the following two commits from oe-core master to rocko:
c3f0a70 musl: Update to 1.1.18
3953c54 musl: Update to latest

Quoted 6 lines

Quoted 1 line
It seems good to me. Please send a pull and CC Armin
Armin, please consider the following two commits for rocko:
c3f0a70 musl: Update to 1.1.18
3953c54 musl: Update to latest

Ping.

Any comments Armin?