ASoC: fsl_asrc: neatening
Subsystems (3)
PATCH 2/2 ASoC: fsl_asrc: constify some arrays
In reply to Joe PerchesUsing const reduces data.
$ size sound/soc/fsl/fsl_asrc.o* text data bss dec hex filename 21691 5872 192 27755 6c6b sound/soc/fsl/fsl_asrc.o.new 21435 6128 192 27755 6c6b sound/soc/fsl/fsl_asrc.o.old
Signed-off-by Joe Perches <[email protected]>
--- sound/soc/fsl/fsl_asrc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
sound/soc/fsl/fsl_asrc.c +7 -7
@@ -49,12 +49,12 @@ static const u8 process_option[][12][2] = { };/* Corresponding to process_option */ -static int supported_input_rate[] = { +static const int supported_input_rate[] = {5512 ,8000 ,11025 ,16000 ,22050 ,32000 ,44100 ,48000 ,64000 ,88200 ,96000 ,176400 ,192000 , }; -static int supported_asrc_rate[] = { +static const int supported_asrc_rate[] = {8000 ,11025 ,16000 ,22050 ,32000 ,44100 ,48000 ,64000 ,88200 ,96000 ,176400 ,192000 , };
@@ -62,26 +62,26 @@ static int supported_asrc_rate[] = {* The following tables map the relationship between asrc_inclk/asrc_outclk in * fsl_asrc.h and the registers of ASRCSR */ -static unsigned char input_clk_map_imx35[] = { +static const unsigned char input_clk_map_imx35[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 ,0xa ,0xb ,0xc ,0xd ,0xe ,0xf , }; -static unsigned char output_clk_map_imx35[] = { +static const unsigned char output_clk_map_imx35[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 ,0xa ,0xb ,0xc ,0xd ,0xe ,0xf , };/* i.MX53 uses the same map for input and output */ -static unsigned char input_clk_map_imx53[] = { +static const unsigned char input_clk_map_imx53[] = {/* 0x0 0x1 0x2 0x3 0x4 0x5 0x6 0x7 0x8 0x9 0xa 0xb 0xc 0xd 0xe 0xf */ 0x0 ,0x1 ,0x2 ,0x7 ,0x4 ,0x5 ,0x6 ,0x3 ,0x8 ,0x9 ,0xa ,0xb ,0xc ,0xf ,0xe ,0xd , }; -static unsigned char output_clk_map_imx53[] = { +static const unsigned char output_clk_map_imx53[] = {/* 0x0 0x1 0x2 0x3 0x4 0x5 0x6 0x7 0x8 0x9 0xa 0xb 0xc 0xd 0xe 0xf */ 0x8 ,0x9 ,0xa ,0x7 ,0xc ,0x5 ,0x6 ,0xb ,0x0 ,0x1 ,0x2 ,0x3 ,0x4 ,0xf ,0xe ,0xd , }; -static unsigned char *clk_map[2 ]; +static const unsigned char *clk_map[2 ];/** * Request ASRC pair
Signature · 1 line
2.15.0
cover ASoC: fsl_asrc: neatening
Joe Perches (2):
ASoC: fsl_asrc: Fix line continuation format
ASoC: fsl_asrc: constify some arrays
sound/soc/fsl/fsl_asrc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
2.15.0
PATCH 1/2 ASoC: fsl_asrc: Fix line continuation format
Line continuations with excess spacing causes unexpected output
Signed-off-by Joe Perches <[email protected]>
--- sound/soc/fsl/fsl_asrc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/fsl/fsl_asrc.c +2 -2
@@ -288,8 +288,8 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair *pair)if ((outrate >8000 && outrate <30000 ) && (outrate/inrate >24 || inrate/outrate >8 )) { -pair_err ("exceed supported ratio range [1/24, 8] for \ -inrate/outrate: %d/%d\n" , inrate, outrate); +pair_err ("exceed supported ratio range [1/24, 8] for inrate/outrate: %d/%d\n" , + inrate, outrate);return -EINVAL ; }
Signature · 1 line
2.15.0
Re: [PATCH 1/2] ASoC: fsl_asrc: Fix line continuation format
Quoted 3 lines · Joe Perches
Line continuations with excess spacing causes unexpected output
Signed-off-by Joe Perches <[email protected]>
Acked-by Nicolin Chen <[email protected]>
Quoted 22 lines
--- sound/soc/fsl/fsl_asrc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)sound/soc/fsl/fsl_asrc.c +2
-2@@ -288,8 +288,8 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair *pair)if ((outrate >8000 && outrate <30000 ) && (outrate/inrate >24 || inrate/outrate >8 )) { -pair_err ("exceed supported ratio range [1/24, 8] for \ -inrate/outrate: %d/%d\n" , inrate, outrate); +pair_err ("exceed supported ratio range [1/24, 8] for inrate/outrate: %d/%d\n" , + inrate, outrate);return -EINVAL ; }Signature · 1 line
2.15.0
Re: [PATCH 2/2] ASoC: fsl_asrc: constify some arrays
In reply to Joe PerchesQuoted 8 lines · Joe Perches
Using const reduces data.
$ size sound/soc/fsl/fsl_asrc.o* text data bss dec hex filename 21691 5872 192 27755 6c6b sound/soc/fsl/fsl_asrc.o.new 21435 6128 192 27755 6c6b sound/soc/fsl/fsl_asrc.o.oldSigned-off-by Joe Perches <[email protected]>
Acked-by Nicolin Chen <[email protected]>
Quoted 58 lines
--- sound/soc/fsl/fsl_asrc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)sound/soc/fsl/fsl_asrc.c +7
-7@@ -49,12 +49,12 @@ static const u8 process_option[][12][2] = { };/* Corresponding to process_option */ -static int supported_input_rate[] = { +static const int supported_input_rate[] = {5512 ,8000 ,11025 ,16000 ,22050 ,32000 ,44100 ,48000 ,64000 ,88200 ,96000 ,176400 ,192000 , }; -static int supported_asrc_rate[] = { +static const int supported_asrc_rate[] = {8000 ,11025 ,16000 ,22050 ,32000 ,44100 ,48000 ,64000 ,88200 ,96000 ,176400 ,192000 , };@@ -62,26 +62,26 @@ static int supported_asrc_rate[] = {* The following tables map the relationship between asrc_inclk/asrc_outclk in * fsl_asrc.h and the registers of ASRCSR */ -static unsigned char input_clk_map_imx35[] = { +static const unsigned char input_clk_map_imx35[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 ,0xa ,0xb ,0xc ,0xd ,0xe ,0xf , }; -static unsigned char output_clk_map_imx35[] = { +static const unsigned char output_clk_map_imx35[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 ,0xa ,0xb ,0xc ,0xd ,0xe ,0xf , };/* i.MX53 uses the same map for input and output */ -static unsigned char input_clk_map_imx53[] = { +static const unsigned char input_clk_map_imx53[] = {/* 0x0 0x1 0x2 0x3 0x4 0x5 0x6 0x7 0x8 0x9 0xa 0xb 0xc 0xd 0xe 0xf */ 0x0 ,0x1 ,0x2 ,0x7 ,0x4 ,0x5 ,0x6 ,0x3 ,0x8 ,0x9 ,0xa ,0xb ,0xc ,0xf ,0xe ,0xd , }; -static unsigned char output_clk_map_imx53[] = { +static const unsigned char output_clk_map_imx53[] = {/* 0x0 0x1 0x2 0x3 0x4 0x5 0x6 0x7 0x8 0x9 0xa 0xb 0xc 0xd 0xe 0xf */ 0x8 ,0x9 ,0xa ,0x7 ,0xc ,0x5 ,0x6 ,0xb ,0x0 ,0x1 ,0x2 ,0x3 ,0x4 ,0xf ,0xe ,0xd , }; -static unsigned char *clk_map[2 ]; +static const unsigned char *clk_map[2 ];/** * Request ASRC pair Signature · 1 line
2.15.0