ltp: add runtime depends ltp-staticdev
cover ltp: add runtime depends ltp-staticdev
The following changes since commit ed48e7b4f0d11bf20e0be44d8403fc16dd6d4411:
usbutils: remove uclibc-specific patch (2017-11-30 10:49:22 +0000)
are available in the git repository at:
https://github.com/DengkeDu/openembedded-core.git fix-nm01-failed
https://github.com//tree/fix-nm01-failed
Dengke Du (1):
ltp: add runtime depends ltp-staticdev
meta/recipes-extended/ltp/ltp_20170929.bb | 1 + 1 file changed, 1 insertion(+)
Signature · 1 line
2.8.1
PATCH 1/1 ltp: add runtime depends ltp-staticdev
The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in ltp-staticdev package.
--- meta/recipes-extended/ltp/ltp_20170929.bb | 1 + 1 file changed, 1 insertion(+)
meta/recipes-extended/ltp/ltp_20170929.bb +1 -0
@@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\ FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/* /opt/ltp/testcases/open_posix_testsuite/conformance/* /opt/ltp/testcases/open_posix_testsuite/Documentation/* /opt/ltp/testcases/open_posix_testsuite/functional/* /opt/ltp/testcases/open_posix_testsuite/include/* /opt/ltp/testcases/open_posix_testsuite/scripts/* /opt/ltp/testcases/open_posix_testsuite/stress/* /opt/ltp/testcases/open_posix_testsuite/tools/*" +RDEPENDES_${PN} += "${PN}-staticdev" # Avoid generated binaries stripping. Otherwise some of the ltp tests such as ldd01 & nm01 fails INHIBIT_PACKAGE_STRIP = "1"
Signature · 1 line
2.8.1
Quoted 3 lines · Dengke Du
The test case nm01 depends on
/opt/ltp/testcases/data/nm01/lib.ain ltp-staticdev package.
perhaps its better to create a packaging exception to include this static library to be packaged into ${PN}
Quoted 25 lines
Signed-off-by Dengke Du <[email protected]>--- meta/recipes-extended/ltp/ltp_20170929.bb | 1 + 1 file changed, 1 insertion(+)meta/recipes-extended/ltp/ltp_20170929.bb +1
-1@@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\ FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/* /opt/ltp/testcases/open_posix_testsuite/conformance/* /opt/ltp/testcases/open_posix_testsuite/Documentation/* /opt/ltp/testcases/open_posix_testsuite/functional/* /opt/ltp/testcases/open_posix_testsuite/include/* /opt/ltp/testcases/open_posix_testsuite/scripts/* /opt/ltp/testcases/open_posix_testsuite/stress/* /opt/ltp/testcases/open_posix_testsuite/tools/*" +RDEPENDES_${PN} += "${PN}-staticdev" # Avoid generated binaries stripping. Otherwise some of the ltp tests such as ldd01 & nm01 fails INHIBIT_PACKAGE_STRIP = "1" --2.8.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 24 lines · Khem Raj
Quoted 3 lines · Dengke Du
The test case nm01 depends on
/opt/ltp/testcases/data/nm01/lib.ain ltp-staticdev package.perhaps its better to create a packaging exception to include this static library to be packaged into ${PN}
Review
Quoted 6 lines
Signed-off-by Dengke Du <[email protected]>--- meta/recipes-extended/ltp/ltp_20170929.bb | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0b/meta/recipes-extended/ltp/ltp_20170929.bb
meta/recipes-extended/ltp/ltp_20170929.bb RDEPENDS_${PN} = "\ · line 108
Quoted 5 lines
index 93a59b3..6fd280c 100644
meta/recipes-extended/ltp/ltp_20170929.bb +0
-0@@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\ FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a
/opt/ltp/testcases/data/nm01/lib.a"meta/recipes-extended/ltp/ltp_20170929.bb RDEPENDS_${PN} = "\ · line 109
Quoted 2 lines
meta/recipes-extended/ltp/ltp_20170929.bb +0
-0FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/*
Quoted 12 lines
/opt/ltp/scenario_groups/*/opt/ltp/testcases/bin/*/opt/ltp/testcases/bin/*/bin/*/opt/ltp/testscripts/*/opt/ltp/testcases/open_posix_testsuite/*/opt/ltp/testcases/open_posix_testsuite/conformance/*/opt/ltp/testcases/open_posix_testsuite/Documentation/*/opt/ltp/testcases/open_posix_testsuite/functional/*/opt/ltp/testcases/open_posix_testsuite/include/*/opt/ltp/testcases/open_posix_testsuite/scripts/*/opt/ltp/testcases/open_posix_testsuite/stress/*/opt/ltp/testcases/open_posix_testsuite/tools/*"Quoted 1 line
meta/recipes-extended/ltp/ltp_20170929.bb +1
-0+RDEPENDES_${PN} += "${PN}-staticdev"
Typo in RDEPENDS
Please make sure you test patches before submitting. This could not have worked as intended.
Quoted 18 lines
meta/recipes-extended/ltp/ltp_20170929.bb RDEPENDS_${PN} = "\ · line 111
Quoted 2 lines
meta/recipes-extended/ltp/ltp_20170929.bb +0
-0# Avoid generated binaries stripping. Otherwise some of the ltp testssuch as ldd01 & nm01 fails
Quoted 9 lines
meta/recipes-extended/ltp/ltp_20170929.bb +0
-1INHIBIT_PACKAGE_STRIP = "1" --2.8.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Sorry for my errors, I have added the "ltp-staticdev" to my IMAGE_INSTALL_append,
so the nm01 test case have passed.
Quoted 68 lines · Tim Orling
On Fri, Dec 1, 2017 at 6:52 AM Khem Raj <[email protected] <mailto:[email protected]>> wrote:
On Thu, Nov 30, 2017 at 10:58 PM, Dengke Du <[email protected] <mailto:[email protected]>> wrote: > The test case nm01 depends on /opt/ltp/testcases/data/nm01/lib.a in > ltp-staticdev package. > perhaps its better to create a packaging exception to include this static library to be packaged into ${PN} > Signed-off-by: Dengke Du <[email protected] <mailto:[email protected]>> > --- > meta/recipes-extended/ltp/ltp_20170929.bb <http://ltp_20170929.bb> | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-extended/ltp/ltp_20170929.bb <http://ltp_20170929.bb> b/meta/recipes-extended/ltp/ltp_20170929.bb <http://ltp_20170929.bb> > index 93a59b3..6fd280c 100644 > --- a/meta/recipes-extended/ltp/ltp_20170929.bb <http://ltp_20170929.bb> > +++ b/meta/recipes-extended/ltp/ltp_20170929.bb <http://ltp_20170929.bb> > @@ -108,6 +108,7 @@ RDEPENDS_${PN} = "\ > FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a /opt/ltp/testcases/data/nm01/lib.a" > > FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/* /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/* /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/* /opt/ltp/testcases/open_posix_testsuite/conformance/* /opt/ltp/testcases/open_posix_testsuite/Documentation/* /opt/ltp/testcases/open_posix_testsuite/functional/* /opt/ltp/testcases/open_posix_testsuite/include/* /opt/ltp/testcases/open_posix_testsuite/scripts/* /opt/ltp/testcases/open_posix_testsuite/stress/* /opt/ltp/testcases/open_posix_testsuite/tools/*" > +RDEPENDES_${PN} += "${PN}-staticdev"Typo in RDEPENDS
Please make sure you test patches before submitting. This could not have worked as intended.Quoted 2 lines
# Avoid generated binaries stripping. Otherwise some of the ltp
tests such as ldd01 & nm01 fails > INHIBIT_PACKAGE_STRIP = "1" > -- > 2.8.1 > > -- > _______________________________________________ > Openembedded-core mailing list > [email protected] <mailto:[email protected]> > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list [email protected] <mailto:[email protected]> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 8 lines · Khem Raj
Quoted 3 lines · Dengke Du
The test case nm01 depends on
/opt/ltp/testcases/data/nm01/lib.ain ltp-staticdev package.perhaps its better to create a packaging exception to include this static library to be packaged into ${PN}
Definitely. For ltp I suspect the standard PN PN-dev PN-staticdev split is entirely pointless, so just don't create those extra packages and silence the QA checks.
Ross