Skip to contentSkip to conversation

e2fsprogs: fixes for ptest

PATCH In review [email protected] 3 participants 6 messages Feb 2, 2018

lore
Share & tools
lore
#0 lore raw

cover e2fsprogs: fixes for ptest

From: Jackie Huang <[email protected]>

--
The following changes since commit 385944254d0ef88bd6450a221a54cbcb40020b42:

tcmode-default.inc: drop preferred version of gzip-native (2018-01-31 17:01:20 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib.git jhuang0/d_e2fsprogs-ptest_180202_0
http://git.pokylinux.org/cgit.cgi//log/?h=jhuang0/d_e2fsprogs-ptest_180202_0

Jackie Huang (2):
e2fsprogs: only quiet debugfs for native package
e2fsprogs: fix the hardcoded paths for ptest

 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/2 e2fsprogs: only quiet debugfs for native package

From: Jackie Huang <[email protected]>

Many test cases expect the output of running commands for debugfs, the patch quiet-debugfs.patch suppress the output so ptest failed:
| 292 tests succeeded 47 tests failed

The patch was meant to suppress the output in do_rootfs according to the original commit:
======================
commit 13a8d3869b0fe0ebdddcee37fb48c5b9cdf718ba
Author: Ross Burton <[email protected]>
Date: Mon Dec 23 13:38:34 2013 +0000

e2fsprogs: silence debugfs

debugfs echos the commands when it is executing a script, but as the scripts used at rootfs time are long this massively inflates the do_rootfs log.

Comment out the echo so that the rootfs isn't 20K lines longer than it needs to be.

======================

So only apply the patch for native package, then the ptest will be pass for target package.

---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb +3 -2
index b5cfc6810b..a53585db47 100644
@@ -1,7 +1,6 @@
 require e2fsprogs.inc
 
 SRC_URI += "file://remove.ldconfig.call.patch \
-            file://quiet-debugfs.patch \
             file://run-ptest \
             file://ptest.patch \
             file://Revert-mke2fs-enable-the-metadata_csum-and-64bit-fea.patch \
@@ -10,7 +9,9 @@ SRC_URI += "file://remove.ldconfig.call.patch \
             file://0001-libext2fs-fix-build-failure-in-swapfs.c-on-big-endia.patch \
             "
 
-SRC_URI_append_class-native = " file://e2fsprogs-fix-missing-check-for-permission-denied.patch"
+SRC_URI_append_class-native = " file://e2fsprogs-fix-missing-check-for-permission-denied.patch \
+                                file://quiet-debugfs.patch \
+"
 
 SRCREV = "af2eac481cf426c05ae12b946396980e16c8ab19"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+\.\d+(\.\d+)*)$"
Signature · 1 line
2.11.0
#2 lore raw

PATCH 2/2 e2fsprogs: fix the hardcoded paths for ptest

In reply to [email protected]

From: Jackie Huang <[email protected]>

Fix the hardcoded paths in test scripts and expect files to avoid issue like:
| cat: ../e2fsck/e2fsck: No such file or directory

---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.8.bb +3 -1
index a53585db47..ceaf171585 100644
@@ -104,7 +104,9 @@ do_compile_ptest() {
 do_install_ptest() {
 	cp -R --no-dereference --preserve=mode,links -v ${B}/tests ${D}${PTEST_PATH}/test
 	cp -R --no-dereference --preserve=mode,links -v ${S}/tests/* ${D}${PTEST_PATH}/test
-	sed -e 's!../e2fsck/e2fsck!e2fsck!g' -i ${D}${PTEST_PATH}/test/*/expect*
+	sed -e 's!../e2fsck/e2fsck!e2fsck!g' \
+	    -e 's!../misc/tune2fs!tune2fs!g' -i ${D}${PTEST_PATH}/test/*/expect*
+	sed -e 's!../e2fsck/e2fsck!${base_sbindir}/e2fsck!g' -i ${D}${PTEST_PATH}/test/*/script
 
 	# Remove various files
 	find "${D}${PTEST_PATH}" -type f \
Signature · 1 line
2.11.0
#3 lore raw

✗ patchtest: failure for e2fsprogs: fixes for ptest

In reply to [email protected]

== Series Details ==

Series: e2fsprogs: fixes for ptest
Revision: 1
URL : https://patchwork.openembedded.org/series/10824/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Patches not removed from tree [test_src_uri_left_files]
Suggested fix Amend the patch containing the software patch file removal
Patch quiet-debugfs.patch

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#4 lore raw

Re: ✗ patchtest: failure for e2fsprogs: fixes for ptest

Quoted 25 lines

-----Original Message-----
From: Patchwork [mailto:[email protected]]
Sent: Friday, February 02, 2018 15:33
To: Huang, Jie (Jackie)
Cc: [email protected]
Subject: ✗ patchtest: failure for e2fsprogs: fixes for ptest

== Series Details ==

Series: e2fsprogs: fixes for ptest
Revision: 1
URL : https://patchwork.openembedded.org/series/10824/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

Quoted 3 lines

* Issue Patches not removed from tree [test_src_uri_left_files]
Suggested fix Amend the patch containing the software patch file removal
Patch quiet-debugfs.patch

What I did is moving the "quiet-debugfs.patch" from SRC_URI to SRC_URI_append_class-native, the patch file is not meant to be removed.

I think the test_src_uri_left_files needs to consider such changes.

Thanks,
Jackie

Quoted 18 lines

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---
Guidelines:
https://www.openembedded.org/wiki/Commit_Patch_Message_Guideline
s

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#5 lore raw

Re: ✗ patchtest: failure for e2fsprogs: fixes for ptest

Yes, this clearly isn't right.

On 2 February 2018 at 07:52, Huang, Jie (Jackie) <[email protected]

Quoted 70 lines
Quoted 17 lines · wrote:

-----Original Message-----
From: Patchwork [mailto:[email protected]]
Sent: Friday, February 02, 2018 15:33
To: Huang, Jie (Jackie)
Cc: [email protected]
Subject: ✗ patchtest: failure for e2fsprogs: fixes for ptest

== Series Details ==

Series: e2fsprogs: fixes for ptest
Revision: 1
URL : https://patchwork.openembedded.org/series/10824/
State : failure

== Summary ==

Quoted 7 lines

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Patches not removed from tree

[test_src_uri_left_files]

Quoted 1 line

Suggested fix Amend the patch containing the software patch file

removal

Quoted 1 line

Patch quiet-debugfs.patch

What I did is moving the "quiet-debugfs.patch" from SRC_URI to SRC_URI_append_class-native,
the patch file is not meant to be removed.

I think the test_src_uri_left_files needs to consider such changes.

Thanks,
Jackie

Quoted 4 lines

If you believe any of these test results are incorrect, please reply to

the

Quoted 5 lines

mailing list ([email protected]) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment

the

Quoted 1 line

version number when sending the new version (i.e. [PATCH] -> [PATCH v2]

->

Quoted 8 lines

[PATCH v3] -> ...).

---
Guidelines:
https://www.openembedded.org/wiki/Commit_Patch_Message_Guideline
s

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core