Skip to contentSkip to conversation

Cleanup for staging lustre obdclass

PATCH New Dafna Hirschfeld 1 participant 4 messages Mar 4, 2018 Staging

lore
Share & tools
lore

Dafna Hirschfeld

author
#0 lore raw

v3 cover Cleanup for staging lustre obdclass

Fixes of issues found with checkpatch.pl for the lustre obdclass driver.

Changes in v3:
Adding the acked-by to the commit body in the patches

Dafna Hirschfeld (3):
staging: lustre: obdclass: Fix comparison to NULL
staging: lustre: obdclass: Add 'const' to char* array
staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'

 drivers/staging/lustre/lustre/obdclass/cl_lock.c        | 2 +-
 drivers/staging/lustre/lustre/obdclass/cl_object.c      | 2 +-
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
 drivers/staging/lustre/lustre/obdclass/lu_object.c      | 8 ++++----
 4 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v3 1/3 staging: lustre: obdclass: Fix comparison to NULL

Replace comparison to NULL with a 'not' operator.
Issue found with checkpatch.

Signed-off-by Dafna Hirschfeld <[email protected]>
Acked-by Julia Lawall <[email protected]>
---
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +1 -1
index e1f4ef2..64cc746 100644
@@ -1585,7 +1585,7 @@ int ldebugfs_seq_create(struct dentry *parent, const char *name,
 	struct dentry *entry;
 
 	/* Disallow secretly (un)writable entries. */
-	LASSERT((seq_fops->write == NULL) == ((mode & 0222) == 0));
+	LASSERT((!seq_fops->write) == ((mode & 0222) == 0));
 
 	entry = debugfs_create_file(name, mode, parent, data, seq_fops);
 	if (IS_ERR_OR_NULL(entry))
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH v3 2/3 staging: lustre: obdclass: Add 'const' to char* array

In reply to Dafna Hirschfeld

Replace 'const char*' arrays with 'const char * const' since the values in the arrays are not changed. Issues found with checkpatch.pl

Signed-off-by Dafna Hirschfeld <[email protected]>
Acked-by Julia Lawall <[email protected]>
---
 drivers/staging/lustre/lustre/obdclass/cl_lock.c   | 2 +-
 drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/lustre/lustre/obdclass/cl_lock.c +1 -1
index 3b683b7..9ca29a2 100644
@@ -224,7 +224,7 @@ EXPORT_SYMBOL(cl_lock_release);
 
 const char *cl_lock_mode_name(const enum cl_lock_mode mode)
 {
-	static const char *names[] = {
+	static const char * const names[] = {
 		[CLM_READ]    = "R",
 		[CLM_WRITE]   = "W",
 		[CLM_GROUP]   = "G"
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -1
index 7b18d77..7809f6a 100644
@@ -495,7 +495,7 @@ static struct cache_stats cl_env_stats = {
 int cl_site_stats_print(const struct cl_site *site, struct seq_file *m)
 {
 	size_t i;
-	static const char *pstate[] = {
+	static const char * const pstate[] = {
 		[CPS_CACHED]  = "c",
 		[CPS_OWNED]   = "o",
 		[CPS_PAGEOUT] = "w",
Signature · 1 line
2.7.4
author
#3 lore raw

PATCH v3 3/3 staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'

In reply to Dafna Hirschfeld

Replace 'unsigned' with 'unsigned int' to improve readability. Issues found with checkpatch.pl

Signed-off-by Dafna Hirschfeld <[email protected]>
Acked-by Julia Lawall <[email protected]>
---
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
 drivers/staging/lustre/lustre/obdclass/lu_object.c      | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +1 -1
index 64cc746..2ed3505 100644
@@ -1467,7 +1467,7 @@ int lprocfs_write_frac_u64_helper(const char __user *buffer,
 {
 	char kernbuf[22], *end, *pbuf;
 	__u64 whole, frac = 0, units;
-	unsigned frac_d = 1;
+	unsigned int frac_d = 1;
 	int sign = 1;
 
 	if (count > (sizeof(kernbuf) - 1))
drivers/staging/lustre/lustre/obdclass/lu_object.c +4 -4
index cca6881..964e854 100644
@@ -1797,10 +1797,10 @@ int lu_env_refill(struct lu_env *env)
 EXPORT_SYMBOL(lu_env_refill);
 
 struct lu_site_stats {
-	unsigned	lss_populated;
-	unsigned	lss_max_search;
-	unsigned	lss_total;
-	unsigned	lss_busy;
+	unsigned int	lss_populated;
+	unsigned int	lss_max_search;
+	unsigned int	lss_total;
+	unsigned int	lss_busy;
 };
 
 static void lu_site_stats_get(struct cfs_hash *hs,
Signature · 1 line
2.7.4