Skip to contentSkip to conversation

rpmsg: use put_device() if device_register fail

PATCH In review Arvind Yadav 2 participants 4 messages Mar 8, 2018 – Mar 18, 2018

Subsystems (2)
Arm Qualcomm mailing list Remote processor messaging (rpmsg)
lore
Share & tools
lore

Arvind Yadav

author
#0 lore raw

cover rpmsg: use put_device() if device_register fail

if device_register() returned an error! Always use put_device() to give up the reference initialized. unregister device for other return error.

Arvind Yadav (2):
[PATCH 1/2] rpmsg: glink: use put_device() if device_register fail [PATCH 2/2] rpmsg: smd: use put_device() if device_register fail

 drivers/rpmsg/qcom_glink_smem.c | 3 ++-
 drivers/rpmsg/qcom_smd.c        | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/2 rpmsg: glink: use put_device() if device_register fail

if device_register() returned an error! Always use put_device() to give up the reference initialized. And unregister device for other return error.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/rpmsg/qcom_glink_smem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/rpmsg/qcom_glink_smem.c +2 -1
index 892f2b9..3fa9d43 100644
@@ -217,6 +217,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent,
 	ret = device_register(dev);
 	if (ret) {
 		pr_err("failed to register glink edge\n");
+		put_device(dev);
 		return ERR_PTR(ret);
 	}
 

@@ -299,7 +300,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent,
 	return glink;
 
 err_put_dev:
-	put_device(dev);
+	device_unregister(dev);
 
 	return ERR_PTR(ret);
 }
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 2/2 rpmsg: smd: use put_device() if device_register fail

In reply to Arvind Yadav

if device_register() returned an error! Always use put_device() to give up the reference initialized. unregister device for other return error.

Signed-off-by Arvind Yadav <[email protected]>
---
 drivers/rpmsg/qcom_smd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/rpmsg/qcom_smd.c +2 -1
index 92d0c6a..ff8101a 100644
@@ -1408,6 +1408,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent,
 	ret = device_register(&edge->dev);
 	if (ret) {
 		pr_err("failed to register smd edge\n");
+		put_device(&edge->dev);
 		return ERR_PTR(ret);
 	}
 

@@ -1428,7 +1429,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent,
 	return edge;
 
 unregister_dev:
-	put_device(&edge->dev);
+	device_unregister(&edge->dev);
 	return ERR_PTR(ret);
 }
 EXPORT_SYMBOL(qcom_smd_register_edge);
Signature · 1 line
1.9.1
#3 lore raw
In reply to Arvind Yadav
Quoted 4 lines · Arvind Yadav

if device_register() returned an error! Always use put_device() to give up the reference initialized. unregister device for other return error.

Patches applied.

Thanks,
Bjorn

Quoted 12 lines

Arvind Yadav (2):
[PATCH 1/2] rpmsg: glink: use put_device() if device_register fail [PATCH 2/2] rpmsg: smd: use put_device() if device_register fail

 drivers/rpmsg/qcom_glink_smem.c | 3 ++-
 drivers/rpmsg/qcom_smd.c        | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1