*** Fix build issue with html5lib in bitbake 1.26/1.28 ***

This fixes a build issue where bitbake won't run because of an issue with one of the libraries it depends on.

The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2:

bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000)

are available in the Git repository at:

git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib

Soemoe Aung (2):
fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch

 bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.0.rc0.231.g781580f067-goog

--
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

What branch is this meant to be applied to?

Also, as it's a bitbake change, this should go to the bitbake list.

Quoted 1 line · Soemoe Aung

This fixes a build issue where bitbake won't run because of an issue

with one of the libraries it depends on.

Quoted 2 lines

The following changes since commit ea6d21066a7cce2fef08ad66287170

c5995bb1e2:

Quoted 2 lines

bitbake: bitbake-user-manual: Fixed porno hack for hello world example

(2018-01-17 22:32:46 +0000)

Quoted 20 lines

are available in the Git repository at:

git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib

Soemoe Aung (2):
fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch

 bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.0.rc0.231.g781580f067-goog

--
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Sorry if it wasn't clear. This is meant for fido (and also jethro). The context is that when doing a fresh checkout of yocto-poky for branches fido or jethro, I wasn't able to build with bitbake because of an error in one of its included libraries. This issue seems to be resolved starting in the krogoth branch.

If I send this change to the bitbake list, would it also get applied to the yocto-poky repo in the fido and jethro branches?

Quoted 2 lines · Soemoe Aung

Sorry if it wasn't clear. This is meant for fido (and also jethro). The context is that when doing a fresh checkout of yocto-poky for branches

fido

Quoted 1 line

or jethro, I wasn't able to build with bitbake because of an error in

one of

Quoted 4 lines

its included libraries. This issue seems to be resolved starting in the krogoth branch.

If I send this change to the bitbake list, would it also get applied to

the

Quoted 1 line

yocto-poky repo in the fido and jethro branches?

Yes, send it to bitbake@ and the maintainer will ensure that it bubbles through to the Poky repos.

Ross

This fixes a build issue where bitbake won't run because of an issue with one of the libraries it depends on.

The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2:

  bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000)

are available in the Git repository at:

  git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib

Soemoe Aung (2):
  fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch

  bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----

  1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.0.rc0.231.g781580f067-goog

--
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

This has already been fixed on a few branches with

bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8

It might be better to backport that where needed.

--
Ola Nilsson
________________________________________
From: [email protected] < [email protected]> on behalf of Soemoe Aung < [email protected]>
Sent: Tuesday, March 27, 2018 23:15
To: [email protected]
Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in
bitbake 1.26/1.28 ***

When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib is indeed different there.

yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also has the issue fixed in the bitbake repo.

I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky fido and jethro branches?

Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky.

The following changes since commit ea6d21066a7cce2fef08ad66287170 c5995bb1e2:

bitbake: bitbake-user-manual: Fixed porno hack for hello world example
(2018-01-17 22:32:46 +0000)

are available in the Git repository at:

git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib

Soemoe Aung (2):
fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch

 bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.0.rc0.231.g781580f067-goog

--
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/bitbake-devel
--
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/bitbake-devel

One way to create and send the patch is:

git cherry-pick 1679188f9c55c615cae780f2b5e6852dea9cf2ec # Assuming you are in the bitbake repository, not poky

git commit --amend # To add your Signed-off-by footer

git format-patch --subject-prefix='jethro][PATCH' 'HEAD^..HEAD'

git send-email [email protected] --confirm=always --no-chain-reply-to --suppress-cc=all 000*

//Peter

*From:* [email protected] [mailto:
[email protected]] *On Behalf Of *Soemoe Aung *Sent:* den 28 mars 2018 18:47
*To:* Ola x Nilsson <[email protected]>
*Cc:* [email protected]
*Subject:* Re: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 ***

Yes, that's essentially what I'm asking for. Sorry if that wasn't clear. That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as well. My change literally took the html5lib file from 1.30 and copied it to the file in 1.26 and submitted it as a patch. Apologies if this was the wrong way to go about this.

What are the steps to backport this change to 1.26 and 1.28 (and also to send these changes upstream to yocto-poky)? Is there anything I need to do?

On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <[email protected]> wrote:

This has already been fixed on a few branches with

bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8

It might be better to backport that where needed.

--
Ola Nilsson
________________________________________
From: [email protected] < [email protected]> on behalf of Soemoe Aung < [email protected]>
Sent: Tuesday, March 27, 2018 23:15
To: [email protected]
Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in
bitbake 1.26/1.28 ***

When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib is indeed different there.

yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also has the issue fixed in the bitbake repo.

I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky fido and jethro branches?

Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky.

The following changes since commit ea6d21066a7cce2fef08ad66287170 c5995bb1e2:

bitbake: bitbake-user-manual: Fixed porno hack for hello world example
(2018-01-17 22:32:46 +0000)

are available in the Git repository at:

git://push.yoctoproject.org/poky-contrib saung/bitbake-html5lib

Soemoe Aung (2):
fix build error in included html5lib in bitbake fix html5lib fix to be the same as in the krogoth branch

 bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.0.rc0.231.g781580f067-goog

--
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/bitbake-devel
--
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/bitbake-devel