Skip to contentSkip to conversation

create-pull-request: handle '/' in subject correctly

PATCH In review Chen Qi 1 participant 4 messages May 8, 2018 – Jun 6, 2018

lore
Share & tools
lore
author
#1 lore raw

PATCH 1/1 create-pull-request: handle '/' in subject correctly

In reply to Chen Qi

When subject contains '/', we will meet the following error when using create-pull-request.

sed: -e expression #1, char 59: unknown option to `s'

The problem is not critical. But it's better to fix it.

---
 scripts/create-pull-request | 1 +
 1 file changed, 1 insertion(+)
scripts/create-pull-request +1 -0
index 280880b..b4cf706 100755
@@ -278,6 +278,7 @@ fi
 
 # Replace the SUBJECT token with it.
 if [ -n "$SUBJECT" ]; then
+	SUBJECT="`echo $SUBJECT | sed -e 's#/#\\\\/#g'`"
 	sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL"
 fi
 
Signature · 1 line
1.9.1

Chen Qi

author
#0 lore raw

cover create-pull-request: handle '/' in subject correctly

The following changes since commit f301a3bc110608c3684c78dd62e276beea73bd94:

settings-daemon: Drop pointless apply=yes in SRC_URI (2018-05-04 13:28:06 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/create-pull-request-fix
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/create-pull-request-fix

Chen Qi (1):
create-pull-request: handle '/' in subject correctly

 scripts/create-pull-request | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
1.9.1
author
#3 lore raw

ping

Quoted 15 lines · Chen Qi

The following changes since commit f301a3bc110608c3684c78dd62e276beea73bd94:

   settings-daemon: Drop pointless apply=yes in SRC_URI (2018-05-04 13:28:06 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/create-pull-request-fix
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/create-pull-request-fix

Chen Qi (1):
create-pull-request: handle '/' in subject correctly

  scripts/create-pull-request | 1 +
  1 file changed, 1 insertion(+)
author
#2 lore raw
In reply to Chen Qi

ping

Quoted 24 lines · Chen Qi

When subject contains '/', we will meet the following error when using create-pull-request.

sed: -e expression #1, char 59: unknown option to `s'

The problem is not critical. But it's better to fix it.

---
  scripts/create-pull-request | 1 +
  1 file changed, 1 insertion(+)
scripts/create-pull-request +1 -0
index 280880b..b4cf706 100755
@@ -278,6 +278,7 @@ fi
 
  # Replace the SUBJECT token with it.
  if [ -n "$SUBJECT" ]; then
+	SUBJECT="`echo $SUBJECT | sed -e 's#/#\\\\/#g'`"
  	sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL"
  fi