Update selfstes strings
David Sterba
maintainercover Update selfstes strings
Update test messages so that error reports are visible in the log, few more tweaks of the strings as they're updated.
David Sterba (2):
btrfs: tests: add helper for error messages and update them
btrfs: tests: drop newline from test_msg strings
fs/btrfs/tests/btrfs-tests.h | 3 +- fs/btrfs/tests/extent-buffer-tests.c | 56 +++--- fs/btrfs/tests/extent-io-tests.c | 75 ++++---- fs/btrfs/tests/extent-map-tests.c | 32 ++-- fs/btrfs/tests/free-space-tests.c | 177 ++++++++++--------- fs/btrfs/tests/free-space-tree-tests.c | 74 ++++---- fs/btrfs/tests/inode-tests.c | 312 +++++++++++++++++---------------- fs/btrfs/tests/qgroup-tests.c | 88 +++++----- 8 files changed, 414 insertions(+), 403 deletions(-)
Signature · 1 line
2.16.2
David Sterba
maintainerPATCH 1/2 btrfs: tests: add helper for error messages and update them
The test failures are not clearly visible in the system log as they're printed at INFO level. Add a new helper that is level ERROR. As this touches almost all strings, I took the opportunity to unify them:
- decapitalize the first letter as there's a prefix and the text continues after ":"
- glue strings split to more lines and un-indent so they fit to 80 columns
- use %llu instead of %Lu
- drop \n from the modified messages (test_msg is left untouched)
--- fs/btrfs/tests/btrfs-tests.h | 1 + fs/btrfs/tests/extent-buffer-tests.c | 56 +++--- fs/btrfs/tests/extent-io-tests.c | 75 ++++---- fs/btrfs/tests/extent-map-tests.c | 30 ++-- fs/btrfs/tests/free-space-tests.c | 177 ++++++++++--------- fs/btrfs/tests/free-space-tree-tests.c | 74 ++++---- fs/btrfs/tests/inode-tests.c | 312 +++++++++++++++++---------------- fs/btrfs/tests/qgroup-tests.c | 88 +++++----- 8 files changed, 412 insertions(+), 401 deletions(-)
fs/btrfs/tests/btrfs-tests.h +1 -0
@@ -10,6 +10,7 @@int btrfs_run_sanity_tests (void );#define test_msg (fmt, ...) pr_info("BTRFS: selftest: " fmt, ##__VA_ARGS__) +#define test_err (fmt, ...) pr_err("BTRFS: selftest: " fmt "\n", ##__VA_ARGS__)struct btrfs_root ;struct btrfs_trans_handle ;
fs/btrfs/tests/extent-buffer-tests.c +28 -28
189 lines not on this page · raw message
fs/btrfs/tests/extent-io-tests.c +38 -37
254 lines not on this page · raw message
fs/btrfs/tests/extent-map-tests.c +15 -15
@@ -19,8 +19,8 @@ static void free_extent_map_tree(struct extent_map_tree *em_tree)#ifdef CONFIG_BTRFS_DEBUG if (refcount_read (&em->refs) !=1 ) { -test_msg ( -"em leak: em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx) refs %d\n" , +test_err ( +"em leak: em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx) refs %d" , em->start, em->len, em->block_start, em->block_len,refcount_read (&em->refs));
@@ -93,12 +93,12 @@ static void test_case_1(struct btrfs_fs_info *fs_info, em->block_len = len; ret =btrfs_add_extent_mapping (fs_info, em_tree, &em, em->start, em->len);if (ret) -test_msg ("case1 [%llu %llu]: ret %d\n" , start, start + len, ret); +test_err ("case1 [%llu %llu]: ret %d" , start, start + len, ret);if (em && (em->start !=0 ||extent_map_end (em) !=SZ_16K || em->block_start !=0 || em->block_len !=SZ_16K )) -test_msg ( -"case1 [%llu %llu]: ret %d return a wrong em (start %llu len %llu block_start %llu block_len %llu\n" , +test_err ( +"case1 [%llu %llu]: ret %d return a wrong em (start %llu len %llu block_start %llu block_len %llu" , start, start + len, ret, em->start, em->len, em->block_start, em->block_len);free_extent_map (em);
@@ -157,12 +157,12 @@ static void test_case_2(struct btrfs_fs_info *fs_info, em->block_len = (u64)-1 ; ret =btrfs_add_extent_mapping (fs_info, em_tree, &em, em->start, em->len);if (ret) -test_msg ("case2 [0 1K]: ret %d\n" , ret); +test_err ("case2 [0 1K]: ret %d" , ret);if (em && (em->start !=0 ||extent_map_end (em) !=SZ_1K || em->block_start !=EXTENT_MAP_INLINE || em->block_len != (u64)-1 )) -test_msg ( -"case2 [0 1K]: ret %d return a wrong em (start %llu len %llu block_start %llu block_len %llu\n" , +test_err ( +"case2 [0 1K]: ret %d return a wrong em (start %llu len %llu block_start %llu block_len %llu" , ret, em->start, em->len, em->block_start, em->block_len);free_extent_map (em);
@@ -203,7 +203,7 @@ static void __test_case_3(struct btrfs_fs_info *fs_info, em->block_len =SZ_16K ; ret =btrfs_add_extent_mapping (fs_info, em_tree, &em, start, len);if (ret) -test_msg ("case3 [0x%llx 0x%llx): ret %d\n" , +test_err ("case3 [0x%llx 0x%llx): ret %d" , start, start + len, ret);/* * Since bytes within em are contiguous, em->block_start is identical to
@@ -212,8 +212,8 @@ static void __test_case_3(struct btrfs_fs_info *fs_info,if (em && (start < em->start || start + len >extent_map_end (em) || em->start != em->block_start || em->len != em->block_len)) -test_msg ( -"case3 [0x%llx 0x%llx): ret %d em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx)\n" , +test_err ( +"case3 [0x%llx 0x%llx): ret %d em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx)" , start, start + len, ret, em->start, em->len, em->block_start, em->block_len);free_extent_map (em);
@@ -290,12 +290,12 @@ static void __test_case_4(struct btrfs_fs_info *fs_info, em->block_len =SZ_32K ; ret =btrfs_add_extent_mapping (fs_info, em_tree, &em, start, len);if (ret) -test_msg ("case4 [0x%llx 0x%llx): ret %d\n" , +test_err ("case4 [0x%llx 0x%llx): ret %d" , start, len, ret);if (em && (start < em->start || start + len >extent_map_end (em))) -test_msg ( -"case4 [0x%llx 0x%llx): ret %d, added wrong em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx)\n" , +test_err ( +"case4 [0x%llx 0x%llx): ret %d, added wrong em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx)" , start, len, ret, em->start, em->len, em->block_start, em->block_len);free_extent_map (em);
@@ -341,7 +341,7 @@ int btrfs_test_extent_map(void)struct btrfs_fs_info *fs_info =NULL ;struct extent_map_tree *em_tree; -test_msg ("Running extent_map tests\n" ); +test_msg ("running extent_map tests\n" );/* * Note: the fs_info is not set up completely, we only need
fs/btrfs/tests/free-space-tests.c +90 -87
621 lines not on this page · raw message
fs/btrfs/tests/free-space-tree-tests.c +38 -36
287 lines not on this page · raw message
fs/btrfs/tests/inode-tests.c +158 -154
877 lines not on this page · raw message
fs/btrfs/tests/qgroup-tests.c +44 -44
335 lines not on this page · raw message
Signature · 1 line
2.16.2
David Sterba
maintainerPATCH 2/2 btrfs: tests: drop newline from test_msg strings
In reply to David SterbaNow that test_err strings do not need the newline, remove them also from the test_msg.
--- fs/btrfs/tests/btrfs-tests.h | 2 +- fs/btrfs/tests/extent-buffer-tests.c | 4 ++-- fs/btrfs/tests/extent-io-tests.c | 8 ++++---- fs/btrfs/tests/extent-map-tests.c | 4 ++-- fs/btrfs/tests/free-space-tests.c | 12 ++++++------ fs/btrfs/tests/free-space-tree-tests.c | 2 +- fs/btrfs/tests/inode-tests.c | 6 +++--- fs/btrfs/tests/qgroup-tests.c | 6 +++--- 8 files changed, 22 insertions(+), 22 deletions(-)
fs/btrfs/tests/btrfs-tests.h +1 -1
@@ -9,7 +9,7 @@#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS int btrfs_run_sanity_tests (void ); -#define test_msg (fmt, ...) pr_info("BTRFS: selftest: " fmt, ##__VA_ARGS__) +#define test_msg (fmt, ...) pr_info("BTRFS: selftest: " fmt "\n", ##__VA_ARGS__)#define test_err (fmt, ...) pr_err("BTRFS: selftest: " fmt "\n", ##__VA_ARGS__)struct btrfs_root ;
fs/btrfs/tests/extent-buffer-tests.c +2 -2
@@ -26,7 +26,7 @@ static int test_btrfs_split_item(u32 sectorsize, u32 nodesize)u32 value_len =strlen (value);int ret =0 ; -test_msg ("running btrfs_split_item tests\n" ); +test_msg ("running btrfs_split_item tests" ); fs_info =btrfs_alloc_dummy_fs_info (nodesize, sectorsize);if (!fs_info) {
@@ -220,6 +220,6 @@ static int test_btrfs_split_item(u32 sectorsize, u32 nodesize)int btrfs_test_extent_buffer_operations (u32 sectorsize,u32 nodesize) { -test_msg ("running extent buffer operation tests\n" ); +test_msg ("running extent buffer operation tests" );return test_btrfs_split_item (sectorsize, nodesize); }
fs/btrfs/tests/extent-io-tests.c +4 -4
@@ -68,7 +68,7 @@ static int test_find_delalloc(u32 sectorsize)u64 found;int ret = -EINVAL ; -test_msg ("running find delalloc tests\n" ); +test_msg ("running find delalloc tests" ); inode =btrfs_new_test_inode ();if (!inode) {
@@ -377,7 +377,7 @@ static int test_eb_bitmaps(u32 sectorsize, u32 nodesize)struct extent_buffer *eb;int ret; -test_msg ("running extent buffer bitmap tests\n" ); +test_msg ("running extent buffer bitmap tests" );/* * In ppc64, sectorsize can be 64K, thus 4 * 64K will be larger than
@@ -425,7 +425,7 @@ int btrfs_test_extent_io(u32 sectorsize, u32 nodesize) {int ret; -test_msg ("running extent I/O tests\n" ); +test_msg ("running extent I/O tests" ); ret =test_find_delalloc (sectorsize);if (ret)
@@ -433,6 +433,6 @@ int btrfs_test_extent_io(u32 sectorsize, u32 nodesize) ret =test_eb_bitmaps (sectorsize, nodesize); out: -test_msg ("extent I/O tests finished\n" ); +test_msg ("extent I/O tests finished" );return ret; }
fs/btrfs/tests/extent-map-tests.c +2 -2
@@ -341,7 +341,7 @@ int btrfs_test_extent_map(void)struct btrfs_fs_info *fs_info =NULL ;struct extent_map_tree *em_tree; -test_msg ("running extent_map tests\n" ); +test_msg ("running extent_map tests" );/* * Note: the fs_info is not set up completely, we only need
@@ -349,7 +349,7 @@ int btrfs_test_extent_map(void)*/ fs_info =btrfs_alloc_dummy_fs_info (PAGE_SIZE ,PAGE_SIZE );if (!fs_info) { -test_msg ("Couldn't allocate dummy fs info\n" ); +test_msg ("Couldn't allocate dummy fs info" );return -ENOMEM ; }
fs/btrfs/tests/free-space-tests.c +6 -6
@@ -20,7 +20,7 @@ static int test_extents(struct btrfs_block_group_cache *cache) {int ret =0 ; -test_msg ("running extent only tests\n" ); +test_msg ("running extent only tests" );/* First just make sure we can remove an entire entry */ ret =btrfs_add_free_space (cache,0 ,SZ_4M );
@@ -92,7 +92,7 @@ static int test_bitmaps(struct btrfs_block_group_cache *cache,u64 next_bitmap_offset;int ret; -test_msg ("running bitmap only tests\n" ); +test_msg ("running bitmap only tests" ); ret =test_add_free_space_entry (cache,0 ,SZ_4M ,1 );if (ret) {
@@ -161,7 +161,7 @@ static int test_bitmaps_and_extents(struct btrfs_block_group_cache *cache,u64 bitmap_offset = (u64)(BITS_PER_BITMAP * sectorsize);int ret; -test_msg ("running bitmap and extent tests\n" ); +test_msg ("running bitmap and extent tests" );/* * First let's do something simple, an extent at the same offset as the
@@ -404,7 +404,7 @@ test_steal_space_from_bitmap_to_extent(struct btrfs_block_group_cache *cache, };const struct btrfs_free_space_op *orig_free_space_ops; -test_msg ("running space stealing from bitmap to extent\n" ); +test_msg ("running space stealing from bitmap to extent" );/* * For this test, we want to ensure we end up with an extent entry
@@ -832,7 +832,7 @@ int btrfs_test_free_space_cache(u32 sectorsize, u32 nodesize)struct btrfs_root *root =NULL ;int ret = -ENOMEM ; -test_msg ("running btrfs free space cache tests\n" ); +test_msg ("running btrfs free space cache tests" ); fs_info =btrfs_alloc_dummy_fs_info (nodesize, sectorsize);if (!fs_info)return -ENOMEM ;
@@ -874,6 +874,6 @@ int btrfs_test_free_space_cache(u32 sectorsize, u32 nodesize)btrfs_free_dummy_block_group (cache);btrfs_free_dummy_root (root);btrfs_free_dummy_fs_info (fs_info); -test_msg ("free space cache tests finished\n" ); +test_msg ("free space cache tests finished" );return ret; }
fs/btrfs/tests/free-space-tree-tests.c +1 -1
@@ -578,7 +578,7 @@ int btrfs_test_free_space_tree(u32 sectorsize, u32 nodesize)*/ bitmap_alignment =BTRFS_FREE_SPACE_BITMAP_BITS *PAGE_SIZE ; -test_msg ("running free space tree tests\n" ); +test_msg ("running free space tree tests" );for (i =0 ; i <ARRAY_SIZE (tests); i++) {int ret;
fs/btrfs/tests/inode-tests.c +3 -3
@@ -1119,14 +1119,14 @@ int btrfs_test_inodes(u32 sectorsize, u32 nodesize)set_bit (EXTENT_FLAG_COMPRESSED , &compressed_only);set_bit (EXTENT_FLAG_PREALLOC , &prealloc_only); -test_msg ("running btrfs_get_extent tests\n" ); +test_msg ("running btrfs_get_extent tests" ); ret =test_btrfs_get_extent (sectorsize, nodesize);if (ret)return ret; -test_msg ("running hole first btrfs_get_extent test\n" ); +test_msg ("running hole first btrfs_get_extent test" ); ret =test_hole_first (sectorsize, nodesize);if (ret)return ret; -test_msg ("running outstanding_extents tests\n" ); +test_msg ("running outstanding_extents tests" );return test_extent_accounting (sectorsize, nodesize); }
fs/btrfs/tests/qgroup-tests.c +3 -3
@@ -215,7 +215,7 @@ static int test_no_shared_qgroup(struct btrfs_root *root,btrfs_init_dummy_trans (&trans, fs_info); -test_msg ("qgroup basic add\n" ); +test_msg ("qgroup basic add" ); ret =btrfs_create_qgroup (NULL , fs_info,BTRFS_FS_TREE_OBJECTID );if (ret) {test_err ("couldn't create a qgroup %d" , ret);
@@ -316,7 +316,7 @@ static int test_multiple_refs(struct btrfs_root *root,btrfs_init_dummy_trans (&trans, fs_info); -test_msg ("qgroup multiple refs test\n" ); +test_msg ("qgroup multiple refs test" );/* * We have BTRFS_FS_TREE_OBJECTID created already from the
@@ -522,7 +522,7 @@ int btrfs_test_qgroups(u32 sectorsize, u32 nodesize) goto out; } -test_msg ("running qgroup tests\n" ); +test_msg ("running qgroup tests" ); ret =test_no_shared_qgroup (root, sectorsize, nodesize);if (ret) goto out;
Signature · 1 line
2.16.2