Skip to contentSkip to conversation

Re-use DEFINE_SHOW_ATTRIBUTE() macro

PATCH In review Peng Donglin 1 participant 4 messages Jun 13, 2018 – Dec 27, 2018

Subsystems (2)
Arm (32-bit) arm64
lore
Share & tools
lore
author
#1 lore raw

PATCH 1/2 ARM: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro

In reply to Peng Donglin

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Peng Donglin <[email protected]>
---
 arch/arm/mm/ptdump_debugfs.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm/mm/ptdump_debugfs.c +1 -12
index be8d87b..79002fe 100644
@@ -11,18 +11,7 @@ static int ptdump_show(struct seq_file *m, void *v)
 	ptdump_walk_pgd(m, info);
 	return 0;
 }
-
-static int ptdump_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, ptdump_show, inode->i_private);
-}
-
-static const struct file_operations ptdump_fops = {
-	.open		= ptdump_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
 
 int ptdump_debugfs_register(struct ptdump_info *info, const char *name)
 {
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 2/2 ARM64: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Peng Donglin <[email protected]>
---
 arch/arm64/mm/ptdump_debugfs.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm64/mm/ptdump_debugfs.c +1 -12
index 02b18f8..24d786f 100644
@@ -10,18 +10,7 @@ static int ptdump_show(struct seq_file *m, void *v)
 	ptdump_walk_pgd(m, info);
 	return 0;
 }
-
-static int ptdump_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, ptdump_show, inode->i_private);
-}
-
-static const struct file_operations ptdump_fops = {
-	.open		= ptdump_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
 
 int ptdump_debugfs_register(struct ptdump_info *info, const char *name)
 {
Signature · 1 line
2.7.4

Peng Donglin

author
#0 lore raw

cover Re-use DEFINE_SHOW_ATTRIBUTE() macro

...instead of open coding file operations followed by custom ->open() callbacks per each attribute.

Peng Donglin (2):
ARM: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro
ARM64: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro

 arch/arm/mm/ptdump_debugfs.c   | 13 +------------
 arch/arm64/mm/ptdump_debugfs.c | 13 +------------
 2 files changed, 2 insertions(+), 24 deletions(-)
Signature · 1 line
2.7.4
author
#3 lore raw

Re: [PATCH 1/2] ARM: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro

In reply to Peng Donglin
Quoted 33 lines · Peng Donglin

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Peng Donglin <[email protected]>
---
 arch/arm/mm/ptdump_debugfs.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm/mm/ptdump_debugfs.c +1 -13
index be8d87b..79002fe 100644
@@ -11,18 +11,7 @@ static int ptdump_show(struct seq_file *m, void *v)
        ptdump_walk_pgd(m, info);
        return 0;
 }
-
-static int ptdump_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, ptdump_show, inode->i_private);
-}
-
-static const struct file_operations ptdump_fops = {
-       .open           = ptdump_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
 
 int ptdump_debugfs_register(struct ptdump_info *info, const char *name)
 {
--
Quoted 2 lines

2.7.4

any suggestion?