Skip to contentSkip to conversation

Minor faad2/faac fixes

PATCH In review Paul Eggleton 3 participants 9 messages Aug 13, 2018 – Mar 22, 2019

lore
Share & tools
lore

Paul Eggleton

author
#0 lore raw

cover Minor faad2/faac fixes

The following changes since commit 30bbde3d09ebdf1ad2eac7764abeae0990f4cea2:

oprofile: upgrade 1.2.0 -> 1.3.0 (2018-08-11 20:16:53 -0700)

are available in the Git repository at:

git://git.openembedded.org/meta-openembedded-contrib paule/faad-fixes
http://cgit.openembedded.org/meta-openembedded-contrib/log/?h=paule/faad-fixes

Paul Eggleton (4):
faac: set HOMEPAGE
faac: set LICENSE_FLAGS
faad2: set more accurate SUMMARY and add HOMEPAGE
faad2: set LICENSE_FLAGS

 meta-multimedia/recipes-multimedia/faac/faac_1.29.bb | 3 +++
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb        | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/4 faac: set HOMEPAGE

Set HOMEPAGE so there is a place to go for more information.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-multimedia/recipes-multimedia/faac/faac_1.29.bb | 1 +
 1 file changed, 1 insertion(+)
meta-multimedia/recipes-multimedia/faac/faac_1.29.bb +1 -0
index 4765c6c9c..9f11dbdaa 100644
@@ -1,6 +1,7 @@
 SUMMARY = "Freeware Advanced Audio Coder (MPEG2-AAC, MPEG4-AAC)"
 SECTION = "libs"
 LICENSE = "LGPLv2+"
+HOMEPAGE = "http://www.audiocoding.com/faac.html"
 LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
                     file://libfaac/coder.h;beginline=5;endline=17;md5=fa1fd6a5fa8cdc877d63a12530d273e0"
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH 2/4 faac: set LICENSE_FLAGS

In reply to Paul Eggleton

Commercial usage requires licensing according to the homepage, so set LICENSE_FLAGS = "commercial" to indicate that.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-multimedia/recipes-multimedia/faac/faac_1.29.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-multimedia/recipes-multimedia/faac/faac_1.29.bb +2 -0
index 9f11dbdaa..d36f2f48d 100644
@@ -5,6 +5,8 @@ HOMEPAGE = "http://www.audiocoding.com/faac.html"
 LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
                     file://libfaac/coder.h;beginline=5;endline=17;md5=fa1fd6a5fa8cdc877d63a12530d273e0"
 
+LICENSE_FLAGS = "commercial"
+
 inherit autotools
 
 SRC_URI = " \
Signature · 1 line
2.17.1
author
#3 lore raw

PATCH 3/4 faad2: set more accurate SUMMARY and add HOMEPAGE

In reply to Paul Eggleton

Make it clear what this library is for and provide a link for more information.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +2 -1
index 63e590c9e..b777831ad 100644
@@ -1,4 +1,5 @@
-SUMMARY = "Library for reading some sort of media format"
+SUMMARY = "An open source MPEG-4 and MPEG-2 AAC decoding library"
+HOMEPAGE = "http://www.audiocoding.com/faad2.html"
 SECTION = "libs"
 LICENSE = "GPLv2"
Signature · 1 line
2.17.1
author
#4 lore raw

PATCH 4/4 faad2: set LICENSE_FLAGS

In reply to Paul Eggleton

Commercial usage requires a license according to the homepage, so set LICENSE_FLAGS = "commercial" to indicate that.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +2 -0
index b777831ad..9e5a3817a 100644
@@ -5,6 +5,8 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958"
 
+LICENSE_FLAGS = "commercial"
+
 PR = "r1"
 
 inherit autotools
Signature · 1 line
2.17.1
#5 lore raw

Re: [meta-oe][PATCH 4/4] faad2: set LICENSE_FLAGS

Quoted 18 lines · Paul Eggleton

Commercial usage requires a license according to the homepage, so set LICENSE_FLAGS = "commercial" to indicate that.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb | 2 ++
 1 file changed, 2 insertions(+)
meta- renamed from meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0

oe/recipes-multimedia/faad2/faad2_2.7.bb
index b777831ad..9e5a3817a 100644

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0
@@ -5,6 +5,8 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM =

"file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958"

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb LICENSE = "GPLv2" · line 9

Quoted 2 lines
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +2 -0
+LICENSE_FLAGS = "commercial"
+

My understanding was that faad2 was GPLv2, but you could *optionally* get a commercial license for it if you needed one. Is the LICENSE_FLAG necessary in that case? It seems like the default license of GPLv2 would apply unless you worked something out with them to get a commercial license?

Quoted 6 lines

PR = "r1"

inherit autotools

Signature · 1 line
2.17.1
Signature · 1 line
Joshua Watt <[email protected]>
#6 lore raw

Re: [meta-oe][PATCH 4/4] faad2: set LICENSE_FLAGS

Quoted 20 lines · Joshua Watt
Quoted 18 lines · Paul Eggleton

Commercial usage requires a license according to the homepage, so set LICENSE_FLAGS = "commercial" to indicate that.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb | 2 ++
 1 file changed, 2 insertions(+)
meta- renamed from meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0

oe/recipes-multimedia/faad2/faad2_2.7.bb
index b777831ad..9e5a3817a 100644

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0
@@ -5,6 +5,8 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM =

"file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958"

Quoted 8 lines

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb LICENSE = "GPLv2" · line 9

Quoted 2 lines
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +2 -0
+LICENSE_FLAGS = "commercial"
+

My understanding was that faad2 was GPLv2, but you could *optionally* get a commercial license for it if you needed one. Is the LICENSE_FLAG necessary in that case? It seems like the default license of GPLv2 would apply unless you worked something out with them to get a commercial license?

Sometimes the use determines the license enforcement. e.g. it might be GPLed for personal use but not for selling products.

Quoted 15 lines
Quoted 7 lines

PR = "r1"

inherit autotools
--
2.17.1

--
Joshua Watt <[email protected]>

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#7 lore raw

Re: [meta-oe][PATCH 4/4] faad2: set LICENSE_FLAGS

Quoted 30 lines · NZDT Khem Raj
Quoted 20 lines · Joshua Watt
Quoted 18 lines · Paul Eggleton

Commercial usage requires a license according to the homepage, so set LICENSE_FLAGS = "commercial" to indicate that.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb | 2 ++
 1 file changed, 2 insertions(+)
meta- renamed from meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0

oe/recipes-multimedia/faad2/faad2_2.7.bb
index b777831ad..9e5a3817a 100644

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0
@@ -5,6 +5,8 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM =

"file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958"

Quoted 8 lines

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb LICENSE = "GPLv2" · line 9

Quoted 2 lines
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +2 -0
+LICENSE_FLAGS = "commercial"
+

My understanding was that faad2 was GPLv2, but you could *optionally* get a commercial license for it if you needed one. Is the LICENSE_FLAG necessary in that case? It seems like the default license of GPLv2 would apply unless you worked something out with them to get a commercial license?

Quoted 2 lines

Sometimes the use determines the license enforcement. e.g. it might be GPLed for personal use but not for selling products.

Also, the GPL unfortunately is not the only concern if you read the full upstream README. I think it's best to err on the side of caution, after all there is the ability for to set LICENSE_FLAGS_WHITELIST signifying "yes I have checked and my usage is OK".

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#8 lore raw

Re: [meta-oe][PATCH 4/4] faad2: set LICENSE_FLAGS

Quoted 35 lines · Paul Eggleton
Quoted 1 line · NZDT Khem Raj

On Thu, Mar 21, 2019 at 2:09 PM Joshua Watt <[email protected]>

Quoted 29 lines · wrote:
Quoted 20 lines · Paul Eggleton
Quoted 18 lines

Commercial usage requires a license according to the homepage, so set LICENSE_FLAGS = "commercial" to indicate that.

Signed-off-by Paul Eggleton <[email protected]>
---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb | 2 ++
 1 file changed, 2 insertions(+)
meta- renamed from meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0

oe/recipes-multimedia/faad2/faad2_2.7.bb
index b777831ad..9e5a3817a 100644

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +0 -0
@@ -5,6 +5,8 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM =

"file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958"

Quoted 8 lines

meta-oe/recipes-multimedia/faad2/faad2_2.7.bb LICENSE = "GPLv2" · line 9

Quoted 2 lines
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +2 -0
+LICENSE_FLAGS = "commercial"
+

My understanding was that faad2 was GPLv2, but you could *optionally* get a commercial license for it if you needed one. Is the LICENSE_FLAG necessary in that case? It seems like the default license of GPLv2 would apply unless you worked something out with them to get a commercial license?

Quoted 2 lines

Sometimes the use determines the license enforcement. e.g. it might be GPLed for personal use but not for selling products.

Quoted 7 lines

Also, the GPL unfortunately is not the only concern if you read the full upstream README. I think it's best to err on the side of caution, after all
there is the ability for to set LICENSE_FLAGS_WHITELIST signifying "yes I have
checked and my usage is OK".

I would tend to agree

Quoted 11 lines

Cheers,
Paul

--

Paul Eggleton
Intel Open Source Technology Centre