sysprof: Fix build with clang
cover sysprof: Fix build with clang
The following changes since commit 9084818dfc5cdf22ed9fb4d13d08941460380267:
busybox/packagegroups: Break out the busybox-syslog dependency (2018-09-07 12:48:00 +0100)
are available in the Git repository at:
git://git.openembedded.org/openembedded-core-contrib kraj/master
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=kraj/master
Khem Raj (1):
sysprof: Fix build with clang
...fix-non-literal-format-string-issues.patch | 34 +++++++++++++++++++ meta/recipes-kernel/sysprof/sysprof_3.30.0.bb | 1 + 2 files changed, 35 insertions(+) create mode 100644 meta/recipes-kernel/sysprof/files/0001-fix-non-literal-format-string-issues.patch
Signature · 1 line
2.18.0
PATCH 1/1 sysprof: Fix build with clang
--- ...fix-non-literal-format-string-issues.patch | 34 +++++++++++++++++++ meta/recipes-kernel/sysprof/sysprof_3.30.0.bb | 1 + 2 files changed, 35 insertions(+) create mode 100644 meta/recipes-kernel/sysprof/files/0001-fix-non-literal-format-string-issues.patch
meta/recipes-kernel/sysprof/files/0001-fix-non-literal-format-string-issues.patch new file +34 -0
@@ -0,0 +1,34 @@ +From de13d1f908335cc882c447e4d7c4360b9e5da190 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Thu, 6 Sep 2018 17:49:44 -0700 +Subject: [PATCH] fix non-literal format string issues + +clang errors out when using -Werror=format-nonliteral +since the definition of g_strdup_vprintf() from glib-2.0 +is using va_list and clangs still warns where as +gcc doesn't do that for va_list arguments + +Fixes +src/sp-window.c:96:27: error: format string is not a string literal [-Werror,-Wformat-nonliteral] +| str = g_strdup_vprintf (format, args); +| ^~~~~~ + +Upstream-Status: Pending +Signed-off-by: Khem Raj <[email protected]> +--- + src/sp-window.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/sp-window.c b/src/sp-window.c +index 4dfac2d..aff4779 100644 +--- a/src/sp-window.c ++++ b/src/sp-window.c +@@ -80,7 +80,7 @@ static guint signals [N_SIGNALS]; + static void sp_window_set_profiler (SpWindow *self, + SpProfiler *profiler); + +-static void ++static G_GNUC_PRINTF(3, 4) void + sp_window_notify_user (SpWindow *self, + GtkMessageType message_type, + const gchar *format,
meta/recipes-kernel/sysprof/sysprof_3.30.0.bb +1 -0
@@ -15,6 +15,7 @@ SRC_URI += " \ file://define-NT_GNU_BUILD_ID.patch \ file://0001-Do-not-build-anything-in-help-as-it-requires-itstool.patch \ file://wordsize.patch \ + file://0001-fix-non-literal-format-string-issues.patch \ " RECIPE_NO_UPDATE_REASON = "Waiting for resolution of https://bugzilla.gnome.org/show_bug.cgi?id=794625"
Signature · 1 line
2.18.0
Quoted 1 line · Khem Raj
+Upstream-Status: Pending
Make that Submitted: https://gitlab.gnome.org/GNOME/sysprof/merge_requests/6
Ross
Picked this to MUT and fixed up the status, no need to resend.
Ross
Quoted 6 lines · Ross
Quoted 1 line · Khem Raj
+Upstream-Status: Pending
Make that Submitted: https://gitlab.gnome.org/GNOME/sysprof/merge_requests/6
Ross
✗ patchtest: failure for sysprof: Fix build with clang
In reply to Khem Raj== Series Details ==
Series: sysprof: Fix build with clang
Revision: 1
URL : https://patchwork.openembedded.org/series/13965/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 0191456d81)
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe