Skip to contentSkip to conversation

net: explicitly requires bash when needed.

PATCH In review Paolo Abeni 3 participants 5 messages Oct 11, 2018 – Oct 12, 2018

Subsystems (3)
lore
Share & tools
lore

Paolo Abeni

author maintainer
#0 lore raw

cover net: explicitly requires bash when needed.

Some test scripts require bash-only features but use the default shell. This may cause random failures if the default shell is not bash. Instead of doing a potentially complex rewrite of such scripts, these patches require the bash interpreter, where needed.

Paolo Abeni (2):
selftests: rtnetlink.sh explicitly requires bash.
selftests: udpgso_bench.sh explicitly requires bash

 tools/testing/selftests/net/rtnetlink.sh    | 2 +-
 tools/testing/selftests/net/udpgso_bench.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.2
author maintainer
#1 lore raw

PATCH 1/2 selftests: rtnetlink.sh explicitly requires bash.

the script rtnetlink.sh requires a bash-only features (sleep with sub-second precision). This may cause random test failure if the default shell is not bash.
Address the above explicitly requiring bash as the script interpreter.

Fixes 33b01b7b4f19 ("selftests: add rtnetlink test script")
---
 tools/testing/selftests/net/rtnetlink.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/rtnetlink.sh +1 -1
index 08c341b49760..e101af52d1d6 100755
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # This test is for checking rtnetlink callpaths, and get as much coverage as possible.
 #
Signature · 1 line
2.17.2
author maintainer
#2 lore raw

PATCH 2/2 selftests: udpgso_bench.sh explicitly requires bash

In reply to Paolo Abeni

The udpgso_bench.sh script requires several bash-only features. This may cause random failures if the default shell is not bash. Address the above explicitly requiring bash as the script interpreter

Fixes 3a687bef148d ("selftests: udp gso benchmark")
---
 tools/testing/selftests/net/udpgso_bench.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/udpgso_bench.sh +1 -1
index 850767befa47..99e537ab5ad9 100755
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 #
 # Run a series of udpgso benchmarks
Signature · 1 line
2.17.2
Acked-by on v1 2/2
#3 lore raw

Re: [PATCH net 2/2] selftests: udpgso_bench.sh explicitly requires bash

Quoted 7 lines · Paolo Abeni

The udpgso_bench.sh script requires several bash-only features. This may cause random failures if the default shell is not bash. Address the above explicitly requiring bash as the script interpreter

Fixes 3a687bef148d ("selftests: udp gso benchmark")
maintainer
#4 lore raw
In reply to Paolo Abeni

From: Paolo Abeni <[email protected]>
Date: Thu, 11 Oct 2018 10:54:51 +0200

Quoted 4 lines

Some test scripts require bash-only features but use the default shell. This may cause random failures if the default shell is not bash. Instead of doing a potentially complex rewrite of such scripts, these patches require the bash interpreter, where needed.

Series applied, thanks.