net: explicitly requires bash when needed.
Subsystems (3)
Paolo Abeni
maintainercover net: explicitly requires bash when needed.
Some test scripts require bash-only features but use the default shell. This may cause random failures if the default shell is not bash. Instead of doing a potentially complex rewrite of such scripts, these patches require the bash interpreter, where needed.
Paolo Abeni (2):
selftests: rtnetlink.sh explicitly requires bash.
selftests: udpgso_bench.sh explicitly requires bash
tools/testing/selftests/net/rtnetlink.sh | 2 +- tools/testing/selftests/net/udpgso_bench.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.2
Paolo Abeni
maintainerPATCH 1/2 selftests: rtnetlink.sh explicitly requires bash.
the script rtnetlink.sh requires a bash-only features (sleep with sub-second precision). This may cause random test failure if the default shell is not bash.
Address the above explicitly requiring bash as the script interpreter.
--- tools/testing/selftests/net/rtnetlink.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/rtnetlink.sh +1 -1
@@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # # This test is for checking rtnetlink callpaths, and get as much coverage as possible. #
Signature · 1 line
2.17.2
Paolo Abeni
maintainerPATCH 2/2 selftests: udpgso_bench.sh explicitly requires bash
In reply to Paolo AbeniThe udpgso_bench.sh script requires several bash-only features. This may cause random failures if the default shell is not bash. Address the above explicitly requiring bash as the script interpreter
--- tools/testing/selftests/net/udpgso_bench.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/udpgso_bench.sh +1 -1
@@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # SPDX-License-Identifier: GPL-2.0 # # Run a series of udpgso benchmarks
Signature · 1 line
2.17.2
Re: [PATCH net 2/2] selftests: udpgso_bench.sh explicitly requires bash
Quoted 7 lines · Paolo Abeni
The
udpgso_bench.shscript requires several bash-only features. This may cause random failures if the default shell is not bash. Address the above explicitly requiring bash as the script interpreterFixes 3a687bef148d ("selftests: udp gso benchmark")Signed-off-by Paolo Abeni <[email protected]>
David Miller
maintainerFrom: Paolo Abeni <[email protected]>
Date: Thu, 11 Oct 2018 10:54:51 +0200
Quoted 4 lines
Some test scripts require bash-only features but use the default shell. This may cause random failures if the default shell is not bash. Instead of doing a potentially complex rewrite of such scripts, these patches require the bash interpreter, where needed.
Series applied, thanks.