staging: rtl8192u: Fix misspellings
cover staging: rtl8192u: Fix misspellings
Fix misspellings in a struct member name, a variable name, and comments.
Kimberly Brown (3):
staging:rtl8192u: Fix misspelling in struct member name - Style staging:rtl8192u: Fix misspelling in variable name - Style staging:rtl8192u: Fix misspellings in comments - Style
drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_dm.c | 10 +++++----- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/3 staging:rtl8192u: Fix misspelling in struct member name - Style
Fix the spelling mistake in the name of struct member 'cmdpacket_frag_thresold'. 'thresold' should be 'threshold'. Issue found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192u/r8192U.h +1 -1
@@ -370,7 +370,7 @@ typedef struct _rt_firmare_seg_container { } fw_seg_container, *pfw_seg_container; typedef struct _rt_firmware { firmware_status_e firmware_status; - u16 cmdpacket_frag_thresold; + u16 cmdpacket_frag_threshold; #define RTL8190_MAX_FIRMWARE_CODE_SIZE 64000 u8 firmware_buf[RTL8190_MAX_FIRMWARE_CODE_SIZE]; u16 firmware_buf_size;
drivers/staging/rtl8192u/r819xU_firmware.c +2 -2
@@ -24,7 +24,7 @@ static void firmware_init_param(struct net_device *dev)struct r8192_priv *priv =ieee80211_priv (dev);rt_firmware *pfirmware = priv->pFirmware; - pfirmware->cmdpacket_frag_thresold =GET_COMMAND_PACKET_FRAG_THRESHOLD (MAX_TRANSMIT_BUFFER_SIZE ); + pfirmware->cmdpacket_frag_threshold =GET_COMMAND_PACKET_FRAG_THRESHOLD (MAX_TRANSMIT_BUFFER_SIZE ); }/*
@@ -49,7 +49,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,firmware_init_param (dev);/* Fragmentation might be required */ - frag_threshold = pfirmware->cmdpacket_frag_thresold; + frag_threshold = pfirmware->cmdpacket_frag_threshold; do { if ((buffer_len - frag_offset) > frag_threshold) { frag_length = frag_threshold;
Signature · 1 line
2.17.1
PATCH 2/3 staging:rtl8192u: Fix misspelling in variable name - Style
In reply to Kimberly BrownFix the spelling mistake in variable name 'txhipower_threshhold'. 'threshhold' should be 'threshold'. Issue found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/r8192U_dm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8192u/r8192U_dm.c +5 -5
@@ -2983,7 +2983,7 @@ static void dm_init_dynamic_txpower(struct net_device *dev)static void dm_dynamic_txpower (struct net_device *dev) {struct r8192_priv *priv =ieee80211_priv (dev); -unsigned int txhipower_threshhold =0 ; +unsigned int txhipower_threshold =0 ;unsigned int txlowpower_threshold =0 ;if (priv->ieee80211->bdynamic_txpower_enable != true) {
@@ -2993,18 +2993,18 @@ static void dm_dynamic_txpower(struct net_device *dev) }/*printk("priv->ieee80211->current_network.unknown_cap_exist is %d , priv->ieee80211->current_network.broadcom_cap_exist is %d\n", priv->ieee80211->current_network.unknown_cap_exist, priv->ieee80211->current_network.broadcom_cap_exist);*/ if ((priv->ieee80211->current_network.atheros_cap_exist) && (priv->ieee80211->mode ==IEEE_G )) { - txhipower_threshhold =TX_POWER_ATHEROAP_THRESH_HIGH ; + txhipower_threshold =TX_POWER_ATHEROAP_THRESH_HIGH ; txlowpower_threshold =TX_POWER_ATHEROAP_THRESH_LOW ; }else { - txhipower_threshhold =TX_POWER_NEAR_FIELD_THRESH_HIGH ; + txhipower_threshold =TX_POWER_NEAR_FIELD_THRESH_HIGH ; txlowpower_threshold =TX_POWER_NEAR_FIELD_THRESH_LOW ; } -/*printk("=======>%s(): txhipower_threshhold is %d, txlowpower_threshold is %d\n", __func__, txhipower_threshhold, txlowpower_threshold);*/ +/*printk("=======>%s(): txhipower_threshold is %d, txlowpower_threshold is %d\n", __func__, txhipower_threshold, txlowpower_threshold);*/ RT_TRACE (COMP_TXAGC ,"priv->undecorated_smoothed_pwdb = %ld\n" , priv->undecorated_smoothed_pwdb);if (priv->ieee80211->state ==IEEE80211_LINKED ) { -if (priv->undecorated_smoothed_pwdb >= txhipower_threshhold) { +if (priv->undecorated_smoothed_pwdb >= txhipower_threshold) { priv->bDynamicTxHighPower = true; priv->bDynamicTxLowPower = false; }else {
Signature · 1 line
2.17.1
PATCH 3/3 staging:rtl8192u: Fix misspellings in comments - Style
In reply to Kimberly BrownFix two spelling mistakes in comments. 'informations' should be 'information', and 'imblance' should be 'imbalance'. Issues found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192u/r819xU_cmdpkt.c +1 -1
@@ -243,7 +243,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)cmdpkt_beacontimerinterrupt_819xusb (dev); } -/* Other informations in interrupt status we need? */ +/* Other information in interrupt status we need? */ DMESG ("<---- cmpk_handle_interrupt_status()\n" ); }
drivers/staging/rtl8192u/r819xU_phyreg.h +1 -1
@@ -53,7 +53,7 @@/* page c */ #define rOFDM0_TRxPathEnable 0xc04#define rOFDM0_XARxAFE 0xc10/* RxIQ DC offset, Rx digital filter, DC notch filter */ -#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imblance matrix */ +#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imbalance matrix */ #define rOFDM0_XBRxAFE 0xc18#define rOFDM0_XBRxIQImbalance 0xc1c#define rOFDM0_XCRxAFE 0xc20
Signature · 1 line
2.17.1
Re: [Outreachy kernel] [PATCH 3/3] staging:rtl8192u: Fix misspellings in comments - Style
In the subject line, normally the words at the beginning are separated by spaces. Do git log --oneline on the affected file and follow what seems most popular.
julia
Quoted 49 lines · Kimberly Brown
Fix two spelling mistakes in comments. 'informations' should be 'information', and 'imblance' should be 'imbalance'. Issues found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
Signed-off-by Kimberly Brown <[email protected]>--- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8192u/r819xU_cmdpkt.c +1
-1@@ -243,7 +243,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)cmdpkt_beacontimerinterrupt_819xusb (dev); } -/* Other informations in interrupt status we need? */ +/* Other information in interrupt status we need? */ DMESG ("<---- cmpk_handle_interrupt_status()\n" ); }drivers/staging/rtl8192u/r819xU_phyreg.h +1
-2@@ -53,7 +53,7 @@/* page c */ #define rOFDM0_TRxPathEnable 0xc04#define rOFDM0_XARxAFE 0xc10/* RxIQ DC offset, Rx digital filter, DC notch filter */ -#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imblance matrix */ +#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imbalance matrix */ #define rOFDM0_XBRxAFE 0xc18#define rOFDM0_XBRxIQImbalance 0xc1c#define rOFDM0_XCRxAFE 0xc20 --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/552e36244c1487a002b7f130d8b5ee07cb8afff7.1540229302.git.kimbrownkd%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] [PATCH 1/3] staging:rtl8192u: Fix misspelling in struct member name - Style
In reply to Kimberly BrownQuoted 9 lines · Kimberly Brown
Fix the spelling mistake in the name of struct member '
cmdpacket_frag_thresold'. 'thresold' should be 'threshold'. Issue found by checkpatch.This is a coding style change which should have no impact on runtime code execution.
Signed-off-by Kimberly Brown <[email protected]>
With Julia's comment [on patch 3] addressed for all 3 patches, feel free to add this for the whole series.
Quoted 49 lines
--- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8192u/r8192U.h +1
-1@@ -370,7 +370,7 @@ typedef struct _rt_firmare_seg_container { } fw_seg_container, *pfw_seg_container; typedef struct _rt_firmware { firmware_status_e firmware_status; - u16 cmdpacket_frag_thresold; + u16 cmdpacket_frag_threshold; #define RTL8190_MAX_FIRMWARE_CODE_SIZE 64000 u8 firmware_buf[RTL8190_MAX_FIRMWARE_CODE_SIZE]; u16 firmware_buf_size;drivers/staging/rtl8192u/r819xU_firmware.c +2
-3@@ -24,7 +24,7 @@ static void firmware_init_param(struct net_device *dev)struct r8192_priv *priv =ieee80211_priv (dev);rt_firmware *pfirmware = priv->pFirmware; - pfirmware->cmdpacket_frag_thresold =GET_COMMAND_PACKET_FRAG_THRESHOLD (MAX_TRANSMIT_BUFFER_SIZE ); + pfirmware->cmdpacket_frag_threshold =GET_COMMAND_PACKET_FRAG_THRESHOLD (MAX_TRANSMIT_BUFFER_SIZE ); }/* @@ -49,7 +49,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,firmware_init_param (dev);/* Fragmentation might be required */ - frag_threshold = pfirmware->cmdpacket_frag_thresold; + frag_threshold = pfirmware->cmdpacket_frag_threshold; do { if ((buffer_len - frag_offset) > frag_threshold) { frag_length = frag_threshold; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/4d1bd329f112fb50c5a234cfa12babf868f3b03c.1540229302.git.kimbrownkd%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] [PATCH 3/3] staging:rtl8192u: Fix misspellings in comments - Style
In reply to Julia LawallQuoted 3 lines · Julia Lawall
In the subject line, normally the words at the beginning are separated by spaces. Do git log --oneline on the affected file and follow what seems most popular.
Thanks for the quick reply, Julia! I did check the git log for this driver, and the format that I used seemed to be the most popular. Over the last 4 months, one author has submitted dozens of patches for this driver with this format, so I matched it.
If you think the normal subject line format with spaces is preferable, please let me know, and I'll change it.
Kimberly
Quoted 61 lines
julia
Quoted 49 lines · Kimberly Brown
Fix two spelling mistakes in comments. 'informations' should be 'information', and 'imblance' should be 'imbalance'. Issues found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
Signed-off-by Kimberly Brown <[email protected]>--- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8192u/r819xU_cmdpkt.c +1
-1@@ -243,7 +243,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)cmdpkt_beacontimerinterrupt_819xusb (dev); } -/* Other informations in interrupt status we need? */ +/* Other information in interrupt status we need? */ DMESG ("<---- cmpk_handle_interrupt_status()\n" ); }drivers/staging/rtl8192u/r819xU_phyreg.h +1
-2@@ -53,7 +53,7 @@/* page c */ #define rOFDM0_TRxPathEnable 0xc04#define rOFDM0_XARxAFE 0xc10/* RxIQ DC offset, Rx digital filter, DC notch filter */ -#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imblance matrix */ +#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imbalance matrix */ #define rOFDM0_XBRxAFE 0xc18#define rOFDM0_XBRxIQImbalance 0xc1c#define rOFDM0_XCRxAFE 0xc20 --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/552e36244c1487a002b7f130d8b5ee07cb8afff7.1540229302.git.kimbrownkd%40gmail.com.
For more options, visit https://groups.google.com/d/optout.Signature · 5 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1810221852140.2333%40hadrien. For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] [PATCH 3/3] staging:rtl8192u: Fix misspellings in comments - Style
Quoted 5 lines · Kimberly Brown
Quoted 3 lines · Julia Lawall
In the subject line, normally the words at the beginning are separated by spaces. Do git log --oneline on the affected file and follow what seems most popular.
Quoted 7 lines
Thanks for the quick reply, Julia! I did check the git log for this driver, and the format that I used seemed to be the most popular. Over the last 4 months, one author has submitted dozens of patches for this driver with this format, so I matched it.
If you think the normal subject line format with spaces is preferable, please let me know, and I'll change it.
OK, I see what you mean. But since most of the other patches in the kernel use spaces, it would probably be better to use spaces here too.
thanks,
julia
Quoted 72 lines
Kimberly
Quoted 47 lines
julia
Quoted 42 lines · Kimberly Brown
Fix two spelling mistakes in comments. 'informations' should be 'information', and 'imblance' should be 'imbalance'. Issues found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
Signed-off-by Kimberly Brown <[email protected]>--- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8192u/r819xU_cmdpkt.c +1
-1@@ -243,7 +243,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)cmdpkt_beacontimerinterrupt_819xusb (dev); } -/* Other informations in interrupt status we need? */ +/* Other information in interrupt status we need? */ DMESG ("<---- cmpk_handle_interrupt_status()\n" ); }drivers/staging/rtl8192u/r819xU_phyreg.h +1
-2@@ -53,7 +53,7 @@/* page c */ #define rOFDM0_TRxPathEnable 0xc04#define rOFDM0_XARxAFE 0xc10/* RxIQ DC offset, Rx digital filter, DC notch filter */ -#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imblance matrix */ +#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imbalance matrix */ #define rOFDM0_XBRxAFE 0xc18#define rOFDM0_XBRxIQImbalance 0xc1c#define rOFDM0_XCRxAFE 0xc20 --2.17.1
Quoted 14 lines
Quoted 7 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/552e36244c1487a002b7f130d8b5ee07cb8afff7.1540229302.git.kimbrownkd%40gmail.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1810221852140.2333%40hadrien.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181023031711.GA6194%40v.
For more options, visit https://groups.google.com/d/optout.
v2 cover staging: rtl8192u: Fix misspellings
In reply to Kimberly BrownFix misspellings in a struct member name, a variable name, and comments.
Changes in v2:
- Changed the subject line for all patches to include a space between 'staging:' and 'rtl8192u:'.
- Added a Reviewed-by line to all patches.
Kimberly Brown (3):
staging: rtl8192u: Fix misspelling in struct member name - Style
staging: rtl8192u: Fix misspelling in variable name - Style
staging: rtl8192u: Fix misspellings in comments - Style
drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_dm.c | 10 +++++----- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/3 staging: rtl8192u: Fix misspelling in struct member name - Style
Fix the spelling mistake in the name of struct member 'cmdpacket_frag_thresold'. 'thresold' should be 'threshold'. Issue found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192u/r8192U.h +1 -1
@@ -370,7 +370,7 @@ typedef struct _rt_firmare_seg_container { } fw_seg_container, *pfw_seg_container; typedef struct _rt_firmware { firmware_status_e firmware_status; - u16 cmdpacket_frag_thresold; + u16 cmdpacket_frag_threshold; #define RTL8190_MAX_FIRMWARE_CODE_SIZE 64000 u8 firmware_buf[RTL8190_MAX_FIRMWARE_CODE_SIZE]; u16 firmware_buf_size;
drivers/staging/rtl8192u/r819xU_firmware.c +2 -2
@@ -24,7 +24,7 @@ static void firmware_init_param(struct net_device *dev)struct r8192_priv *priv =ieee80211_priv (dev);rt_firmware *pfirmware = priv->pFirmware; - pfirmware->cmdpacket_frag_thresold =GET_COMMAND_PACKET_FRAG_THRESHOLD (MAX_TRANSMIT_BUFFER_SIZE ); + pfirmware->cmdpacket_frag_threshold =GET_COMMAND_PACKET_FRAG_THRESHOLD (MAX_TRANSMIT_BUFFER_SIZE ); }/*
@@ -49,7 +49,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,firmware_init_param (dev);/* Fragmentation might be required */ - frag_threshold = pfirmware->cmdpacket_frag_thresold; + frag_threshold = pfirmware->cmdpacket_frag_threshold; do { if ((buffer_len - frag_offset) > frag_threshold) { frag_length = frag_threshold;
Signature · 1 line
2.17.1
PATCH v2 2/3 staging: rtl8192u: Fix misspelling in variable name - Style
In reply to Kimberly BrownFix the spelling mistake in variable name 'txhipower_threshhold'. 'threshhold' should be 'threshold'. Issue found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/r8192U_dm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8192u/r8192U_dm.c +5 -5
@@ -2983,7 +2983,7 @@ static void dm_init_dynamic_txpower(struct net_device *dev)static void dm_dynamic_txpower (struct net_device *dev) {struct r8192_priv *priv =ieee80211_priv (dev); -unsigned int txhipower_threshhold =0 ; +unsigned int txhipower_threshold =0 ;unsigned int txlowpower_threshold =0 ;if (priv->ieee80211->bdynamic_txpower_enable != true) {
@@ -2993,18 +2993,18 @@ static void dm_dynamic_txpower(struct net_device *dev) }/*printk("priv->ieee80211->current_network.unknown_cap_exist is %d , priv->ieee80211->current_network.broadcom_cap_exist is %d\n", priv->ieee80211->current_network.unknown_cap_exist, priv->ieee80211->current_network.broadcom_cap_exist);*/ if ((priv->ieee80211->current_network.atheros_cap_exist) && (priv->ieee80211->mode ==IEEE_G )) { - txhipower_threshhold =TX_POWER_ATHEROAP_THRESH_HIGH ; + txhipower_threshold =TX_POWER_ATHEROAP_THRESH_HIGH ; txlowpower_threshold =TX_POWER_ATHEROAP_THRESH_LOW ; }else { - txhipower_threshhold =TX_POWER_NEAR_FIELD_THRESH_HIGH ; + txhipower_threshold =TX_POWER_NEAR_FIELD_THRESH_HIGH ; txlowpower_threshold =TX_POWER_NEAR_FIELD_THRESH_LOW ; } -/*printk("=======>%s(): txhipower_threshhold is %d, txlowpower_threshold is %d\n", __func__, txhipower_threshhold, txlowpower_threshold);*/ +/*printk("=======>%s(): txhipower_threshold is %d, txlowpower_threshold is %d\n", __func__, txhipower_threshold, txlowpower_threshold);*/ RT_TRACE (COMP_TXAGC ,"priv->undecorated_smoothed_pwdb = %ld\n" , priv->undecorated_smoothed_pwdb);if (priv->ieee80211->state ==IEEE80211_LINKED ) { -if (priv->undecorated_smoothed_pwdb >= txhipower_threshhold) { +if (priv->undecorated_smoothed_pwdb >= txhipower_threshold) { priv->bDynamicTxHighPower = true; priv->bDynamicTxLowPower = false; }else {
Signature · 1 line
2.17.1
PATCH v2 3/3 staging: rtl8192u: Fix misspellings in comments - Style
In reply to Kimberly BrownFix two spelling mistakes in comments. 'informations' should be 'information', and 'imblance' should be 'imbalance'. Issues found by checkpatch.
This is a coding style change which should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192u/r819xU_cmdpkt.c +1 -1
@@ -243,7 +243,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)cmdpkt_beacontimerinterrupt_819xusb (dev); } -/* Other informations in interrupt status we need? */ +/* Other information in interrupt status we need? */ DMESG ("<---- cmpk_handle_interrupt_status()\n" ); }
drivers/staging/rtl8192u/r819xU_phyreg.h +1 -1
@@ -53,7 +53,7 @@/* page c */ #define rOFDM0_TRxPathEnable 0xc04#define rOFDM0_XARxAFE 0xc10/* RxIQ DC offset, Rx digital filter, DC notch filter */ -#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imblance matrix */ +#define rOFDM0_XARxIQImbalance 0xc14/* RxIQ imbalance matrix */ #define rOFDM0_XBRxAFE 0xc18#define rOFDM0_XBRxIQImbalance 0xc1c#define rOFDM0_XCRxAFE 0xc20
Signature · 1 line
2.17.1