Skip to contentSkip to conversation

multilib_script: fix packages split

PATCH New [email protected] 1 participant 2 messages Nov 26, 2018

lore
Share & tools
lore
#0 lore raw

cover multilib_script: fix packages split

From: Kai Kang <[email protected]>

The following changes since commit 6bf94ad3b6a3f1202e86b500bfce205d0bda977e:

u-boot: Upgrade 2018.07 -> 2018.11 (2018-11-23 23:35:20 +0000)

are available in the Git repository at:

git://git.pokylinux.org/poky-contrib kangkai/ml_script
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/ml_script

Kai Kang (1):
multilib_script: fix packages split

 meta/classes/multilib_script.bbclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.19.0.rc2
#1 lore raw

PATCH 1/1 multilib_script: fix packages split

From: Kai Kang <[email protected]>

In multilib_script.bbclass it renames script file which listed in MULTILIB_SCRIPTS. It may mix up packages split. Take package curl as example, ${bindir}/curl-config is packaged to curl-dev originally. But it is renamed to curl-config-${MULTILIB_SUFFIX} and packaged to curl when multilib is enabled.

And expand 'pkg' to fix QA warning:

| WARNING: Variable key FILES_${PN}-dev (
| ${bindir}/curl-config-${MULTILIB_SUFFIX}) replaces original key
| FILES_curl-dev (${includedir} ${FILES_SOLIBSDEV} ... ${bindir}/*-config)

Insert a necessary space to the argument 'value' of d.appendVar() as well.

---
 meta/classes/multilib_script.bbclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/classes/multilib_script.bbclass +3 -1
index 51c9fcc12c..dc166d06c1 100644
@@ -24,9 +24,11 @@ python () {
 
     for entry in (d.getVar("MULTILIB_SCRIPTS", False) or "").split():
        pkg, script = entry.split(":")
+       epkg = d.expand(pkg)
        scriptname = os.path.basename(script)
-       d.appendVar("ALTERNATIVE_" + pkg, scriptname + " ")
+       d.appendVar("ALTERNATIVE_" + epkg, " " + scriptname + " ")
        d.setVarFlag("ALTERNATIVE_LINK_NAME", scriptname, script)
        d.setVarFlag("ALTERNATIVE_TARGET", scriptname, script + "-${MULTILIB_SUFFIX}")
        d.appendVar("multilibscript_rename",  "\n	mv ${PKGD}" + script + " ${PKGD}" + script + "-${MULTILIB_SUFFIX}")
+       d.appendVar("FILES_" + epkg, " " + script + "-${MULTILIB_SUFFIX}")
 }
Signature · 1 line
2.19.0.rc2