native.bbclass: remove invalid CONFIG_SITE
PATCH 1/1 native.bbclass: remove invalid CONFIG_SITE
In reply to Robert YangThis CONFIG_SITE has no effect since autotools.bbclass handles it. And the comment line is out of date, it was for "CONFIG_SITE = ''", so remove them.
--- meta/classes/native.bbclass | 3 --- meta/site/native | 1 - 2 files changed, 4 deletions(-) delete mode 100644 meta/site/native
meta/classes/native.bbclass +0 -3
@@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = "" # Don't build ptest natively PTEST_ENABLED = "0" -# Don't use site files for native builds -export CONFIG_SITE = "${COREBASE}/meta/site/native" - # set the compiler as well. It could have been set to something else export CC = "${BUILD_CC}" export CXX = "${BUILD_CXX}"
meta/site/native deleted +0 -1
@@ -1 +0,0 @@ -ac_cv_path_SED=sed
Signature · 1 line
2.7.4
cover native.bbclass: remove invalid CONFIG_SITE
The following changes since commit a4edfa4cf451bf412525887b5b24b9db6486ae97:
remove unused distutils-tools.bbclass (2019-01-23 07:57:02 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/native
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/native
Robert Yang (1):
native.bbclass: remove invalid CONFIG_SITE
meta/classes/native.bbclass | 3 --- meta/site/native | 1 - 2 files changed, 4 deletions(-) delete mode 100644 meta/site/native
Signature · 1 line
2.7.4
Quoted 4 lines · Robert Yang
This
CONFIG_SITEhas no effect since autotools.bbclass handles it. And the
comment line is out of date, it was for "CONFIG_SITE= ''", so remove them.
Going from memory, we had a problem where the path to sed was being encoded into scripts (e.g. libtool/autotools and others). It may be /usr/bin/sed on some systems and /bin/sed on others.
Are you sure this is no longer a problem?
Cheers,
Richard
Quoted 32 lines
Signed-off-by Robert Yang <[email protected]>--- meta/classes/native.bbclass | 3 --- meta/site/native | 1 - 2 files changed, 4 deletions(-) delete mode 100644 meta/site/nativemeta/classes/native.bbclass +0
-3@@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = "" # Don't build ptest natively PTEST_ENABLED = "0" -# Don't use site files for native builds -export CONFIG_SITE = "${COREBASE}/meta/site/native" - # set the compiler as well. It could have been set to something else export CC = "${BUILD_CC}" export CXX = "${BUILD_CXX}"meta/site/native deleted +0
-1@@ -1 +0,0 @@ -ac_cv_path_SED=sedSignature · 1 line
2.7.4
Quoted 11 lines · Richard Purdie
Quoted 4 lines · Robert Yang
This
CONFIG_SITEhas no effect since autotools.bbclass handles it. And the
comment line is out of date, it was for "CONFIG_SITE= ''", so remove them.Going from memory, we had a problem where the path to sed was being encoded into scripts (e.g. libtool/autotools and others). It may be
/usr/bin/sedon some systems and/bin/sedon others.Are you sure this is no longer a problem?
Yes, that might be a problem, please ignore the patch, and I will update the comment:
"# Don't use site files for native builds"
To:
# Only use site/native for native builds
// Robert
Quoted 39 lines
Cheers,
Richard
Quoted 32 lines
Signed-off-by Robert Yang <[email protected]>--- meta/classes/native.bbclass | 3 --- meta/site/native | 1 - 2 files changed, 4 deletions(-)delete mode 100644 meta/site/native
meta/classes/native.bbclass +0
-3@@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = "" # Don't build ptest natively PTEST_ENABLED = "0" -# Don't use site files for native builds -export CONFIG_SITE = "${COREBASE}/meta/site/native" - # set the compiler as well. It could have been set to something else export CC = "${BUILD_CC}" export CXX = "${BUILD_CXX}"meta/site/native deleted +0
-1@@ -1 +0,0 @@ -ac_cv_path_SED=sedSignature · 1 line
2.7.4
Quoted 9 lines · Robert Yang
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Robert Yang
This
CONFIG_SITEhas no effect since autotools.bbclass handles it. And the
comment line is out of date, it was for "CONFIG_SITE= ''", so remove them.
Quoted 8 lines
Quoted 5 lines
Going from memory, we had a problem where the path to sed was being encoded into scripts (e.g. libtool/autotools and others). It may be
/usr/bin/sedon some systems and/bin/sedon others.Are you sure this is no longer a problem?
Yes, that might be a problem, please ignore the patch, and I will update the comment:
After more investigations, I'm sure it is not longer needed, I was mis-leaded by:
$ bitbake m4-native -cconfigure -e > m4-native.py
It shows that CONFIG_SITE="/buildarea1/lyang1/poky/meta/site/native"
But if I run:
$ bitbake m4-native -cconfigure
And check temp/run.do_configure:CONFIG_SITE="/buildarea1/lyang1/poky/meta/site/endian-little /buildarea1/lyang1/poky/meta/site/common-linux /buildarea1/lyang1/poky/meta/site/common-glibc /buildarea1/lyang1/poky/meta/site/x86_64-linux /buildarea1/lyang1/poky/meta/site/common "
So the site/native was never used, and I think that it can be removed safely.
// Robert
Quoted 47 lines
"# Don't use site files for native builds"
To:
# Only use site/native for native builds
// Robert
Quoted 38 lines
Cheers,
Richard
Quoted 31 lines
Signed-off-by Robert Yang <[email protected]>---
meta/classes/native.bbclass | 3 ---
meta/site/native | 1 -2 files changed, 4 deletions(-)delete mode 100644 meta/site/native
meta/classes/native.bbclass +0
-0@@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = "" # Don't build ptest natively
PTEST_ENABLED= "0"meta/classes/native.bbclass +0
-3-# Don't use site files for native builds -export CONFIG_SITE = "${COREBASE}/meta/site/native" -# set the compiler as well. It could have been set to something else export CC = "${BUILD_CC}" export CXX = "${BUILD_CXX}"meta/site/native deleted +0
-1@@ -1 +0,0 @@ -ac_cv_path_SED=sedSignature · 1 line
2.7.4
Quoted 9 lines · Robert Yang
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Robert Yang
This
CONFIG_SITEhas no effect since autotools.bbclass handles it. And the
comment line is out of date, it was for "CONFIG_SITE= ''", so remove them.
Quoted 8 lines
Quoted 5 lines
Going from memory, we had a problem where the path to sed was being encoded into scripts (e.g. libtool/autotools and others). It may be
/usr/bin/sedon some systems and/bin/sedon others.Are you sure this is no longer a problem?
Yes, that might be a problem, please ignore the patch, and I will update the comment:
After more investigations, I'm sure that site/native can be removed safely, I was mis-leaded by the following command just now:
$ bitbake m4-native -cconfigure -e > m4-native.py
It shows that CONFIG_SITE="/buildarea1/lyang1/poky/meta/site/native"
But if I run:
$ bitbake m4-native -cconfigure
And check temp/run.do_configure:CONFIG_SITE="/buildarea1/lyang1/poky/meta/site/endian-little /buildarea1/lyang1/poky/meta/site/common-linux /buildarea1/lyang1/poky/meta/site/common-glibc /buildarea1/lyang1/poky/meta/site/x86_64-linux /buildarea1/lyang1/poky/meta/site/common "
So the site/native was never used, and I think that it can be removed safely.
The "$ bitbake m4-native -cconfigure -e" showed incorrect CONFIG_SITE, is this a bug, please ?
// Robert
Quoted 47 lines
"# Don't use site files for native builds"
To:
# Only use site/native for native builds
// Robert
Quoted 38 lines
Cheers,
Richard
Quoted 31 lines
Signed-off-by Robert Yang <[email protected]>---
meta/classes/native.bbclass | 3 ---
meta/site/native | 1 -2 files changed, 4 deletions(-)delete mode 100644 meta/site/native
meta/classes/native.bbclass +0
-0@@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = "" # Don't build ptest natively
PTEST_ENABLED= "0"meta/classes/native.bbclass +0
-3-# Don't use site files for native builds -export CONFIG_SITE = "${COREBASE}/meta/site/native" -# set the compiler as well. It could have been set to something else export CC = "${BUILD_CC}" export CXX = "${BUILD_CXX}"meta/site/native deleted +0
-1@@ -1 +0,0 @@ -ac_cv_path_SED=sedSignature · 1 line
2.7.4
Quoted 7 lines · Robert Yang
Quoted 4 lines · Robert Yang
Quoted 1 line · Richard Purdie
On Thu, 2019-01-24 at 15:06 +0800, Robert Yang wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
This
CONFIG_SITEhas no effect since autotools.bbclass handles it. And the
comment line is out of date, it was for "CONFIG_SITE= ''", so remove them.Going from memory, we had a problem where the path to sed was being encoded into scripts (e.g. libtool/autotools and others). It may be
/usr/bin/sedon some systems and/bin/sedon others.
And for the sed issue, it has been set in meta/site/common:
ac_cv_path_SED=${ac_cv_path_SED=sed}
// Robert
Quoted 73 lines
Quoted 5 lines
Quoted 2 lines
Are you sure this is no longer a problem?
Yes, that might be a problem, please ignore the patch, and I will update the comment:
After more investigations, I'm sure that site/native can be removed safely, I was mis-leaded by the following command just now:
$ bitbake m4-native -cconfigure -e > m4-native.pyIt shows that
CONFIG_SITE="/buildarea1/lyang1/poky/meta/site/native"But if I run:
$ bitbake m4-native -cconfigureAnd check temp/run.do_configure:
CONFIG_SITE="/buildarea1/lyang1/poky/meta/site/endian-little/buildarea1/lyang1/poky/meta/site/common-linux /buildarea1/lyang1/poky/meta/site/common-glibc /buildarea1/lyang1/poky/meta/site/x86_64-linux /buildarea1/lyang1/poky/meta/site/common "So the site/native was never used, and I think that it can be removed safely.
The "$ bitbake m4-native -cconfigure -e" showed incorrect
CONFIG_SITE, is this a bug, please ?// Robert
Quoted 47 lines
"# Don't use site files for native builds"
To:
# Only use site/native for native builds
// Robert
Quoted 38 lines
Cheers,
Richard
Quoted 31 lines
Signed-off-by Robert Yang <[email protected]>---
meta/classes/native.bbclass | 3 ---
meta/site/native | 1 -2 files changed, 4 deletions(-)delete mode 100644 meta/site/native
meta/classes/native.bbclass +0
-0@@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = "" # Don't build ptest natively
PTEST_ENABLED= "0"meta/classes/native.bbclass +0
-3-# Don't use site files for native builds -export CONFIG_SITE = "${COREBASE}/meta/site/native" -# set the compiler as well. It could have been set to something else export CC = "${BUILD_CC}" export CXX = "${BUILD_CXX}"meta/site/native deleted +0
-1@@ -1 +0,0 @@ -ac_cv_path_SED=sedSignature · 1 line
2.7.4