Skip to contentSkip to conversation

base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

PATCH In review Robert Yang 2 participants 5 messages Jan 28, 2019 – Jan 30, 2019

lore
Share & tools
lore
#0 lore raw

cover base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

The following changes since commit ebc96f2f612ebc1b7aefb06935bb308fc2e40cfd:

libtool: Fix ignoring compiler-rt libs (2019-01-26 23:11:39 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/ht
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/ht

Robert Yang (1):
base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

 meta/classes/base.bbclass | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

Fixed:

$ export BB_SERVER_TIMEOUT=-1
$ bitbake quilt-native
$ rm -fr tmp
$ bitbake quilt-native
ERROR: Error running gcc  --version: /bin/sh: gcc: command not found

This is because bb.event.ParseStarted fires only once when server is running, but bb.event.ParseStarted fires every time when build configs are changed, so use bb.event.ParseStarted to fix the problem.

[YOCTO #13022]

---
 meta/classes/base.bbclass | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
meta/classes/base.bbclass +9 -2
index f1a3c0e..c273a29 100644
@@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
         bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
 
 addhandler base_eventhandler
-base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
+base_eventhandler[eventmask] = "\
+	bb.event.ParseStarted \
+	bb.event.MultiConfigParsed \
+	bb.event.BuildStarted \
+	bb.event.RecipePreFinalise \
+	bb.runqueue.sceneQueueComplete \
+	bb.event.RecipeParsed \
+"
 python base_eventhandler() {
     import bb.runqueue
 
-    if isinstance(e, bb.event.ConfigParsed):
+    if isinstance(e, bb.event.ParseStarted):
         if not d.getVar("NATIVELSBSTRING", False):
             d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
         d.setVar('BB_VERSION', bb.__version__)
Signature · 1 line
2.7.4
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Robert Yang
Sent: den 28 januari 2019 10:19
To: [email protected]
Subject: [OE-core] [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

Quoted 8 lines

Fixed:

$ export BB_SERVER_TIMEOUT=-1
$ bitbake quilt-native
$ rm -fr tmp
$ bitbake quilt-native
ERROR: Error running gcc  --version: /bin/sh: gcc: command not found

This is because bb.event.ParseStarted fires only once when server is running,

I assume you meant bb.event.ConfigParsed above?

Quoted 36 lines

but bb.event.ParseStarted fires every time when build configs are changed, so use bb.event.ParseStarted to fix the problem.

[YOCTO #13022]

---
 meta/classes/base.bbclass | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
meta/classes/base.bbclass +9 -3
index f1a3c0e..c273a29 100644
@@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
         bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
 
 addhandler base_eventhandler
-base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
+base_eventhandler[eventmask] = "\
+	bb.event.ParseStarted \
+	bb.event.MultiConfigParsed \
+	bb.event.BuildStarted \
+	bb.event.RecipePreFinalise \
+	bb.runqueue.sceneQueueComplete \
+	bb.event.RecipeParsed \
+"
 python base_eventhandler() {
     import bb.runqueue
 
-    if isinstance(e, bb.event.ConfigParsed):
+    if isinstance(e, bb.event.ParseStarted):
         if not d.getVar("NATIVELSBSTRING", False):
             d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
         d.setVar('BB_VERSION', bb.__version__)
--
Quoted 1 line

2.7.4

//Peter

#3 lore raw
Quoted 15 lines · Peter Kjellerstedt
Quoted 15 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Robert Yang
Sent: den 28 januari 2019 10:19
To: [email protected]
Subject: [OE-core] [PATCH 1/1] base.bbclass: Use bb.event.ParseStarted for HOSTTOOLS

Fixed:

$ export BB_SERVER_TIMEOUT=-1
$ bitbake quilt-native
$ rm -fr tmp
$ bitbake quilt-native
ERROR: Error running gcc  --version: /bin/sh: gcc: command not found
Quoted 3 lines
Quoted 1 line

This is because bb.event.ParseStarted fires only once when server is running,

I assume you meant bb.event.ConfigParsed above?

Yes, thanks for pointing it out, fixed it in the repo:

git://git.openembedded.org/openembedded-core-contrib rbt/ht

// Robert

Quoted 42 lines
Quoted 37 lines

but bb.event.ParseStarted fires every time when build configs are changed, so use bb.event.ParseStarted to fix the problem.

[YOCTO #13022]

---
  meta/classes/base.bbclass | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)
meta/classes/base.bbclass +9 -3
index f1a3c0e..c273a29 100644
@@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
          bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
 
  addhandler base_eventhandler
-base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
+base_eventhandler[eventmask] = "\
+	bb.event.ParseStarted \
+	bb.event.MultiConfigParsed \
+	bb.event.BuildStarted \
+	bb.event.RecipePreFinalise \
+	bb.runqueue.sceneQueueComplete \
+	bb.event.RecipeParsed \
+"
  python base_eventhandler() {
      import bb.runqueue
 
-    if isinstance(e, bb.event.ConfigParsed):
+    if isinstance(e, bb.event.ParseStarted):
          if not d.getVar("NATIVELSBSTRING", False):
              d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
          d.setVar('BB_VERSION', bb.__version__)
--
Quoted 1 line

2.7.4

//Peter

#4 lore raw
In reply to Robert Yang

Sorry, this patch doesn't work, it breaks fresh build's sanity check since the hosttools are bot ready when run sanity check.

ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker
(see sanity.conf).
Following is the list of potential problems / advisories:

Please install the following missing utilities: GNU make,C Compiler (gcc
),C++ Compiler (g++ ),patch,diffstat,makeinfo,git,bzip2,tar,gzip,gawk,chrpath,wget,cpio,perl,file,which

Please ignore this patch.

// Robert

Quoted 44 lines · Robert Yang

Fixed:

$ export BB_SERVER_TIMEOUT=-1
$ bitbake quilt-native
$ rm -fr tmp
$ bitbake quilt-native
ERROR: Error running gcc  --version: /bin/sh: gcc: command not found

This is because bb.event.ParseStarted fires only once when server is running, but bb.event.ParseStarted fires every time when build configs are changed, so use bb.event.ParseStarted to fix the problem.

[YOCTO #13022]

---
  meta/classes/base.bbclass | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)
meta/classes/base.bbclass +9 -2
index f1a3c0e..c273a29 100644
@@ -220,11 +220,18 @@ def buildcfg_neededvars(d):
          bb.fatal('The following variable(s) were not set: %s\nPlease set them directly, or choose a MACHINE or DISTRO that sets them.' % ', '.join(pesteruser))
 
  addhandler base_eventhandler
-base_eventhandler[eventmask] = "bb.event.ConfigParsed bb.event.MultiConfigParsed bb.event.BuildStarted bb.event.RecipePreFinalise bb.runqueue.sceneQueueComplete bb.event.RecipeParsed"
+base_eventhandler[eventmask] = "\
+	bb.event.ParseStarted \
+	bb.event.MultiConfigParsed \
+	bb.event.BuildStarted \
+	bb.event.RecipePreFinalise \
+	bb.runqueue.sceneQueueComplete \
+	bb.event.RecipeParsed \
+"
  python base_eventhandler() {
      import bb.runqueue
 
-    if isinstance(e, bb.event.ConfigParsed):
+    if isinstance(e, bb.event.ParseStarted):
          if not d.getVar("NATIVELSBSTRING", False):
              d.setVar("NATIVELSBSTRING", lsb_distro_identifier(d))
          d.setVar('BB_VERSION', bb.__version__)