Skip to contentSkip to conversation

Fix checkpatch.pl issues

PATCH In review Madhumitha Prabakaran 3 participants 14 messages Mar 2, 2019 – Mar 4, 2019 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover Fix checkpatch.pl issues

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
Staging: vt6655: card.h: Fix line over 80 character
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

 drivers/staging/vt6655/card.h       | 6 ++++--
 drivers/staging/vt6655/device.h     | 2 +-
 drivers/staging/vt6655/device_cfg.h | 2 +-
 drivers/staging/vt6655/dpc.h        | 2 +-
 drivers/staging/vt6655/key.h        | 2 +-
 drivers/staging/vt6655/mac.c        | 1 -
 drivers/staging/vt6655/mac.h        | 2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/8 Staging: vt6655: Fix line over 80 character

Fix the warning
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
index d71022aa3f86..6bbbbe1314d5 100644
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/8 Staging: vt6655: Fix line over 80 characters

In reply to Madhumitha Prabakaran

Fix the warning
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
index 6bbbbe1314d5..490cecf8fb9d 100644
@@ -62,6 +62,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv);
 bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type);
 bool CARDbUpdateTSF(struct vnt_private *priv, unsigned char byRxRate,
 		    u64 qwBSSTimestamp);
-bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval);
+bool CARDbSetBeaconPeriod(struct vnt_private *priv,
+			  unsigned short wBeaconInterval);
 
 #endif /* __CARD_H__ */
Signature · 1 line
2.17.1
#3 lore raw

PATCH v2 3/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifier based on License Identifier syntax for header type file.

---
 drivers/staging/vt6655/device_cfg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/device_cfg.h +1 -1
index 6b41c74f7c2a..04db6a8d3db3 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#4 lore raw

PATCH v2 4/8 Staging: vt6655: Fix comment style of SPDX License Identifer

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header type file based on License Identifier syntax.

---
 drivers/staging/vt6655/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/device.h +1 -1
index 2f9e9219e8c8..29f354ced563 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#5 lore raw

PATCH v2 5/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header file based on License Identifier syntax.

---
 drivers/staging/vt6655/dpc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/dpc.h +1 -1
index 93af4220605f..eac67794cc49 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#6 lore raw

PATCH v2 6/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifier for header file type based on License Identifer syntax.

---
 drivers/staging/vt6655/key.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/key.h +1 -1
index 0942d8703f98..9347776fa3a5 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#7 lore raw

PATCH v2 7/8 Staging: vt6655: Remove unnecessary blank line

In reply to Madhumitha Prabakaran

Remove unnecessary blank line before end of block brace so that it fix the check
CHECK: Blank lines aren't necessary before a close brace '}'

---
 drivers/staging/vt6655/mac.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/mac.c +0 -1
index 4750863c1bb7..40a8f1ce837c 100644
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
 	iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
 	if (org_dma_ctl & DMACTL_RUN)
 		iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
 }
 
 /*
Signature · 1 line
2.17.1
#8 lore raw

PATCH v2 8/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header type file based on License Identifer syntax.

---
 drivers/staging/vt6655/mac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +1 -1
index b8ab09434773..8c8c26792343 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#9 lore raw
In reply to Madhumitha Prabakaran
Quoted 12 lines · Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
Staging: vt6655: card.h: Fix line over 80 character
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

I'm confused about this series. I have the impression that it touches the same files as the other series with only two patches. And it has the same problem with the subject lines. You have made them unique in the cover letter, but they are not unique in the patches. You should use

git rebase -i HEAD~n

where n is the number of patches you need to go back in the history to get to the ones you want to adjust. Then in the menu that it offers you, you can edit the log message of each one, specifically the first line, which will become the subject line. Then regenerate your patches in the normal way.

julia

Quoted 23 lines

---
Changes in v2
- Fixed subject line difference

 drivers/staging/vt6655/card.h       | 6 ++++--
 drivers/staging/vt6655/device.h     | 2 +-
 drivers/staging/vt6655/device_cfg.h | 2 +-
 drivers/staging/vt6655/dpc.h        | 2 +-
 drivers/staging/vt6655/key.h        | 2 +-
 drivers/staging/vt6655/mac.c        | 1 -
 drivers/staging/vt6655/mac.h        | 2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1551550323.git.madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

maintainer
#10 lore raw
In reply to Madhumitha Prabakaran
Quoted 12 lines · Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
Staging: vt6655: card.h: Fix line over 80 character
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

Again, does not match the subject lines :(

Perhaps if you typed out here _exactly_ what you did to create this cover letter, and send them off to us, it might help in determining what you did wrong.

thanks,

greg k-h

#11 lore raw
Quoted 16 lines · Greg KH
Quoted 12 lines · Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
Staging: vt6655: card.h: Fix line over 80 character
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

Again, does not match the subject lines :(

Quoted 7 lines

Perhaps if you typed out here _exactly_ what you did to create this cover letter, and send them off to us, it might help in determining what you did wrong.

thanks,

greg k-h

Thanks

Task: commit patchsets, which contains two patches

1. git log --pretty=oneline --abbrev-commit

8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ... f68b96b7f7f5 Staging: vt6655: Fix comment ...

08b9bee66e3e (origin/staging-testing, origin/staging-next) ...

2. Format-patch

git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="[email protected]" f68b96b7f7f5^..8f8d8bbad6bc

/tmp/three/0000-cover-letter.patch /tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch /tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch

3. Format patch for versioning

git format-patch -n --subject-prefix="PATCH v2" --cover-letter

On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation.

4. I manually edit the vim /tmp/three/0000-cover-letter.patch

5. Edited the 'SUBJECT HERE' and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually. I tried to change subject prefix for all the three files manually

6. After that I tried using mutt and git to send files

For git I used
git send-email --to-cover --cc-cover /tmp/three/*.patch

For mutt I used
mutt -H /tmp/third/0000......patch
For all three files I individually sent it via mutt

Referred: 1. https://kernelnewbies.org/Outreachyfirstpatch
2. https://kernelnewbies.org/PatchSeries

Thanks,

Madhumitha

maintainer
#12 lore raw
Quoted 27 lines · Madhumthia Prabakaran
Quoted 16 lines · Greg KH
Quoted 12 lines · Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
Staging: vt6655: card.h: Fix line over 80 character
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

Again, does not match the subject lines :(

Quoted 7 lines

Perhaps if you typed out here _exactly_ what you did to create this cover letter, and send them off to us, it might help in determining what you did wrong.

thanks,

greg k-h

Thanks

Quoted 8 lines

Task: commit patchsets, which contains two patches

1. git log --pretty=oneline --abbrev-commit

8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ... f68b96b7f7f5 Staging: vt6655: Fix comment ...

08b9bee66e3e (origin/staging-testing, origin/staging-next) ...

Ah, the problem is you never changed the actual changelog text in the patch itself. You need to do that.

Quoted 7 lines

2. Format-patch

git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="[email protected]" f68b96b7f7f5^..8f8d8bbad6bc

/tmp/three/0000-cover-letter.patch /tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch /tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch

See the subject line does not have the file name in it.

Quoted 5 lines

3. Format patch for versioning

git format-patch -n --subject-prefix="PATCH v2" --cover-letter

On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation.

As discussed on irc, you don't need to use --subject-prefix.

Also, no need to call format-patch twice.

Quoted 4 lines

4. I manually edit the vim /tmp/three/0000-cover-letter.patch

5. Edited the 'SUBJECT HERE' and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually. I tried to change subject prefix for all the three files manually

Editing this file does not change the actual text in the patches themselves.

Quoted 8 lines

6. After that I tried using mutt and git to send files

For git I used
git send-email --to-cover --cc-cover /tmp/three/*.patch

For mutt I used
mutt -H /tmp/third/0000......patch
For all three files I individually sent it via mutt

Sending is fine.

Ok, you need to change the subject lines of your patch.

to do this, rebase the patches and edit the changelog text. Look up how 'git rebase -i' works, with the "reword" option. That will give you the chance to reword the changlog text to properly change the first line of the patches to contain the filenames.

Then do your step 3 and others and all should be good.

Hope this helps,

greg k-h

#13 lore raw
Quoted 86 lines · Greg KH
Quoted 27 lines · Madhumthia Prabakaran
Quoted 16 lines · Greg KH
Quoted 12 lines · Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
Staging: vt6655: card.h: Fix line over 80 character
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

Again, does not match the subject lines :(

Quoted 7 lines

Perhaps if you typed out here _exactly_ what you did to create this cover letter, and send them off to us, it might help in determining what you did wrong.

thanks,

greg k-h

Thanks

Quoted 8 lines

Task: commit patchsets, which contains two patches

1. git log --pretty=oneline --abbrev-commit

8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ... f68b96b7f7f5 Staging: vt6655: Fix comment ...

08b9bee66e3e (origin/staging-testing, origin/staging-next) ...

Ah, the problem is you never changed the actual changelog text in the patch itself. You need to do that.

Quoted 7 lines

2. Format-patch

git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="[email protected]" f68b96b7f7f5^..8f8d8bbad6bc

/tmp/three/0000-cover-letter.patch /tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch /tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch

See the subject line does not have the file name in it.

Quoted 5 lines

3. Format patch for versioning

git format-patch -n --subject-prefix="PATCH v2" --cover-letter

On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation.

As discussed on irc, you don't need to use --subject-prefix.

Also, no need to call format-patch twice.

Quoted 4 lines

4. I manually edit the vim /tmp/three/0000-cover-letter.patch

5. Edited the 'SUBJECT HERE' and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually. I tried to change subject prefix for all the three files manually

Editing this file does not change the actual text in the patches themselves.

Quoted 8 lines

6. After that I tried using mutt and git to send files

For git I used
git send-email --to-cover --cc-cover /tmp/three/*.patch

For mutt I used
mutt -H /tmp/third/0000......patch
For all three files I individually sent it via mutt

Sending is fine.

Ok, you need to change the subject lines of your patch.

to do this, rebase the patches and edit the changelog text. Look up how 'git rebase -i' works, with the "reword" option. That will give you the chance to reword the changlog text to properly change the first line of the patches to contain the filenames.

Quoted 5 lines

Then do your step 3 and others and all should be good.

Hope this helps,

greg k-h

Thanks, I will fix it and resend it.

Madhumitha