Staging: vt6655: Fix checkpatch.pl issues
cover Staging: vt6655: Fix checkpatch.pl issues
This patchset modifies following -
1) Fix comment style for SPDX License Identifier in dpc.h
2) Fix comment style for SPDX License Identifier in key.h
3) Remove unnecessary blank line
4) Fix comment style for SPDX License Identifier in mac.h
5) Fix warning line over 80 characters
6) Align function declaration
Madhumitha Prabakaran (6):
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Fix line over 80 characters
Staging: vt6655: Align function declaration
drivers/staging/vt6655/dpc.h | 2 +- drivers/staging/vt6655/key.h | 2 +- drivers/staging/vt6655/mac.c | 1 - drivers/staging/vt6655/mac.h | 5 +++-- drivers/staging/vt6655/power.c | 7 ++----- 5 files changed, 7 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/6 Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Modify comment style of SPDX License Identifier for header file type, as per the license identifier syntax.
--- drivers/staging/vt6655/dpc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/dpc.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
PATCH 2/6 Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
In reply to Madhumitha PrabakaranModify comment style for SPDX-License Identifier based on license identifier syntax.
--- drivers/staging/vt6655/key.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/key.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
PATCH 3/6 Staging: vt6655: Remove unnecessary blank line
In reply to Madhumitha PrabakaranFix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
--- drivers/staging/vt6655/mac.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/vt6655/mac.c +0 -1
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)iowrite32 (curr_desc_addr, io_base +MAC_REG_RXDMAPTR1 );if (org_dma_ctl &DMACTL_RUN )iowrite8 (DMACTL_RUN , io_base +MAC_REG_RXDMACTL1 ); - }/*
Signature · 1 line
2.17.1
PATCH 4/6 Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
In reply to Madhumitha PrabakaranModify comment style for header type file based on license identifier syntax.
--- drivers/staging/vt6655/mac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
PATCH 5/6 Staging: vt6655: Fix line over 80 characters
In reply to Madhumitha PrabakaranFix the checkpatch.pl warning
WARNING: line over 80 characters
--- drivers/staging/vt6655/mac.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +2 -1
@@ -883,7 +883,8 @@ bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,bool MACbIsIntDisable (struct vnt_private *priv); -void MACvSetShortRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); +void MACvSetShortRetryLimit (struct vnt_private *priv, +unsigned char byRetryLimit);void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); void MACvGetLongRetryLimit(struct vnt_private *priv,
Signature · 1 line
2.17.1
PATCH 6/6 Staging: vt6655: Align function declaration
In reply to Madhumitha PrabakaranFix function return type and function arguments to improve readbility.
--- drivers/staging/vt6655/power.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/vt6655/power.c +2 -5
@@ -48,11 +48,8 @@* */ -void -PSvEnablePowerSaving ( -struct vnt_private *priv, -unsigned short wListenInterval -) +void PSvEnablePowerSaving (struct vnt_private *priv, +unsigned short wListenInterval) {u16 wAID = priv->current_aid |BIT (14 ) |BIT (15 );
Signature · 1 line
2.17.1
v2 cover Modify checkpatch.pl issues
In reply to Madhumitha PrabakaranThis patchset modifies following -
1) Fix comment style for SPDX License Identifier in dpc.h
2) Fix comment style for SPDX License Identifier in key.h
3) Remove unnecessary blank line
4) Fix comment style for SPDX License Identifier in mac.h
5) Fix warning line over 80 characters
6) Align function declaration
Madhumitha Prabakaran (6):
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Fix the warning line over 80 characters
Staging: vt6655: Align function declaration
---
Change in v2
- Modified SUBJECT HERE for patch series
- Changed subject line for fifth patch
drivers/staging/vt6655/dpc.h | 2 +- drivers/staging/vt6655/key.h | 2 +- drivers/staging/vt6655/mac.c | 1 - drivers/staging/vt6655/mac.h | 5 +++-- drivers/staging/vt6655/power.c | 7 ++----- 5 files changed, 7 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/6 Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Modify comment style of SPDX License Identifier for header file type, as per the license identifier syntax.
--- drivers/staging/vt6655/dpc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/dpc.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
PATCH v2 2/6 Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
In reply to Madhumitha PrabakaranModify comment style for SPDX-License Identifier based on license identifier syntax.
--- drivers/staging/vt6655/key.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/key.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
PATCH v2 3/6 Staging: vt6655: Remove unnecessary blank line
In reply to Madhumitha PrabakaranFix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
--- drivers/staging/vt6655/mac.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/vt6655/mac.c +0 -1
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)iowrite32 (curr_desc_addr, io_base +MAC_REG_RXDMAPTR1 );if (org_dma_ctl &DMACTL_RUN )iowrite8 (DMACTL_RUN , io_base +MAC_REG_RXDMACTL1 ); - }/*
Signature · 1 line
2.17.1
PATCH v2 4/6 Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
In reply to Madhumitha PrabakaranModify comment style for header type file based on license identifier syntax.
--- drivers/staging/vt6655/mac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
PATCH v2 5/6 Staging: vt6655: Fix the warning line over 80 characters
In reply to Madhumitha PrabakaranFix the checkpatch.pl warning
WARNING: line over 80 characters
--- drivers/staging/vt6655/mac.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +2 -1
@@ -883,7 +883,8 @@ bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,bool MACbIsIntDisable (struct vnt_private *priv); -void MACvSetShortRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); +void MACvSetShortRetryLimit (struct vnt_private *priv, +unsigned char byRetryLimit);void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); void MACvGetLongRetryLimit(struct vnt_private *priv,
Signature · 1 line
2.17.1
PATCH v2 6/6 Staging: vt6655: Align function declaration
In reply to Madhumitha PrabakaranFix function return type and function arguments to improve readbility.
--- drivers/staging/vt6655/power.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/vt6655/power.c +2 -5
@@ -48,11 +48,8 @@* */ -void -PSvEnablePowerSaving ( -struct vnt_private *priv, -unsigned short wListenInterval -) +void PSvEnablePowerSaving (struct vnt_private *priv, +unsigned short wListenInterval) {u16 wAID = priv->current_aid |BIT (14 ) |BIT (15 );
Signature · 1 line
2.17.1