Skip to contentSkip to conversation

Staging: vt6655: Fix checkpatch.pl issues

PATCH Superseded Madhumitha Prabakaran 1 participant 14 messages Mar 5, 2019 Staging

lore
Share & tools
lore
#0 lore raw

cover Staging: vt6655: Fix checkpatch.pl issues

This patchset modifies following -
1) Fix comment style for SPDX License Identifier in dpc.h
2) Fix comment style for SPDX License Identifier in key.h
3) Remove unnecessary blank line
4) Fix comment style for SPDX License Identifier in mac.h
5) Fix warning line over 80 characters
6) Align function declaration

Madhumitha Prabakaran (6):
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Fix line over 80 characters
Staging: vt6655: Align function declaration

 drivers/staging/vt6655/dpc.h   | 2 +-
 drivers/staging/vt6655/key.h   | 2 +-
 drivers/staging/vt6655/mac.c   | 1 -
 drivers/staging/vt6655/mac.h   | 5 +++--
 drivers/staging/vt6655/power.c | 7 ++-----
 5 files changed, 7 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/6 Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier

Modify comment style of SPDX License Identifier for header file type, as per the license identifier syntax.

---
 drivers/staging/vt6655/dpc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/dpc.h +1 -1
index 93af4220605f..eac67794cc49 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/6 Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier

In reply to Madhumitha Prabakaran

Modify comment style for SPDX-License Identifier based on license identifier syntax.

---
 drivers/staging/vt6655/key.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/key.h +1 -1
index 0942d8703f98..9347776fa3a5 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/6 Staging: vt6655: Remove unnecessary blank line

In reply to Madhumitha Prabakaran

Fix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'

---
 drivers/staging/vt6655/mac.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/mac.c +0 -1
index 4750863c1bb7..40a8f1ce837c 100644
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
 	iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
 	if (org_dma_ctl & DMACTL_RUN)
 		iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
 }
 
 /*
Signature · 1 line
2.17.1
#4 lore raw

PATCH 4/6 Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier

In reply to Madhumitha Prabakaran

Modify comment style for header type file based on license identifier syntax.

---
 drivers/staging/vt6655/mac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +1 -1
index b8ab09434773..8c8c26792343 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#5 lore raw

PATCH 5/6 Staging: vt6655: Fix line over 80 characters

In reply to Madhumitha Prabakaran

Fix the checkpatch.pl warning
WARNING: line over 80 characters

---
 drivers/staging/vt6655/mac.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +2 -1
index 8c8c26792343..99de843b4551 100644
@@ -883,7 +883,8 @@ bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 
 bool MACbIsIntDisable(struct vnt_private *priv);
 
-void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetShortRetryLimit(struct vnt_private *priv,
+			    unsigned char byRetryLimit);
 
 void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
 void MACvGetLongRetryLimit(struct vnt_private *priv,
Signature · 1 line
2.17.1
#6 lore raw

PATCH 6/6 Staging: vt6655: Align function declaration

In reply to Madhumitha Prabakaran

Fix function return type and function arguments to improve readbility.

---
 drivers/staging/vt6655/power.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/vt6655/power.c +2 -5
index d6c581b31569..9725de3bca6a 100644
@@ -48,11 +48,8 @@
  *
  */
 
-void
-PSvEnablePowerSaving(
-	struct vnt_private *priv,
-	unsigned short wListenInterval
-)
+void PSvEnablePowerSaving(struct vnt_private *priv,
+			  unsigned short wListenInterval)
 {
 	u16 wAID = priv->current_aid | BIT(14) | BIT(15);
 
Signature · 1 line
2.17.1
#7 lore raw

v2 cover Modify checkpatch.pl issues

In reply to Madhumitha Prabakaran

This patchset modifies following -
1) Fix comment style for SPDX License Identifier in dpc.h
2) Fix comment style for SPDX License Identifier in key.h
3) Remove unnecessary blank line
4) Fix comment style for SPDX License Identifier in mac.h
5) Fix warning line over 80 characters
6) Align function declaration

Madhumitha Prabakaran (6):
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
Staging: vt6655: Fix the warning line over 80 characters
Staging: vt6655: Align function declaration

---
Change in v2
- Modified SUBJECT HERE for patch series
- Changed subject line for fifth patch

 drivers/staging/vt6655/dpc.h   | 2 +-
 drivers/staging/vt6655/key.h   | 2 +-
 drivers/staging/vt6655/mac.c   | 1 -
 drivers/staging/vt6655/mac.h   | 5 +++--
 drivers/staging/vt6655/power.c | 7 ++-----
 5 files changed, 7 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
#8 lore raw

PATCH v2 1/6 Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier

Modify comment style of SPDX License Identifier for header file type, as per the license identifier syntax.

---
 drivers/staging/vt6655/dpc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/dpc.h +1 -1
index 93af4220605f..eac67794cc49 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#9 lore raw

PATCH v2 2/6 Staging: vt6655: key.h: Fix comment style for SPDX-License Identifier

In reply to Madhumitha Prabakaran

Modify comment style for SPDX-License Identifier based on license identifier syntax.

---
 drivers/staging/vt6655/key.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/key.h +1 -1
index 0942d8703f98..9347776fa3a5 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#10 lore raw

PATCH v2 3/6 Staging: vt6655: Remove unnecessary blank line

In reply to Madhumitha Prabakaran

Fix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'

---
 drivers/staging/vt6655/mac.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/mac.c +0 -1
index 4750863c1bb7..40a8f1ce837c 100644
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
 	iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
 	if (org_dma_ctl & DMACTL_RUN)
 		iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
 }
 
 /*
Signature · 1 line
2.17.1
#11 lore raw

PATCH v2 4/6 Staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier

In reply to Madhumitha Prabakaran

Modify comment style for header type file based on license identifier syntax.

---
 drivers/staging/vt6655/mac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +1 -1
index b8ab09434773..8c8c26792343 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#12 lore raw

PATCH v2 5/6 Staging: vt6655: Fix the warning line over 80 characters

In reply to Madhumitha Prabakaran

Fix the checkpatch.pl warning
WARNING: line over 80 characters

---
 drivers/staging/vt6655/mac.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +2 -1
index 8c8c26792343..99de843b4551 100644
@@ -883,7 +883,8 @@ bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 
 bool MACbIsIntDisable(struct vnt_private *priv);
 
-void MACvSetShortRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetShortRetryLimit(struct vnt_private *priv,
+			    unsigned char byRetryLimit);
 
 void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
 void MACvGetLongRetryLimit(struct vnt_private *priv,
Signature · 1 line
2.17.1
#13 lore raw

PATCH v2 6/6 Staging: vt6655: Align function declaration

In reply to Madhumitha Prabakaran

Fix function return type and function arguments to improve readbility.

---
 drivers/staging/vt6655/power.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/vt6655/power.c +2 -5
index d6c581b31569..9725de3bca6a 100644
@@ -48,11 +48,8 @@
  *
  */
 
-void
-PSvEnablePowerSaving(
-	struct vnt_private *priv,
-	unsigned short wListenInterval
-)
+void PSvEnablePowerSaving(struct vnt_private *priv,
+			  unsigned short wListenInterval)
 {
 	u16 wAID = priv->current_aid | BIT(14) | BIT(15);
 
Signature · 1 line
2.17.1