Skip to contentSkip to conversation

drm: imx: Add NWL MIPI DSI host controller support

PATCH In review Guido Günther 5 participants 19 messages Mar 7, 2019 – Jul 31, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover drm: imx: Add NWL MIPI DSI host controller support

This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs.

It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform data for other SoCs.

The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by but I'm happy to swap Author: and Co-authored-by: if that looks more appropriate. The most notable changes over the BSP driver are
- Calculate HS mode timing from phy_configure_opts_mipi_dphy
- Perform all clock setup via DT
- Merge nwl-imx and nwl drivers
- Add B0 silion revision quirk

Posting this is likely a bit premature (hence v0) but I wanted for one show how this hooks into the mixel dphy posted earlier [1] and avoid duplicating work. So if there's other code out there doing the same I'm be happy to merge efforts.

It has been tested quite bit (in a version backported to 4.18) on Librem 5 devkit using DCSS (which is not mainlined yet) and a MIPI DSI panel[2]. In principle LCDIF can also act as input source. I intend look into next so this can actually be tested without further patches on mainline kernels.

[1]: https://lists.freedesktop.org/archives/dri-devel/2019-March/209680.html
[2]: https://source.puri.sm/guido.gunther/linux-imx8/tree/imx8-4.18-wip-nwl-dsi-rework

Guido Günther (2):
dt-bindings: imx: Add binding for IMX NWL mipi dsi host controller drm/imx: Add NWL MIPI DSI host controller support

 .../bindings/display/imx/imx-nwl-dsi.txt      |  72 ++
 drivers/gpu/drm/Kconfig                       |   2 +
 drivers/gpu/drm/Makefile                      |   1 +
 drivers/gpu/drm/nwl/Kconfig                   |  12 +
 drivers/gpu/drm/nwl/Makefile                  |   2 +
 drivers/gpu/drm/nwl/nwl-drv.c                 | 594 ++++++++++++++
 drivers/gpu/drm/nwl/nwl-drv.h                 |  68 ++
 drivers/gpu/drm/nwl/nwl-dsi.c                 | 752 ++++++++++++++++++
 drivers/gpu/drm/nwl/nwl-dsi.h                 | 105 +++
 9 files changed, 1608 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/imx/imx-nwl-dsi.txt
 create mode 100644 drivers/gpu/drm/nwl/Kconfig
 create mode 100644 drivers/gpu/drm/nwl/Makefile
 create mode 100644 drivers/gpu/drm/nwl/nwl-drv.c
 create mode 100644 drivers/gpu/drm/nwl/nwl-drv.h
 create mode 100644 drivers/gpu/drm/nwl/nwl-dsi.c
 create mode 100644 drivers/gpu/drm/nwl/nwl-dsi.h
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH 1/2 dt-bindings: imx: Add binding for IMX NWL mipi dsi host controller

The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 Socs.

---
 .../bindings/display/imx/imx-nwl-dsi.txt      | 72 +++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/imx/imx-nwl-dsi.txt
Documentation/devicetree/bindings/display/imx/imx-nwl-dsi.txt new file +72 -0
new file mode 100644
index 000000000000..d74b9e303417
@@ -0,0 +1,72 @@
+Northwest Logic MIPI-DSI on imx SoCs
+=====================================
+
+NWL MIPI-DSI host controller found in i.MX8 platforms. This is an
+encoder/connector for the for the NWL MIPI-DSI host.
+
+Required properties:
+- compatible: 		"fsl,<chip>-mipi-dsi"
+	The following strings are expected:
+			"fsl,imx8mq-mipi-dsi_drm"
+- reg: 			the register range of the MIPI-DSI controller
+- interrupts: 		the interrupt number for this module
+- clock, clock-names: 	phandles to the MIPI-DSI clocks
+	The following clocks are expected on all platforms:
+                "core"    - DSI core clock
+		"tx_esc"  - TX_ESC clock (used in escape mode)
+		"rx_esc"  - RX_ESC clock (used in escape mode)
+		"phy_ref" - PHY_REF clock. Clock is managed by the phy. Only
+                            used to read the clock rate.
+	The following clocks are expected on i.MX8mq:
+		"cosre"  - DSI core clock
+- assigned-clocks:	phandles to clocks that requires initial configuration
+- assigned-clock-rates:	rates of the clocks that requires initial configuration
+	The following clocks needs to have an initial configuration:
+	"tx_esc" (20 MHz) and "rx_esc" (80 Mhz).
+- phys: 		phandle to the phy module representing the DPHY
+			inside the MIPI-DSI IP block
+- phy-names: 		should be "dphy"
+
+Optional properties:
+- power-domains 	phandle to the power domain
+- src			phandle to the system reset controller (required on
+			i.MX8mq)
+- mux-sel		phandle to the MUX register set (required on i.MX8mq)
+- assigned-clock-parents phandles to parent clocks that needs to be assigned as
+			parents to clocks defined in assigned-clocks
+
+Example:
+	mipi_dsi: mipi_dsi@30A00000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "fsl,imx8mq-nwl-dsi";
+		reg = <0x0 0x30A00000 0x0 0x300>;
+		clocks = <&clk IMX8MQ_CLK_DSI_CORE_DIV>,
+			 <&clk IMX8MQ_CLK_DSI_AHB_DIV>,
+		         <&clk IMX8MQ_CLK_DSI_IPG_DIV>,
+			 <&clk IMX8MQ_CLK_DSI_PHY_REF_DIV>;
+		clock-names = "core", "rx_esc", "tx_esc", "phy_ref";
+		assigned-clocks = <&clk IMX8MQ_CLK_DSI_AHB_SRC>,
+				  <&clk IMX8MQ_CLK_DSI_CORE_SRC>,
+				  <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
+				  <&clk IMX8MQ_VIDEO_PLL1>,
+				  <&clk IMX8MQ_CLK_DSI_IPG_DIV>,
+				  <&clk IMX8MQ_CLK_DSI_AHB_DIV>;
+		assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>,
+					 <&clk IMX8MQ_SYS1_PLL_266M>,
+					 <&clk IMX8MQ_CLK_25M>,
+					 <&clk IMX8MQ_CLK_DSI_AHB_DIV>;
+		assigned-clock-rates = <80000000>,
+				       <266000000>,
+				       <0>,
+				       <599999999>,
+				       <20000000>,
+				       <80000000>;
+		interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+		power-domains = <&mipi_pd>;
+		src = <&src>;
+		mux-sel = <&gpr>;
+		phys = <&mipi_dsi_phy>;
+		phy-names = "dphy";
+		status = "okay";
+	};
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

PATCH 2/2 drm/imx: Add NWL MIPI DSI host controller support

In reply to Guido Günther

This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs.

It adds support for the i.MX8MQ but the same IP can be found on i.MX8QXP.

It has been tested on the Librem 5 devkit using DCSS.

---
 drivers/gpu/drm/Kconfig       |   2 +
 drivers/gpu/drm/Makefile      |   1 +
 drivers/gpu/drm/nwl/Kconfig   |  12 +
 drivers/gpu/drm/nwl/Makefile  |   2 +
 drivers/gpu/drm/nwl/nwl-drv.c | 594 +++++++++++++++++++++++++++
 drivers/gpu/drm/nwl/nwl-drv.h |  68 +++
 drivers/gpu/drm/nwl/nwl-dsi.c | 752 ++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/nwl/nwl-dsi.h | 105 +++++
 8 files changed, 1536 insertions(+)
 create mode 100644 drivers/gpu/drm/nwl/Kconfig
 create mode 100644 drivers/gpu/drm/nwl/Makefile
 create mode 100644 drivers/gpu/drm/nwl/nwl-drv.c
 create mode 100644 drivers/gpu/drm/nwl/nwl-drv.h
 create mode 100644 drivers/gpu/drm/nwl/nwl-dsi.c
 create mode 100644 drivers/gpu/drm/nwl/nwl-dsi.h
drivers/gpu/drm/Kconfig +2 -0
index bd943a71756c..0c9ee3ef55c6 100644
@@ -303,6 +303,8 @@ source "drivers/gpu/drm/sti/Kconfig"
 
 source "drivers/gpu/drm/imx/Kconfig"
 
+source "drivers/gpu/drm/nwl/Kconfig"
+
 source "drivers/gpu/drm/v3d/Kconfig"
 
 source "drivers/gpu/drm/vc4/Kconfig"
drivers/gpu/drm/Makefile +1 -0
index f0c1f8731a27..169dd8062964 100644
@@ -96,6 +96,7 @@ obj-$(CONFIG_DRM_STI) += sti/
 obj-$(CONFIG_DRM_IMX) += imx/
 obj-$(CONFIG_DRM_MEDIATEK) += mediatek/
 obj-$(CONFIG_DRM_MESON)	+= meson/
+obj-$(CONFIG_DRM_IMX_NWL_DSI) += nwl/
 obj-y			+= i2c/
 obj-y			+= panel/
 obj-y			+= bridge/
drivers/gpu/drm/nwl/Kconfig new file +12 -0
new file mode 100644
index 000000000000..9a6d275c8119
@@ -0,0 +1,12 @@
+config DRM_IMX_NWL_DSI
+	tristate "Support for Northwest Logic MIPI DSI Host controller"
+	depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
+	depends on COMMON_CLK
+	depends on MFD_SYSCON
+	depends on OF
+	select DRM_PANEL
+	select GENERIC_PHY
+	help
+	  This enables the Northwest Logic MIPI DSI Host controller as
+	  found on NXP's i.MX8 Processors.
+
drivers/gpu/drm/nwl/Makefile new file +2 -0
new file mode 100644
index 000000000000..9fa63483da5b
@@ -0,0 +1,2 @@
+imx-nwl-objs := nwl-drv.o nwl-dsi.o
+obj-$(CONFIG_DRM_IMX_NWL_DSI) += imx-nwl.o
drivers/gpu/drm/nwl/nwl-drv.c new file +594 -0

594 lines not on this page · raw message

drivers/gpu/drm/nwl/nwl-drv.h new file +68 -0

68 lines not on this page · raw message

drivers/gpu/drm/nwl/nwl-dsi.c new file +752 -0

752 lines not on this page · raw message

drivers/gpu/drm/nwl/nwl-dsi.h new file +105 -0

105 lines not on this page · raw message

Signature · 7 lines
2.20.1


_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw
In reply to Guido Günther

Hi,

Quoted 15 lines · Guido Günther

This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs.

It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform data for other SoCs.

The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by but I'm happy to swap Author: and Co-authored-by: if that looks more appropriate. The most notable changes over the BSP driver are
- Calculate HS mode timing from phy_configure_opts_mipi_dphy
- Perform all clock setup via DT
- Merge nwl-imx and nwl drivers
- Add B0 silion revision quirk

Quoted 4 lines

Posting this is likely a bit premature (hence v0) but I wanted for one show how this hooks into the mixel dphy posted earlier [1] and avoid duplicating work. So if there's other code out there doing the same I'm be happy to merge efforts.

Since this is likely not going anywhere until we have a dcss driver aimed for mainline I'm not going spam the list with further revisions. However the 5.x version is maintained here:

    https://source.puri.sm/guido.gunther/linux-imx8/tree/forward-upstream/next-20190506/imx-nwl/v1-wip

Feedback is still welcome. It'll eventually be forwarded to newer linux-next versions.

Changes over the posted version are:

- Add quirk for IMQ8MQ silicon B0 revision to not mess with the system reset controller on power down since enable won't work afterwards otherwise.
- Disable tx esc clock *after* the phy power down to unbreak disable/enable (unblank/blank)
- Drop devm_free_irq() handled by the device driver core
- Add ports to dt binding docs
- Select GENERIC_PHY_MIPI_DPHY instead of GENERIC_PHY for phy_mipi_dphy_get_default_config
- Include drm_print.h to fix build on next-20190408
- Drop some debugging messages
- Newline terminate all DRM_ printouts

If somebody is working on DCSS support it'd be cool to know since this driver is currently a component of imx-display-subsystem which will only work out if dcss is handled like this as well.
Cheers,
-- Guido

Quoted 22 lines

It has been tested quite bit (in a version backported to 4.18) on Librem 5 devkit using DCSS (which is not mainlined yet) and a MIPI DSI panel[2]. In principle LCDIF can also act as input source. I intend look into next so this can actually be tested without further patches on mainline kernels.

[1]: https://lists.freedesktop.org/archives/dri-devel/2019-March/209680.html
[2]: https://source.puri.sm/guido.gunther/linux-imx8/tree/imx8-4.18-wip-nwl-dsi-rework

Guido Günther (2):
dt-bindings: imx: Add binding for IMX NWL mipi dsi host controller drm/imx: Add NWL MIPI DSI host controller support

 .../bindings/display/imx/imx-nwl-dsi.txt      |  72 ++
 drivers/gpu/drm/Kconfig                       |   2 +
 drivers/gpu/drm/Makefile                      |   1 +
 drivers/gpu/drm/nwl/Kconfig                   |  12 +
 drivers/gpu/drm/nwl/Makefile                  |   2 +
 drivers/gpu/drm/nwl/nwl-drv.c                 | 594 ++++++++++++++
 drivers/gpu/drm/nwl/nwl-drv.h                 |  68 ++
 drivers/gpu/drm/nwl/nwl-dsi.c                 | 752 ++++++++++++++++++
 drivers/gpu/drm/nwl/nwl-dsi.h                 | 105 +++
Quoted 16 lines
 9 files changed, 1608 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/imx/imx-nwl-dsi.txt
 create mode 100644 drivers/gpu/drm/nwl/Kconfig
 create mode 100644 drivers/gpu/drm/nwl/Makefile
 create mode 100644 drivers/gpu/drm/nwl/nwl-drv.c
 create mode 100644 drivers/gpu/drm/nwl/nwl-drv.h
 create mode 100644 drivers/gpu/drm/nwl/nwl-dsi.c
 create mode 100644 drivers/gpu/drm/nwl/nwl-dsi.h
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 1 line · Guido Günther

If somebody is working on DCSS support it'd be cool to know since this

I have some time slots here and will start looking at it, if no one else is already working on it.

Shawn

Quoted 2 lines

driver is currently a component of imx-display-subsystem which will only work out if dcss is handled like this as well.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Hi,

Quoted 5 lines · Shawn Guo
Quoted 1 line · Guido Günther

If somebody is working on DCSS support it'd be cool to know since this

I have some time slots here and will start looking at it, if no one else is already working on it.

Nice. My current forward port of a minimal DCSS needed for DSI is here:

    https://source.puri.sm/guido.gunther/linux-imx8/tree/imx8-5.x-drm

Cheers,
-- Guido
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw
In reply to Guido Günther

Am Mittwoch, den 08.05.2019, 19:18 +0200 schrieb Guido Günther:

Quoted 46 lines

Hi,

Quoted 15 lines · Guido Günther

This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs.

It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform data for other SoCs.

The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by but I'm happy to swap Author: and Co-authored-by: if that looks more appropriate. The most notable changes over the BSP driver are
 - Calculate HS mode timing from phy_configure_opts_mipi_dphy
 - Perform all clock setup via DT
 - Merge nwl-imx and nwl drivers
 - Add B0 silion revision quirk

Quoted 4 lines

Posting this is likely a bit premature (hence v0) but I wanted for one show how this hooks into the mixel dphy posted earlier [1] and avoid duplicating work. So if there's other code out there doing the same I'm be happy to merge efforts.

Since this is likely not going anywhere until we have a dcss driver aimed for mainline I'm not going spam the list with further revisions. However the 5.x version is maintained here:

    https://source.puri.sm/guido.gunther/linux-imx8/tree/forward-upstream/next-20190506/imx-nwl/v1-wip

Feedback is still welcome. It'll eventually be forwarded to newer linux-next versions.

Changes over the posted version are:

- Add quirk for IMQ8MQ silicon B0 revision to not mess with the system reset controller on power down since enable won't work afterwards otherwise.
- Disable tx esc clock *after* the phy power down to unbreak disable/enable (unblank/blank)
- Drop devm_free_irq() handled by the device driver core
- Add ports to dt binding docs
- Select GENERIC_PHY_MIPI_DPHY instead of GENERIC_PHY for phy_mipi_dphy_get_default_config
- Include drm_print.h to fix build on next-20190408
- Drop some debugging messages
- Newline terminate all DRM_ printouts

Quoted 3 lines

If somebody is working on DCSS support it'd be cool to know since this driver is currently a component of imx-display-subsystem which will only work out if dcss is handled like this as well.

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Regards,
Lucas
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw

Hi Lucas,

Quoted 60 lines · Lucas Stach

Am Mittwoch, den 08.05.2019, 19:18 +0200 schrieb Guido Günther:

Quoted 46 lines

Hi,

Quoted 15 lines · Guido Günther

This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 SoCs.

It adds support for the i.MX8MQ but the same IP core can also be found on e.g. i.MX8QXP. I added the necessary hooks to support other imx8 variants but since I only have imx8mq boards to test I omitted the platform data for other SoCs.

The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by but I'm happy to swap Author: and Co-authored-by: if that looks more appropriate. The most notable changes over the BSP driver are
 - Calculate HS mode timing from phy_configure_opts_mipi_dphy
 - Perform all clock setup via DT
 - Merge nwl-imx and nwl drivers
 - Add B0 silion revision quirk

Quoted 4 lines

Posting this is likely a bit premature (hence v0) but I wanted for one show how this hooks into the mixel dphy posted earlier [1] and avoid duplicating work. So if there's other code out there doing the same I'm be happy to merge efforts.

Since this is likely not going anywhere until we have a dcss driver aimed for mainline I'm not going spam the list with further revisions. However the 5.x version is maintained here:

    https://source.puri.sm/guido.gunther/linux-imx8/tree/forward-upstream/next-20190506/imx-nwl/v1-wip

Feedback is still welcome. It'll eventually be forwarded to newer linux-next versions.

Changes over the posted version are:

- Add quirk for IMQ8MQ silicon B0 revision to not mess with the system reset controller on power down since enable won't work afterwards otherwise.
- Disable tx esc clock *after* the phy power down to unbreak disable/enable (unblank/blank)
- Drop devm_free_irq() handled by the device driver core
- Add ports to dt binding docs
- Select GENERIC_PHY_MIPI_DPHY instead of GENERIC_PHY for phy_mipi_dphy_get_default_config
- Include drm_print.h to fix build on next-20190408
- Drop some debugging messages
- Newline terminate all DRM_ printouts

Quoted 3 lines

If somebody is working on DCSS support it'd be cool to know since this driver is currently a component of imx-display-subsystem which will only work out if dcss is handled like this as well.

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

Quoted 6 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

I agree. While moving if forward from NXPs tree this caused more trouble than good so let's keep it separate form imx-drm.
Cheers,
-- Guido
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#8 lore raw
In reply to Lucas Stach

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Which is the one that you want me to read?

Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

Quoted 6 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#9 lore raw

Hi Shawn, Lucas,

Quoted 12 lines · Shawn Guo

Caution: EXT Email

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

Quoted 8 lines

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Which is the one that you want me to read?

We're already working on clearing up the DCSS code and preparing it for upstreaming. It should be done in the following weeks. The reason we've been delaying this is because neither HDMI nor MIPI support was present and, until these are upstream, testing DCSS would be quite impossible.

Quoted 11 lines
Quoted 5 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

I'd be interested to hear about this as well.

Quoted 9 lines
Quoted 7 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

I also agree on this. DCSS core code will probably be moved inside the same directory: drivers/gpu/drm/imx/dcss.

Thanks,
laurentiu

Quoted 6 lines

Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7Cda7e62c6b69f4e0c800408d6e30d4dfc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946043619737103&amp;sdata=bnr9EJG5y4Hqr%2FUT5T3EfvWIQKAvkVCZGhdPwEPJQOw%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw

Hi Laurentiu,

Quoted 22 lines · Laurentiu Palcu

Hi Shawn, Lucas,

Quoted 19 lines · Shawn Guo

Caution: EXT Email

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Quoted 4 lines
Quoted 1 line

Which is the one that you want me to read?

We're already working on clearing up the DCSS code and preparing it for upstreaming. It should be done in the following weeks.

Great! I will stay away from this then :)

Quoted 3 lines

The reason we've
been delaying this is because neither HDMI nor MIPI support was present and, until these are upstream, testing DCSS would be quite impossible.

Well, they have to be done one by one, and I guess DCSS should be the first one. I think it's fine to test DCSS with out-of-tree HDMI or MIPI driver which is not ready for submission yet.

Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#15 lore raw
In reply to Shawn Guo

Hi Shawn,

Am Dienstag, den 28.05.2019, 09:38 +0800 schrieb Shawn Guo:

Quoted 10 lines

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute.  Would you suggest how I should help here?

Quoted 8 lines

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Which is the one that you want me to read?

Mostly the 3rd. We spent some time on getting the DCSS driver to work on upstream kernel and familiarize with the hardware, but we don't have any close to mainline quality code.

Quoted 10 lines
Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm.  It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs.  So can you please elaborate a bit on why it's really a bad idea?

It's a totally different hardware, with very different behavior, so there is basically no potential for any code sharing. The downstream driver is a hell of "oh, things are different here, let's introduce yet another function pointer to make the distinction between the HW". It complicates the imx-drm for no good reason. Our experience with imx-drm is that it is already at a complexity level that makes it hard to reason about things when hunting bugs.

The boiler plate required to write a atomic KMS driver is not that much, so I would rather have a clean split between the two hardware drivers. Frankly they don't share anything except both being a atomic KMS driver and running on a SoC called i.MX.

Quoted 8 lines
Quoted 6 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

Regards,
Lucas
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#16 lore raw
Quoted 46 lines · Lucas Stach

Hi Shawn,

Am Dienstag, den 28.05.2019, 09:38 +0800 schrieb Shawn Guo:

Quoted 10 lines

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

Quoted 8 lines

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Which is the one that you want me to read?

Mostly the 3rd. We spent some time on getting the DCSS driver to work on upstream kernel and familiarize with the hardware, but we don't have any close to mainline quality code.

Quoted 10 lines
Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

It's a totally different hardware, with very different behavior, so there is basically no potential for any code sharing. The downstream driver is a hell of "oh, things are different here, let's introduce yet another function pointer to make the distinction between the HW". It complicates the imx-drm for no good reason. Our experience with imx-drm is that it is already at a complexity level that makes it hard to reason about things when hunting bugs.

Quoted 4 lines

The boiler plate required to write a atomic KMS driver is not that much, so I would rather have a clean split between the two hardware drivers. Frankly they don't share anything except both being a atomic KMS driver and running on a SoC called i.MX.

We've also made lots of improvements in the helpers, I think a clean driver will be quiet a bit smaller than an imx based one. ARM is doing the same with komeda and the malidp driver btw. Another option would be 2 kms drivers in one .ko, which is what nouveau does with pre-nv50 and post-nv50. But that only makes sense if you have also the render side in the same driver because it's all from the same vendor. msm is similar, with msm4 vs msm5.

But for soc display-only I think two separate drivers, if the hw really changed enough, is the best option. You can still stuff them into the same subdir ofc.

Cheers, Daniel

Quoted 15 lines
Quoted 8 lines
Quoted 6 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

Regards,
Lucas
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#11 lore raw
In reply to Laurentiu Palcu

Hi Laurentiu,

Quoted 22 lines · Laurentiu Palcu

Hi Shawn, Lucas,

Quoted 19 lines · Shawn Guo

Caution: EXT Email

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Quoted 6 lines
Quoted 1 line

Which is the one that you want me to read?

We're already working on clearing up the DCSS code and preparing it for upstreaming. It should be done in the following weeks. The reason we've been delaying this is because neither HDMI nor MIPI support was present and, until these are upstream, testing DCSS would be quite impossible.

MIPI support is here:

mixel: https://patchwork.freedesktop.org/series/58817/
nwl: https://patchwork.freedesktop.org/series/57686/

The NWL driver needs to be adjusted depending on whether we hook into imx-display-subsystem or not (and then likely moved to the right subdir). Can we somehow get this moving in sync (even in a non public tree if necessary).
Cheers,
-- Guido

Quoted 35 lines
Quoted 10 lines
Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

I'd be interested to hear about this as well.

Quoted 9 lines
Quoted 7 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

I also agree on this. DCSS core code will probably be moved inside the same directory: drivers/gpu/drm/imx/dcss.

Thanks,
laurentiu

Quoted 6 lines

Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7Cda7e62c6b69f4e0c800408d6e30d4dfc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946043619737103&amp;sdata=bnr9EJG5y4Hqr%2FUT5T3EfvWIQKAvkVCZGhdPwEPJQOw%3D&amp;reserved=0

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#17 lore raw
In reply to Daniel Vetter

Lucas and Daniel,

Quoted 62 lines · Daniel Vetter

Caution: EXT Email

Quoted 46 lines · Lucas Stach

Hi Shawn,

Am Dienstag, den 28.05.2019, 09:38 +0800 schrieb Shawn Guo:

Quoted 10 lines

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

Quoted 8 lines

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Which is the one that you want me to read?

Mostly the 3rd. We spent some time on getting the DCSS driver to work on upstream kernel and familiarize with the hardware, but we don't have any close to mainline quality code.

Quoted 10 lines
Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

It's a totally different hardware, with very different behavior, so there is basically no potential for any code sharing. The downstream driver is a hell of "oh, things are different here, let's introduce yet another function pointer to make the distinction between the HW". It complicates the imx-drm for no good reason. Our experience with imx-drm is that it is already at a complexity level that makes it hard to reason about things when hunting bugs.

Quoted 4 lines

The boiler plate required to write a atomic KMS driver is not that much, so I would rather have a clean split between the two hardware drivers. Frankly they don't share anything except both being a atomic KMS driver and running on a SoC called i.MX.

We've also made lots of improvements in the helpers, I think a clean driver will be quiet a bit smaller than an imx based one. ARM is doing the same with komeda and the malidp driver btw. Another option would be 2 kms drivers in one .ko, which is what nouveau does with pre-nv50 and post-nv50. But that only makes sense if you have also the render side in the same driver because it's all from the same vendor. msm is similar, with msm4 vs msm5.

Quoted 3 lines

But for soc display-only I think two separate drivers, if the hw really changed enough, is the best option. You can still stuff them into the same subdir ofc.

Sounds good to me. I'll rewrite the DCSS driver and make it separate from imx-drm. Though, to be honest, this defeats the whole purpose of imx-drm in the first place... Wasn't this supposed to act like a glue and gather all i.MX related display controllers under the imx-drm umbrella?

But, on the other hand, I agree it would be best, going forward, to have it separate. Easier to maintain and, most likely, simpler.

thanks,
laurentiu

Quoted 21 lines

Cheers, Daniel

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Quoted 8 lines
Quoted 1 line

Agreed on this.

Regards,
Lucas
_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C8dca19419c7e49bd10f608d6e347a6e9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946294240955699&amp;sdata=jaSgJsk2LinqaCbUxe6aIvkM6oasWFgezfTZMEMo5Uo%3D&amp;reserved=0

Quoted 8 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C8dca19419c7e49bd10f608d6e347a6e9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946294240965691&amp;sdata=ObCThdTNsTYvJ75nnLQe4G7HToiIFseQgJoaeljZn6M%3D&amp;reserved=0
_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C8dca19419c7e49bd10f608d6e347a6e9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946294240965691&amp;sdata=n9a86mh1apiyDgv3rSJ7G3fz1k22x%2B%2Bu31uxZAI9N0Q%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#12 lore raw
In reply to Guido Günther

Hi Guido,

Quoted 35 lines · Guido Günther

Caution: EXT Email

Hi Laurentiu,

Quoted 22 lines · Laurentiu Palcu

Hi Shawn, Lucas,

Quoted 19 lines · Shawn Guo

Caution: EXT Email

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Quoted 6 lines
Quoted 1 line

Which is the one that you want me to read?

We're already working on clearing up the DCSS code and preparing it for upstreaming. It should be done in the following weeks. The reason we've been delaying this is because neither HDMI nor MIPI support was present and, until these are upstream, testing DCSS would be quite impossible.

MIPI support is here:

Quoted 7 lines

mixel: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F58817%2F&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839828366&amp;sdata=VZvvhe2WkMVCSOEw5oZDJfy7rsqF7YaEirrkLFC8Icw%3D&amp;reserved=0
nwl: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F57686%2F&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=Q4s6OZq1KElktjSXRd2lKBMdg1yPJsWGm8UrSPqqTiE%3D&amp;reserved=0

The NWL driver needs to be adjusted depending on whether we hook into imx-display-subsystem or not (and then likely moved to the right subdir). Can we somehow get this moving in sync (even in a non public tree if necessary).

I guess we could do that as well. I'll start adjusting the driver and take it out of imx-drm, as suggested by Lucas and Daniel. I'll use your MIPI patches to test with.

thanks,
laurentiu

Quoted 43 lines

Cheers,
-- Guido

Quoted 39 lines
Quoted 10 lines
Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

I'd be interested to hear about this as well.

Quoted 9 lines
Quoted 7 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

I also agree on this. DCSS core code will probably be moved inside the same directory: drivers/gpu/drm/imx/dcss.

Thanks,
laurentiu

Quoted 6 lines

Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=6I8MCXrt3y4nX20SnpfoSwEZkg%2B1zP3AFLGHUNaI%2Fls%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=6I8MCXrt3y4nX20SnpfoSwEZkg%2B1zP3AFLGHUNaI%2Fls%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#18 lore raw
In reply to Laurentiu Palcu

Hi Laurentiu,

Am Dienstag, den 28.05.2019, 10:04 +0000 schrieb Laurentiu Palcu:

Quoted 1 line

Lucas and Daniel,

[...]

Quoted 25 lines
Quoted 21 lines
Quoted 8 lines

It's a totally different hardware, with very different behavior, so there is basically no potential for any code sharing. The downstream driver is a hell of "oh, things are different here, let's introduce yet another function pointer to make the distinction between the HW". It complicates the imx-drm for no good reason. Our experience with imx-drm is that it is already at a complexity level that makes it hard to reason about things when hunting bugs.

Quoted 4 lines

The boiler plate required to write a atomic KMS driver is not that much, so I would rather have a clean split between the two hardware drivers. Frankly they don't share anything except both being a atomic KMS driver and running on a SoC called i.MX.

We've also made lots of improvements in the helpers, I think a clean driver will be quiet a bit smaller than an imx based one. ARM is doing the same with komeda and the malidp driver btw. Another option would be 2 kms drivers in one .ko, which is what nouveau does with pre-nv50 and post-nv50. But that only makes sense if you have also the render side in the same driver because it's all from the same vendor. msm is similar, with msm4 vs msm5.

Quoted 3 lines

But for soc display-only I think two separate drivers, if the hw really changed enough, is the best option. You can still stuff them into the same subdir ofc.

Quoted 5 lines

Sounds good to me. I'll rewrite the DCSS driver and make it separate from imx-drm. Though, to be honest, this defeats the whole purpose of imx-drm in the first place... Wasn't this supposed to act like a glue and gather all i.MX related display controllers under the imx-drm umbrella?

Not really. We never had a plan to support all kinds of i.MX display hardware in a single driver.

At some point imx-drm acted as the glue to bring all the components of the i.MX display pipeline together, but much of that functionality has since been split out and is now available as infrastructure in the kernel, like the DRM bridges, devicetree graph bindings and device links. All those infrastructure parts make it easy to write a separate DRM driver, without duplicating lots of code from imx-drm.

It made sense to extend imx-drm as long as the hardware was close and/or an extension to already existing hardware. But DCSS is totally different from the currently supported IPU design.

Quoted 2 lines

But, on the other hand, I agree it would be best, going forward, to have it separate. Easier to maintain and, most likely, simpler.

Seems we agree on the direction this should take. :)

Regards,
Lucas
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#13 lore raw
In reply to Laurentiu Palcu

Hi,

Quoted 41 lines · Laurentiu Palcu

Hi Guido,

Quoted 38 lines · Guido Günther

Caution: EXT Email

Hi Laurentiu,

Quoted 22 lines · Laurentiu Palcu

Hi Shawn, Lucas,

Quoted 19 lines · Shawn Guo

Caution: EXT Email

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Quoted 6 lines
Quoted 1 line

Which is the one that you want me to read?

We're already working on clearing up the DCSS code and preparing it for upstreaming. It should be done in the following weeks. The reason we've been delaying this is because neither HDMI nor MIPI support was present and, until these are upstream, testing DCSS would be quite impossible.

MIPI support is here:

mixel: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F58817%2F&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839828366&amp;sdata=VZvvhe2WkMVCSOEw5oZDJfy7rsqF7YaEirrkLFC8Icw%3D&amp;reserved=0
nwl: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F57686%2F&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=Q4s6OZq1KElktjSXRd2lKBMdg1yPJsWGm8UrSPqqTiE%3D&amp;reserved=0

Quoted 8 lines
Quoted 4 lines

The NWL driver needs to be adjusted depending on whether we hook into imx-display-subsystem or not (and then likely moved to the right subdir). Can we somehow get this moving in sync (even in a non public tree if necessary).

I guess we could do that as well. I'll start adjusting the driver and take it out of imx-drm, as suggested by Lucas and Daniel. I'll use your MIPI patches to test with.

Cool. this will likely mean turning the NWL part into a bridge which I can look into. We want that when interfacing with mxsfb anyway. Cheers,
-- Guido
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#14 lore raw
In reply to Laurentiu Palcu

Hi Laurentiu,

Quoted 41 lines · Laurentiu Palcu

Hi Guido,

Quoted 38 lines · Guido Günther

Caution: EXT Email

Hi Laurentiu,

Quoted 22 lines · Laurentiu Palcu

Hi Shawn, Lucas,

Quoted 19 lines · Shawn Guo

Caution: EXT Email

Hi Lucas,

Quoted 3 lines · Lucas Stach

We have been looking at how to support DCSS in mainline for a while, but most of the actual work got pushed behind in schedule due to other priorities.

I have some time to contribute. Would you suggest how I should help here?

1. You guys already have something close to completion and do not need more hands.
2. You guys already have some preliminary code and can use help from others.
3. You guys haven't got anything to start with, but just some design principles that anyone who wants to work on it should consider.

Quoted 6 lines
Quoted 1 line

Which is the one that you want me to read?

We're already working on clearing up the DCSS code and preparing it for upstreaming. It should be done in the following weeks. The reason we've been delaying this is because neither HDMI nor MIPI support was present and, until these are upstream, testing DCSS would be quite impossible.

MIPI support is here:

mixel: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F58817%2F&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839828366&amp;sdata=VZvvhe2WkMVCSOEw5oZDJfy7rsqF7YaEirrkLFC8Icw%3D&amp;reserved=0
nwl: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F57686%2F&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=Q4s6OZq1KElktjSXRd2lKBMdg1yPJsWGm8UrSPqqTiE%3D&amp;reserved=0

Quoted 8 lines
Quoted 4 lines

The NWL driver needs to be adjusted depending on whether we hook into imx-display-subsystem or not (and then likely moved to the right subdir). Can we somehow get this moving in sync (even in a non public tree if necessary).

I guess we could do that as well. I'll start adjusting the driver and take it out of imx-drm, as suggested by Lucas and Daniel. I'll use your MIPI patches to test with.

Is there anything I could test against v1 of the imx-nwl driver to make sure that works as well:

    https://patchwork.freedesktop.org/series/64185/

Is your focus more towards DSI or HDMI / DP for inital submission?

Cheers,
-- Guido

Quoted 47 lines

thanks,
laurentiu

Quoted 43 lines

Cheers,
-- Guido

Quoted 39 lines
Quoted 10 lines
Quoted 4 lines

One thing I can can say for certain is that DCSS should not be integrated into imx-drm. It's a totally different hardware and downstream clearly shows that it's not a good idea to cram it into imx- drm.

I haven't gone deeper into the vendor code, but from a brief looking I didn't see so many problems with integrating DCSS into imx-drm. It's not so unreasonable to take imx-drm as an imx-display-subsystem which can have multiple CRTCs. So can you please elaborate a bit on why it's really a bad idea?

I'd be interested to hear about this as well.

Quoted 9 lines
Quoted 7 lines

Also the artificial split between hardware control in drivers/gpu/imx/dcss and the DRM driver is just cargo-cult from the IPU/imx-drm split. For the IPU we did it as the IPU has legs in both DRM for the output parts and V4L2 for the input parts. As the DCSS has no video input capabilities the driver could be simplified a lot by moving it all into a single DRM driver.

Agreed on this.

I also agree on this. DCSS core code will probably be moved inside the same directory: drivers/gpu/drm/imx/dcss.

Thanks,
laurentiu

Quoted 6 lines

Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=6I8MCXrt3y4nX20SnpfoSwEZkg%2B1zP3AFLGHUNaI%2Fls%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Claurentiu.palcu%40nxp.com%7C9924c4628d5f4f98d8a808d6e34f7b26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636946327839838359&amp;sdata=6I8MCXrt3y4nX20SnpfoSwEZkg%2B1zP3AFLGHUNaI%2Fls%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel