Skip to contentSkip to conversation

Staging: vt6655: Remove unused function prototype and definition

PATCH In review Madhumitha Prabakaran 2 participants 4 messages Mar 7, 2019 Staging

lore
Share & tools
lore
#0 lore raw

cover Staging: vt6655: Remove unused function prototype and definition

This patchset remove an unused function prototype and function definition in vt6655 driver.

Madhumitha Prabakaran (2):
Staging: vt6655: Remove an unused function prototype
Staging: vt6655: Remove function definition

 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 Staging: vt6655: Remove an unused function prototype

Remove an unused function prototype, as the function definition is never used in kernel tree.

---
 drivers/staging/vt6655/mac.h | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/vt6655/mac.h +0 -2
index 59538ac09fc5..c7888c4e96f2 100644
@@ -876,8 +876,6 @@ do {								\
 #define MACvSetRFLE_LatchBase(iobase)                                 \
 	MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
 
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 		      unsigned char byTestBits);
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 Staging: vt6655: Remove function definition

In reply to Madhumitha Prabakaran

Remove function definition as it is never called in kernel tree.

---
 drivers/staging/vt6655/mac.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/vt6655/mac.c +0 -7
index 40a8f1ce837c..2f773fdf8d64 100644
@@ -57,13 +57,6 @@
  * Return Value: true if all test bits On; otherwise false
  *
  */
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits)
-{
-	void __iomem *io_base = priv->PortOffset;
-
-	return (ioread8(io_base + byRegOfs) & byTestBits) == byTestBits;
-}
 
 /*
  * Description:
Signature · 1 line
2.17.1
#3 lore raw
In reply to Madhumitha Prabakaran
Quoted 6 lines · Madhumitha Prabakaran

This patchset remove an unused function prototype and function definition in vt6655 driver.

Madhumitha Prabakaran (2):
Staging: vt6655: Remove an unused function prototype
Staging: vt6655: Remove function definition

Actually, the prototype and the function definition go together. It would be better to remove them both in one patch.

julia

Quoted 15 lines
 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1551990063.git.madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.