Skip to contentSkip to conversation

Update TXT maintainter

PATCH In review Hawrylko, Lukasz 5 participants 14 messages Mar 12, 2019 – May 7, 2019

lore
Share & tools
lore
#0 lore raw

cover Update TXT maintainter

Due to personal changes at Intel, I am new TXT maintainer for XEN. Adding patch that updates maintainers list.

Lukasz Hawrylko (1):
Update TXT maintainter

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 17 lines
2.20.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

PATCH 1/1 Update TXT maintainter

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index a0cda4f7a1..4c47294706 100644
@@ -237,7 +237,7 @@ F:	xen/arch/x86/debug.c
 F:	tools/debugger/gdbsx/
 
 INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
-M:	Gang Wei <[email protected]>
+M:	Lukasz Hawrylko <[email protected]>
 M:	Shane Wang <[email protected]>
 S:	Supported
 F:	xen/arch/x86/tboot.c
Signature · 17 lines
2.20.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw

Thanks. The format looks correct now.

Shane, can you ack this patch?

Quoted 32 lines · Lukasz
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index a0cda4f7a1..4c47294706 100644
@@ -237,7 +237,7 @@ F:	xen/arch/x86/debug.c
 F:	tools/debugger/gdbsx/
 
 INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
-M:	Gang Wei <[email protected]>
+M:	Lukasz Hawrylko <[email protected]>
 M:	Shane Wang <[email protected]>
 S:	Supported
 F:	xen/arch/x86/tboot.c
Signature · 12 lines
2.20.1


--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.

The only thing that's remaining is this footer. It doesn't make sense to append this to an email to a public mailing list. Also it makes this patch hard to apply. Please avoid appending this footer in the future.

For avoidance of doubt, no need to resend this patch.

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw

Hi Wei,

Quoted 3 lines · Wei Liu

Thanks. The format looks correct now.

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#4 lore raw
Quoted 8 lines · Julien Grall

Hi Wei,

Quoted 3 lines · Wei Liu

Thanks. The format looks correct now.

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

So in this case, Shane's ack should be sufficient. Or we can rely on backchannel to verify the change.

Wei.

Quoted 5 lines

Cheers,

Signature · 1 line
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw

Hi Wei,

Quoted 8 lines · Wei Liu
Quoted 7 lines · Julien Grall

Hi Wei,

Quoted 3 lines · Wei Liu

Thanks. The format looks correct now.

Shane, can you ack this patch?

Quoted 8 lines
Quoted 1 line

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

So in this case, Shane's ack should be sufficient. Or we can rely on backchannel to verify the change.

I had a confirmation from Gang Wei (via his personal e-mail provided by Shane). But I wasn't sure whether we also need an official confirmation from him.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#6 lore raw
Quoted 17 lines · Julien Grall

Hi Wei,

Quoted 14 lines · Wei Liu
Quoted 8 lines · Julien Grall

Hi Wei,

Quoted 3 lines · Wei Liu

Thanks. The format looks correct now.

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

Quoted 6 lines
Quoted 2 lines

So in this case, Shane's ack should be sufficient. Or we can rely on backchannel to verify the change.

I had a confirmation from Gang Wei (via his personal e-mail provided by Shane). But I wasn't sure whether we also need an official confirmation from him.

Oh great. If you had verified the Gang you talked to was the one listed here, you can ask if he's okay with replying explicitly.

Wei.

Quoted 10 lines

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#7 lore raw
In reply to Wei Liu
Quoted 7 lines · Wei Liu
Quoted 5 lines · Julien Grall

Hi Wei,

Quoted 2 lines · Wei Liu

Thanks. The format looks correct now.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

Perhaps for this reason it would be nice if each maintainer recorded a pgp key in either the maintainers file or some other file so they can prove their identity if needed. Should also have a policy that ensures that key is not shared with the parent organization or we may have "maintainers" who just happen to live forever ;)

Tamas

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#8 lore raw
Quoted 16 lines · Tamas K Lengyel
Quoted 7 lines · Wei Liu
Quoted 5 lines · Julien Grall

Hi Wei,

Quoted 2 lines · Wei Liu

Thanks. The format looks correct now.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

Quoted 5 lines

Perhaps for this reason it would be nice if each maintainer recorded a pgp key in either the maintainers file or some other file so they can prove their identity if needed. Should also have a policy that ensures that key is not shared with the parent organization or we may have "maintainers" who just happen to live forever ;)

Perhaps. :-)

There are a few drawbacks:

1. PGP is difficult to use.
2. Key management is tedious and tiresome.
3. A key still needs to be associated with an email address (ID).
4. The policy requirement is difficult to enforce and check.

I think #3 is a deal breaker. Not everyone likes to mingle personal and professional life, so the key may be associate with their work email address. A philosophical question is if you don't own that email address anymore, can you still claim you own that key?

Ultimately we want to solve a trust issue. Although I like the concept of PGP and have been a user for a long time, we probably don't want to use PGP just for the sake of using it, when there are other easier way to get things done. :-)

Wei.

Quoted 7 lines

Tamas

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#9 lore raw
Quoted 33 lines · Wei Liu
Quoted 16 lines · Tamas K Lengyel
Quoted 7 lines · Wei Liu
Quoted 5 lines · Julien Grall

Hi Wei,

Quoted 2 lines · Wei Liu

Thanks. The format looks correct now.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

Quoted 5 lines

Perhaps for this reason it would be nice if each maintainer recorded a pgp key in either the maintainers file or some other file so they can prove their identity if needed. Should also have a policy that ensures that key is not shared with the parent organization or we may have "maintainers" who just happen to live forever ;)

Perhaps. :-)

There are a few drawbacks:

1. PGP is difficult to use.
2. Key management is tedious and tiresome.
3. A key still needs to be associated with an email address (ID).
4. The policy requirement is difficult to enforce and check.

Quoted 4 lines

I think #3 is a deal breaker. Not everyone likes to mingle personal and professional life, so the key may be associate with their work email address. A philosophical question is if you don't own that email address anymore, can you still claim you own that key?

Yes, owning the key is proved by the fact that you have the private portion and can sign a message saying "I no longer have that other email that I used before". What address that signed message comes from doesn't matter.

Quoted 5 lines

Ultimately we want to solve a trust issue. Although I like the concept of PGP and have been a user for a long time, we probably don't want to use PGP just for the sake of using it, when there are other easier way to get things done. :-)

If there are better alternatives then sure, pgp is a bit of a pita I agree. But there is certainly a trust aspect here that we don't really have a good way of handling other then crossing fingers that people are actually who they claim to be. For off-shoot patches being contributed this doesn't matter too much but for the maintainers it's a bit different. There certainly are maintainers who I never met and can't even find any public information about them online (conference talks or anything). So even if at a summit someone would appear and claim, for example, to be Gang Wei, how would I know? :) If not pgp then maybe at least a photo of each maintainer would go a long way to make sure noone got replaced by the borg ;)

Tamas

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#10 lore raw
In reply to Tamas K Lengyel
Quoted 16 lines · Tamas K Lengyel
Quoted 7 lines · Wei Liu
Quoted 5 lines · Julien Grall

Hi Wei,

Quoted 2 lines · Wei Liu

Thanks. The format looks correct now.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Shane, can you ack this patch?

Do we also need Gang Wei acked-by to confirm he wants to be removed?

In theory yes, but if Gang had left Intel there he couldn't possibly reply from his intel address. And there will be no way to verify if a Gang Wei email from any other address is the Gang Wei we're looking for.

Quoted 5 lines

Perhaps for this reason it would be nice if each maintainer recorded a pgp key in either the maintainers file or some other file so they can prove their identity if needed. Should also have a policy that ensures that key is not shared with the parent organization or we may have "maintainers" who just happen to live forever ;)

We have to do a cost/benefits analysis for this sort of thing. If it turns out that someone is impersonating being someone from Intel, and Gang Wei actually *is* still and Intel and doesn't approve of the change, what bad thing could happen? Eventually Gang Wei will show up and say it was fake; we can revert all the changes proposed by the impostor. They should all be reviewed by other people anyway; and if we email him, hopefully he'd notice before the next release.

All in all, I think assuming that Lukasz is who he says he is, (giving Gang Wei a chance to object, but assuming consent if we don't hear anything), and fixing things up if it turns out to not be the case, is a better approach than pgp keys and what-not. :-)

-George

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#11 lore raw
In reply to Hawrylko, Lukasz

Hi,

Adding Gang Wei so he can ack the patch.

Cheers,

Quoted 19 lines · Lukasz
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index a0cda4f7a1..4c47294706 100644
@@ -237,7 +237,7 @@ F:	xen/arch/x86/debug.c
  F:	tools/debugger/gdbsx/
 
  INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
-M:	Gang Wei <[email protected]>
+M:	Lukasz Hawrylko <[email protected]>
  M:	Shane Wang <[email protected]>
  S:	Supported
  F:	xen/arch/x86/tboot.c
Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#12 lore raw

Hi,

I haven't seen any answer from Gang Wei. I assume this is fine.

I will queue this patch in my branch next-4.13.

Cheers,

Quoted 26 lines · Julien Grall

Hi,

Adding Gang Wei so he can ack the patch.

Cheers,

Quoted 18 lines · Lukasz

---
  MAINTAINERS | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index a0cda4f7a1..4c47294706 100644
@@ -237,7 +237,7 @@ F:    xen/arch/x86/debug.c

  F:    tools/debugger/gdbsx/
  INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)

MAINTAINERS +1 -1
-M:    Gang Wei <[email protected]>
+M:    Lukasz Hawrylko <[email protected]>

  M:    Shane Wang <[email protected]>
  S:    Supported
  F:    xen/arch/x86/tboot.c

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#13 lore raw
Quoted 5 lines · Julien Grall

Hi,

I haven't seen any answer from Gang Wei. I assume this is fine.

I will queue this patch in my branch next-4.13.

Looking again the thread, we still need an ack from Shane Wang before this can go in.

Sorry for the confusion.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel