Skip to contentSkip to conversation

mt7603: core: do not use magic numbers in mt7603_reg_map

PATCH Applied Lorenzo Bianconi 2 participants 2 messages Mar 16, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Lorenzo Bianconi

author maintainer
#1 lore raw

PATCH 1/1 mt7603: core: do not use magic numbers in mt7603_reg_map

Use register definitions instead of magic numbers in mt7603_reg_map

---
 drivers/net/wireless/mediatek/mt76/mt7603/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7603/core.c +2 -2
index e32a16f2ebe8..4668c573f74a 100644
@@ -53,8 +53,8 @@ irqreturn_t mt7603_irq_handler(int irq, void *dev_instance)
 
 u32 mt7603_reg_map(struct mt7603_dev *dev, u32 addr)
 {
-	u32 base = addr & GENMASK(31, 19);
-	u32 offset = addr & GENMASK(18, 0);
+	u32 base = addr & MT_MCU_PCIE_REMAP_2_BASE;
+	u32 offset = addr & MT_MCU_PCIE_REMAP_2_OFFSET;
 
 	dev->bus_ops->wr(&dev->mt76, MT_MCU_PCIE_REMAP_2, base);
 
Signature · 1 line
2.20.1