Skip to contentSkip to conversation

mt76: mt7615: stop mcu first in mt7615_unregister_device

PATCH Applied Lorenzo Bianconi 2 participants 2 messages May 14, 2019 – Jun 7, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Lorenzo Bianconi

author maintainer
#1 lore raw

PATCH 1/1 mt76: mt7615: stop mcu first in mt7615_unregister_device

In reply to a message not in the archive

Stop mcu engine and then dma one in mt7615_unregister_device in order to avoid a mcu hang in mt7615_unregister_device

---
This patch ca be squashed with 'mt76: mt7615: rearrange cleanup operations in mt7615_unregister_device' since it is not upstream yet

---
 drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt7615/init.c +1 -1
index 59f604f3161f..369b9a8e07be 100644
@@ -213,8 +213,8 @@ void mt7615_unregister_device(struct mt7615_dev *dev)
 	int id;
 
 	mt76_unregister_device(&dev->mt76);
-	mt7615_dma_cleanup(dev);
 	mt7615_mcu_exit(dev);
+	mt7615_dma_cleanup(dev);
 
 	spin_lock_bh(&dev->token_lock);
 	idr_for_each_entry(&dev->token, txwi, id) {
Signature · 1 line
2.20.1
maintainer Applied
#2 lore raw
Quoted 7 lines · Lorenzo Bianconi

Stop mcu engine and then dma one in mt7615_unregister_device in order to avoid a mcu hang in mt7615_unregister_device

---
This patch ca be squashed with 'mt76: mt7615: rearrange cleanup operations in mt7615_unregister_device' since it is not upstream yet

Applied, thanks.

- Felix