Skip to contentSkip to conversation

vfio-ccw: Destroy kmem cache region on module exit

PATCH Applied Farhan Ali 2 participants 3 messages Jun 3, 2019 – Jun 4, 2019 1 message not in the archive

Subsystems (4)
KVM s390 s390 common I/O layer s390 VFIO-CCW driver
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Farhan Ali

author
#1 lore raw

PATCH 1/1 vfio-ccw: Destroy kmem cache region on module exit

Free the vfio_ccw_cmd_region on module exit.

Signed-off-by Farhan Ali <[email protected]>

---

I guess I missed this earlier while reviewing, but should'nt we destroy the vfio_ccw_cmd_region on module exit, as well?

 drivers/s390/cio/vfio_ccw_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/s390/cio/vfio_ccw_drv.c +1 -0
index 66a66ac..9cee9f2 100644
@@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
 	css_driver_unregister(&vfio_ccw_sch_driver);
 	isc_unregister(VFIO_CCW_ISC);
 	kmem_cache_destroy(vfio_ccw_io_region);
+	kmem_cache_destroy(vfio_ccw_cmd_region);
 	destroy_workqueue(vfio_ccw_work_q);
 }
 module_init(vfio_ccw_sch_init);
Signature · 1 line
2.7.4
#2 lore raw
Quoted 16 lines · On Mon, 3 Jun 2019 11:42:47 -0400 Farhan Ali <[email protected]> wrote:

Free the vfio_ccw_cmd_region on module exit.

Signed-off-by Farhan Ali <[email protected]>

---

I guess I missed this earlier while reviewing, but should'nt we destroy the vfio_ccw_cmd_region on module exit, as well?

 drivers/s390/cio/vfio_ccw_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/s390/cio/vfio_ccw_drv.c +0 -0
index 66a66ac..9cee9f2 100644

drivers/s390/cio/vfio_ccw_drv.c static void __exit vfio_ccw_sch_exit(void) · line 305

Quoted 7 lines
drivers/s390/cio/vfio_ccw_drv.c +1 -0
@@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
 	css_driver_unregister(&vfio_ccw_sch_driver);
 	isc_unregister(VFIO_CCW_ISC);
 	kmem_cache_destroy(vfio_ccw_io_region);
+	kmem_cache_destroy(vfio_ccw_cmd_region);
 	destroy_workqueue(vfio_ccw_work_q);
 }
 module_init(vfio_ccw_sch_init);

Yes, you're right. Will queue when the pull req has been processed.

Applied
#3 lore raw
In reply to Farhan Ali
Quoted 1 line · On Mon, 3 Jun 2019 11:42:47 -0400 Farhan Ali <[email protected]> wrote:

Free the vfio_ccw_cmd_region on module exit.

Fixes d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
Quoted 15 lines
Signed-off-by Farhan Ali <[email protected]>

---

I guess I missed this earlier while reviewing, but should'nt we destroy the vfio_ccw_cmd_region on module exit, as well?

 drivers/s390/cio/vfio_ccw_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/s390/cio/vfio_ccw_drv.c +0 -0
index 66a66ac..9cee9f2 100644

drivers/s390/cio/vfio_ccw_drv.c static void __exit vfio_ccw_sch_exit(void) · line 305

Quoted 7 lines
drivers/s390/cio/vfio_ccw_drv.c +1 -0
@@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
 	css_driver_unregister(&vfio_ccw_sch_driver);
 	isc_unregister(VFIO_CCW_ISC);
 	kmem_cache_destroy(vfio_ccw_io_region);
+	kmem_cache_destroy(vfio_ccw_cmd_region);
 	destroy_workqueue(vfio_ccw_work_q);
 }
 module_init(vfio_ccw_sch_init);

Thanks, applied.