Skip to contentSkip to conversation

Move SCons to Python 3

PATCH In review Tim Orling 8 participants 23 messages Jun 7, 2019 – Jun 24, 2019

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

cover Move SCons to Python 3

python-scons and python-scons-native are perhaps the last python2 only recipes in oe-core. With Python 2 going EOL in or before 2020, it's time to switch everything to Python 3.

I updated scons.bbclass to use python3-scons-native. Tested build with serf.

I also added a simple oeqa/runtime test while I was at it.

I did not drop python-scons and python-scons-native, although we should at some point soon.

[YOCTO #13381]

The following changes since commit 666f6192aaa9e847ad0d920a487b82d984b58d26:

gnutls: Use the sysconfdir variable for the ca-certificates path (2019-06-07 09:10:34 +0100)

are available in the Git repository at:

git://git.openembedded.org/openembedded-core-contrib timo/python3-scons
http://cgit.openembedded.org//log/?h=timo/python3-scons

Tim Orling (4):
python3-scons-{native}: add recipe for v3.0.5
scons.bbclass: use python3-scons
serf: switch to python3-scons-native
oeqa/runtime: add simple test for scons

 meta/classes/scons.bbclass                    |  2 +-
 meta/conf/distro/include/maintainers.inc      |  2 +
 meta/lib/oeqa/runtime/cases/scons.py          | 37 +++++++++++++++++++
 meta/lib/oeqa/runtime/files/SConstruct        |  1 +
 meta/lib/oeqa/runtime/files/hello.c           |  5 +++
 .../python/python3-scons-native_3.0.5.bb      |  8 ++++
 .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++
 meta/recipes-support/serf/serf_1.3.9.bb       |  2 +-
 8 files changed, 84 insertions(+), 2 deletions(-)
 create mode 100644 meta/lib/oeqa/runtime/cases/scons.py
 create mode 100644 meta/lib/oeqa/runtime/files/SConstruct
 create mode 100644 meta/lib/oeqa/runtime/files/hello.c
 create mode 100644 meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
 create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH 1/4 python3-scons-{native}: add recipe for v3.0.5

SCons has supported python 3 since v3.0.0
https://scons.org/tag/releases.html

Fix shebangs in scripts

[YOCTO #13381]

---
 meta/conf/distro/include/maintainers.inc      |  2 ++
 .../python/python3-scons-native_3.0.5.bb      |  8 +++++
 .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
 create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb
meta/conf/distro/include/maintainers.inc +2 -0
index d6f66510e3..6ddf9f5fc7 100644
@@ -604,6 +604,8 @@ RECIPE_MAINTAINER_pn-python3-pip = "Derek Straka <[email protected]>"
 RECIPE_MAINTAINER_pn-python3-pycairo = "Derek Straka <[email protected]>"
 RECIPE_MAINTAINER_pn-python3-pygments = "Derek Straka <[email protected]>"
 RECIPE_MAINTAINER_pn-python3-pygobject = "Derek Straka <[email protected]>"
+RECIPE_MAINTAINER_pn-python3-scons = "Tim Orling <[email protected]>"
+RECIPE_MAINTAINER_pn-python3-scons-native = "Tim Orling <[email protected]>"
 RECIPE_MAINTAINER_pn-python3-setuptools = "Derek Straka <[email protected]>"
 RECIPE_MAINTAINER_pn-python3-six = "Derek Straka <[email protected]>"
 RECIPE_MAINTAINER_pn-python3-smmap = "Derek Straka <[email protected]>"
meta/recipes-devtools/python/python3-scons-native_3.0.5.bb new file +8 -0
new file mode 100644
index 0000000000..5cd5956625
@@ -0,0 +1,8 @@
+require python3-scons_${PV}.bb
+inherit native python3native
+DEPENDS = "python3-native"
+RDEPENDS_${PN} = ""
+
+do_install_append() {
+    create_wrapper ${D}${bindir}/scons SCONS_LIB_DIR='${STAGING_DIR_HOST}/${PYTHON_SITEPACKAGES_DIR}' PYTHONNOUSERSITE='1'
+}
meta/recipes-devtools/python/python3-scons_3.0.5.bb new file +29 -0
new file mode 100644
index 0000000000..91e4a945e3
@@ -0,0 +1,29 @@
+SUMMARY = "Software Construction tool (make/autotools replacement)"
+SECTION = "devel/python"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=37bb53a08e6beaea0c90e7821d731284"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz"
+SRC_URI[md5sum] = "9f9c163e8bd48cf8cd92f03e85ca6395"
+SRC_URI[sha256sum] = "df676f23dc6d4bfa384fc389d95dcd21ab907e6349d4c848958ba4befb73c73e"
+
+S = "${WORKDIR}/scons-${PV}"
+
+UPSTREAM_CHECK_URI = "http://scons.org/pages/download.html"
+UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.tar"
+
+inherit setuptools3
+
+do_install_prepend() {
+    sed -i -e "s:/usr/bin/env python:/usr/bin/env python3:g" ${S}/script/*
+}
+
+RDEPENDS_${PN} = "\
+  python3-core \
+  python3-fcntl \
+  python3-io \
+  python3-json \
+  python3-shell \
+  python3-pickle \
+  python3-pprint \
+  "
Signature · 1 line
2.20.1
author
#3 lore raw

PATCH 2/4 scons.bbclass: use python3-scons

In reply to Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/scons.bbclass +1 -1
index 9ee7d1587d..a8ddae35f7 100644
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 
 EXTRA_OESCONS ?= ""
 
Signature · 1 line
2.20.1
author
#15 lore raw

PATCH 3/4 serf: switch to python3-scons-native

In reply to Tim Orling

SCons has supported python3 since v3.0.0, use it.

---
 meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/serf/serf_1.3.9.bb +1 -1
index 65a8114bb4..706c86be47 100644
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] = "549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
 
-DEPENDS = "python-scons-native openssl apr apr-util util-linux expat"
+DEPENDS = "python3-scons-native openssl apr apr-util util-linux expat"
 
 do_compile() {
 	${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} PREFIX=${prefix} \
Signature · 1 line
2.20.1
author
#19 lore raw

PATCH 4/4 oeqa/runtime: add simple test for scons

In reply to Tim Orling

This test simply compiles a hello world program using scons.

---
 meta/lib/oeqa/runtime/cases/scons.py   | 37 ++++++++++++++++++++++++++
 meta/lib/oeqa/runtime/files/SConstruct |  1 +
 meta/lib/oeqa/runtime/files/hello.c    |  5 ++++
 3 files changed, 43 insertions(+)
 create mode 100644 meta/lib/oeqa/runtime/cases/scons.py
 create mode 100644 meta/lib/oeqa/runtime/files/SConstruct
 create mode 100644 meta/lib/oeqa/runtime/files/hello.c
meta/lib/oeqa/runtime/cases/scons.py new file +37 -0
new file mode 100644
index 0000000000..3c7c7f7270
@@ -0,0 +1,37 @@
+#
+# SPDX-License-Identifier: MIT
+#
+
+import os
+
+from oeqa.runtime.case import OERuntimeTestCase
+from oeqa.core.decorator.depends import OETestDepends
+from oeqa.runtime.decorator.package import OEHasPackage
+
+class SconsCompileTest(OERuntimeTestCase):
+
+    @classmethod
+    def setUp(cls):
+        dst = '/tmp/'
+        src = os.path.join(cls.tc.runtime_files_dir, 'hello.c')
+        cls.tc.target.copyTo(src, dst)
+
+        src = os.path.join(cls.tc.runtime_files_dir, 'SConstruct')
+        cls.tc.target.copyTo(src, dst)
+
+    @classmethod
+    def tearDown(cls):
+        files = '/tmp/hello.c /tmp/hello.o /tmp/hello /tmp/SConstruct'
+        cls.tc.target.run('rm %s' % files)
+
+    @OETestDepends(['ssh.SSHTest.test_ssh'])
+    @OEHasPackage(['gcc'])
+    @OEHasPackage(['python3-scons'])
+    def test_scons_compile(self):
+        status, output = self.target.run('cd /tmp/ && scons')
+        msg = 'scons compile failed, output: %s' % output
+        self.assertEqual(status, 0, msg=msg)
+
+        status, output = self.target.run('/tmp/hello')
+        msg = 'running compiled file failed, output: %s' % output
+        self.assertEqual(status, 0, msg=msg)
meta/lib/oeqa/runtime/files/SConstruct new file +1 -0
new file mode 100644
index 0000000000..d2cb6dd122
@@ -0,0 +1 @@
+Program('hello.c')
meta/lib/oeqa/runtime/files/hello.c new file +5 -0
new file mode 100644
index 0000000000..b0697a3304
@@ -0,0 +1,5 @@
+int
+      main()
+      {
+          printf("Hello, world!\n");
+      }
Signature · 1 line
2.20.1
#2 lore raw

Re: [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5

In reply to Tim Orling
Quoted 26 lines · Tim Orling

SCons has supported python 3 since v3.0.0
https://scons.org/tag/releases.html

Fix shebangs in scripts

[YOCTO #13381]

---
 meta/conf/distro/include/maintainers.inc      |  2 ++
 .../python/python3-scons-native_3.0.5.bb      |  8 +++++
 .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-devtools/python/
python3-scons-native_3.0.5.bb
 create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb
meta/conf/distro/include/maintainers.inc +0 -0
index d6f66510e3..6ddf9f5fc7 100644
@@ -604,6 +604,8 @@ RECIPE_MAINTAINER_pn-python3-pip = "Derek Straka <

[email protected]>"
RECIPE_MAINTAINER_pn-python3-pycairo = "Derek Straka <[email protected]>" RECIPE_MAINTAINER_pn-python3-pygments = "Derek Straka <[email protected]

Quoted 7 lines
Quoted 1 line

"

RECIPE_MAINTAINER_pn-python3-pygobject = "Derek Straka <[email protected]

Quoted 1 line

"

+RECIPE_MAINTAINER_pn-python3-scons = "Tim Orling < [email protected]>" +RECIPE_MAINTAINER_pn-python3-scons-native = "Tim Orling <[email protected]>"

Grr. Typo.

Quoted 68 lines

RECIPE_MAINTAINER_pn-python3-setuptools = "Derek Straka <
[email protected]>"
RECIPE_MAINTAINER_pn-python3-six = "Derek Straka <[email protected]>" RECIPE_MAINTAINER_pn-python3-smmap = "Derek Straka <[email protected]>"

meta/recipes-devtools/python/python3-scons-native_3.0.5.bb new file +7 -0
new file mode 100644
index 0000000000..5cd5956625
@@ -0,0 +1,8 @@
+require python3-scons_${PV}.bb
+inherit native python3native
+DEPENDS = "python3-native"
+RDEPENDS_${PN} = ""
+
+do_install_append() {
+    create_wrapper ${D}${bindir}/scons

SCONS_LIB_DIR='${STAGING_DIR_HOST}/${PYTHON_SITEPACKAGES_DIR}' PYTHONNOUSERSITE='1'

meta/recipes-devtools/python/python3-scons-native_3.0.5.bb new file +1 -0
+}
meta/recipes-devtools/python/python3-scons_3.0.5.bb new file +4 -0
new file mode 100644
index 0000000000..91e4a945e3
@@ -0,0 +1,29 @@
+SUMMARY = "Software Construction tool (make/autotools replacement)"
+SECTION = "devel/python"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM =

"file://LICENSE.txt;md5=37bb53a08e6beaea0c90e7821d731284"

meta/recipes-devtools/python/python3-scons_3.0.5.bb new file +4 -0
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz"
+SRC_URI[md5sum] = "9f9c163e8bd48cf8cd92f03e85ca6395"
+SRC_URI[sha256sum] =

"df676f23dc6d4bfa384fc389d95dcd21ab907e6349d4c848958ba4befb73c73e"

meta/recipes-devtools/python/python3-scons_3.0.5.bb new file +21 -1
+
+S = "${WORKDIR}/scons-${PV}"
+
+UPSTREAM_CHECK_URI = "http://scons.org/pages/download.html"
+UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.tar"
+
+inherit setuptools3
+
+do_install_prepend() {
+    sed -i -e "s:/usr/bin/env python:/usr/bin/env python3:g" ${S}/script/*
+}
+
+RDEPENDS_${PN} = "\
+  python3-core \
+  python3-fcntl \
+  python3-io \
+  python3-json \
+  python3-shell \
+  python3-pickle \
+  python3-pprint \
+  "
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#20 lore raw

✗ patchtest: failure for Move SCons to Python 3

In reply to Tim Orling

== Series Details ==

Series: Move SCons to Python 3
Revision: 1
URL : https://patchwork.openembedded.org/series/18049/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Errors in your Python code were encountered [test_pylint]
Suggested fix Correct the lines introduced by your patch
Output Please, fix the listed issues:
meta/lib/oeqa/runtime/cases/scons.py does not exist

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#21 lore raw

Re: ✗ patchtest: failure for Move SCons to Python 3

False negative. The file was included in the series.

Quoted 45 lines · Patchwork

== Series Details ==

Series: Move SCons to Python 3
Revision: 1
URL : https://patchwork.openembedded.org/series/18049/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Errors in your Python code were encountered
[test_pylint]
Suggested fix Correct the lines introduced by your patch
Output Please, fix the listed issues:
meta/lib/oeqa/runtime/cases/scons.py does not exist

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---
Guidelines:
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#22 lore raw
In reply to Tim Orling

Hurrah, last time I looked at this the Py3 support wasn't quite ready yet.

Ross

Quoted 52 lines · Tim Orling

python-scons and python-scons-native are perhaps the last python2 only recipes in oe-core. With Python 2 going EOL in or before 2020, it's time to switch everything to Python 3.

I updated scons.bbclass to use python3-scons-native. Tested build with serf.

I also added a simple oeqa/runtime test while I was at it.

I did not drop python-scons and python-scons-native, although we should at some point soon.

[YOCTO #13381]

The following changes since commit 666f6192aaa9e847ad0d920a487b82d984b58d26:

gnutls: Use the sysconfdir variable for the ca-certificates path (2019-06-07 09:10:34 +0100)

are available in the Git repository at:

git://git.openembedded.org/openembedded-core-contrib timo/python3-scons
http://cgit.openembedded.org//log/?h=timo/python3-scons

Tim Orling (4):
python3-scons-{native}: add recipe for v3.0.5
scons.bbclass: use python3-scons
serf: switch to python3-scons-native
oeqa/runtime: add simple test for scons

 meta/classes/scons.bbclass                    |  2 +-
 meta/conf/distro/include/maintainers.inc      |  2 +
 meta/lib/oeqa/runtime/cases/scons.py          | 37 +++++++++++++++++++
 meta/lib/oeqa/runtime/files/SConstruct        |  1 +
 meta/lib/oeqa/runtime/files/hello.c           |  5 +++
 .../python/python3-scons-native_3.0.5.bb      |  8 ++++
 .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++
 meta/recipes-support/serf/serf_1.3.9.bb       |  2 +-
 8 files changed, 84 insertions(+), 2 deletions(-)
 create mode 100644 meta/lib/oeqa/runtime/cases/scons.py
 create mode 100644 meta/lib/oeqa/runtime/files/SConstruct
 create mode 100644 meta/lib/oeqa/runtime/files/hello.c
 create mode 100644 meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
 create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb

--
2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#16 lore raw

Re: [PATCH 3/4] serf: switch to python3-scons-native

In reply to Tim Orling

This is causing on CentOS 7:

| DEBUG: Executing shell function do_compile
| scons: *** SCons version 3.0.5 does not run under Python version 3.4.8.
| Python 2.7 or >= 3.5 is required.

Looks like it's using host python which is at 3.4.8 in this case.

Thanks,

Anuj

Quoted 29 lines · Tim Orling

SCons has supported python3 since v3.0.0, use it.

---
 meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes- renamed from meta/recipes-support/serf/serf_1.3.9.bb +0 -0

support/serf/serf_1.3.9.bb
index 65a8114bb4..706c86be47 100644

meta/recipes-support/serf/serf_1.3.9.bb +0 -0
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] =

"549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM =
"file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"

-DEPENDS = "python-scons-native openssl apr apr-util util-linux expat"
+DEPENDS = "python3-scons-native openssl apr apr-util util-linux expat"

do_compile() {
${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE}
PREFIX=${prefix} \

Signature · 1 line
2.20.1
#17 lore raw

Re: [PATCH 3/4] serf: switch to python3-scons-native

Quoted 9 lines · Anuj

This is causing on CentOS 7:

| DEBUG: Executing shell function do_compile
| scons: *** SCons version 3.0.5 does not run under Python version 3.4.8.
| Python 2.7 or >= 3.5 is required.

Looks like it's using host python which is at 3.4.8 in this case.

Hmmm. Host contamination is bad. We should make sure it is using python3native.

Quoted 41 lines

Thanks,

Anuj

Quoted 23 lines · Tim Orling

SCons has supported python3 since v3.0.0, use it.

---
 meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes- renamed from meta/recipes-support/serf/serf_1.3.9.bb +0 -0

support/serf/serf_1.3.9.bb
index 65a8114bb4..706c86be47 100644

meta/recipes-support/serf/serf_1.3.9.bb +0 -0
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] =

"549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM =
"file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"

-DEPENDS = "python-scons-native openssl apr apr-util util-linux expat"
+DEPENDS = "python3-scons-native openssl apr apr-util util-linux expat"

Quoted 6 lines
 do_compile() {
      ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE}

PREFIX=${prefix} \
--
2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#18 lore raw

Re: [PATCH 3/4] serf: switch to python3-scons-native

In reply to Mittal, Anuj
Quoted 10 lines · Anuj

This is causing on CentOS 7:

| DEBUG: Executing shell function do_compile
| scons: *** SCons version 3.0.5 does not run under Python version 3.4.8.
| Python 2.7 or >= 3.5 is required.

Looks like it's using host python which is at 3.4.8 in this case.

same error on ubuntu 14.04 on both serf and serf-native
https://errors.yoctoproject.org/Errors/Details/248342/
https://errors.yoctoproject.org/Errors/Details/248341/

Quoted 40 lines

Thanks,

Anuj

Quoted 23 lines · Tim Orling

SCons has supported python3 since v3.0.0, use it.

---
 meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes- renamed from meta/recipes-support/serf/serf_1.3.9.bb +0 -0

support/serf/serf_1.3.9.bb
index 65a8114bb4..706c86be47 100644

meta/recipes-support/serf/serf_1.3.9.bb +0 -0
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] =

"549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM =
"file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"

-DEPENDS = "python-scons-native openssl apr apr-util util-linux expat"
+DEPENDS = "python3-scons-native openssl apr apr-util util-linux expat"

Quoted 6 lines
 do_compile() {
      ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE}

PREFIX=${prefix} \
--
2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

In reply to Tim Orling
Quoted 15 lines · Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/scons.bbclass +0 -0
index 9ee7d1587d..a8ddae35f7 100644

meta/classes/scons.bbclass line 2

Quoted 3 lines
meta/classes/scons.bbclass +1 -1
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

Quoted 10 lines
meta/classes/scons.bbclass +0 -1
 EXTRA_OESCONS ?= ""
 
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#5 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 12 lines · Khem Raj
Quoted 10 lines · Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

meta/classes/scons.bbclass line 2

Quoted 8 lines
meta/classes/scons.bbclass +1 -1
index 9ee7d1587d..a8ddae35f7 100644
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.

Latest mongo release appears to be 4.3.0 and appears to support python3:

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Quoted 16 lines
Quoted 10 lines
meta/classes/scons.bbclass +0 -1
 EXTRA_OESCONS ?= ""
 
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#6 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 33 lines · Tim Orling
Quoted 12 lines · Khem Raj
Quoted 10 lines · Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

meta/classes/scons.bbclass line 2

Quoted 8 lines
meta/classes/scons.bbclass +1 -1
index 9ee7d1587d..a8ddae35f7 100644
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.

Quoted 8 lines

Latest mongo release appears to be 4.3.0 and appears to support python3:

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Yes for master this upgrade is fine

Quoted 19 lines
Quoted 18 lines
Quoted 7 lines
meta/classes/scons.bbclass +0 -1
 EXTRA_OESCONS ?= ""
 
--

2.20.1

Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#7 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 11 lines · Khem Raj

On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <[email protected]> wrote:
...

Quoted 7 lines

Latest mongo release appears to be 4.3.0 and appears to support python3:

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Yes for master this upgrade is fine

Are you approving the changed licence for OE,
or were you not aware that this was the question?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#8 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 10 lines · Adrian Bunk
Quoted 3 lines · Khem Raj

On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <[email protected]> wrote:
...

Quoted 1 line

Latest mongo release appears to be 4.3.0 and appears to support

python3:

Quoted 3 lines
Quoted 3 lines

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Yes for master this upgrade is fine

Are you approving the changed licence for OE,
or were you not aware that this was the question?

What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?

Quoted 11 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

#9 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 17 lines · Khem Raj
Quoted 13 lines · Adrian Bunk
Quoted 3 lines · Khem Raj

On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <[email protected]> wrote:
...

Quoted 1 line

Latest mongo release appears to be 4.3.0 and appears to support

python3:

Quoted 3 lines
Quoted 3 lines

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Quoted 4 lines
Quoted 3 lines

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Yes for master this upgrade is fine

Are you approving the changed licence for OE,
or were you not aware that this was the question?

What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?

The Server Side License is already in 4.0.6
https://github.com/mongodb/mongo/blob/caa42a1f75a56c7643d0b68d3880444375ec42e3/LICENSE-Community.txt

4.2.0+ use python 3 in SConstruct

Quoted 12 lines
Quoted 12 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

#10 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 25 lines · Tim Orling
Quoted 23 lines · Khem Raj
Quoted 18 lines · Adrian Bunk
Quoted 3 lines · Khem Raj

On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <[email protected]> wrote:
...

Quoted 1 line

Latest mongo release appears to be 4.3.0 and appears to support

python3:

Quoted 3 lines
Quoted 3 lines

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Quoted 5 lines
Quoted 3 lines

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Yes for master this upgrade is fine

Are you approving the changed licence for OE,
or were you not aware that this was the question?

Quoted 6 lines
Quoted 2 lines

What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?

The Server Side License is already in 4.0.6
https://github.com/mongodb/mongo/blob/caa42a1f75a56c7643d0b68d3880444375ec42e3/LICENSE-Community.txt
...

Ah sorry, I missed that.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#11 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 31 lines · Adrian Bunk
Quoted 8 lines · Tim Orling
Quoted 6 lines · Khem Raj
Quoted 2 lines · Adrian Bunk
Quoted 1 line · Khem Raj

On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <[email protected]>

Quoted 7 lines · wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

...

Quoted 1 line

Latest mongo release appears to be 4.3.0 and appears to support

python3:

Quoted 3 lines
Quoted 3 lines

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Quoted 13 lines
Quoted 12 lines
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Yes for master this upgrade is fine

Are you approving the changed licence for OE,
or were you not aware that this was the question?

What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?

Quoted 9 lines
Quoted 2 lines

The Server Side License is already in 4.0.6

https://github.com/mongodb/mongo/blob/caa42a1f75a56c7643d0b68d3880444375ec42e3/LICENSE-Community.txt

Quoted 1 line

...

Ah sorry, I missed that.

I didn’t know either. And you are correct in identifying what I was asking.... (without asking)

Quoted 11 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

#12 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

In reply to Tim Orling
Quoted 31 lines · Tim Orling
Quoted 13 lines · Khem Raj
Quoted 10 lines · Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

meta/classes/scons.bbclass line 2

Quoted 8 lines
meta/classes/scons.bbclass +1 -1
index 9ee7d1587d..a8ddae35f7 100644
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

Quoted 1 line

Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.

This also breaks the gpsd install, I tried upgrading to the latest release and that didn't help. I am going to send a patch for the upgrade which I tested with this patch reverted.

Alistair

Quoted 29 lines

Latest mongo release appears to be 4.3.0 and appears to support python3:

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Is this an aceptable upgrade? I am not savvy on which versions are desirable.

Quoted 11 lines
Quoted 11 lines
meta/classes/scons.bbclass +0 -1
 EXTRA_OESCONS ?= ""
 
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#13 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 32 lines · Alistair Francis
Quoted 31 lines · Tim Orling
Quoted 24 lines · Khem Raj
Quoted 15 lines · Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/scons.bbclass +0 -0
index 9ee7d1587d..a8ddae35f7 100644

meta/classes/scons.bbclass line 2

Quoted 3 lines
meta/classes/scons.bbclass +1 -1
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

Quoted 5 lines
Quoted 1 line

Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.

This also breaks the gpsd install, I tried upgrading to the latest release and that didn't help. I am going to send a patch for the upgrade which I tested with this patch reverted.

This is already workarounded:
http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=22bfe06d15e07cac0df3f34566a9d33007663bae

There are post-3.18.1 changes required for Python 3 scons, but I went for this hack after seeing that a proper fix would involve all of:
1. upgrading to 3.18.1
2. rebasing oe-only patches to 3.18.1
3. adding post-3.18.1 patches

Quoted 1 line

Alistair

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#14 lore raw

Re: [PATCH 2/4] scons.bbclass: use python3-scons

Quoted 34 lines · Adrian Bunk
Quoted 32 lines · Alistair Francis
Quoted 31 lines · Tim Orling
Quoted 24 lines · Khem Raj
Quoted 15 lines · Tim Orling

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/scons.bbclass +0 -0
index 9ee7d1587d..a8ddae35f7 100644

meta/classes/scons.bbclass line 2

Quoted 3 lines
meta/classes/scons.bbclass +1 -1
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.

This also breaks the gpsd install, I tried upgrading to the latest release and that didn't help. I am going to send a patch for the upgrade which I tested with this patch reverted.

This is already workarounded:
http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=22bfe06d15e07cac0df3f34566a9d33007663bae

Argh, I must not have pulled recently enough.

Quoted 6 lines

There are post-3.18.1 changes required for Python 3 scons, but I went for this hack after seeing that a proper fix would involve all of:
1. upgrading to 3.18.1
2. rebasing oe-only patches to 3.18.1

I sent a patch (with you CCed) that does the first two.

Quoted 1 line

3. adding post-3.18.1 patches

How hard would this be? I'm happy to look into it but I didn't see anything in the gpsd tree that seemed to fix the issue.

Alistair

Quoted 13 lines
Quoted 2 lines

Alistair

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed