Patch review
cover Patch review
Most of these where back port requests so I am giving a short review window. Commnets by Sunday.
The following changes since commit 21cbe3ec166696b4d67d2ef5486a394d14d29269:
aufs-util: prevent native aufs-util depending on target kernel (2019-05-18 07:38:39 -0700)
are available in the git repository at:
https://git.openembedded.org/meta-openembedded-contrib stable/warrior-nmut
http://cgit.openembedded.org//log/?h=stable/warrior-nmut
Changqing Li (1):
netkit-telnet: add rconflicts
Hongxu Jia (1):
crash: do not use unstable github archive tarballs
Liwei Song (1):
turbostat: copy bits.h from kernel to turbostat
Martin Jansa (16):
gtkwave: add distro_features_check
ndctl: make MACHINE_ARCH and ignore from libblockdev
oprofile: make MACHINE_ARCH
umip: make MACHINE_ARCH
mscgen: fix SRC_URI for multilib
triggerhappy: fix issues python-cassandra-driver.inc: fix DEPENDS
opencv: use the same package name in PACKAGES and RDEPENDS
igmpproxy: remove
0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch and
_GNU_SOURCE libvncserver: set PV in the recipe
ccid: fix SRC_URI
ne10, libopus: add armv7ve override as well
hunspell: use git fetcher instead of github archive ttf-mplus, ttf-vlgothic: add ttf-mplus license
libmikmod: fix SRC_URI
leptonica: fix SRC_URI
Mingli Yu (1):
mariadb: Upgrade to 10.3.15
[email protected] (1):
polkit: fix CVE-2019-6133
Scott Ellis (1):
wireguard: Upgrade 20190123 -> 20190406
nick83ola (1):
uthash: do not use unstable github archive tarballs
.../recipes-connectivity/umip/umip_1.0.bb | 3 +
...xy.h-Include-sys-types.h-for-u_short-u_in.patch | 25 ---
.../recipes-daemons/igmpproxy/igmpproxy_0.2.1.bb | 6 +-
...0190123.bb => wireguard-module_0.0.20190406.bb} | 0
...20190123.bb => wireguard-tools_0.0.20190406.bb} | 0
.../recipes-kernel/wireguard/wireguard.inc | 4 +-
.../netkit-telnet/netkit-telnet_0.17.bb | 1 +
meta-oe/conf/layer.conf | 6 +
meta-oe/licenses/ttf-mplus | 16 ++
meta-oe/recipes-core/ndctl/ndctl_v63.bb | 3 +
.../packagegroups/packagegroup-meta-oe.bb | 3 +-
...native_10.3.13.bb => mariadb-native_10.3.15.bb} | 0
meta-oe/recipes-dbs/mysql/mariadb.inc | 4 +-
.../{mariadb_10.3.13.bb => mariadb_10.3.15.bb} | 0
...pare-PolkitUnixProcess-uids-for-temporary.patch | 186 +++++++++++++++++++++
meta-oe/recipes-extended/polkit/polkit_0.115.bb | 7 +-
.../{triggerhappy_0.5.0.bb => triggerhappy_git.bb} | 22 +--
meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 +
.../recipes-graphics/leptonica/leptonica_1.74.4.bb | 2 +-
.../libvncserver/libvncserver_git.bb | 2 +-
.../recipes-graphics/ttf-fonts/ttf-mplus_027.bb | 2 +-
.../ttf-fonts/ttf-vlgothic_20141206.bb | 2 +-
meta-oe/recipes-kernel/crash/crash_7.2.5.bb | 8 +-
meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb | 3 +
meta-oe/recipes-kernel/turbostat/turbostat_3.4.bb | 2 +
.../recipes-multimedia/libopus/libopus_1.1.3.bb | 3 +-
.../recipes-multimedia/mikmod/libmikmod_3.3.6.bb | 2 +-
meta-oe/recipes-support/ccid/ccid_1.4.24.bb | 4 +-
meta-oe/recipes-support/hunspell/hunspell_1.7.0.bb | 7 +-
meta-oe/recipes-support/mscgen/mscgen_0.20.bb | 2 +-
meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 +-
meta-oe/recipes-support/opencv/opencv_3.4.5.bb | 2 +-
meta-oe/recipes-support/uthash/uthash_2.1.0.bb | 7 +-
.../python/python-cassandra-driver.inc | 2 +-
34 files changed, 272 insertions(+), 72 deletions(-)
delete mode 100644 meta-networking/recipes-daemons/igmpproxy/igmpproxy/0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch
rename meta-networking/recipes-kernel/wireguard/{wireguard-module_0.0.20190123.bb => wireguard-module_0.0.20190406.bb} (100%)
rename meta-networking/recipes-kernel/wireguard/{wireguard-tools_0.0.20190123.bb => wireguard-tools_0.0.20190406.bb} (100%)
create mode 100644 meta-oe/licenses/ttf-mplus
rename meta-oe/recipes-dbs/mysql/{mariadb-native_10.3.13.bb => mariadb-native_10.3.15.bb} (100%)
rename meta-oe/recipes-dbs/mysql/{mariadb_10.3.13.bb => mariadb_10.3.15.bb} (100%)
create mode 100644 meta-oe/recipes-extended/polkit/polkit/0001-backend-Compare-PolkitUnixProcess-uids-for-temporary.patch
rename meta-oe/recipes-extended/triggerhappy/{triggerhappy_0.5.0.bb => triggerhappy_git.bb} (73%)Signature · 1 line
2.7.4
PATCH 1/23 gtkwave: add distro_features_check
From: Martin Jansa <[email protected]>
* fixes:
ERROR: Nothing PROVIDES 'gtk+' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it) gtk+ was skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'gtk+']
and
ERROR: Nothing PROVIDES 'tk' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it) tk was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'tk']
--- meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 ++++ 1 file changed, 4 insertions(+)
meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb +4 -0
@@ -14,6 +14,10 @@ inherit pkgconfig autotools gettext texinfo DEPENDS = "tcl tk gperf-native bzip2 xz pango zlib gtk+ gdk-pixbuf glib-2.0" RDEPENDS_${PN} = "tk-lib" +# depends on gtk+ which has this restriction +inherit distro_features_check +ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}" + EXTRA_OECONF = "--with-tcl=${STAGING_BINDIR_CROSS} --with-tk=${STAGING_BINDIR_CROSS}" FILES_${PN} = "${bindir} ${datadir}"
Signature · 1 line
2.7.4
PATCH 2/23 ndctl: make MACHINE_ARCH and ignore from libblockdev
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* fixes:
ERROR: libblockdev different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task libblockdev/libblockdev_2.20.bb.do_prepare_recipe_sysroot changed from bee357e6fd2c8479c9dbf9ccef6f30c416df1eb608b53a775383069a4215286b to 23a2ff7864fbd6d38b77918829651cff8d009702894ee670fab145c520d05be8
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-extended/libblockdev/libblockdev_2.20.bb.do_prepare_recipe_sysroot with hashes bee357e6fd2c8479c9dbf9ccef6f30c416df1eb608b53a775383069a4215286b or 23a2ff7864fbd6d38b77918829651cff8d009702894ee670fab145c520d05be8
ERROR: ndctl different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task ndctl/ndctl_v63.bb.do_prepare_recipe_sysroot changed from ea34e9d64a9f30c3ed898bd3850e43e95297dacc560732e1d6bdfa961a6b357b to f886d72844b05c99cd241b8402d760d2c02e0264bfc66503d1e8742815463b3c
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-core/ndctl/ndctl_v63.bb.do_prepare_recipe_sysroot with hashes ea34e9d64a9f30c3ed898bd3850e43e95297dacc560732e1d6bdfa961a6b357b or f886d72844b05c99cd241b8402d760d2c02e0264bfc66503d1e8742815463b3c
$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/ndctl/*do_prepare*.sigdata* runtaskdeps changed: ['autoconf/autoconf_2.69.bb.do_populate_sysroot:virtual:native automake/automake_1.16.1.bb.do_populate_sysroot:virtual:native bash-completion/bash-completion_2.8.bb.do_populate_sysroot gcc/gcc-cross_7.3.bb.do_populate_sysroot gcc/gcc-runtime_7.3.bb.do_populate_sysroot glibc/glibc_2.29.bb.do_populate_sysroot gnu-config/gnu-config_git.bb.do_populate_sysroot:virtual:native json-c/json-c_0.13.1.bb.do_populate_sysroot kmod/kmod_git.bb.do_populate_sysroot libtool/libtool-cross_2.4.6.bb.do_populate_sysroot libtool/libtool-native_2.4.6.bb.do_populate_sysroot', -linux/linux-lg-hammerhead_git.bb.do_populate_sysroot, +linux/linux-lg-mako_git.bb.do_populate_sysroot, 'ndctl/ndctl_v63.bb.do_fetch pkgconfig/pkgconfig_git.bb.do_populate_sysroot:virtual:native systemd/systemd-systemctl-native.bb.do_populate_sysroot systemd/systemd_242.bb.do_populate_sysroot'] linux/linux-lg-hammerhead_git.bb.do_populate_sysroot with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438 changed to linux/linux-lg-mako_git.bb.do_populate_sysroot with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3 Dependency on task linux/linux-lg-mako_git.bb.do_populate_sysroot was added with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3 Dependency on task linux/linux-lg-hammerhead_git.bb.do_populate_sysroot was removed with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438
$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/libblockdev/*do_prepare*.sigdata* Hash for dependent task ndctl/ndctl_v63.bb.do_populate_sysroot changed from 0d123eb0e330a9e34d199eb012da9ae2eb614063f9412725ef39a06b152341f1 to 40077996bc35ac047210928559ad692f4eb20e37b07ef675bf49c9c39c46fe1e Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-core/ndctl/ndctl_v63.bb.do_populate_sysroot with hashes 0d123eb0e330a9e34d199eb012da9ae2eb614063f9412725ef39a06b152341f1 or 40077996bc35ac047210928559ad692f4eb20e37b07ef675bf49c9c39c46fe1e
as detected with:openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"
--- meta-oe/conf/layer.conf | 6 ++++++ meta-oe/recipes-core/ndctl/ndctl_v63.bb | 3 +++ 2 files changed, 9 insertions(+)
meta-oe/conf/layer.conf +6 -0
@@ -51,6 +51,12 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ phoronix-test-suite->php \ " +# Depends on ndctl (through nvdimm PACKAGECONFIG) which depends on MACHINE_ARCH kernel +# and making libblockdev MACHINE_ARCH is not an option as python3-blivet, udisks2, gvfs +# would be MACHINE_ARCH as well +SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ + libblockdev->ndctl \ +" # ttf.inc inherits fontcache which adds fontconfig-utils to RDEPENDS SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ terminus-font->fontconfig \
meta-oe/recipes-core/ndctl/ndctl_v63.bb +3 -0
@@ -19,6 +19,9 @@ S = "${WORKDIR}/git" EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs" +# Depends on MACHINE_ARCH kernel +PACKAGE_ARCH = "${MACHINE_ARCH}" + PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','',d)}" PACKAGECONFIG[systemd] = "--with-systemd, --without-systemd, systemd"
Signature · 1 line
2.7.4
PATCH 3/23 oprofile: make MACHINE_ARCH
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* fixes:
ERROR: oprofile different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task oprofile/oprofile_1.3.0.bb.do_prepare_recipe_sysroot changed from deecd34bc94f47935ce3dc7f83f9a8407269959e446518bd9700a2ebae4324bb to d4d6301a72fcd061c167a6715372a6e35f57bf08152a6223b1571957834428f0
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb.do_prepare_recipe_sysroot with hashes deecd34bc94f47935ce3dc7f83f9a8407269959e446518bd9700a2ebae4324bb or d4d6301a72fcd061c167a6715372a6e35f57bf08152a6223b1571957834428f0
$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/oprofile/*do_prepare*.sigdata* runtaskdeps changed: ['autoconf/autoconf_2.69.bb.do_populate_sysroot:virtual:native automake/automake_1.16.1.bb.do_populate_sysroot:virtual:native binutils/binutils_2.32.bb.do_populate_sysroot gcc/gcc-cross_7.3.bb.do_populate_sysroot gcc/gcc-runtime_7.3.bb.do_populate_sysroot glibc/glibc_2.29.bb.do_populate_sysroot gnu-config/gnu-config_git.bb.do_populate_sysroot:virtual:native libtool/libtool-cross_2.4.6.bb.do_populate_sysroot libtool/libtool-native_2.4.6.bb.do_populate_sysroot', -linux/linux-lg-hammerhead_git.bb.do_populate_sysroot, +linux/linux-lg-mako_git.bb.do_populate_sysroot, 'oprofile/oprofile_1.3.0.bb.do_fetch pkgconfig/pkgconfig_git.bb.do_populate_sysroot:virtual:native popt/popt_1.16.bb.do_populate_sysroot'] linux/linux-lg-hammerhead_git.bb.do_populate_sysroot with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438 changed to linux/linux-lg-mako_git.bb.do_populate_sysroot with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3 Dependency on task linux/linux-lg-mako_git.bb.do_populate_sysroot was added with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3 Dependency on task linux/linux-lg-hammerhead_git.bb.do_populate_sysroot was removed with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438
* as detected with:openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"
--- meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb | 3 +++ 1 file changed, 3 insertions(+)
meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb +3 -0
@@ -3,6 +3,9 @@ require oprofile.inc DEPENDS += "virtual/kernel" DEPENDS_append_powerpc64 = " libpfm4" +# Depends on MACHINE_ARCH kernel +PACKAGE_ARCH = "${MACHINE_ARCH}" + SRC_URI[md5sum] = "bd998df5521ebedae31e71cd3fb6200b" SRC_URI[sha256sum] = "95ded8bde1ec39922f0af015981a67aec63e025a501e4dc04cd65d38f73647e6"
Signature · 1 line
2.7.4
PATCH 4/23 umip: make MACHINE_ARCH
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* Depends on ipsec-tools which is already MACHINE_ARCH (and also RRECOMMENDS kernel modules)
* Fixes:
ERROR: umip different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task umip/umip_1.0.bb.do_prepare_recipe_sysroot changed from 7c74a208880f6c8a5aa46b1c8577e39b6b71429d9a379ea75f17a155ca270035 to 87c6cd438dd9645c98530e3ac1094005bace785bfd89bfe4073bc8815926abba
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-networking/recipes-connectivity/umip/umip_1.0.bb.do_prepare_recipe_sysroot with hashes 7c74a208880f6c8a5aa46b1c8577e39b6b71429d9a379ea75f17a155ca270035 or 87c6cd438dd9645c98530e3ac1094005bace785bfd89bfe4073bc8815926abba
bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/umip/*do_prepare*.sigdata*
Hash for dependent task ipsec-tools/ipsec-tools_0.8.2.bb.do_populate_sysroot changed from 1100c4984d88050bb7ca154445205bac3c3ab80c3ff0aa7c9124825c9d4f6e14 to feeddbd35a8106b264c98076e21d0b3cb227ab1d209e150926112b2906273ef4
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-networking/recipes-support/ipsec-tools/ipsec-tools_0.8.2.bb.do_populate_sysroot with hashes 1100c4984d88050bb7ca154445205bac3c3ab80c3ff0aa7c9124825c9d4f6e14 or feeddbd35a8106b264c98076e21d0b3cb227ab1d209e150926112b2906273ef4
as detected with: openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"
--- meta-networking/recipes-connectivity/umip/umip_1.0.bb | 3 +++ 1 file changed, 3 insertions(+)
meta-networking/recipes-connectivity/umip/umip_1.0.bb +3 -0
@@ -20,6 +20,9 @@ SRC_URI = "git://git.umip.org/umip/umip.git \ " SRCREV = "cbd441c5db719db554ff2b4fcb02fef88ae2f791" +# Depends on ipsec-tools which is already MACHINE_ARCH (and also RRECOMMENDS kernel modules) +PACKAGE_ARCH = "${MACHINE_ARCH}" + S = "${WORKDIR}/git" EXTRA_OECONF = "--enable-vt"
Signature · 1 line
2.7.4
PATCH 5/23 mscgen: fix SRC_URI for multilib
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
--- meta-oe/recipes-support/mscgen/mscgen_0.20.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-support/mscgen/mscgen_0.20.bb +1 -1
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.mcternan.me.uk/mscgen/" LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=b1e6a340187c1cf716513439d07c1d79" -SRC_URI = "http://www.mcternan.me.uk/mscgen/software/${PN}-src-${PV}.tar.gz" +SRC_URI = "http://www.mcternan.me.uk/mscgen/software/${BPN}-src-${PV}.tar.gz" SRC_URI[md5sum] = "65c90fb5150d7176b65b793f0faa7377" SRC_URI[sha256sum] = "3c3481ae0599e1c2d30b7ed54ab45249127533ab2f20e768a0ae58d8551ddc23"
Signature · 1 line
2.7.4
PATCH 6/23 triggerhappy: fix issues
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* using PN instead of BPN in S causes all tasks to fail:
make: *** No targets specified and no makefile found. Stop.
* using github archives is bad, because they are regenerated from time to time with different checksums
* set PV, because this isn't exactly 0.5.0, because of the debian changes mostly the systemd support
* fix indentation
---
.../{triggerhappy_0.5.0.bb => triggerhappy_git.bb} | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
rename meta-oe/recipes-extended/triggerhappy/{triggerhappy_0.5.0.bb => triggerhappy_git.bb} (73%)meta-oe/recipes-extended/triggerhappy/triggerhappy_git.bb renamed from meta-oe/recipes-extended/triggerhappy/triggerhappy_0.5.0.bb +11 -11
@@ -4,12 +4,12 @@ HOMEPAGE = "https://github.com/wertarbyte/triggerhappy" LICENSE = "GPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" -SRC_URI = "https://github.com/wertarbyte/triggerhappy/archive/debian/0.5.0-1.tar.gz" +# matches debian/0.5.0-1 tag +SRCREV = "44a173195986d0d853316cb02a58785ded66c12b" +PV = "0.5.0+git${SRCPV}" +SRC_URI = "git://github.com/wertarbyte/${BPN}.git;branch=debian" -SRC_URI[md5sum] = "77f90a18c775e47c4c5e9e08987ca32f" -SRC_URI[sha256sum] = "9150bafbf7f2de7d57e6cc154676c33da98dc11ac6442e1ca57e5dce82bd4292" - -S = "${WORKDIR}/${PN}-debian-${PV}-1" +S = "${WORKDIR}/git" inherit autotools-brokensep pkgconfig update-rc.d systemd
@@ -21,12 +21,12 @@ INITSCRIPT_PARAMS = "defaults" SYSTEMD_SERVICE_${PN} = "triggerhappy.service triggerhappy.socket" FILES_${PN} = "\ -${sbindir}/thd \ -${sbindir}/th-cmd \ -${sysconfdir}/triggerhappy/triggers.d \ -${nonarch_base_libdir}/udev/rules.d/80-triggerhappy.rules \ -${sysconfdir}/init.d/triggerhappy \ -${systemd_unitdir}/system \ + ${sbindir}/thd \ + ${sbindir}/th-cmd \ + ${sysconfdir}/triggerhappy/triggers.d \ + ${nonarch_base_libdir}/udev/rules.d/80-triggerhappy.rules \ + ${sysconfdir}/init.d/triggerhappy \ + ${systemd_unitdir}/system \ " CONFFILES_${PN} = "${sysconfdir}/udev/rules.d/80-triggerhappy.rules"
Signature · 1 line
2.7.4
PATCH 7/23 python-cassandra-driver.inc: fix DEPENDS
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* there is no such thing as DEPENDS_${PN}
--- meta-python/recipes-devtools/python/python-cassandra-driver.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-python/recipes-devtools/python/python-cassandra-driver.inc +1 -1
@@ -28,6 +28,6 @@ RDEPENDS_${PN} += "\ libevent \ " -DEPENDS_${PN} += "\ +DEPENDS += "\ ${PYTHON_PN}-cython \ "
Signature · 1 line
2.7.4
PATCH 8/23 opencv: use the same package name in PACKAGES and RDEPENDS
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
--- meta-oe/recipes-support/opencv/opencv_3.4.5.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-support/opencv/opencv_3.4.5.bb +1 -1
@@ -176,7 +176,7 @@ SUMMARY_python3-opencv = "Python bindings to opencv" FILES_python3-opencv = "${PYTHON_SITEPACKAGES_DIR}/*" RDEPENDS_python3-opencv = "python3-core python3-numpy" -RDEPENDS_opencv-apps = "bash" +RDEPENDS_${PN}-apps = "bash" do_install_append() { cp ${S}/include/opencv/*.h ${D}${includedir}/opencv/
Signature · 1 line
2.7.4
PATCH 9/23 igmpproxy: remove 0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch and _GNU_SOURCE
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* it was upgraded to 0.2.1 in:
commit 50979151e69e5707580b2f3d263a9b36b6a190d5
Author: Oleksandr Kravchuk <[email protected]>
Date: Sat Mar 16 18:22:59 2019 +0100
igmpproxy: update to 0.2.1
* which includes _GNU_SOURCE:
https://github.com/pali/igmpproxy/commit/7d790aa2f16afad63418e573db13ea39d76ed141
* and includes sys/types.h in os-linux.h:
https://github.com/pali/igmpproxy/commit/6f92242b23178e979f4a806abe4ac9652b51c593
* and the patch doesn't apply cleanly:
ERROR: Fuzz detected:
checking file src/igmpproxy.h
Hunk #1 succeeded at 51 with fuzz 2 (offset 5 lines).
patching file src/igmpproxy.h
Hunk #1 succeeded at 51 with fuzz 2 (offset 5 lines).
The context lines in the patches can be updated with devtool:
devtool modify lib32-igmpproxy
devtool finish --force-patch-refresh lib32-igmpproxy <layer_path>
Don't forget to review changes done by devtool!
ERROR: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]
--- ...xy.h-Include-sys-types.h-for-u_short-u_in.patch | 25 ---------------------- .../recipes-daemons/igmpproxy/igmpproxy_0.2.1.bb | 6 +----- 2 files changed, 1 insertion(+), 30 deletions(-) delete mode 100644 meta-networking/recipes-daemons/igmpproxy/igmpproxy/0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch
meta-networking/recipes-daemons/igmpproxy/igmpproxy/0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch deleted +0 -25
@@ -1,25 +0,0 @@ -From a557651a08e21e3c7c7f5eca9f5405f86624903f Mon Sep 17 00:00:00 2001 -From: Khem Raj <[email protected]> -Date: Fri, 14 Jul 2017 22:42:51 -0700 -Subject: [PATCH] src/igmpproxy.h: Include sys/types.h for u_short/u_init - -Signed-off-by: Khem Raj <[email protected]> ---- - src/igmpproxy.h | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/src/igmpproxy.h b/src/igmpproxy.h -index 4dabd1c..4454729 100644 ---- a/src/igmpproxy.h -+++ b/src/igmpproxy.h -@@ -46,6 +46,7 @@ - #include <stdbool.h> - - #include <sys/socket.h> -+#include <sys/types.h> - #include <sys/un.h> - #include <sys/time.h> - #include <sys/ioctl.h> --- -2.13.3 -
meta-networking/recipes-daemons/igmpproxy/igmpproxy_0.2.1.bb +1 -5
@@ -4,12 +4,8 @@ HOMEPAGE = "http://sourceforge.net/projects/igmpproxy/" LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=432040ff3a55670c1dec0c32b209ad69" -SRC_URI = "https://github.com/pali/igmpproxy/releases/download/${PV}/igmpproxy-${PV}.tar.gz \ - file://0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch \ -" +SRC_URI = "https://github.com/pali/igmpproxy/releases/download/${PV}/${BP}.tar.gz" SRC_URI[md5sum] = "3a9c2cb42c1f5ee0cb769a4884545641" SRC_URI[sha256sum] = "d351e623037390f575c1203d9cbb7ba33a8bdef85a3c5e1d2901c5a2a38449a1" inherit autotools pkgconfig - -CFLAGS += "-D_GNU_SOURCE"
Signature · 1 line
2.7.4
PATCH 10/23 libvncserver: set PV in the recipe
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* last SRCREV bump commit says:
libvncserver: Update to latest commit post 0.9.12 but there is no PV in the recipe, so the version was just:
git-r0
--- meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb +1 -1
@@ -32,6 +32,6 @@ inherit cmake SRC_URI = "git://github.com/LibVNC/libvncserver" SRCREV = "c0a23857a5c42b45b6d22ccf7218becd1fa69402" - +PV = "0.9.12+git${SRCPV}" S = "${WORKDIR}/git"
Signature · 1 line
2.7.4
PATCH 11/23 ccid: fix SRC_URI
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* alioth.debian.org isn't available anymore
* master already has this (was part of the upgrade to newer version)
--- meta-oe/recipes-support/ccid/ccid_1.4.24.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/ccid/ccid_1.4.24.bb +2 -2
@@ -1,12 +1,12 @@ SUMMARY = "Generic USB CCID smart card reader driver" -HOMEPAGE = "http://pcsclite.alioth.debian.org/ccid.html" +HOMEPAGE = "https://ccid.apdu.fr/" LICENSE = "LGPLv2.1+" LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1" DEPENDS = "virtual/libusb0 pcsc-lite" RDEPENDS_${PN} = "pcsc-lite" -SRC_URI = "https://alioth.debian.org/frs/download.php/file/4171/ccid-${PV}.tar.bz2 \ +SRC_URI = "https://ccid.apdu.fr/files/ccid-${PV}.tar.bz2 \ file://no-dep-on-libfl.patch \ "
Signature · 1 line
2.7.4
PATCH 12/23 wireguard: Upgrade 20190123 -> 20190406
In reply to Armin KusterFrom: Scott Ellis <[email protected]>
Fixes issues with kernels 5.1 and greater.
Backport from master fc1b5310b28f70900a8a432048e08ee06ae309d7
---
...eguard-module_0.0.20190123.bb => wireguard-module_0.0.20190406.bb} | 0
...ireguard-tools_0.0.20190123.bb => wireguard-tools_0.0.20190406.bb} | 0
meta-networking/recipes-kernel/wireguard/wireguard.inc | 4 ++--
3 files changed, 2 insertions(+), 2 deletions(-)
rename meta-networking/recipes-kernel/wireguard/{wireguard-module_0.0.20190123.bb => wireguard-module_0.0.20190406.bb} (100%)
rename meta-networking/recipes-kernel/wireguard/{wireguard-tools_0.0.20190123.bb => wireguard-tools_0.0.20190406.bb} (100%)meta-networking/recipes-kernel/wireguard/wireguard-module_0.0.20190406.bb renamed from meta-networking/recipes-kernel/wireguard/wireguard-module_0.0.20190123.bb +0 -0
meta-networking/recipes-kernel/wireguard/wireguard-tools_0.0.20190406.bb renamed from meta-networking/recipes-kernel/wireguard/wireguard-tools_0.0.20190123.bb +0 -0
meta-networking/recipes-kernel/wireguard/wireguard.inc +2 -2
@@ -11,7 +11,7 @@ LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://../COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" SRC_URI = "https://git.zx2c4.com/WireGuard/snapshot/WireGuard-${PV}.tar.xz" -SRC_URI[md5sum] = "8a0a232f65d5d86dd408efd9ac30bcf9" -SRC_URI[sha256sum] = "edd13c7631af169e3838621b1a1bff3ef73cf7bc778eec2bd55f7c1089ffdf9b" +SRC_URI[md5sum] = "c11254fe48695e61c145a7e82756ecba" +SRC_URI[sha256sum] = "2f06f3adf70b95e74a7736a22dcf6e9ef623b311a15b7d55b5474e57c3d0415b" S = "${WORKDIR}/WireGuard-${PV}/src/"
Signature · 1 line
2.7.4
PATCH 13/23 ne10, libopus: add armv7ve override as well
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* fix the override in packagegroup-meta-oe.bb
* alllow building ne10 for armv7ve (e.g. Cortex-A15)
--- meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb | 3 ++- meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb | 3 ++- meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-)
meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb +2 -1
@@ -220,7 +220,8 @@ RDEPENDS_packagegroup-meta-oe-shells ="\ NE10 = "" NE10_aarch64 = "ne10" -NE10_arm7 = "ne10" +NE10_armv7a = "ne10" +NE10_armv7ve = "ne10" RDEPENDS_packagegroup-meta-oe-support ="\ anthy asio atop augeas avro-c bdwgc frame grail \
meta-oe/recipes-multimedia/libopus/libopus_1.1.3.bb +2 -1
@@ -28,9 +28,10 @@ EXTRA_OECONF = " \ --enable-custom-modes \ " -# ne10 is available only for armv7a and aarch64 +# ne10 is available only for armv7a, armv7ve and aarch64 DEPENDS_append_aarch64 = " ne10" DEPENDS_append_armv7a = " ne10" +DEPENDS_append_armv7ve = " ne10" python () { if d.getVar('TARGET_FPU') in [ 'soft' ]:
meta-oe/recipes-support/ne10/ne10_1.2.1.bb +3 -1
@@ -15,13 +15,15 @@ PV .= "gitr+${SRCPV}" inherit cmake -# Incompatible with archs other than armv7 and aarch64 +# Incompatible with archs other than armv7, armv7ve and aarch64 COMPATIBLE_MACHINE = "(^$)" COMPATIBLE_MACHINE_aarch64 = "(.*)" COMPATIBLE_MACHINE_armv7a = "(.*)" +COMPATIBLE_MACHINE_armv7ve = "(.*)" NE10_TARGET_ARCH = "" NE10_TARGET_ARCH_aarch64 = "aarch64" NE10_TARGET_ARCH_armv7a = "armv7" +NE10_TARGET_ARCH_armv7ve = "armv7" EXTRA_OECMAKE = '-DGNULINUX_PLATFORM=ON -DNE10_BUILD_SHARED=ON -DNE10_LINUX_TARGET_ARCH="${NE10_TARGET_ARCH}"'
Signature · 1 line
2.7.4
PATCH 14/23 hunspell: use git fetcher instead of github archive
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* fixes:
ERROR: QA Issue: https://github.com/hunspell/hunspell/archive/v1.7.0.tar.gz: SRC_URI uses unstable GitHub archives [src-uri-bad]
* there is developer uploaded tarball in:
https://github.com/hunspell/hunspell/files/2573619/hunspell-1.7.0.tar.gz
but it's already reconfigured which we don't need, so I've used git fetcher
to stay closer to what we already use.
* the diff between:
https://github.com/hunspell/hunspell/files/2573619/hunspell-1.7.0.tar.gz
and
https://github.com/hunspell/hunspell/archive/v1.7.0.tar.gz
docker-shr @ ~/hunspell $ diff -rq hunspell-1.7.0*/
Only in hunspell-1.7.0-archive/: .gitignore
Only in hunspell-1.7.0-archive/: .travis.yml
Only in hunspell-1.7.0-archive/: COPYING.MPL
Only in hunspell-1.7.0/: INSTALL
Only in hunspell-1.7.0/: Makefile.in
Only in hunspell-1.7.0-archive/: README.md
Only in hunspell-1.7.0/: aclocal.m4
Only in hunspell-1.7.0-archive/: appveyor.yml
Only in hunspell-1.7.0/: compile
Only in hunspell-1.7.0/: config.guess
Only in hunspell-1.7.0/: config.h.in
Only in hunspell-1.7.0/: config.sub
Only in hunspell-1.7.0/: configure
Only in hunspell-1.7.0/: depcomp
Only in hunspell-1.7.0/: install-sh
Only in hunspell-1.7.0/: ltmain.sh
Only in hunspell-1.7.0-archive/m4: ChangeLog
Only in hunspell-1.7.0-archive/m4: README
Only in hunspell-1.7.0/m4: libtool.m4
Only in hunspell-1.7.0/m4: ltoptions.m4
Only in hunspell-1.7.0/m4: ltsugar.m4
Only in hunspell-1.7.0/m4: ltversion.m4
Only in hunspell-1.7.0/m4: lt~obsolete.m4
Only in hunspell-1.7.0/man: Makefile.in
Only in hunspell-1.7.0/man/hu: Makefile.in
Only in hunspell-1.7.0/: missing
Only in hunspell-1.7.0-archive/: msvc
Only in hunspell-1.7.0-archive/po: .gitignore
Only in hunspell-1.7.0/po: ca.gmo
Files hunspell-1.7.0-archive/po/ca.po and hunspell-1.7.0/po/ca.po differ Only in hunspell-1.7.0/po: de.gmo
Files hunspell-1.7.0-archive/po/de.po and hunspell-1.7.0/po/de.po differ Only in hunspell-1.7.0/po: es.gmo
Files hunspell-1.7.0-archive/po/es.po and hunspell-1.7.0/po/es.po differ Only in hunspell-1.7.0/po: hu.gmo
Files hunspell-1.7.0-archive/po/hu.po and hunspell-1.7.0/po/hu.po differ Files hunspell-1.7.0-archive/po/hunspell.pot and hunspell-1.7.0/po/hunspell.pot differ Only in hunspell-1.7.0/po: it.gmo
Files hunspell-1.7.0-archive/po/it.po and hunspell-1.7.0/po/it.po differ Only in hunspell-1.7.0/po: pl.gmo
Files hunspell-1.7.0-archive/po/pl.po and hunspell-1.7.0/po/pl.po differ Only in hunspell-1.7.0/po: pt_BR.gmo
Files hunspell-1.7.0-archive/po/pt_BR.po and hunspell-1.7.0/po/pt_BR.po differ Only in hunspell-1.7.0/po: tg.gmo
Files hunspell-1.7.0-archive/po/tg.po and hunspell-1.7.0/po/tg.po differ Only in hunspell-1.7.0/src: Makefile.in
Only in hunspell-1.7.0/src/hunspell: Makefile.in
Only in hunspell-1.7.0-archive/src/parsers: .gitignore
Only in hunspell-1.7.0/src/parsers: Makefile.in
Only in hunspell-1.7.0-archive/src/tools: .gitignore
Only in hunspell-1.7.0/src/tools: Makefile.in
Only in hunspell-1.7.0-archive/src/tools: fuzzer.cxx
Only in hunspell-1.7.0/: tap-driver.sh
Only in hunspell-1.7.0/: test-driver
Only in hunspell-1.7.0-archive/tests: .gitattributes
Only in hunspell-1.7.0-archive/tests: .gitignore
Only in hunspell-1.7.0/tests: Makefile.in
Only in hunspell-1.7.0-archive/tests: hu.wrong
Only in hunspell-1.7.0-archive/tests: nepali.wrong
Only in hunspell-1.7.0-archive/tests: ph2.good
Only in hunspell-1.7.0-archive/tests/suggestiontest: .gitignore
Only in hunspell-1.7.0/tests/suggestiontest: Makefile.in
Only in hunspell-1.7.0-archive/tests/suggestiontest: prepare2
Only in hunspell-1.7.0-archive/tests: wordpair.good
--- meta-oe/recipes-support/hunspell/hunspell_1.7.0.bb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
meta-oe/recipes-support/hunspell/hunspell_1.7.0.bb +4 -3
@@ -6,9 +6,10 @@ LIC_FILES_CHKSUM = " \ file://COPYING.LESSER;md5=c96ca6c1de8adc025adfada81d06fba5 \ " -SRC_URI = "https://github.com/${BPN}/${BPN}/archive/v${PV}.tar.gz" -SRC_URI[md5sum] = "b2399a4aa927e8b3e171d9ea6737cc02" -SRC_URI[sha256sum] = "bb27b86eb910a8285407cf3ca33b62643a02798cf2eef468c0a74f6c3ee6bc8a" +SRCREV = "4ddd8ed5ca6484b930b111aec50c2750a6119a0f" +SRC_URI = "git://github.com/${BPN}/${BPN}.git" + +S = "${WORKDIR}/git" inherit autotools pkgconfig gettext
Signature · 1 line
2.7.4
PATCH 15/23 ttf-mplus, ttf-vlgothic: add ttf-mplus license
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* add meta-oe/licenses/ttf-mplus from ttf-mplus/027-r4/mplus-TESTFLIGHT-027/LICENSE_E
* use BPN to use the same LICENSE even with multilib
* use the same license name from ttf-vlgothic
* fixes following warnings:
WARNING: ttf-mplus-027-r4 do_populate_lic: ttf-mplus: No generic license file exists for: ttf-mplus in any provider
WARNING: ttf-vlgothic-20141206-r0 do_populate_lic: ttf-vlgothic: No generic license file exists for: mplus in any provider
--- meta-oe/licenses/ttf-mplus | 16 ++++++++++++++++ meta-oe/recipes-graphics/ttf-fonts/ttf-mplus_027.bb | 2 +- .../recipes-graphics/ttf-fonts/ttf-vlgothic_20141206.bb | 2 +- 3 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 meta-oe/licenses/ttf-mplus
meta-oe/licenses/ttf-mplus new file +16 -0
@@ -0,0 +1,16 @@ +M+ FONTS Copyright (C) 2002-2009 M+ FONTS PROJECT + +- + +LICENSE_E + + + + +These fonts are free softwares. +Unlimited permission is granted to use, copy, and distribute it, with +or without modification, either commercially and noncommercially. +THESE FONTS ARE PROVIDED "AS IS" WITHOUT WARRANTY. + + +http://mplus-fonts.sourceforge.jp/mplus-outline-fonts/
meta-oe/recipes-graphics/ttf-fonts/ttf-mplus_027.bb +1 -1
@@ -2,7 +2,7 @@ require ttf.inc SUMMARY = "MPlus font - TTF Edition" HOMEPAGE = "http://dejavu.sourceforge.net/wiki/" -LICENSE = "${PN}" +LICENSE = "${BPN}" LIC_FILES_CHKSUM = "file://LICENSE_E;md5=ac161e96eda00db9a3aec7870b5d9658 \ file://LICENSE_J;md5=a120ca8d7c8e4a475d5277c9aeb95221 \ "
meta-oe/recipes-graphics/ttf-fonts/ttf-vlgothic_20141206.bb +1 -1
@@ -4,7 +4,7 @@ SUMMARY = "Japanese TrueType fonts from Vine Linux" AUTHOR = "Contributor: noonov <[email protected]>" HOMEPAGE = "http://vlgothic.dicey.org/" -LICENSE = "mplus & BSD" +LICENSE = "ttf-mplus & BSD" LIC_FILES_CHKSUM = "file://LICENSE.en;md5=66ecd0fd7e4da6246fa30317c7b66755 \ file://LICENSE_E.mplus;md5=1c4767416f20215f1e61b970f2117db9 \ "
Signature · 1 line
2.7.4
PATCH 16/23 polkit: fix CVE-2019-6133
In reply to Armin KusterFrom: "[email protected]" <[email protected]>
--- ...pare-PolkitUnixProcess-uids-for-temporary.patch | 186 +++++++++++++++++++++ meta-oe/recipes-extended/polkit/polkit_0.115.bb | 7 +- 2 files changed, 190 insertions(+), 3 deletions(-) create mode 100644 meta-oe/recipes-extended/polkit/polkit/0001-backend-Compare-PolkitUnixProcess-uids-for-temporary.patch
meta-oe/recipes-extended/polkit/polkit/0001-backend-Compare-PolkitUnixProcess-uids-for-temporary.patch new file +186 -0
@@ -0,0 +1,186 @@ +From eb1f1336e8e49b4db6243b543e0a71f7c0c9b5b1 Mon Sep 17 00:00:00 2001 +From: Colin Walters <[email protected]> +Date: Fri, 4 Jan 2019 14:24:48 -0500 +Subject: [PATCH] backend: Compare PolkitUnixProcess uids for temporary + authorizations + +It turns out that the combination of `(pid, start time)` is not +enough to be unique. For temporary authorizations, we can avoid +separate users racing on pid reuse by simply comparing the uid. + +https://bugs.chromium.org/p/project-zero/issues/detail?id=1692 + +And the above original email report is included in full in a new comment. + +Reported-by: Jann Horn <[email protected]> + +Closes: https://gitlab.freedesktop.org/polkit/polkit/issues/75 + +Upstream-Status: Backport +CVE: CVE-2019-6133 +Signed-off-by: Chen Qi <[email protected]> +--- + src/polkit/polkitsubject.c | 2 + + src/polkit/polkitunixprocess.c | 71 +++++++++++++++++++++- + .../polkitbackendinteractiveauthority.c | 39 +++++++++++- + 3 files changed, 110 insertions(+), 2 deletions(-) + +diff --git a/src/polkit/polkitsubject.c b/src/polkit/polkitsubject.c +index d4c1182..ccabd0a 100644 +--- a/src/polkit/polkitsubject.c ++++ b/src/polkit/polkitsubject.c +@@ -99,6 +99,8 @@ polkit_subject_hash (PolkitSubject *subject) + * @b: A #PolkitSubject. + * + * Checks if @a and @b are equal, ie. represent the same subject. ++ * However, avoid calling polkit_subject_equal() to compare two processes; ++ * for more information see the `PolkitUnixProcess` documentation. + * + * This function can be used in e.g. g_hash_table_new(). + * +diff --git a/src/polkit/polkitunixprocess.c b/src/polkit/polkitunixprocess.c +index 972b777..7a6d48b 100644 +--- a/src/polkit/polkitunixprocess.c ++++ b/src/polkit/polkitunixprocess.c +@@ -51,7 +51,10 @@ + * @title: PolkitUnixProcess + * @short_description: Unix processs + * +- * An object for representing a UNIX process. ++ * An object for representing a UNIX process. NOTE: This object as ++ * designed is now known broken; a mechanism to exploit a delay in ++ * start time in the Linux kernel was identified. Avoid ++ * calling polkit_subject_equal() to compare two processes. + * + * To uniquely identify processes, both the process id and the start + * time of the process (a monotonic increasing value representing the +@@ -66,6 +69,72 @@ + * polkit_unix_process_new_for_owner() with trusted data. + */ + ++/* See https://gitlab.freedesktop.org/polkit/polkit/issues/75 ++ ++ But quoting the original email in full here to ensure it's preserved: ++ ++ From: Jann Horn <[email protected]> ++ Subject: [SECURITY] polkit: temporary auth hijacking via PID reuse and non-atomic fork ++ Date: Wednesday, October 10, 2018 5:34 PM ++ ++When a (non-root) user attempts to e.g. control systemd units in the system ++instance from an active session over DBus, the access is gated by a polkit ++policy that requires "auth_admin_keep" auth. This results in an auth prompt ++being shown to the user, asking the user to confirm the action by entering the ++password of an administrator account. ++ ++After the action has been confirmed, the auth decision for "auth_admin_keep" is ++cached for up to five minutes. Subject to some restrictions, similar actions can ++then be performed in this timespan without requiring re-auth: ++ ++ - The PID of the DBus client requesting the new action must match the PID of ++ the DBus client requesting the old action (based on SO_PEERCRED information ++ forwarded by the DBus daemon). ++ - The "start time" of the client's PID (as seen in /proc/$pid/stat, field 22) ++ must not have changed. The granularity of this timestamp is in the ++ millisecond range. ++ - polkit polls every two seconds whether a process with the expected start time ++ still exists. If not, the temporary auth entry is purged. ++ ++Without the start time check, this would obviously be buggy because an attacker ++could simply wait for the legitimate client to disappear, then create a new ++client with the same PID. ++ ++Unfortunately, the start time check is bypassable because fork() is not atomic. ++Looking at the source code of copy_process() in the kernel: ++ ++ p->start_time = ktime_get_ns(); ++ p->real_start_time = ktime_get_boot_ns(); ++ [...] ++ retval = copy_thread_tls(clone_flags, stack_start, stack_size, p, tls); ++ if (retval) ++ goto bad_fork_cleanup_io; ++ ++ if (pid != &init_struct_pid) { ++ pid = alloc_pid(p->nsproxy->pid_ns_for_children); ++ if (IS_ERR(pid)) { ++ retval = PTR_ERR(pid); ++ goto bad_fork_cleanup_thread; ++ } ++ } ++ ++The ktime_get_boot_ns() call is where the "start time" of the process is ++recorded. The alloc_pid() call is where a free PID is allocated. In between ++these, some time passes; and because the copy_thread_tls() call between them can ++access userspace memory when sys_clone() is invoked through the 32-bit syscall ++entry point, an attacker can even stall the kernel arbitrarily long at this ++point (by supplying a pointer into userspace memory that is associated with a ++userfaultfd or is backed by a custom FUSE filesystem). ++ ++This means that an attacker can immediately call sys_clone() when the victim ++process is created, often resulting in a process that has the exact same start ++time reported in procfs; and then the attacker can delay the alloc_pid() call ++until after the victim process has died and the PID assignment has cycled ++around. This results in an attacker process that polkit can't distinguish from ++the victim process. ++*/ ++ ++ + /** + * PolkitUnixProcess: + * +diff --git a/src/polkitbackend/polkitbackendinteractiveauthority.c b/src/polkitbackend/polkitbackendinteractiveauthority.c +index de3f752..098d343 100644 +--- a/src/polkitbackend/polkitbackendinteractiveauthority.c ++++ b/src/polkitbackend/polkitbackendinteractiveauthority.c +@@ -3035,6 +3035,43 @@ temporary_authorization_store_free (TemporaryAuthorizationStore *store) + g_free (store); + } + ++/* See the comment at the top of polkitunixprocess.c */ ++static gboolean ++subject_equal_for_authz (PolkitSubject *a, ++ PolkitSubject *b) ++{ ++ if (!polkit_subject_equal (a, b)) ++ return FALSE; ++ ++ /* Now special case unix processes, as we want to protect against ++ * pid reuse by including the UID. ++ */ ++ if (POLKIT_IS_UNIX_PROCESS (a) && POLKIT_IS_UNIX_PROCESS (b)) { ++ PolkitUnixProcess *ap = (PolkitUnixProcess*)a; ++ int uid_a = polkit_unix_process_get_uid ((PolkitUnixProcess*)a); ++ PolkitUnixProcess *bp = (PolkitUnixProcess*)b; ++ int uid_b = polkit_unix_process_get_uid ((PolkitUnixProcess*)b); ++ ++ if (uid_a != -1 && uid_b != -1) ++ { ++ if (uid_a == uid_b) ++ { ++ return TRUE; ++ } ++ else ++ { ++ g_printerr ("denying slowfork; pid %d uid %d != %d!\n", ++ polkit_unix_process_get_pid (ap), ++ uid_a, uid_b); ++ return FALSE; ++ } ++ } ++ /* Fall through; one of the uids is unset so we can't reliably compare */ ++ } ++ ++ return TRUE; ++} ++ + static gboolean + temporary_authorization_store_has_authorization (TemporaryAuthorizationStore *store, + PolkitSubject *subject, +@@ -3077,7 +3114,7 @@ temporary_authorization_store_has_authorization (TemporaryAuthorizationStore *st + TemporaryAuthorization *authorization = l->data; + + if (strcmp (action_id, authorization->action_id) == 0 && +- polkit_subject_equal (subject_to_use, authorization->subject)) ++ subject_equal_for_authz (subject_to_use, authorization->subject)) + { + ret = TRUE; + if (out_tmp_authz_id != NULL)
meta-oe/recipes-extended/polkit/polkit_0.115.bb +4 -3
@@ -23,9 +23,10 @@ PACKAGECONFIG[consolekit] = ",,,consolekit" PAM_SRC_URI = "file://polkit-1_pam.patch" SRC_URI = "http://www.freedesktop.org/software/polkit/releases/polkit-${PV}.tar.gz \ - file://0001-make-netgroup-support-configurable.patch \ - ${@bb.utils.contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)} \ -" + file://0001-make-netgroup-support-configurable.patch \ + ${@bb.utils.contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)} \ + file://0001-backend-Compare-PolkitUnixProcess-uids-for-temporary.patch \ + " SRC_URI[md5sum] = "f03b055d6ae5fc8eac76838c7d83d082" SRC_URI[sha256sum] = "2f87ecdabfbd415c6306673ceadc59846f059b18ef2fce42bac63fe283f12131"
Signature · 1 line
2.7.4
PATCH 17/23 mariadb: Upgrade to 10.3.15
In reply to Armin KusterFrom: Mingli Yu <[email protected]>
Fixes for the following security vulnerabilities:
CVE-2019-2614
CVE-2019-2627
CVE-2019-2628
---
.../mysql/{mariadb-native_10.3.13.bb => mariadb-native_10.3.15.bb} | 0
meta-oe/recipes-dbs/mysql/mariadb.inc | 4 ++--
meta-oe/recipes-dbs/mysql/{mariadb_10.3.13.bb => mariadb_10.3.15.bb} | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename meta-oe/recipes-dbs/mysql/{mariadb-native_10.3.13.bb => mariadb-native_10.3.15.bb} (100%)
rename meta-oe/recipes-dbs/mysql/{mariadb_10.3.13.bb => mariadb_10.3.15.bb} (100%)meta-oe/recipes-dbs/mysql/mariadb-native_10.3.15.bb renamed from meta-oe/recipes-dbs/mysql/mariadb-native_10.3.13.bb +0 -0
meta-oe/recipes-dbs/mysql/mariadb.inc +2 -2
@@ -19,8 +19,8 @@ SRC_URI = "https://downloads.mariadb.org/interstitial/${BPN}-${PV}/source/${BPN} file://clang_version_header_conflict.patch \ file://fix-arm-atomic.patch \ " -SRC_URI[md5sum] = "603ce42e35b9a688f2cca05275acb5cb" -SRC_URI[sha256sum] = "b2aa857ef5b84f85a7ea60a1eac7b34c0ca5151c71a0d44ce2d7fb028d71459a" +SRC_URI[md5sum] = "08edd8b5060a181e6dd3c6aac23218cd" +SRC_URI[sha256sum] = "27f391a54d544f93850d4edfb3ef1b4cf24f8e27e61e51727b0e7d31bb4d6968" UPSTREAM_CHECK_URI = "https://github.com/MariaDB/server/releases"
meta-oe/recipes-dbs/mysql/mariadb_10.3.15.bb renamed from meta-oe/recipes-dbs/mysql/mariadb_10.3.13.bb +0 -0
Signature · 1 line
2.7.4
PATCH 18/23 libmikmod: fix SRC_URI
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* it was moved to outdated_versions directory
--- meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb +1 -1
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c" DEPENDS = "alsa-lib texinfo" SRC_URI = "\ - ${SOURCEFORGE_MIRROR}/project/mikmod/${BPN}/${PV}/${BPN}-${PV}.tar.gz \ + ${SOURCEFORGE_MIRROR}/project/mikmod/outdated_versions/${BPN}/${PV}/${BPN}-${PV}.tar.gz \ " SRC_URI[md5sum] = "9dd9bed30c6f7607a55480234606071b" SRC_URI[sha256sum] = "3f363e03f7b1db75b9b6602841bbd440ed275a548e53545f980df8155de4d330"
Signature · 1 line
2.7.4
PATCH 19/23 leptonica: fix SRC_URI
In reply to Armin KusterFrom: Martin Jansa <[email protected]>
* leptonica.com now only redirects to www.leptonica.org, so it only downloads the HTML home page instead of the source tarball
--- meta-oe/recipes-graphics/leptonica/leptonica_1.74.4.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-graphics/leptonica/leptonica_1.74.4.bb +1 -1
@@ -3,7 +3,7 @@ DEPENDS = "jpeg tiff libpng zlib" LICENSE = "BSD-2-Clause" LIC_FILES_CHKSUM = "file://leptonica-license.txt;md5=34aa579294e8284b7b848c8d5d361e8f" -SRC_URI = "http://leptonica.com/source/leptonica-${PV}.tar.gz" +SRC_URI = "http://www.leptonica.org/source/leptonica-${PV}.tar.gz" SRC_URI[md5sum] = "4f32be9bd2e2c142ba018037ab5d746f" SRC_URI[sha256sum] = "29c35426a416bf454413c6fec24c24a0b633e26144a17e98351b6dffaa4a833b"
Signature · 1 line
2.7.4
PATCH 20/23 crash: do not use unstable github archive tarballs
In reply to Armin KusterFrom: Hongxu Jia <[email protected]>
Since commit [21f84fc insane: add sanity checks to SRC_URI] applied in oe-core, do not use unstable github archive tarballs
--- meta-oe/recipes-kernel/crash/crash_7.2.5.bb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
meta-oe/recipes-kernel/crash/crash_7.2.5.bb +4 -4
@@ -12,8 +12,9 @@ LIC_FILES_CHKSUM = "file://COPYING3;md5=d32239bcb673463ab874e80d47fae504" DEPENDS = "zlib readline coreutils-native" -SRC_URI = "https://github.com/crash-utility/${BPN}/archive/${PV}.tar.gz;downloadfilename=${BP}.tar.gz \ - http://ftp.gnu.org/gnu/gdb/gdb-7.6.tar.gz;name=gdb;subdir=${BP} \ +S = "${WORKDIR}/git" +SRC_URI = "git://github.com/crash-utility/${BPN}.git \ + http://ftp.gnu.org/gnu/gdb/gdb-7.6.tar.gz;name=gdb;subdir=git \ file://7001force_define_architecture.patch \ file://7003cross_ranlib.patch \ file://0001-cross_add_configure_option.patch \
@@ -25,8 +26,7 @@ SRC_URI = "https://github.com/crash-utility/${BPN}/archive/${PV}.tar.gz;download file://0002-crash-fix-build-error-unknown-type-name-gdb_fpregset.patch \ file://0003-crash-detect-the-sysroot-s-glibc-header-file.patch \ " -SRC_URI[md5sum] = "3f6e18d38821bb326700f1d6d43bcaec" -SRC_URI[sha256sum] = "114a83ca27c91e4321f6399d637a9d2270f72b9327e56d687c5fb139e903069b" +SRCREV = "c0a2fc9d322cf0c5f569ce54e9201d2f586edb0c" SRC_URI[gdb.md5sum] = "a9836707337e5f7bf76a009a8904f470" SRC_URI[gdb.sha256sum] = "8070389a5dcc104eb0be483d582729f98ed4d761ad19cedd3f17b5d2502faa36"
Signature · 1 line
2.7.4
PATCH 21/23 uthash: do not use unstable github archive tarballs
In reply to Armin KusterFrom: nick83ola <[email protected]>
Since commit [21f84fc insane: add sanity checks to SRC_URI] applied in oe-core, do not use unstable github archive tarballs.
--- meta-oe/recipes-support/uthash/uthash_2.1.0.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
meta-oe/recipes-support/uthash/uthash_2.1.0.bb +3 -4
@@ -9,15 +9,14 @@ HOMEPAGE = "https://troydhanson.github.io/uthash/" SECTION = "base" LICENSE = "BSD-1-Clause" LIC_FILES_CHKSUM = "file://LICENSE;md5=a2513f7d2291df840527b76b2a8f9718" +SRCREV = "8b214aefcb81df86a7e5e0d4fa20e59a6c18bc02" SRC_URI = "\ - https://github.com/troydhanson/${BPN}/archive/v${PV}.tar.gz;downloadfilename=${BP}.tar.gz \ + git://github.com/troydhanson/${BPN}.git \ file://run-ptest \ " -UPSTREAM_CHECK_URI = "https://github.com/troydhanson/${BPN}/releases" -SRC_URI[md5sum] = "4d0a33f6393260926032f1fad4bad39a" -SRC_URI[sha256sum] = "152ccd8e64d0f495377232e3964d06c7ec8bb8c3fbd3217f8a5702614f9a669e" +S = "${WORKDIR}/git" inherit ptest
Signature · 1 line
2.7.4
PATCH 22/23 netkit-telnet: add rconflicts
In reply to Armin KusterFrom: Changqing Li <[email protected]>
fix below error:
file /etc/xinetd.d/telnet conflicts between attempted installs of netkit-telnet-0.17-r0.i586 and inetutils-telnetd-1.9.4-r0.i586 file /usr/sbin/in.telnetd conflicts between attempted installs of netkit-telnet-0.17-r0.i586 and inetutils-telnetd-1.9.4-r0.i586
--- meta-networking/recipes-netkit/netkit-telnet/netkit-telnet_0.17.bb | 1 + 1 file changed, 1 insertion(+)
meta-networking/recipes-netkit/netkit-telnet/netkit-telnet_0.17.bb +1 -0
@@ -63,3 +63,4 @@ FILES_${PN} += "${sbindir}/in.* ${libdir}/* ${sysconfdir}/xinetd.d/*" # http://errors.yoctoproject.org/Errors/Details/186954/ EXCLUDE_FROM_WORLD_libc-musl = "1" +RCONFLICTS_${PN} = "inetutils-telnetd"
Signature · 1 line
2.7.4
PATCH 23/23 turbostat: copy bits.h from kernel to turbostat
In reply to Armin KusterFrom: Liwei Song <[email protected]>
because bits.h was included in msr-index.h, so we also need copy bits.h from kernel to tubostat to aviod compile error.
--- meta-oe/recipes-kernel/turbostat/turbostat_3.4.bb | 2 ++ 1 file changed, 2 insertions(+)
meta-oe/recipes-kernel/turbostat/turbostat_3.4.bb +2 -0
@@ -41,11 +41,13 @@ do_configure_prepend() { mkdir -p ${S} cp -r ${STAGING_KERNEL_DIR}/arch/x86/include/asm/msr-index.h ${S} cp -r ${STAGING_KERNEL_DIR}/arch/x86/include/asm/intel-family.h ${S} + cp -r ${STAGING_KERNEL_DIR}/include/linux/bits.h ${S} cp -r ${STAGING_KERNEL_DIR}/tools/power/x86/turbostat/* ${S} cp -r ${WORKDIR}/COPYING ${S} } do_compile() { + sed -i 's#<linux/bits.h>#"bits.h"#' msr-index.h sed -i 's#MSRHEADER#"msr-index.h"#' turbostat.c sed -i 's#INTEL_FAMILY_HEADER#"intel-family.h"#' turbostat.c sed -i 's#\$(CC) \$(CFLAGS) \$< -o \$(BUILD_OUTPUT)/\$@#\$(CC) \$(CFLAGS) \$(LDFLAGS) \$< -o \$(BUILD_OUTPUT)/\$@#' Makefile
Signature · 1 line
2.7.4
sorry, cut and paste error in email adder.
- armin
Quoted 97 lines · Armin Kuster
Most of these where back port requests so I am giving a short review window. Commnets by Sunday.
The following changes since commit
21cbe3ec166696b4d67d2ef5486a394d14d29269:aufs-util: prevent native aufs-util depending on target kernel (2019-05-18 07:38:39 -0700)
are available in the git repository at:
https://git.openembedded.org/meta-openembedded-contrib stable/warrior-nmut
http://cgit.openembedded.org//log/?h=stable/warrior-nmutChangqing Li (1):
netkit-telnet: add rconflictsHongxu Jia (1):
crash: do not use unstable github archive tarballsLiwei Song (1):
turbostat: copybits.hfrom kernel to turbostatMartin Jansa (16):
gtkwave: adddistro_features_check
ndctl: makeMACHINE_ARCHand ignore from libblockdev
oprofile: makeMACHINE_ARCH
umip: makeMACHINE_ARCH
mscgen: fixSRC_URIfor multilib
triggerhappy: fix issues python-cassandra-driver.inc: fix DEPENDS
opencv: use the same package name in PACKAGES and RDEPENDS
igmpproxy: remove0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch and _GNU_SOURCElibvncserver: set PV in the recipe
ccid: fixSRC_URI
ne10, libopus: add armv7ve override as well
hunspell: use git fetcher instead of github archive ttf-mplus, ttf-vlgothic: add ttf-mplus license
libmikmod: fixSRC_URI
leptonica: fixSRC_URIMingli Yu (1):
mariadb: Upgrade to 10.3.15[email protected] (1):
polkit: fix CVE-2019-6133Scott Ellis (1):
wireguard: Upgrade 20190123 -> 20190406nick83ola (1):
uthash: do not use unstable github archive tarballs.../recipes-connectivity/umip/umip_1.0.bb | 3 + ...xy.h-Include-sys-types.h-for-u_short-u_in.patch | 25 --- .../recipes-daemons/igmpproxy/igmpproxy_0.2.1.bb | 6 +- ...0190123.bb => wireguard-module_0.0.20190406.bb} | 0 ...20190123.bb => wireguard-tools_0.0.20190406.bb} | 0 .../recipes-kernel/wireguard/wireguard.inc | 4 +- .../netkit-telnet/netkit-telnet_0.17.bb | 1 + meta-oe/conf/layer.conf | 6 + meta-oe/licenses/ttf-mplus | 16 ++ meta-oe/recipes-core/ndctl/ndctl_v63.bb | 3 + .../packagegroups/packagegroup-meta-oe.bb | 3 +- ...native_10.3.13.bb => mariadb-native_10.3.15.bb} | 0 meta-oe/recipes-dbs/mysql/mariadb.inc | 4 +- .../{mariadb_10.3.13.bb => mariadb_10.3.15.bb} | 0 ...pare-PolkitUnixProcess-uids-for-temporary.patch | 186 +++++++++++++++++++++ meta-oe/recipes-extended/polkit/polkit_0.115.bb | 7 +- .../{triggerhappy_0.5.0.bb => triggerhappy_git.bb} | 22 +-- meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 + .../recipes-graphics/leptonica/leptonica_1.74.4.bb | 2 +- .../libvncserver/libvncserver_git.bb | 2 +- .../recipes-graphics/ttf-fonts/ttf-mplus_027.bb | 2 +- .../ttf-fonts/ttf-vlgothic_20141206.bb | 2 +- meta-oe/recipes-kernel/crash/crash_7.2.5.bb | 8 +- meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb | 3 + meta-oe/recipes-kernel/turbostat/turbostat_3.4.bb | 2 + .../recipes-multimedia/libopus/libopus_1.1.3.bb | 3 +- .../recipes-multimedia/mikmod/libmikmod_3.3.6.bb | 2 +- meta-oe/recipes-support/ccid/ccid_1.4.24.bb | 4 +- meta-oe/recipes-support/hunspell/hunspell_1.7.0.bb | 7 +- meta-oe/recipes-support/mscgen/mscgen_0.20.bb | 2 +- meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 +- meta-oe/recipes-support/opencv/opencv_3.4.5.bb | 2 +- meta-oe/recipes-support/uthash/uthash_2.1.0.bb | 7 +- .../python/python-cassandra-driver.inc | 2 +- 34 files changed, 272 insertions(+), 72 deletions(-) delete mode 100644 meta-networking/recipes-daemons/igmpproxy/igmpproxy/0001-src-igmpproxy.h-Include-sys-types.h-for-u_short-u_in.patch rename meta-networking/recipes-kernel/wireguard/{wireguard-module_0.0.20190123.bb => wireguard-module_0.0.20190406.bb} (100%) rename meta-networking/recipes-kernel/wireguard/{wireguard-tools_0.0.20190123.bb => wireguard-tools_0.0.20190406.bb} (100%) create mode 100644 meta-oe/licenses/ttf-mplus rename meta-oe/recipes-dbs/mysql/{mariadb-native_10.3.13.bb => mariadb-native_10.3.15.bb} (100%) rename meta-oe/recipes-dbs/mysql/{mariadb_10.3.13.bb => mariadb_10.3.15.bb} (100%) create mode 100644 meta-oe/recipes-extended/polkit/polkit/0001-backend-Compare-PolkitUnixProcess-uids-for-temporary.patch rename meta-oe/recipes-extended/triggerhappy/{triggerhappy_0.5.0.bb => triggerhappy_git.bb} (73%)
Re: [Warror][ 12/23] wireguard: Upgrade 20190123 -> 20190406
In reply to Armin KusterSuch an upgrade from the upstream master branch is not appropriate for a stable series.
Backporting fixes for 5.1 might be an option, the compile error that was posted to the mailing list has a trivial upstream fix.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [Warror][ 03/23] oprofile: make MACHINE_ARCH
In reply to Armin KusterThis was already reverted in master, and the dependency on virtual/kernel removed instead.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [Warror][ 02/23] ndctl: make MACHINE_ARCH and ignore from libblockdev
In reply to Armin KusterQuoted 21 lines · Armin Kuster
...
meta-oe/conf/layer.conf +6
-0@@ -51,6 +51,12 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ phoronix-test-suite->php \ " +# Depends on ndctl (through nvdimm PACKAGECONFIG) which depends on MACHINE_ARCH kernel +# and making libblockdev MACHINE_ARCH is not an option as python3-blivet, udisks2, gvfs +# would be MACHINE_ARCH as well +SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ + libblockdev->ndctl \ +" # ttf.inc inherits fontcache which adds fontconfig-utils to RDEPENDS SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ terminus-font->fontconfig \meta-oe/recipes-core/ndctl/ndctl_v63.bb +0
-0
meta-oe/recipes-core/ndctl/ndctl_v63.bb S = "${WORKDIR}/git" · line 24
Quoted 7 lines
meta-oe/recipes-core/ndctl/ndctl_v63.bb +3
-0@@ -19,6 +19,9 @@ S = "${WORKDIR}/git" EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs" +# Depends on MACHINE_ARCH kernel +PACKAGE_ARCH = "${MACHINE_ARCH}" +
This looks like another case where the actual problem is an unnecessary DEPENDS on virtual/kernel, and the proper fix is to remove that instead.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [Warror][ 19/23] leptonica: fix SRC_URI
In reply to Armin KusterHi Armin,
Care to cherry-pick this fix also to Thud?
Thanks in advance.
--
Javier Viguera