Skip to contentSkip to conversation

gettext: avoid useless RPATH QA issue

PATCH In review Chen Qi 3 participants 4 messages Aug 27, 2019

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover gettext: avoid useless RPATH QA issue

*** BLURB HERE ***
The following changes since commit c17113f1e2e7bd8ab019169660718fab81df16fb:

quilt: added less to RDEPENDS list (2019-08-22 22:48:27 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/gettext-qa
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/gettext-qa

Chen Qi (1):
gettext: avoid useless RPATH QA issue

 meta/recipes-core/gettext/gettext_0.19.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 gettext: avoid useless RPATH QA issue

We are getting useless rpath QA error when enabling libunistring and msgcat-curses PACKAGECONFIG. Use chrpath to delete the redundant RPATH in binaries.

Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-core/gettext/gettext_0.19.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
meta/recipes-core/gettext/gettext_0.19.8.1.bb +10 -0
index 30121ad..4ce47a6 100644
@@ -118,6 +118,14 @@ FILES_gettext-runtime-doc = "${mandir}/man1/gettext.* \
 
 do_install_append() {
     rm -f ${D}${libdir}/preloadable_libintl.so
+    # remove useless rpath to avoid QA issue
+    useless_rpath_list="${D}${libdir}/gettext/urlget ${D}${libdir}/gettext/cldr-plurals \
+                        ${D}${libdir}/gettext/hostname ${D}${bindir}/recode-sr-latin"
+    for f in $useless_rpath_list; do
+	if [ -e $f ]; then
+	    chrpath -d $f
+	fi
+    done
 }
 
 do_install_append_class-native () {

@@ -163,6 +171,8 @@ do_install_ptest() {
         find ${D}${PTEST_PATH}/ -name "*.o" -exec rm {} \;
         chmod 0755 ${D}${PTEST_PATH}/tests/lang-vala ${D}${PTEST_PATH}/tests/plural-1 ${D}${PTEST_PATH}/tests/xgettext-tcl-4 \
                    ${D}${PTEST_PATH}/tests/xgettext-vala-1  ${D}${PTEST_PATH}/tests/xgettext-po-2
+        # avoid useless rpath
+        [ -e ${D}${PTEST_PATH}/src/cldr-plurals ] && chrpath -d ${D}${PTEST_PATH}/src/cldr-plurals
     fi
 }
Signature · 1 line
1.9.1
#2 lore raw
Quoted 41 lines · Chen Qi

We are getting useless rpath QA error when enabling libunistring and msgcat-curses PACKAGECONFIG. Use chrpath to delete the redundant RPATH in binaries.

Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-core/gettext/gettext_0.19.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
meta/recipes-core/gettext/gettext_0.19.8.1.bb +3 -0
index 30121ad..4ce47a6 100644
@@ -118,6 +118,14 @@ FILES_gettext-runtime-doc =
 "${mandir}/man1/gettext.* \
 
 do_install_append() {
     rm -f ${D}${libdir}/preloadable_libintl.so
+    # remove useless rpath to avoid QA issue
+    useless_rpath_list="${D}${libdir}/gettext/urlget
 ${D}${libdir}/gettext/cldr-plurals \
+                        ${D}${libdir}/gettext/hostname

${D}${bindir}/recode-sr-latin"

meta/recipes-core/gettext/gettext_0.19.8.1.bb +5 -0
+    for f in $useless_rpath_list; do
+	if [ -e $f ]; then
+	    chrpath -d $f
+	fi
+    done
 }
 
 do_install_append_class-native () {

@@ -163,6 +171,8 @@ do_install_ptest() {
         find ${D}${PTEST_PATH}/ -name "*.o" -exec rm {} \;
         chmod 0755 ${D}${PTEST_PATH}/tests/lang-vala

${D}${PTEST_PATH}/tests/plural-1 ${D}${PTEST_PATH}/tests/xgettext-

tcl-4 \
                    ${D}${PTEST_PATH}/tests/xgettext-vala-

1 ${D}${PTEST_PATH}/tests/xgettext-po-2

meta/recipes-core/gettext/gettext_0.19.8.1.bb +2 -0
+        # avoid useless rpath
+        [ -e ${D}${PTEST_PATH}/src/cldr-plurals ] && chrpath -d
Quoted 3 lines

${D}${PTEST_PATH}/src/cldr-plurals
fi
}

In general we try and fix the reason they're getting included in the first place as it means the compiler flags are incorrect. Any idea why that is happening and if we can fix it?

Cheers,

Richard

#3 lore raw

I also have to point out that a new release of gettext (0.20.x) has been out for a while now, so maybe it's better to upgrade to that first.

Alex

Quoted 62 lines · Richard Purdie
Quoted 41 lines · Chen Qi

We are getting useless rpath QA error when enabling libunistring and msgcat-curses PACKAGECONFIG. Use chrpath to delete the redundant RPATH in binaries.

Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-core/gettext/gettext_0.19.8.1.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
meta/recipes-core/gettext/gettext_0.19.8.1.bb +3 -0
index 30121ad..4ce47a6 100644
@@ -118,6 +118,14 @@ FILES_gettext-runtime-doc =
 "${mandir}/man1/gettext.* \
 
 do_install_append() {
     rm -f ${D}${libdir}/preloadable_libintl.so
+    # remove useless rpath to avoid QA issue
+    useless_rpath_list="${D}${libdir}/gettext/urlget
 ${D}${libdir}/gettext/cldr-plurals \
+                        ${D}${libdir}/gettext/hostname

${D}${bindir}/recode-sr-latin"

meta/recipes-core/gettext/gettext_0.19.8.1.bb +5 -0
+    for f in $useless_rpath_list; do
+     if [ -e $f ]; then
+         chrpath -d $f
+     fi
+    done
 }
 
 do_install_append_class-native () {

@@ -163,6 +171,8 @@ do_install_ptest() {
         find ${D}${PTEST_PATH}/ -name "*.o" -exec rm {} \;
         chmod 0755 ${D}${PTEST_PATH}/tests/lang-vala

${D}${PTEST_PATH}/tests/plural-1 ${D}${PTEST_PATH}/tests/xgettext-

tcl-4 \
                    ${D}${PTEST_PATH}/tests/xgettext-vala-

1 ${D}${PTEST_PATH}/tests/xgettext-po-2

meta/recipes-core/gettext/gettext_0.19.8.1.bb +2 -0
+        # avoid useless rpath
+        [ -e ${D}${PTEST_PATH}/src/cldr-plurals ] && chrpath -d
Quoted 3 lines

${D}${PTEST_PATH}/src/cldr-plurals
fi
}

In general we try and fix the reason they're getting included in the first place as it means the compiler flags are incorrect. Any idea why that is happening and if we can fix it?

Cheers,

Richard

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core