drm/print: add and use drm_debug_enabled()
Subsystems (9)
v2 cover drm/print: add and use drm_debug_enabled()
Hi all, v2 of [1], a little refactoring around drm_debug access to abstract it better. There shouldn't be any functional changes.
I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converted in drm-next.
BR,
Jani.
[1] http://mid.mail-archive.com/[email protected]
Jani Nikula (9):
drm/print: move drm_debug variable to drm_print.[ch] drm/print: add drm_debug_enabled()
drm/etnaviv: use drm_debug_enabled() to check for debug categories drm/i2c/sil164: use drm_debug_enabled() to check for debug categories drm/i915: use drm_debug_enabled() to check for debug categories drm/msm: use drm_debug_enabled() to check for debug categories drm/nouveau: use drm_debug_enabled() to check for debug categories drm/amdgpu: use drm_debug_enabled() to check for debug categories drm/print: rename drm_debug to __drm_debug to discourage use
drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++--- drivers/gpu/drm/drm_drv.c | 17 --------------- drivers/gpu/drm/drm_edid.c | 2 +- drivers/gpu/drm/drm_edid_load.c | 2 +- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- drivers/gpu/drm/drm_print.c | 23 ++++++++++++++++++-- drivers/gpu/drm/drm_vblank.c | 6 ++--- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 8 +++---- drivers/gpu/drm/i2c/sil164_drv.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_gem.h | 2 +- drivers/gpu/drm/i915/i915_utils.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++-- drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_drv.h | 4 ++-- include/drm/drm_drv.h | 2 -- include/drm/drm_print.h | 8 +++++++ 22 files changed, 60 insertions(+), 52 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 1/9 drm/print: move drm_debug variable to drm_print.[ch]
Move drm_debug variable declaration and definition to where they are relevant and needed. No functional changes.
--- drivers/gpu/drm/drm_drv.c | 17 ----------------- drivers/gpu/drm/drm_print.c | 19 +++++++++++++++++++ include/drm/drm_drv.h | 2 -- include/drm/drm_print.h | 2 ++ 4 files changed, 21 insertions(+), 19 deletions(-)
drivers/gpu/drm/drm_drv.c +0 -17
@@ -46,26 +46,9 @@#include "drm_internal.h" #include "drm_legacy.h" -/* -* drm_debug: Enable debug output. -* Bitmask of DRM_UT_x. See include/drm/drm_print.h for details. -*/ -unsigned int drm_debug =0 ; -EXPORT_SYMBOL (drm_debug); -MODULE_AUTHOR ("Gareth Hughes, Leif Delgass, José Fonseca, Jon Smirl" );MODULE_DESCRIPTION ("DRM shared core routines" );MODULE_LICENSE ("GPL and additional rights" ); -MODULE_PARM_DESC (debug,"Enable debug output, where each bit enables a debug category.\n" -"\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n" -"\t\tBit 1 (0x02) will enable DRIVER messages (drm controller code)\n" -"\t\tBit 2 (0x04) will enable KMS messages (modesetting code)\n" -"\t\tBit 3 (0x08) will enable PRIME messages (prime code)\n" -"\t\tBit 4 (0x10) will enable ATOMIC messages (atomic code)\n" -"\t\tBit 5 (0x20) will enable VBL messages (vblank code)\n" -"\t\tBit 7 (0x80) will enable LEASE messages (leasing code)\n" -"\t\tBit 8 (0x100) will enable DP messages (displayport code)" ); -module_param_named (debug, drm_debug, int,0600 );static DEFINE_SPINLOCK (drm_minor_lock);static struct idr drm_minors_idr;
drivers/gpu/drm/drm_print.c +19 -0
@@ -28,6 +28,7 @@#include <stdarg.h> #include <linux/io.h> +#include <linux/moduleparam.h> #include <linux/seq_file.h> #include <linux/slab.h>
@@ -35,6 +36,24 @@#include <drm/drm_drv.h> #include <drm/drm_print.h> +/* +* drm_debug: Enable debug output. +* Bitmask of DRM_UT_x. See include/drm/drm_print.h for details. +*/ +unsigned int drm_debug; +EXPORT_SYMBOL (drm_debug); + +MODULE_PARM_DESC (debug,"Enable debug output, where each bit enables a debug category.\n" +"\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n" +"\t\tBit 1 (0x02) will enable DRIVER messages (drm controller code)\n" +"\t\tBit 2 (0x04) will enable KMS messages (modesetting code)\n" +"\t\tBit 3 (0x08) will enable PRIME messages (prime code)\n" +"\t\tBit 4 (0x10) will enable ATOMIC messages (atomic code)\n" +"\t\tBit 5 (0x20) will enable VBL messages (vblank code)\n" +"\t\tBit 7 (0x80) will enable LEASE messages (leasing code)\n" +"\t\tBit 8 (0x100) will enable DP messages (displayport code)" ); +module_param_named (debug, drm_debug, int,0600 ); +void __drm_puts_coredump (struct drm_printer *p,const char *str) {struct drm_print_iterator *iterator = p->arg;
include/drm/drm_drv.h +0 -2
@@ -778,8 +778,6 @@ struct drm_driver {int dev_priv_size; }; -extern unsigned int drm_debug; -int drm_dev_init (struct drm_device *dev,struct drm_driver *driver,struct device *parent);
include/drm/drm_print.h +2 -0
@@ -34,6 +34,8 @@#include <drm/drm.h> +extern unsigned int drm_debug; +/** * DOC: print *
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/9 drm/print: add drm_debug_enabled()
In reply to Jani NikulaAdd helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes.
v2: Move unlikely() to drm_debug_enabled() (Eric)
--- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- drivers/gpu/drm/drm_edid.c | 2 +- drivers/gpu/drm/drm_edid_load.c | 2 +- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- drivers/gpu/drm/drm_print.c | 4 ++-- drivers/gpu/drm/drm_vblank.c | 6 +++--- include/drm/drm_print.h | 5 +++++ 8 files changed, 18 insertions(+), 13 deletions(-)
drivers/gpu/drm/drm_atomic_uapi.c +1 -1
@@ -1405,7 +1405,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, }else if (arg->flags &DRM_MODE_ATOMIC_NONBLOCK ) { ret =drm_atomic_nonblocking_commit (state); }else { -if (unlikely (drm_debug &DRM_UT_STATE )) +if (drm_debug_enabled (DRM_UT_STATE ))drm_atomic_print_state (state); ret =drm_atomic_commit (state);
drivers/gpu/drm/drm_dp_mst_topology.c +3 -3
@@ -1180,7 +1180,7 @@ static int drm_dp_mst_wait_tx_reply(struct drm_dp_mst_branch *mstb, } } out: -if (unlikely (ret == -EIO && drm_debug &DRM_UT_DP )) { +if (ret == -EIO &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);
@@ -2321,7 +2321,7 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, idx += tosend +1 ; ret =drm_dp_send_sideband_msg (mgr, up, chunk, idx); -if (unlikely (ret && drm_debug &DRM_UT_DP )) { +if (ret &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_printf (&p,"sideband msg failed to send\n" );
@@ -2388,7 +2388,7 @@ static void drm_dp_queue_down_tx(struct drm_dp_mst_topology_mgr *mgr,mutex_lock (&mgr->qlock);list_add_tail (&txmsg->next, &mgr->tx_msg_downq); -if (unlikely (drm_debug &DRM_UT_DP )) { +if (drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);
drivers/gpu/drm/drm_edid.c +1 -1
@@ -1651,7 +1651,7 @@ static void connector_bad_edid(struct drm_connector *connector, {int i; -if (connector->bad_edid_counter++ && !(drm_debug &DRM_UT_KMS )) +if (connector->bad_edid_counter++ && !drm_debug_enabled (DRM_UT_KMS ))return ; dev_warn(connector->dev->dev,
drivers/gpu/drm/drm_edid_load.c +1 -1
@@ -175,7 +175,7 @@ static void *edid_load(struct drm_connector *connector, const char *name,u8 *edid;int fwsize, builtin;int i, valid_extensions =0 ; -bool print_bad_edid = !connector->bad_edid_counter || (drm_debug &DRM_UT_KMS ); +bool print_bad_edid = !connector->bad_edid_counter ||drm_debug_enabled (DRM_UT_KMS ); builtin =match_string (generic_edid_name,GENERIC_EDIDS , name);if (builtin >=0 ) {
drivers/gpu/drm/drm_mipi_dbi.c +2 -2
@@ -783,7 +783,7 @@ static int mipi_dbi_spi1e_transfer(struct mipi_dbi *dbi, int dc,int i, ret;u8 *dst; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);
@@ -907,7 +907,7 @@ static int mipi_dbi_spi1_transfer(struct mipi_dbi *dbi, int dc, max_chunk = dbi->tx_buf9_len; dst16 = dbi->tx_buf9; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);
drivers/gpu/drm/drm_print.c +2 -2
@@ -264,7 +264,7 @@ void drm_dev_dbg(const struct device *dev, unsigned int category,struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);
@@ -287,7 +287,7 @@ void drm_dbg(unsigned int category, const char *format, ...)struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);
drivers/gpu/drm/drm_vblank.c +3 -3
@@ -332,7 +332,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)u64 vblank;unsigned long flags; -WARN_ONCE (drm_debug &DRM_UT_VBL && !dev->driver->get_vblank_timestamp, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !dev->driver->get_vblank_timestamp,"This function requires support for accurate vblank timestamps." );spin_lock_irqsave (&dev->vblank_time_lock, flags);
@@ -706,7 +706,7 @@ bool drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev,*/ *vblank_time =ktime_sub_ns (etime, delta_ns); -if ((drm_debug &DRM_UT_VBL ) ==0 ) +if (!drm_debug_enabled (DRM_UT_VBL ))return true; ts_etime =ktime_to_timespec64 (etime);
@@ -1352,7 +1352,7 @@ void drm_vblank_restore(struct drm_device *dev, unsigned int pipe)assert_spin_locked (&dev->vblank_time_lock); vblank = &dev->vblank[pipe]; -WARN_ONCE ((drm_debug &DRM_UT_VBL ) && !vblank->framedur_ns, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !vblank->framedur_ns,"Cannot compute missed vblanks without frame duration\n" ); framedur_ns = vblank->framedur_ns;
include/drm/drm_print.h +5 -0
@@ -294,6 +294,11 @@ static inline struct drm_printer drm_err_printer(const char *prefix)#define DRM_UT_LEASE 0x80#define DRM_UT_DP 0x100 +static inline bool drm_debug_enabled (unsigned int category) +{ +return unlikely (drm_debug & category); +} + __printf(3, 4)void drm_dev_printk (const struct device *dev,const char *level,const char *format, ...);
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 3/9 drm/etnaviv: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaAllow better abstraction of the drm_debug global variable in the future. No functional changes.
--- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_buffer.c +4 -4
@@ -326,7 +326,7 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,lockdep_assert_held (&gpu->lock); -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))etnaviv_buffer_dump (gpu, buffer,0 ,0x50 ); link_target = etnaviv_cmdbuf_get_va(cmdbuf,
@@ -459,13 +459,13 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,etnaviv_cmdbuf_get_va (buffer, &gpu->mmu_context->cmdbuf_mapping) + buffer->user_size - 4); -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_info ("stream link to 0x%08x @ 0x%08x %p\n" , return_target,etnaviv_cmdbuf_get_va (cmdbuf, &gpu->mmu_context->cmdbuf_mapping), cmdbuf->vaddr); -if (drm_debug &DRM_UT_DRIVER ) { +if (drm_debug_enabled (DRM_UT_DRIVER )) {print_hex_dump (KERN_INFO ,"cmd " ,DUMP_PREFIX_OFFSET ,16 ,4 , cmdbuf->vaddr, cmdbuf->size,0 );
@@ -484,6 +484,6 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,VIV_FE_LINK_HEADER_PREFETCH (link_dwords), link_target); -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))etnaviv_buffer_dump (gpu, buffer,0 ,0x50 ); }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/9 drm/i2c/sil164: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaAllow better abstraction of the drm_debug global variable in the future. No functional changes.
--- drivers/gpu/drm/i2c/sil164_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i2c/sil164_drv.c +1 -1
@@ -44,7 +44,7 @@ struct sil164_priv { ((struct sil164_priv *)to_encoder_slave(x)->slave_priv)#define sil164_dbg (client, format, ...) do { \ - if (drm_debug & DRM_UT_KMS) \ + if (drm_debug_enabled(DRM_UT_KMS)) \ dev_printk(KERN_DEBUG, &client->dev, \ "%s: " format, __func__, ## __VA_ARGS__); \ } while (0)
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 5/9 drm/i915: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaAllow better abstraction of the drm_debug global variable in the future. No functional changes.
--- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_gem.h | 2 +- drivers/gpu/drm/i915/i915_utils.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -2
@@ -12041,7 +12041,7 @@ static void intel_dump_infoframe(struct drm_i915_private *dev_priv, const union hdmi_infoframe *frame) { -if ((drm_debug &DRM_UT_KMS ) ==0 ) +if (!drm_debug_enabled (DRM_UT_KMS ))return ;hdmi_infoframe_log (KERN_DEBUG , dev_priv->drm.dev, frame);
@@ -12557,7 +12557,7 @@ pipe_config_infoframe_mismatch(struct drm_i915_private *dev_priv, const union hdmi_infoframe *b) {if (fastset) { -if ((drm_debug &DRM_UT_KMS ) ==0 ) +if (!drm_debug_enabled (DRM_UT_KMS ))return ;drm_dbg (DRM_UT_KMS ,"fastset mismatch in %s infoframe" , name);
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
@@ -1685,7 +1685,7 @@ static void intel_dp_print_rates(struct intel_dp *intel_dp) {char str[128 ];/* FIXME: too big for stack? */ -if ((drm_debug &DRM_UT_KMS ) ==0 ) +if (!drm_debug_enabled (DRM_UT_KMS ))return ; snprintf_int_array(str, sizeof(str),
drivers/gpu/drm/i915/i915_drv.c +1 -1
@@ -1455,7 +1455,7 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)static void i915_welcome_messages (struct drm_i915_private *dev_priv) { -if (drm_debug &DRM_UT_DRIVER ) { +if (drm_debug_enabled (DRM_UT_DRIVER )) {struct drm_printer p =drm_debug_printer ("i915 device info:" ); drm_printf(&p, "pciid=0x%04x rev=0x%02x platform=%s (subplatform=0x%x) gen=%i\n",
drivers/gpu/drm/i915/i915_gem.h +1 -1
@@ -34,7 +34,7 @@ struct drm_i915_private;#ifdef CONFIG_DRM_I915_DEBUG_GEM -#define GEM_SHOW_DEBUG () (drm_debug & DRM_UT_DRIVER) +#define GEM_SHOW_DEBUG () drm_debug_enabled(DRM_UT_DRIVER)#define GEM_BUG_ON (condition) do { if (unlikely((condition))) { \ pr_err("%s:%d GEM_BUG_ON(%s)\n", \
drivers/gpu/drm/i915/i915_utils.c +1 -1
@@ -23,7 +23,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,struct va_format vaf;va_list args; -if (is_debug && !(drm_debug &DRM_UT_DRIVER )) +if (is_debug && !drm_debug_enabled (DRM_UT_DRIVER ))return ;va_start (args, fmt);
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -5342,7 +5342,7 @@ skl_print_wm_changes(struct intel_atomic_state *state)struct intel_crtc *crtc;int i; -if ((drm_debug &DRM_UT_KMS ) ==0 ) +if (!drm_debug_enabled (DRM_UT_KMS ))return ; for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 6/9 drm/msm: use drm_debug_enabled() to check for debug categories
In reply to a message not in the archiveAllow better abstraction of the drm_debug global variable in the future. No functional changes.
v2: Move unlikely() to drm_debug_enabled()
--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h +2 -2
@@ -31,7 +31,7 @@*/ #define DPU_DEBUG (fmt, ...) \ do { \ - if (unlikely(drm_debug & DRM_UT_KMS)) \ + if (drm_debug_enabled(DRM_UT_KMS)) \ DRM_DEBUG(fmt, ##__VA_ARGS__); \ else \ pr_debug(fmt, ##__VA_ARGS__); \
@@ -43,7 +43,7 @@*/ #define DPU_DEBUG_DRIVER (fmt, ...) \ do { \ - if (unlikely(drm_debug & DRM_UT_DRIVER)) \ + if (drm_debug_enabled(DRM_UT_DRIVER)) \ DRM_ERROR(fmt, ##__VA_ARGS__); \ else \ pr_debug(fmt, ##__VA_ARGS__); \
Signature · 6 lines
2.20.1 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v2 7/9 drm/nouveau: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaAllow better abstraction of the drm_debug global variable in the future. No functional changes.
v2: move unlikely() to drm_debug_enabled()
--- drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_drv.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/nouveau/dispnv50/disp.h +2 -2
@@ -78,14 +78,14 @@ void evo_kick(u32 *, struct nv50_dmac *);#define evo_mthd (p, m, s) do { \ const u32 _m = (m), _s = (s); \ - if (drm_debug & DRM_UT_KMS) \ + if (drm_debug_enabled(DRM_UT_KMS)) \ pr_err("%04x %d %s\n", _m, _s, __func__); \ *((p)++) = ((_s << 18) | _m); \ } while(0)#define evo_data (p, d) do { \ const u32 _d = (d); \ - if (drm_debug & DRM_UT_KMS) \ + if (drm_debug_enabled(DRM_UT_KMS)) \ pr_err("\t%08x\n", _d); \ *((p)++) = _d; \ } while(0)
drivers/gpu/drm/nouveau/nouveau_drv.h +2 -2
@@ -248,11 +248,11 @@ void nouveau_drm_device_remove(struct drm_device *dev); #define NV_INFO(drm,f,a...) NV_PRINTK(info, &(drm)->client, f, ##a) #define NV_DEBUG(drm,f,a...) do { \ - if (unlikely(drm_debug & DRM_UT_DRIVER)) \ + if (drm_debug_enabled(DRM_UT_DRIVER)) \ NV_PRINTK(info, &(drm)->client, f, ##a); \ } while(0) #define NV_ATOMIC(drm,f,a...) do { \ - if (unlikely(drm_debug & DRM_UT_ATOMIC)) \ + if (drm_debug_enabled(DRM_UT_ATOMIC)) \ NV_PRINTK(info, &(drm)->client, f, ##a); \ } while(0)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 8/9 drm/amdgpu: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaAllow better abstraction of the drm_debug global variable in the future. No functional changes.
--- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c +2 -2
@@ -234,7 +234,7 @@ static uint32_t smu_v11_0_i2c_transmit(struct i2c_adapter *control,DRM_DEBUG_DRIVER ("I2C_Transmit(), address = %x, bytes = %d , data: " , (uint16_t )address, numbytes); -if (drm_debug &DRM_UT_DRIVER ) { +if (drm_debug_enabled (DRM_UT_DRIVER )) {print_hex_dump (KERN_INFO ,"data: " ,DUMP_PREFIX_NONE ,16 ,1 , data, numbytes, false); }
@@ -388,7 +388,7 @@ static uint32_t smu_v11_0_i2c_receive(struct i2c_adapter *control,DRM_DEBUG_DRIVER ("I2C_Receive(), address = %x, bytes = %d, data :" , (uint16_t )address, bytes_received); -if (drm_debug &DRM_UT_DRIVER ) { +if (drm_debug_enabled (DRM_UT_DRIVER )) {print_hex_dump (KERN_INFO ,"data: " ,DUMP_PREFIX_NONE ,16 ,1 , data, bytes_received, false); }
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 9/9 drm/print: rename drm_debug to __drm_debug to discourage use
In reply to Jani Nikuladrm_debug_enabled() is the way to check. __drm_debug is now reserved for drm print code only. No functional changes.
v2: Rebase on move unlikely() to drm_debug_enabled()
--- drivers/gpu/drm/drm_print.c | 8 ++++---- include/drm/drm_print.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-)
drivers/gpu/drm/drm_print.c +4 -4
@@ -37,11 +37,11 @@#include <drm/drm_print.h> /* -* drm_debug: Enable debug output. +* __drm_debug: Enable debug output. * Bitmask of DRM_UT_x. See include/drm/drm_print.h for details. */ -unsigned int drm_debug; -EXPORT_SYMBOL (drm_debug); +unsigned int __drm_debug; +EXPORT_SYMBOL (__drm_debug);MODULE_PARM_DESC (debug,"Enable debug output, where each bit enables a debug category.\n" "\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n"
@@ -52,7 +52,7 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat"\t\tBit 5 (0x20) will enable VBL messages (vblank code)\n" "\t\tBit 7 (0x80) will enable LEASE messages (leasing code)\n" "\t\tBit 8 (0x100) will enable DP messages (displayport code)"); -module_param_named (debug, drm_debug, int,0600 ); +module_param_named (debug, __drm_debug, int,0600 );void __drm_puts_coredump (struct drm_printer *p,const char *str) {
include/drm/drm_print.h +3 -2
@@ -34,7 +34,8 @@#include <drm/drm.h> -extern unsigned int drm_debug; +/* Do *not* use outside of drm_print.[ch]! */ +extern unsigned int __drm_debug;/** * DOC: print
@@ -296,7 +297,7 @@ static inline struct drm_printer drm_err_printer(const char *prefix)static inline bool drm_debug_enabled (unsigned int category) { -return unlikely (drm_debug & category); +return unlikely (__drm_debug & category); }__printf (3 ,4 )
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/print: add and use drm_debug_enabled() (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/print: add and use drm_debug_enabled() (rev2)
URL : https://patchwork.freedesktop.org/series/66656/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6948 -> Patchwork_14515
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/
Known issues
------------
Here are the changes found in Patchwork_14515 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@legacy-render:
- fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#111381])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/fi-icl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/fi-icl-u2/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([fdo#111407])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/fi-blb-e6850/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/fi-blb-e6850/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
Participating hosts (52 -> 43)
------------------------------
Additional (1): fi-icl-dsi
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-tgl-u2 fi-byt-squawks fi-bsw-cyan fi-cfl-8109u fi-icl-y fi-icl-guc fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6948 -> Patchwork_14515
CI-20190529: 20190529
CI_DRM_6948: 485ca160d8ffac7ffb5be5e76fa12ad46a7e5a19 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5201: 3c1633abec14679300d52eeaf9fb7b63e435e51e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14515: 491355cf518c01c2dc89e6f6a1966655a2e8d022 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
491355cf518c drm/print: rename drm_debug to __drm_debug to discourage use 2cbafa884368 drm/amdgpu: use drm_debug_enabled() to check for debug categories 4627d170b42c drm/nouveau: use drm_debug_enabled() to check for debug categories 21b92a4f5fb0 drm/msm: use drm_debug_enabled() to check for debug categories 8e098071f8b8 drm/i915: use drm_debug_enabled() to check for debug categories af5d21aa95a3 drm/i2c/sil164: use drm_debug_enabled() to check for debug categories 3e3a1a9db7a1 drm/etnaviv: use drm_debug_enabled() to check for debug categories 80e12eef48fc drm/print: add drm_debug_enabled()fd2a29e9424f drm/print: move drm_debug variable to drm_print.[ch]
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 8/9] drm/amdgpu: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaQuoted 9 lines · Jani Nikula
Allow better abstraction of the
drm_debugglobal variable in the future. No functional changes.Cc Alex Deucher <[email protected]>Cc Christian König <[email protected]>Cc David (ChunMing) Zhou <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Quoted 29 lines
--- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c +2
-3@@ -234,7 +234,7 @@ static uint32_t smu_v11_0_i2c_transmit(struct i2c_adapter *control,DRM_DEBUG_DRIVER ("I2C_Transmit(), address = %x, bytes = %d , data: " , (uint16_t )address, numbytes); -if (drm_debug &DRM_UT_DRIVER ) { +if (drm_debug_enabled (DRM_UT_DRIVER )) {print_hex_dump (KERN_INFO ,"data: " ,DUMP_PREFIX_NONE ,16 ,1 , data, numbytes, false); }@@ -388,7 +388,7 @@ static uint32_t smu_v11_0_i2c_receive(struct i2c_adapter *control,DRM_DEBUG_DRIVER ("I2C_Receive(), address = %x, bytes = %d, data :" , (uint16_t )address, bytes_received); -if (drm_debug &DRM_UT_DRIVER ) { +if (drm_debug_enabled (DRM_UT_DRIVER )) {print_hex_dump (KERN_INFO ,"data: " ,DUMP_PREFIX_NONE ,16 ,1 , data, bytes_received, false); } --2.20.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 1/9] drm/print: move drm_debug variable to drm_print.[ch]
In reply to Jani NikulaQuoted 5 lines · Jani Nikula
Move
drm_debugvariable declaration and definition to where they are relevant and needed. No functional changes.Signed-off-by Jani Nikula <[email protected]>
Quoted 104 lines
--- drivers/gpu/drm/drm_drv.c | 17 ----------------- drivers/gpu/drm/drm_print.c | 19 +++++++++++++++++++ include/drm/drm_drv.h | 2 -- include/drm/drm_print.h | 2 ++ 4 files changed, 21 insertions(+), 19 deletions(-)drivers/gpu/drm/drm_drv.c +0
-17@@ -46,26 +46,9 @@#include "drm_internal.h" #include "drm_legacy.h" -/* -* drm_debug: Enable debug output. -* Bitmask of DRM_UT_x. See include/drm/drm_print.h for details. -*/ -unsigned int drm_debug =0 ; -EXPORT_SYMBOL (drm_debug); -MODULE_AUTHOR ("Gareth Hughes, Leif Delgass, José Fonseca, Jon Smirl" );MODULE_DESCRIPTION ("DRM shared core routines" );MODULE_LICENSE ("GPL and additional rights" ); -MODULE_PARM_DESC (debug,"Enable debug output, where each bit enables a debug category.\n" -"\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n" -"\t\tBit 1 (0x02) will enable DRIVER messages (drm controller code)\n" -"\t\tBit 2 (0x04) will enable KMS messages (modesetting code)\n" -"\t\tBit 3 (0x08) will enable PRIME messages (prime code)\n" -"\t\tBit 4 (0x10) will enable ATOMIC messages (atomic code)\n" -"\t\tBit 5 (0x20) will enable VBL messages (vblank code)\n" -"\t\tBit 7 (0x80) will enable LEASE messages (leasing code)\n" -"\t\tBit 8 (0x100) will enable DP messages (displayport code)" ); -module_param_named (debug, drm_debug, int,0600 );static DEFINE_SPINLOCK (drm_minor_lock);static struct idr drm_minors_idr;drivers/gpu/drm/drm_print.c +19
-0@@ -28,6 +28,7 @@#include <stdarg.h> #include <linux/io.h> +#include <linux/moduleparam.h> #include <linux/seq_file.h> #include <linux/slab.h> @@ -35,6 +36,24 @@#include <drm/drm_drv.h> #include <drm/drm_print.h> +/* +* drm_debug: Enable debug output. +* Bitmask of DRM_UT_x. See include/drm/drm_print.h for details. +*/ +unsigned int drm_debug; +EXPORT_SYMBOL (drm_debug); + +MODULE_PARM_DESC (debug,"Enable debug output, where each bit enables a debug category.\n" +"\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n" +"\t\tBit 1 (0x02) will enable DRIVER messages (drm controller code)\n" +"\t\tBit 2 (0x04) will enable KMS messages (modesetting code)\n" +"\t\tBit 3 (0x08) will enable PRIME messages (prime code)\n" +"\t\tBit 4 (0x10) will enable ATOMIC messages (atomic code)\n" +"\t\tBit 5 (0x20) will enable VBL messages (vblank code)\n" +"\t\tBit 7 (0x80) will enable LEASE messages (leasing code)\n" +"\t\tBit 8 (0x100) will enable DP messages (displayport code)" ); +module_param_named (debug, drm_debug, int,0600 ); +void __drm_puts_coredump (struct drm_printer *p,const char *str) {struct drm_print_iterator *iterator = p->arg;include/drm/drm_drv.h +0
-2@@ -778,8 +778,6 @@ struct drm_driver {int dev_priv_size; }; -extern unsigned int drm_debug; -int drm_dev_init (struct drm_device *dev,struct drm_driver *driver,struct device *parent);include/drm/drm_print.h +2
-1@@ -34,6 +34,8 @@#include <drm/drm.h> +extern unsigned int drm_debug; +/** * DOC: print * -- 2.20.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/9] drm/print: add drm_debug_enabled()
In reply to Jani NikulaQuoted 7 lines · Jani Nikula
Add helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes.
v2: Move
unlikely()todrm_debug_enabled()(Eric)Signed-off-by Jani Nikula <[email protected]>
Quoted 175 lines
--- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- drivers/gpu/drm/drm_edid.c | 2 +- drivers/gpu/drm/drm_edid_load.c | 2 +- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- drivers/gpu/drm/drm_print.c | 4 ++-- drivers/gpu/drm/drm_vblank.c | 6 +++--- include/drm/drm_print.h | 5 +++++ 8 files changed, 18 insertions(+), 13 deletions(-)drivers/gpu/drm/drm_atomic_uapi.c +1
-1@@ -1405,7 +1405,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, }else if (arg->flags &DRM_MODE_ATOMIC_NONBLOCK ) { ret =drm_atomic_nonblocking_commit (state); }else { -if (unlikely (drm_debug &DRM_UT_STATE )) +if (drm_debug_enabled (DRM_UT_STATE ))drm_atomic_print_state (state); ret =drm_atomic_commit (state);drivers/gpu/drm/drm_dp_mst_topology.c +3
-3@@ -1180,7 +1180,7 @@ static int drm_dp_mst_wait_tx_reply(struct drm_dp_mst_branch *mstb, } } out: -if (unlikely (ret == -EIO && drm_debug &DRM_UT_DP )) { +if (ret == -EIO &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);@@ -2321,7 +2321,7 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, idx += tosend +1 ; ret =drm_dp_send_sideband_msg (mgr, up, chunk, idx); -if (unlikely (ret && drm_debug &DRM_UT_DP )) { +if (ret &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_printf (&p,"sideband msg failed to send\n" );@@ -2388,7 +2388,7 @@ static void drm_dp_queue_down_tx(struct drm_dp_mst_topology_mgr *mgr,mutex_lock (&mgr->qlock);list_add_tail (&txmsg->next, &mgr->tx_msg_downq); -if (unlikely (drm_debug &DRM_UT_DP )) { +if (drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);drivers/gpu/drm/drm_edid.c +1
-1@@ -1651,7 +1651,7 @@ static void connector_bad_edid(struct drm_connector *connector, {int i; -if (connector->bad_edid_counter++ && !(drm_debug &DRM_UT_KMS )) +if (connector->bad_edid_counter++ && !drm_debug_enabled (DRM_UT_KMS ))return ; dev_warn(connector->dev->dev,drivers/gpu/drm/drm_edid_load.c +1
-1@@ -175,7 +175,7 @@ static void *edid_load(struct drm_connector *connector, const char *name,u8 *edid;int fwsize, builtin;int i, valid_extensions =0 ; -bool print_bad_edid = !connector->bad_edid_counter || (drm_debug &DRM_UT_KMS ); +bool print_bad_edid = !connector->bad_edid_counter ||drm_debug_enabled (DRM_UT_KMS ); builtin =match_string (generic_edid_name,GENERIC_EDIDS , name);if (builtin >=0 ) {drivers/gpu/drm/drm_mipi_dbi.c +2
-2@@ -783,7 +783,7 @@ static int mipi_dbi_spi1e_transfer(struct mipi_dbi *dbi, int dc,int i, ret;u8 *dst; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);@@ -907,7 +907,7 @@ static int mipi_dbi_spi1_transfer(struct mipi_dbi *dbi, int dc, max_chunk = dbi->tx_buf9_len; dst16 = dbi->tx_buf9; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);drivers/gpu/drm/drm_print.c +2
-2@@ -264,7 +264,7 @@ void drm_dev_dbg(const struct device *dev, unsigned int category,struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);@@ -287,7 +287,7 @@ void drm_dbg(unsigned int category, const char *format, ...)struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);drivers/gpu/drm/drm_vblank.c +3
-3@@ -332,7 +332,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)u64 vblank;unsigned long flags; -WARN_ONCE (drm_debug &DRM_UT_VBL && !dev->driver->get_vblank_timestamp, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !dev->driver->get_vblank_timestamp,"This function requires support for accurate vblank timestamps." );spin_lock_irqsave (&dev->vblank_time_lock, flags);@@ -706,7 +706,7 @@ bool drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev,*/ *vblank_time =ktime_sub_ns (etime, delta_ns); -if ((drm_debug &DRM_UT_VBL ) ==0 ) +if (!drm_debug_enabled (DRM_UT_VBL ))return true; ts_etime =ktime_to_timespec64 (etime);@@ -1352,7 +1352,7 @@ void drm_vblank_restore(struct drm_device *dev, unsigned int pipe)assert_spin_locked (&dev->vblank_time_lock); vblank = &dev->vblank[pipe]; -WARN_ONCE ((drm_debug &DRM_UT_VBL ) && !vblank->framedur_ns, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !vblank->framedur_ns,"Cannot compute missed vblanks without frame duration\n" ); framedur_ns = vblank->framedur_ns;include/drm/drm_print.h +5
-1@@ -294,6 +294,11 @@ static inline struct drm_printer drm_err_printer(const char *prefix)#define DRM_UT_LEASE 0x80#define DRM_UT_DP 0x100 +static inline bool drm_debug_enabled (unsigned int category) +{ +return unlikely (drm_debug & category); +} + __printf(3, 4)void drm_dev_printk (const struct device *dev,const char *level,const char *format, ...); --2.20.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 9/9] drm/print: rename drm_debug to __drm_debug to discourage use
In reply to Jani NikulaQuoted 7 lines · Jani Nikula
drm_debug_enabled()is the way to check.__drm_debugis now reserved for drm print code only. No functional changes.v2: Rebase on move
unlikely()todrm_debug_enabled()Signed-off-by Jani Nikula <[email protected]>
Quoted 59 lines
--- drivers/gpu/drm/drm_print.c | 8 ++++---- include/drm/drm_print.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-)drivers/gpu/drm/drm_print.c +4
-4@@ -37,11 +37,11 @@#include <drm/drm_print.h> /* -* drm_debug: Enable debug output. +* __drm_debug: Enable debug output. * Bitmask of DRM_UT_x. See include/drm/drm_print.h for details. */ -unsigned int drm_debug; -EXPORT_SYMBOL (drm_debug); +unsigned int __drm_debug; +EXPORT_SYMBOL (__drm_debug);MODULE_PARM_DESC (debug,"Enable debug output, where each bit enables a debug category.\n" "\t\tBit 0 (0x01) will enable CORE messages (drm core code)\n"@@ -52,7 +52,7 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat"\t\tBit 5 (0x20) will enable VBL messages (vblank code)\n" "\t\tBit 7 (0x80) will enable LEASE messages (leasing code)\n" "\t\tBit 8 (0x100) will enable DP messages (displayport code)"); -module_param_named (debug, drm_debug, int,0600 ); +module_param_named (debug, __drm_debug, int,0600 );void __drm_puts_coredump (struct drm_printer *p,const char *str) {include/drm/drm_print.h +3
-3@@ -34,7 +34,8 @@#include <drm/drm.h> -extern unsigned int drm_debug; +/* Do *not* use outside of drm_print.[ch]! */ +extern unsigned int __drm_debug;/** * DOC: print @@ -296,7 +297,7 @@ static inline struct drm_printer drm_err_printer(const char *prefix)static inline bool drm_debug_enabled (unsigned int category) { -return unlikely (drm_debug & category); +return unlikely (__drm_debug & category); }__printf (3 ,4 ) --2.20.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 4/9] drm/i2c/sil164: use drm_debug_enabled() to check for debug categories
In reply to Jani NikulaQuoted 5 lines · Jani Nikula
Allow better abstraction of the
drm_debugglobal variable in the future. No functional changes.Cc Francisco Jerez <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Quoted 19 lines
--- drivers/gpu/drm/i2c/sil164_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i2c/sil164_drv.c +1
-1@@ -44,7 +44,7 @@ struct sil164_priv { ((struct sil164_priv *)to_encoder_slave(x)->slave_priv)#define sil164_dbg (client, format, ...) do { \ - if (drm_debug & DRM_UT_KMS) \ + if (drm_debug_enabled(DRM_UT_KMS)) \ dev_printk(KERN_DEBUG, &client->dev, \ "%s: " format, __func__, ## __VA_ARGS__); \ } while (0)Signature · 1 line
2.20.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✗ Fi.CI.IGT: failure for drm/print: add and use drm_debug_enabled() (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/print: add and use drm_debug_enabled() (rev2)
URL : https://patchwork.freedesktop.org/series/66656/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6948_full -> Patchwork_14515_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14515_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_14515_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14515_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3:
- shard-iclb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb1/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@gem_exec_balancer@bonded-slice}:
- shard-iclb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb1/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14515_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110841])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb1/igt@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +11 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#111325]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb1/igt@[email protected]
* igt@gem_mmap_gtt@hang:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#109677])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb7/igt@[email protected]
* igt@gem_partial_pwrite_pread@write-display:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([fdo#107713] / [fdo#109100])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb7/igt@[email protected]
* igt@i915_pm_rps@waitboost:
- shard-glk: [PASS][17] -> [FAIL][18] ([fdo#102250])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-glk3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-glk1/igt@[email protected]
* igt@kms_ccs@pipe-a-ccs-on-another-bo:
- shard-iclb: [PASS][19] -> [INCOMPLETE][20] ([fdo#107713])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb7/igt@[email protected]
* igt@kms_cursor_legacy@pipe-c-single-bo:
- shard-apl: [PASS][21] -> [INCOMPLETE][22] ([fdo#103927])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-apl2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-apl4/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][23] -> [FAIL][24] ([fdo#105363])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-glk9/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-glk1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-skl5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-skl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-apl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-apl1/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][33] -> [FAIL][34] ([fdo#99912])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-apl1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-apl1/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: [PASS][35] -> [INCOMPLETE][36] ([fdo#103665])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-kbl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-kbl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@vecs0-s3:
- shard-apl: [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-apl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-apl8/igt@[email protected]
- shard-skl: [INCOMPLETE][39] ([fdo#104108]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-skl9/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-skl1/igt@[email protected]
* igt@gem_ctx_switch@rcs0-heavy-queue:
- shard-iclb: [INCOMPLETE][41] ([fdo#107713]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb7/igt@[email protected]
* igt@gem_eio@reset-stress:
- shard-snb: [FAIL][43] ([fdo#109661]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-snb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-snb6/igt@[email protected]
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][45] ([fdo#111325]) -> [PASS][46] +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb8/igt@[email protected]
* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-apl: [INCOMPLETE][47] ([fdo#103927]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-apl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-apl7/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [DMESG-WARN][49] ([fdo#108686]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-apl8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-apl5/igt@[email protected]
* {igt@i915_pm_dc@dc5-dpms}:
- shard-iclb: [FAIL][51] ([fdo#111795 ]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb3/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][53] ([fdo#103540]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-hsw5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-hsw6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [FAIL][55] ([fdo#103167]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-slowdraw:
- shard-iclb: [INCOMPLETE][57] ([fdo#106978] / [fdo#107713]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb7/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: [INCOMPLETE][61] ([fdo#103665]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-kbl6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-kbl3/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [FAIL][63] ([fdo#110728]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-skl6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-skl3/igt@[email protected]
* igt@perf@short-reads:
- shard-skl: [FAIL][65] ([fdo#103183]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-skl9/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-skl1/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +14 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb8/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb1/igt@[email protected]
#### Warnings ####
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [SKIP][69] ([fdo#109276]) -> [FAIL][70] ([fdo#111330])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6948/shard-iclb6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/shard-iclb1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6948 -> Patchwork_14515
CI-20190529: 20190529
CI_DRM_6948: 485ca160d8ffac7ffb5be5e76fa12ad46a7e5a19 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5201: 3c1633abec14679300d52eeaf9fb7b63e435e51e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14515: 491355cf518c01c2dc89e6f6a1966655a2e8d022 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14515/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 28 lines · Jani Nikula
Hi all, v2 of [1], a little refactoring around
drm_debugaccess to abstract it better. There shouldn't be any functional changes.I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converted in drm-next.
BR,
Jani.Cc Eric Engestrom <[email protected]>Cc Alex Deucher <[email protected]>Cc Christian König <[email protected]>Cc David (ChunMing) Zhou <[email protected]>Cc Ben Skeggs <[email protected]>Cc Rob Clark <[email protected]>Cc Sean Paul <[email protected]>Cc Francisco Jerez <[email protected]>Cc Lucas Stach <[email protected]>Cc Russell King <[email protected]>Cc Christian Gmeiner <[email protected]>
Quoted 7 lines
[1] http://mid.mail-archive.com/[email protected]
Jani Nikula (9):
drm/print: movedrm_debugvariable to drm_print.[ch] drm/print: adddrm_debug_enabled()
drm/i915: usedrm_debug_enabled()to check for debug categories drm/print: renamedrm_debugto__drm_debugto discourage use
The above four patches are:
Did you check to make sure the unlikely() is propagated correctly outside the drm_debug_enabled() call?
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 37 lines · Eric Engestrom
Quoted 28 lines · Jani Nikula
Hi all, v2 of [1], a little refactoring around
drm_debugaccess to abstract it better. There shouldn't be any functional changes.I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converted in drm-next.
BR,
Jani.Cc Eric Engestrom <[email protected]>Cc Alex Deucher <[email protected]>Cc Christian König <[email protected]>Cc David (ChunMing) Zhou <[email protected]>Cc Ben Skeggs <[email protected]>Cc Rob Clark <[email protected]>Cc Sean Paul <[email protected]>Cc Francisco Jerez <[email protected]>Cc Lucas Stach <[email protected]>Cc Russell King <[email protected]>Cc Christian Gmeiner <[email protected]>Quoted 7 lines
[1] http://mid.mail-archive.com/[email protected]
Jani Nikula (9):
drm/print: movedrm_debugvariable to drm_print.[ch] drm/print: adddrm_debug_enabled()
drm/i915: usedrm_debug_enabled()to check for debug categories drm/print: renamedrm_debugto__drm_debugto discourage use
Quoted 5 lines
The above four patches are:
Reviewed-by Eric Engestrom <[email protected]>Did you check to make sure the
unlikely()is propagated correctly outside thedrm_debug_enabled()call?
I did now.
Having drm_debug_enabled() as a macro vs. as an inline function does not seem to make a difference, so I think the inline is clearly preferrable.
However, for example
unlikely(foo && drm_debug & DRM_UT_DP)
does produce code different from
(foo && drm_debug_enabled(DRM_UT_DP))
indicating that the unlikely() within drm_debug_enabled() does not propagate to the whole condition. It's possible to retain the same assembly output with
(unlikely(foo) && drm_debug_enabled(DRM_UT_DP))
but it's unclear to me whether this is really worth it, either readability or performance wise.
Thoughts?
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
Quoted 41 lines · Jani Nikula
Quoted 40 lines · Eric Engestrom
Quoted 28 lines · Jani Nikula
Hi all, v2 of [1], a little refactoring around
drm_debugaccess to abstract it better. There shouldn't be any functional changes.I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converted in drm-next.
BR,
Jani.Cc Eric Engestrom <[email protected]>Cc Alex Deucher <[email protected]>Cc Christian König <[email protected]>Cc David (ChunMing) Zhou <[email protected]>Cc Ben Skeggs <[email protected]>Cc Rob Clark <[email protected]>Cc Sean Paul <[email protected]>Cc Francisco Jerez <[email protected]>Cc Lucas Stach <[email protected]>Cc Russell King <[email protected]>Cc Christian Gmeiner <[email protected]>Quoted 7 lines
[1] http://mid.mail-archive.com/[email protected]
Jani Nikula (9):
drm/print: movedrm_debugvariable to drm_print.[ch] drm/print: adddrm_debug_enabled()
drm/i915: usedrm_debug_enabled()to check for debug categories drm/print: renamedrm_debugto__drm_debugto discourage useThe above four patches are:
Reviewed-by Eric Engestrom <[email protected]>
Quoted 7 lines
Quoted 2 lines
Did you check to make sure the
unlikely()is propagated correctly outside thedrm_debug_enabled()call?I did now.
Having
drm_debug_enabled()as a macro vs. as an inline function does not seem to make a difference, so I think the inline is clearly preferrable.
Agreed :)
Quoted 13 lines
However, for example
unlikely(foo && drm_debug & DRM_UT_DP)does produce code different from
(foo && drm_debug_enabled(DRM_UT_DP))indicating that the
unlikely()withindrm_debug_enabled()does not propagate to the whole condition. It's possible to retain the same assembly output with
Quoted 6 lines
(unlikely(foo) && drm_debug_enabled(DRM_UT_DP))but it's unclear to me whether this is really worth it, either readability or performance wise.
Thoughts?
That kind of code only happens 2 times, both in drivers/gpu/drm/drm_dp_mst_topology.c (in patch 2/9), right?
I think your suggestion is the right thing to do here:
- if (unlikely(ret && drm_debug & DRM_UT_DP)) {
+ if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
It doesn't really cost much in readability (especially compared to what it was before), and whether it's important performance wise I couldn't tell, but I think it's best to keep the code optimised as it was before unless there's a reason to drop it.
Lyude might know more since she wrote 2f015ec6eab69301fdcf5, if you want to ping her?
Quoted 7 lines
BR,
Jani.Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
PATCH v3 1/1 drm/print: add drm_debug_enabled()
In reply to Jani NikulaAdd helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes.
v2: Move unlikely() to drm_debug_enabled() (Eric)
v3: Keep unlikely() when combined with other conditions (Eric)
--- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- drivers/gpu/drm/drm_edid.c | 2 +- drivers/gpu/drm/drm_edid_load.c | 2 +- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- drivers/gpu/drm/drm_print.c | 4 ++-- drivers/gpu/drm/drm_vblank.c | 6 +++--- include/drm/drm_print.h | 5 +++++ 8 files changed, 18 insertions(+), 13 deletions(-)
drivers/gpu/drm/drm_atomic_uapi.c +1 -1
@@ -1405,7 +1405,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, }else if (arg->flags &DRM_MODE_ATOMIC_NONBLOCK ) { ret =drm_atomic_nonblocking_commit (state); }else { -if (unlikely (drm_debug &DRM_UT_STATE )) +if (drm_debug_enabled (DRM_UT_STATE ))drm_atomic_print_state (state); ret =drm_atomic_commit (state);
drivers/gpu/drm/drm_dp_mst_topology.c +3 -3
@@ -1179,7 +1179,7 @@ static int drm_dp_mst_wait_tx_reply(struct drm_dp_mst_branch *mstb, } } out: -if (unlikely (ret == -EIO && drm_debug &DRM_UT_DP )) { +if (unlikely (ret == -EIO ) &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);
@@ -2322,7 +2322,7 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, idx += tosend +1 ; ret =drm_dp_send_sideband_msg (mgr, up, chunk, idx); -if (unlikely (ret && drm_debug &DRM_UT_DP )) { +if (unlikely (ret) &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_printf (&p,"sideband msg failed to send\n" );
@@ -2389,7 +2389,7 @@ static void drm_dp_queue_down_tx(struct drm_dp_mst_topology_mgr *mgr,mutex_lock (&mgr->qlock);list_add_tail (&txmsg->next, &mgr->tx_msg_downq); -if (unlikely (drm_debug &DRM_UT_DP )) { +if (drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);
drivers/gpu/drm/drm_edid.c +1 -1
@@ -1651,7 +1651,7 @@ static void connector_bad_edid(struct drm_connector *connector, {int i; -if (connector->bad_edid_counter++ && !(drm_debug &DRM_UT_KMS )) +if (connector->bad_edid_counter++ && !drm_debug_enabled (DRM_UT_KMS ))return ; dev_warn(connector->dev->dev,
drivers/gpu/drm/drm_edid_load.c +1 -1
@@ -175,7 +175,7 @@ static void *edid_load(struct drm_connector *connector, const char *name,u8 *edid;int fwsize, builtin;int i, valid_extensions =0 ; -bool print_bad_edid = !connector->bad_edid_counter || (drm_debug &DRM_UT_KMS ); +bool print_bad_edid = !connector->bad_edid_counter ||drm_debug_enabled (DRM_UT_KMS ); builtin =match_string (generic_edid_name,GENERIC_EDIDS , name);if (builtin >=0 ) {
drivers/gpu/drm/drm_mipi_dbi.c +2 -2
@@ -783,7 +783,7 @@ static int mipi_dbi_spi1e_transfer(struct mipi_dbi *dbi, int dc,int i, ret;u8 *dst; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);
@@ -907,7 +907,7 @@ static int mipi_dbi_spi1_transfer(struct mipi_dbi *dbi, int dc, max_chunk = dbi->tx_buf9_len; dst16 = dbi->tx_buf9; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);
drivers/gpu/drm/drm_print.c +2 -2
@@ -262,7 +262,7 @@ void drm_dev_dbg(const struct device *dev, unsigned int category,struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);
@@ -285,7 +285,7 @@ void drm_dbg(unsigned int category, const char *format, ...)struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);
drivers/gpu/drm/drm_vblank.c +3 -3
@@ -332,7 +332,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)u64 vblank;unsigned long flags; -WARN_ONCE (drm_debug &DRM_UT_VBL && !dev->driver->get_vblank_timestamp, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !dev->driver->get_vblank_timestamp,"This function requires support for accurate vblank timestamps." );spin_lock_irqsave (&dev->vblank_time_lock, flags);
@@ -706,7 +706,7 @@ bool drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev,*/ *vblank_time =ktime_sub_ns (etime, delta_ns); -if ((drm_debug &DRM_UT_VBL ) ==0 ) +if (!drm_debug_enabled (DRM_UT_VBL ))return true; ts_etime =ktime_to_timespec64 (etime);
@@ -1352,7 +1352,7 @@ void drm_vblank_restore(struct drm_device *dev, unsigned int pipe)assert_spin_locked (&dev->vblank_time_lock); vblank = &dev->vblank[pipe]; -WARN_ONCE ((drm_debug &DRM_UT_VBL ) && !vblank->framedur_ns, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !vblank->framedur_ns,"Cannot compute missed vblanks without frame duration\n" ); framedur_ns = vblank->framedur_ns;
include/drm/drm_print.h +5 -0
@@ -293,6 +293,11 @@ static inline struct drm_printer drm_err_printer(const char *prefix)#define DRM_UT_LEASE 0x80#define DRM_UT_DP 0x100 +static inline bool drm_debug_enabled (unsigned int category) +{ +return unlikely (drm_debug & category); +} + __printf(3, 4)void drm_dev_printk (const struct device *dev,const char *level,const char *format, ...);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 80 lines · Eric Engestrom
Quoted 41 lines · Jani Nikula
Quoted 40 lines · Eric Engestrom
Quoted 28 lines · Jani Nikula
Hi all, v2 of [1], a little refactoring around
drm_debugaccess to abstract it better. There shouldn't be any functional changes.I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and converted in drm-next.
BR,
Jani.Cc Eric Engestrom <[email protected]>Cc Alex Deucher <[email protected]>Cc Christian König <[email protected]>Cc David (ChunMing) Zhou <[email protected]>Cc Ben Skeggs <[email protected]>Cc Rob Clark <[email protected]>Cc Sean Paul <[email protected]>Cc Francisco Jerez <[email protected]>Cc Lucas Stach <[email protected]>Cc Russell King <[email protected]>Cc Christian Gmeiner <[email protected]>Quoted 7 lines
[1] http://mid.mail-archive.com/[email protected]
Jani Nikula (9):
drm/print: movedrm_debugvariable to drm_print.[ch] drm/print: adddrm_debug_enabled()
drm/i915: usedrm_debug_enabled()to check for debug categories drm/print: renamedrm_debugto__drm_debugto discourage useThe above four patches are:
Reviewed-by Eric Engestrom <[email protected]>Quoted 7 lines
Quoted 2 lines
Did you check to make sure the
unlikely()is propagated correctly outside thedrm_debug_enabled()call?I did now.
Having
drm_debug_enabled()as a macro vs. as an inline function does not seem to make a difference, so I think the inline is clearly preferrable.Agreed :)
Quoted 13 lines
However, for example
unlikely(foo && drm_debug & DRM_UT_DP)does produce code different from
(foo && drm_debug_enabled(DRM_UT_DP))indicating that the
unlikely()withindrm_debug_enabled()does not propagate to the whole condition. It's possible to retain the same assembly output withQuoted 6 lines
(unlikely(foo) && drm_debug_enabled(DRM_UT_DP))but it's unclear to me whether this is really worth it, either readability or performance wise.
Thoughts?
That kind of code only happens 2 times, both in
drivers/gpu/drm/drm_dp_mst_topology.c(in patch 2/9), right?I think your suggestion is the right thing to do here:
(quoted diff) +1
-1- if (unlikely(ret && drm_debug & DRM_UT_DP)) { + if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
Quoted 7 lines
It doesn't really cost much in readability (especially compared to what it was before), and whether it's important performance wise I couldn't tell, but I think it's best to keep the code optimised as it was before unless there's a reason to drop it.
Lyude might know more since she wrote
2f015ec6eab69301fdcf5, if you want to ping her?
Just ended up sending the updated version with what you suggest and I agree with; pedantically the change should be a separate patch anyway.
Thanks for your inputs.
BR,
Jani.
Quoted 8 lines
Quoted 8 lines
BR,
Jani.Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Re: [PATCH v3] drm/print: add drm_debug_enabled()
In reply to Jani NikulaQuoted 8 lines · Jani Nikula
Add helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes.
v2: Move
unlikely()todrm_debug_enabled()(Eric)v3: Keep
unlikely()when combined with other conditions (Eric)Cc Eric Engestrom <[email protected]>
Quoted 177 lines
Acked-by Alex Deucher <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_atomic_uapi.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- drivers/gpu/drm/drm_edid.c | 2 +- drivers/gpu/drm/drm_edid_load.c | 2 +- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- drivers/gpu/drm/drm_print.c | 4 ++-- drivers/gpu/drm/drm_vblank.c | 6 +++--- include/drm/drm_print.h | 5 +++++ 8 files changed, 18 insertions(+), 13 deletions(-)drivers/gpu/drm/drm_atomic_uapi.c +1
-1@@ -1405,7 +1405,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, }else if (arg->flags &DRM_MODE_ATOMIC_NONBLOCK ) { ret =drm_atomic_nonblocking_commit (state); }else { -if (unlikely (drm_debug &DRM_UT_STATE )) +if (drm_debug_enabled (DRM_UT_STATE ))drm_atomic_print_state (state); ret =drm_atomic_commit (state);drivers/gpu/drm/drm_dp_mst_topology.c +3
-3@@ -1179,7 +1179,7 @@ static int drm_dp_mst_wait_tx_reply(struct drm_dp_mst_branch *mstb, } } out: -if (unlikely (ret == -EIO && drm_debug &DRM_UT_DP )) { +if (unlikely (ret == -EIO ) &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);@@ -2322,7 +2322,7 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, idx += tosend +1 ; ret =drm_dp_send_sideband_msg (mgr, up, chunk, idx); -if (unlikely (ret && drm_debug &DRM_UT_DP )) { +if (unlikely (ret) &&drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_printf (&p,"sideband msg failed to send\n" );@@ -2389,7 +2389,7 @@ static void drm_dp_queue_down_tx(struct drm_dp_mst_topology_mgr *mgr,mutex_lock (&mgr->qlock);list_add_tail (&txmsg->next, &mgr->tx_msg_downq); -if (unlikely (drm_debug &DRM_UT_DP )) { +if (drm_debug_enabled (DRM_UT_DP )) {struct drm_printer p =drm_debug_printer (DBG_PREFIX );drm_dp_mst_dump_sideband_msg_tx (&p, txmsg);drivers/gpu/drm/drm_edid.c +1
-1@@ -1651,7 +1651,7 @@ static void connector_bad_edid(struct drm_connector *connector, {int i; -if (connector->bad_edid_counter++ && !(drm_debug &DRM_UT_KMS )) +if (connector->bad_edid_counter++ && !drm_debug_enabled (DRM_UT_KMS ))return ; dev_warn(connector->dev->dev,drivers/gpu/drm/drm_edid_load.c +1
-1@@ -175,7 +175,7 @@ static void *edid_load(struct drm_connector *connector, const char *name,u8 *edid;int fwsize, builtin;int i, valid_extensions =0 ; -bool print_bad_edid = !connector->bad_edid_counter || (drm_debug &DRM_UT_KMS ); +bool print_bad_edid = !connector->bad_edid_counter ||drm_debug_enabled (DRM_UT_KMS ); builtin =match_string (generic_edid_name,GENERIC_EDIDS , name);if (builtin >=0 ) {drivers/gpu/drm/drm_mipi_dbi.c +2
-2@@ -783,7 +783,7 @@ static int mipi_dbi_spi1e_transfer(struct mipi_dbi *dbi, int dc,int i, ret;u8 *dst; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);@@ -907,7 +907,7 @@ static int mipi_dbi_spi1_transfer(struct mipi_dbi *dbi, int dc, max_chunk = dbi->tx_buf9_len; dst16 = dbi->tx_buf9; -if (drm_debug &DRM_UT_DRIVER ) +if (drm_debug_enabled (DRM_UT_DRIVER ))pr_debug ("[drm:%s] dc=%d, max_chunk=%zu, transfers:\n" , __func__, dc, max_chunk);drivers/gpu/drm/drm_print.c +2
-2@@ -262,7 +262,7 @@ void drm_dev_dbg(const struct device *dev, unsigned int category,struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);@@ -285,7 +285,7 @@ void drm_dbg(unsigned int category, const char *format, ...)struct va_format vaf;va_list args; -if (!(drm_debug & category)) +if (!drm_debug_enabled (category))return ;va_start (args, format);drivers/gpu/drm/drm_vblank.c +3
-3@@ -332,7 +332,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)u64 vblank;unsigned long flags; -WARN_ONCE (drm_debug &DRM_UT_VBL && !dev->driver->get_vblank_timestamp, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !dev->driver->get_vblank_timestamp,"This function requires support for accurate vblank timestamps." );spin_lock_irqsave (&dev->vblank_time_lock, flags);@@ -706,7 +706,7 @@ bool drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev,*/ *vblank_time =ktime_sub_ns (etime, delta_ns); -if ((drm_debug &DRM_UT_VBL ) ==0 ) +if (!drm_debug_enabled (DRM_UT_VBL ))return true; ts_etime =ktime_to_timespec64 (etime);@@ -1352,7 +1352,7 @@ void drm_vblank_restore(struct drm_device *dev, unsigned int pipe)assert_spin_locked (&dev->vblank_time_lock); vblank = &dev->vblank[pipe]; -WARN_ONCE ((drm_debug &DRM_UT_VBL ) && !vblank->framedur_ns, +WARN_ONCE (drm_debug_enabled (DRM_UT_VBL ) && !vblank->framedur_ns,"Cannot compute missed vblanks without frame duration\n" ); framedur_ns = vblank->framedur_ns;include/drm/drm_print.h +5
-0@@ -293,6 +293,11 @@ static inline struct drm_printer drm_err_printer(const char *prefix)#define DRM_UT_LEASE 0x80#define DRM_UT_DP 0x100 +static inline bool drm_debug_enabled (unsigned int category) +{ +return unlikely (drm_debug & category); +} + __printf(3, 4)void drm_dev_printk (const struct device *dev,const char *level,const char *format, ...);Signature · 1 line
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/print: add and use drm_debug_enabled() (rev3)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/print: add and use drm_debug_enabled() (rev3)
URL : https://patchwork.freedesktop.org/series/66656/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14611
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/index.html
Known issues
------------
Here are the changes found in Patchwork_14611 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@legacy-render:
- fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#111381])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-icl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-icl-u2/igt@[email protected]
* igt@i915_module_load@reload-no-display:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-icl-u3/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [PASS][5] -> [FAIL][6] ([fdo#103167])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-icl-u3/igt@[email protected]
- fi-blb-e6850: [INCOMPLETE][9] ([fdo#107718]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-blb-e6850/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-blb-e6850/igt@[email protected]
- {fi-tgl-u2}: [INCOMPLETE][11] ([fdo#111850]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-tgl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-tgl-u2/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-hsw-peppy/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-hsw-peppy/igt@[email protected]
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#111045] / [fdo#111096]) -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/fi-kbl-7500u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/fi-kbl-7500u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
Participating hosts (51 -> 45)
------------------------------
Additional (3): fi-cml-h fi-apl-guc fi-pnv-d510
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6985 -> Patchwork_14611
CI-20190529: 20190529
CI_DRM_6985: 75d23ba38b952a5f3d0fc42baf1df2d15c5e74b1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14611: dee3ed02e6bd5fd3c1ceb728e7db2efe9fe0e0c3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dee3ed02e6bd drm/print: rename drm_debug to __drm_debug to discourage use ad06bd20c91a drm/amdgpu: use drm_debug_enabled() to check for debug categories 58d1c68ef69b drm/nouveau: use drm_debug_enabled() to check for debug categories a0e799ef7d32 drm/msm: use drm_debug_enabled() to check for debug categories d87f881b4027 drm/i915: use drm_debug_enabled() to check for debug categories 89665ceba5b7 drm/i2c/sil164: use drm_debug_enabled() to check for debug categories 10ebc8687080 drm/etnaviv: use drm_debug_enabled() to check for debug categories bbb5db7c55ad drm/print: add drm_debug_enabled()758ab8c6457a drm/print: move drm_debug variable to drm_print.[ch]
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/print: add and use drm_debug_enabled() (rev3)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/print: add and use drm_debug_enabled() (rev3)
URL : https://patchwork.freedesktop.org/series/66656/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6985_full -> Patchwork_14611_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14611_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@gem_eio@kms}:
- shard-glk: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-glk6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-glk9/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_14611_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb8/igt@[email protected]
* igt@gem_exec_reuse@contexts:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#109100])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +20 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb7/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-kbl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-kbl6/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#109385] / [fdo#111870]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl3/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl10/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103665] / [fdo#108767])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-kbl1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-kbl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#103232])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl7/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103184] / [fdo#103232])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl9/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-apl: [PASS][23] -> [INCOMPLETE][24] ([fdo#103927])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#103191])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl7/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#103166])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([fdo#108566]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl2/igt@[email protected]
* igt@perf@polling:
- shard-skl: [PASS][37] -> [FAIL][38] ([fdo#110728])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl10/igt@[email protected]
* igt@prime_busy@wait-hang-default:
- shard-iclb: [PASS][39] -> [INCOMPLETE][40] ([fdo#107713]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb1/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][41] ([fdo#109276]) -> [PASS][42] +16 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][43] ([fdo#111325]) -> [PASS][44] +6 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-iclb: [DMESG-WARN][45] ([fdo#111870]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb5/igt@[email protected]
- shard-snb: [DMESG-WARN][47] ([fdo#111870]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-snb1/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-snb4/igt@[email protected]
- shard-skl: [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl2/igt@[email protected]
- shard-kbl: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-kbl3/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-kbl2/igt@[email protected]
- shard-glk: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-glk5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-glk4/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-hsw7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-hsw8/igt@[email protected]
- shard-apl: [DMESG-WARN][57] ([fdo#109385] / [fdo#111870]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-suspend:
- shard-hsw: [INCOMPLETE][59] ([fdo#103540]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-hsw8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-hsw1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][61] ([fdo#105363]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl7/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl1/igt@[email protected]
- shard-glk: [FAIL][63] ([fdo#105363]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-glk1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-glk3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: [FAIL][65] ([fdo#103167]) -> [PASS][66] +4 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][69] ([fdo#108145] / [fdo#110403]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl5/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl6/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][71] ([fdo#103166]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb5/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb5/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][73] ([fdo#109642] / [fdo#111068]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb3/igt@kms_psr2_su@page_flip.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_sequence@queue-idle:
- shard-skl: [FAIL][77] ([fdo#109191]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl9/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl2/igt@[email protected]
* igt@kms_setmode@basic:
- shard-apl: [FAIL][79] ([fdo#99912]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl4/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [FAIL][81] ([fdo#110728]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-skl4/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-skl6/igt@[email protected]
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][83] ([fdo#111329]) -> [SKIP][84] ([fdo#109276])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb8/igt@[email protected]
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][85] ([fdo#111330]) -> [SKIP][86] ([fdo#109276]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-iclb4/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-iclb3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-apl: [INCOMPLETE][87] ([fdo#103927]) -> [SKIP][88] ([fdo#109271])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6985/shard-apl7/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/shard-apl1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109191]: https://bugs.freedesktop.org/show_bug.cgi?id=109191
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109385]: https://bugs.freedesktop.org/show_bug.cgi?id=109385
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (16 -> 10)
------------------------------
Missing (6): shard-tglb1 shard-tglb2 shard-tglb3 shard-tglb4 shard-tglb5 shard-tglb6
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6985 -> Patchwork_14611
CI-20190529: 20190529
CI_DRM_6985: 75d23ba38b952a5f3d0fc42baf1df2d15c5e74b1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14611: dee3ed02e6bd5fd3c1ceb728e7db2efe9fe0e0c3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14611/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Jani Nikula
drm/print: move
drm_debugvariable to drm_print.[ch] drm/print: adddrm_debug_enabled()
drm/etnaviv: usedrm_debug_enabled()to check for debug categories drm/i2c/sil164: usedrm_debug_enabled()to check for debug categories drm/msm: usedrm_debug_enabled()to check for debug categories
Pushed the above patches to drm-misc-next, thanks for the reviews and acks!
The below i915 and amdgpu patches conflict on drm-misc-next, and I haven't received any feedback on nouveau.
Quoted 4 lines
drm/i915: use
drm_debug_enabled()to check for debug categories drm/nouveau: usedrm_debug_enabled()to check for debug categories drm/amdgpu: usedrm_debug_enabled()to check for debug categories drm/print: renamedrm_debugto__drm_debugto discourage use
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno