Skip to contentSkip to conversation

staging: rtl8723bs: Fix style issues in function call

PATCH New Javier F. Arias 1 participant 4 messages Oct 9, 2019 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: rtl8723bs: Fix style issues in function call

This patchset fixes multiple style issues in the same function call. Now this segment of code complies with the coding style guidelines.

Javier F. Arias (3):
staging: rtl8723bs: Fix line over 80 characters
staging: rtl8723bs: Fix function call wrapping style
staging: rtl8723bs: Add space between elements

 drivers/staging/rtl8723bs/core/rtw_ap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/3 staging: rtl8723bs: Fix line over 80 characters

Break last two function call arguments into two separate lines. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -1
index 6d18d23acdc0..43af76b9fa49 100644
@@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter *padapter)
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
 		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
-			, FUNC_NDEV_ARG(padapter->pnetdev), pstapriv->auth_list_cnt);
+			, FUNC_NDEV_ARG(padapter->pnetdev)
+			, pstapriv->auth_list_cnt);
 	}
 	#endif
 	while (phead != plist) {
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/3 staging: rtl8723bs: Fix function call wrapping style

In reply to Javier F. Arias

Fix the wrapping style used for the function call. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +3 -3
index 43af76b9fa49..ca84e4b00310 100644
@@ -216,9 +216,9 @@ void expire_timeout_chk(struct adapter *padapter)
 	/* check auth_queue */
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
-		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
-			, FUNC_NDEV_ARG(padapter->pnetdev)
-			, pstapriv->auth_list_cnt);
+		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n",
+			 FUNC_NDEV_ARG(padapter->pnetdev),
+			 pstapriv->auth_list_cnt);
 	}
 	#endif
 	while (phead != plist) {
Signature · 1 line
2.20.1
#3 lore raw

PATCH 3/3 staging: rtl8723bs: Add space between elements

In reply to Javier F. Arias

Concatenated strings should use spaces between elements. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -1
index ca84e4b00310..33b4e1d7a520 100644
@@ -216,7 +216,7 @@ void expire_timeout_chk(struct adapter *padapter)
 	/* check auth_queue */
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
-		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n",
+		DBG_871X(FUNC_NDEV_FMT " auth_list, cnt:%u\n",
 			 FUNC_NDEV_ARG(padapter->pnetdev),
 			 pstapriv->auth_list_cnt);
 	}
Signature · 1 line
2.20.1