Skip to contentSkip to conversation

weston: Fix PACKAGECONFIG for remoting

PATCH In review Robert Yang 2 participants 4 messages Oct 15, 2019 – Oct 16, 2019

lore
Share & tools
lore
#0 lore raw

cover weston: Fix PACKAGECONFIG for remoting

The following changes since commit 59938780e7e776d87146002ea939b185f8704408:

build-appliance-image: Update to master head revision (2019-10-09 22:28:44 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/weston
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/weston

Robert Yang (1):
weston: Fix PACKAGECONFIG for remoting

 meta/recipes-graphics/wayland/weston_7.0.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 weston: Fix PACKAGECONFIG for remoting

Fix a typo: gstreamer-1.0 -> gstreamer1.0.

---
 meta/recipes-graphics/wayland/weston_7.0.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_7.0.0.bb +1 -1
index d212754..02d724a 100644
@@ -64,7 +64,7 @@ PACKAGECONFIG[colord] = "-Dcolor-management-colord=true,-Dcolor-management-color
 # Clients support
 PACKAGECONFIG[clients] = "-Dsimple-clients=all -Ddemo-clients=true,-Dsimple-clients= -Ddemo-clients=false"
 # Virtual remote output with GStreamer on DRM backend
-PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer-1.0"
+PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer1.0"
 # Weston with PAM support
 PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam"
 
Signature · 1 line
2.7.4
#2 lore raw
Quoted 12 lines · Robert Yang

Fix a typo: gstreamer-1.0 -> gstreamer1.0.

---
  meta/recipes-graphics/wayland/weston_7.0.0.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_7.0.0.bb +0 -0
index d212754..02d724a 100644

meta/recipes-graphics/wayland/weston_7.0.0.bb PACKAGECONFIG[colord] = "-Dcolor-management-colord=true,-Dcolor-management-color · line 70

Quoted 8 lines
meta/recipes-graphics/wayland/weston_7.0.0.bb +1 -1
@@ -64,7 +64,7 @@ PACKAGECONFIG[colord] = "-Dcolor-management-colord=true,-Dcolor-management-color
  # Clients support
  PACKAGECONFIG[clients] = "-Dsimple-clients=all -Ddemo-clients=true,-Dsimple-clients= -Ddemo-clients=false"
  # Virtual remote output with GStreamer on DRM backend
-PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer-1.0"
+PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer1.0"
  # Weston with PAM support
  PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam"
 

You'll need to add gstreamer1.0-plugins-base as well if it is going to successfully build, i.e. the line should be

PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer1.0 gstreamer1.0-plugins-base"

Otherwise, you'll run into do_package_qa errors.

#3 lore raw
Quoted 26 lines · Trevor Gamblin
Quoted 19 lines · Robert Yang

Fix a typo: gstreamer-1.0 -> gstreamer1.0.

---
  meta/recipes-graphics/wayland/weston_7.0.0.bb | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_7.0.0.bb +0 -0
index d212754..02d724a 100644
@@ -64,7 +64,7 @@ PACKAGECONFIG[colord] = 

"-Dcolor-management-colord=true,-Dcolor-management-color # Clients support
  PACKAGECONFIG[clients] = "-Dsimple-clients=all -Ddemo-clients=true,-Dsimple-clients= -Ddemo-clients=false" # Virtual remote output with GStreamer on DRM backend

meta/recipes-graphics/wayland/weston_7.0.0.bb +1 -1
-PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer-1.0"
+PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer1.0"
Quoted 2 lines

  # Weston with PAM support PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam"

You'll need to add gstreamer1.0-plugins-base as well if it is going to successfully build, i.e. the line should be

Quoted 1 line

PACKAGECONFIG[remoting] = "-Dremoting=true,-Dremoting=false,gstreamer1.0 gstreamer1.0-plugins-base"

Thanks, make sense, I will send a V2 for it.

// Robert

Quoted 4 lines

Otherwise, you'll run into do_package_qa errors.