PM / devfreq: Add dynamic scaling for imx8m ddr controller
Subsystems (6)
v7 cover PM / devfreq: Add dynamic scaling for imx8m ddr controller
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via CLK_GET_RATE_NO_CACHE for dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call clk_set_parent to ensure the parents in clock framework are up-to-date.
This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Changes since v6:
* Replace ARCH_MXC || COMPILE_TEST with ARCH_MXC && HAVE_ARM_SMCCC
* Collect reviews
Link to v6: https://patchwork.kernel.org/cover/11244283/
I'd rather not fix COMPILE_TEST with ifdefs for this driver, if anything that should be fixed in smccc header. ARCH_MXC doesn't imply SMCCC, it also covers some very old chips which don't have it.
Resending full series because that's the standard method.
Changes since v5:
* Fix a dram_apb/dram_alt mixup in imx8m_ddrc_set_freq
* Make clk_get_parent_by_index static (kbuild robot)
* Adjust messages in imx8m_ddrc_set_freq
* Use a for loop inside imx8m_ddrc_check_opps instead of while
* More elaborate description in dt-bindings file. Link to v5: https://patchwork.kernel.org/cover/11240289/
Changes since v4:
* Restore empty _get_dev_status: testing shows this is *NOT* optional. If absent then switching to simple_ondemand governor will trigger an Oops.
* Keep clk registration on single-line in clk-imx8m* for consistency with rest of the file.
* Drop explicit "select PM_OPP"
* Check for NULL new_dram_core_parent
* Rename "out_dis_" labels to out_disable_*
* Use dev_warn on imx8m_ddrc_set_freq error paths after SMC call (where operation is not abandoned).
* More elaborate error messages in imx8m_ddrc_target
* More elaborate checks when fetching clks in imx8m_ddrc_set_freq
* Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names Recommendation"
* Defer perf support, it requires perf changes to fetch PMU by DT Link to v4: https://patchwork.kernel.org/cover/11235685/
Changes since v3:
* Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm but soc integration is different.
* Move dt bindings to /memory-controllers/fsl/
* Fix dt validation issues
* Fix imx8mm.dtsi ddrc referencing ddrc_opp_table which is only defined in evk
* Move opps to child of ddrc device node
* Only add imx_ddrc_get_dev_status in perf patch.
* Adjust print messages
Link to v3: https://patchwork.kernel.org/cover/11221935/
Changes since v2:
* Add support for entire imx8m family including imx8mq B0.
* Also mark dram PLLs as CLK_GET_RATE_NO_CACHE (required for imx8mq b0 low OPP)
* Explicitly update dram pll rate at the end of imx_ddrc_set_freq.
* Use do_div in imx-ddrc (kbuild robot)
* Improve explanations around adding CLK_GET_RATE_NO_CACHE to dram clks. (Stephen Boyd)
* Handle ddrc devfreq-events earlier for fewer probe defers.
* Validate DDRC opp tables versus firmware: supported OPPs depend on board and SOC revision.
* Move DDRC opp tables to board dts because they can vary based on ram type on board.
* Verify DDRC rate is changed in clk tree and otherwise report an error.
* Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ in imx_ddrc_find_freq instead.
* Split away from NOC scaling and interconnect support.
Link to v2: https://patchwork.kernel.org/cover/11104113/
Changes since v1:
* bindings: Stop using "contains" for "compatible"
* bindings: Set "additionalProperties: false" and document missing stuff.
* Remove (c) from NXP copyright notice
* Fix various checkpatch issues
* Remove unused dram_alt_root clk from imx-ddrc
Link to v1: https://patchwork.kernel.org/cover/11090649/
Leonard Crestez (5):
clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes
.../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml create mode 100644 drivers/devfreq/imx8m-ddrc.c
Signature · 1 line
2.17.1
PATCH v7 1/5 clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
These clocks are only modified as part of DRAM frequency switches during which DRAM itself is briefly inaccessible. The switch is performed with a SMC call to by TF-A which runs from a SRAM area; upon returning to linux several clocks bits are modified and we need to update them.
For rate bits an easy solution is to just mark with CLK_GET_RATE_NOCACHE so that new rates are always read back from registers.
--- drivers/clk/imx/clk-imx8mm.c | 9 +++++++-- drivers/clk/imx/clk-imx8mn.c | 10 ++++++++-- drivers/clk/imx/clk-imx8mq.c | 12 ++++++++---- 3 files changed, 23 insertions(+), 8 deletions(-)
drivers/clk/imx/clk-imx8mm.c +7 -2
@@ -440,13 +440,18 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)/* IPG */ clks[IMX8MM_CLK_IPG_ROOT ] =imx_clk_divider2 ("ipg_root" ,"ahb" , base +0x9080 ,0 ,1 ); clks[IMX8MM_CLK_IPG_AUDIO_ROOT ] =imx_clk_divider2 ("ipg_audio_root" ,"audio_ahb" , base +0x9180 ,0 ,1 ); +/* +* DRAM clocks are manipulated from TF-A outside clock framework. +* Mark with GET_RATE_NOCACHE to always read div value from hardware +*/ + clks[IMX8MM_CLK_DRAM_ALT ] =__imx8m_clk_composite ("dram_alt" , imx8mm_dram_alt_sels, base +0xa000 ,CLK_GET_RATE_NOCACHE ); + clks[IMX8MM_CLK_DRAM_APB ] =__imx8m_clk_composite ("dram_apb" , imx8mm_dram_apb_sels, base +0xa080 ,CLK_IS_CRITICAL |CLK_GET_RATE_NOCACHE ); +/* IP */ - clks[IMX8MM_CLK_DRAM_ALT ] =imx8m_clk_composite ("dram_alt" , imx8mm_dram_alt_sels, base +0xa000 ); - clks[IMX8MM_CLK_DRAM_APB ] =imx8m_clk_composite_critical ("dram_apb" , imx8mm_dram_apb_sels, base +0xa080 ); clks[IMX8MM_CLK_VPU_G1 ] =imx8m_clk_composite ("vpu_g1" , imx8mm_vpu_g1_sels, base +0xa100 ); clks[IMX8MM_CLK_VPU_G2 ] =imx8m_clk_composite ("vpu_g2" , imx8mm_vpu_g2_sels, base +0xa180 ); clks[IMX8MM_CLK_DISP_DTRC ] =imx8m_clk_composite ("disp_dtrc" , imx8mm_disp_dtrc_sels, base +0xa200 ); clks[IMX8MM_CLK_DISP_DC8000 ] =imx8m_clk_composite ("disp_dc8000" , imx8mm_disp_dc8000_sels, base +0xa280 ); clks[IMX8MM_CLK_PCIE1_CTRL ] =imx8m_clk_composite ("pcie1_ctrl" , imx8mm_pcie1_ctrl_sels, base +0xa300 );
drivers/clk/imx/clk-imx8mn.c +8 -2
@@ -428,12 +428,18 @@ static int imx8mn_clocks_probe(struct platform_device *pdev) clks[IMX8MN_CLK_AHB ] =imx8m_clk_composite_critical ("ahb" , imx8mn_ahb_sels, base +0x9000 ); clks[IMX8MN_CLK_AUDIO_AHB ] =imx8m_clk_composite ("audio_ahb" , imx8mn_audio_ahb_sels, base +0x9100 ); clks[IMX8MN_CLK_IPG_ROOT ] =imx_clk_divider2 ("ipg_root" ,"ahb" , base +0x9080 ,0 ,1 ); clks[IMX8MN_CLK_IPG_AUDIO_ROOT ] =imx_clk_divider2 ("ipg_audio_root" ,"audio_ahb" , base +0x9180 ,0 ,1 ); clks[IMX8MN_CLK_DRAM_CORE ] =imx_clk_mux2_flags ("dram_core_clk" , base +0x9800 ,24 ,1 , imx8mn_dram_core_sels,ARRAY_SIZE (imx8mn_dram_core_sels),CLK_IS_CRITICAL ); - clks[IMX8MN_CLK_DRAM_ALT ] =imx8m_clk_composite ("dram_alt" , imx8mn_dram_alt_sels, base +0xa000 ); - clks[IMX8MN_CLK_DRAM_APB ] =imx8m_clk_composite_critical ("dram_apb" , imx8mn_dram_apb_sels, base +0xa080 ); + +/* +* DRAM clocks are manipulated from TF-A outside clock framework. +* Mark with GET_RATE_NOCACHE to always read div value from hardware +*/ + clks[IMX8MN_CLK_DRAM_ALT ] =__imx8m_clk_composite ("dram_alt" , imx8mn_dram_alt_sels, base +0xa000 ,CLK_GET_RATE_NOCACHE ); + clks[IMX8MN_CLK_DRAM_APB ] =__imx8m_clk_composite ("dram_apb" , imx8mn_dram_apb_sels, base +0xa080 ,CLK_IS_CRITICAL |CLK_GET_RATE_NOCACHE ); + clks[IMX8MN_CLK_DISP_PIXEL ] =imx8m_clk_composite ("disp_pixel" , imx8mn_disp_pixel_sels, base +0xa500 ); clks[IMX8MN_CLK_SAI2 ] =imx8m_clk_composite ("sai2" , imx8mn_sai2_sels, base +0xa600 ); clks[IMX8MN_CLK_SAI3 ] =imx8m_clk_composite ("sai3" , imx8mn_sai3_sels, base +0xa680 ); clks[IMX8MN_CLK_SAI5 ] =imx8m_clk_composite ("sai5" , imx8mn_sai5_sels, base +0xa780 ); clks[IMX8MN_CLK_SAI6 ] =imx8m_clk_composite ("sai6" , imx8mn_sai6_sels, base +0xa800 );
drivers/clk/imx/clk-imx8mq.c +8 -4
@@ -341,11 +341,11 @@ static int imx8mq_clocks_probe(struct platform_device *pdev) clks[IMX8MQ_VIDEO_PLL1_OUT ] =imx_clk_gate ("video_pll1_out" ,"video_pll1_bypass" , base +0x10 ,21 ); clks[IMX8MQ_SYS1_PLL_OUT ] =imx_clk_fixed ("sys1_pll_out" ,800000000 ); clks[IMX8MQ_SYS2_PLL_OUT ] =imx_clk_fixed ("sys2_pll_out" ,1000000000 ); clks[IMX8MQ_SYS3_PLL_OUT ] =imx_clk_sccg_pll ("sys3_pll_out" , sys3_pll_out_sels,ARRAY_SIZE (sys3_pll_out_sels),0 ,0 ,0 , base +0x48 ,CLK_IS_CRITICAL ); - clks[IMX8MQ_DRAM_PLL_OUT ] =imx_clk_sccg_pll ("dram_pll_out" , dram_pll_out_sels,ARRAY_SIZE (dram_pll_out_sels),0 ,0 ,0 , base +0x60 ,CLK_IS_CRITICAL ); + clks[IMX8MQ_DRAM_PLL_OUT ] =imx_clk_sccg_pll ("dram_pll_out" , dram_pll_out_sels,ARRAY_SIZE (dram_pll_out_sels),0 ,0 ,0 , base +0x60 ,CLK_IS_CRITICAL |CLK_GET_RATE_NOCACHE ); clks[IMX8MQ_VIDEO2_PLL_OUT ] =imx_clk_sccg_pll ("video2_pll_out" , video2_pll_out_sels,ARRAY_SIZE (video2_pll_out_sels),0 ,0 ,0 , base +0x54 ,0 );/* SYS PLL1 fixed output */ clks[IMX8MQ_SYS1_PLL_40M_CG ] =imx_clk_gate ("sys1_pll_40m_cg" ,"sys1_pll_out" , base +0x30 ,9 ); clks[IMX8MQ_SYS1_PLL_80M_CG ] =imx_clk_gate ("sys1_pll_80m_cg" ,"sys1_pll_out" , base +0x30 ,11 );
@@ -433,15 +433,19 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)/* IPG */ clks[IMX8MQ_CLK_IPG_ROOT ] =imx_clk_divider2 ("ipg_root" ,"ahb" , base +0x9080 ,0 ,1 ); clks[IMX8MQ_CLK_IPG_AUDIO_ROOT ] =imx_clk_divider2 ("ipg_audio_root" ,"audio_ahb" , base +0x9180 ,0 ,1 ); -/* IP */ +/* +* DRAM clocks are manipulated from TF-A outside clock framework. +* Mark with GET_RATE_NOCACHE to always read div value from hardware +*/ clks[IMX8MQ_CLK_DRAM_CORE ] =imx_clk_mux2_flags ("dram_core_clk" , base +0x9800 ,24 ,1 , imx8mq_dram_core_sels,ARRAY_SIZE (imx8mq_dram_core_sels),CLK_IS_CRITICAL ); + clks[IMX8MQ_CLK_DRAM_ALT ] =__imx8m_clk_composite ("dram_alt" , imx8mq_dram_alt_sels, base +0xa000 ,CLK_GET_RATE_NOCACHE ); + clks[IMX8MQ_CLK_DRAM_APB ] =__imx8m_clk_composite ("dram_apb" , imx8mq_dram_apb_sels, base +0xa080 ,CLK_IS_CRITICAL |CLK_GET_RATE_NOCACHE ); - clks[IMX8MQ_CLK_DRAM_ALT ] =imx8m_clk_composite ("dram_alt" , imx8mq_dram_alt_sels, base +0xa000 ); - clks[IMX8MQ_CLK_DRAM_APB ] =imx8m_clk_composite_critical ("dram_apb" , imx8mq_dram_apb_sels, base +0xa080 ); +/* IP */ clks[IMX8MQ_CLK_VPU_G1 ] =imx8m_clk_composite ("vpu_g1" , imx8mq_vpu_g1_sels, base +0xa100 ); clks[IMX8MQ_CLK_VPU_G2 ] =imx8m_clk_composite ("vpu_g2" , imx8mq_vpu_g2_sels, base +0xa180 ); clks[IMX8MQ_CLK_DISP_DTRC ] =imx8m_clk_composite ("disp_dtrc" , imx8mq_disp_dtrc_sels, base +0xa200 ); clks[IMX8MQ_CLK_DISP_DC8000 ] =imx8m_clk_composite ("disp_dc8000" , imx8mq_disp_dc8000_sels, base +0xa280 ); clks[IMX8MQ_CLK_PCIE1_CTRL ] =imx8m_clk_composite ("pcie1_ctrl" , imx8mq_pcie1_ctrl_sels, base +0xa300 );
Signature · 1 line
2.17.1
PATCH v7 2/5 clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
In reply to Leonard CrestezDRAM frequency switches are executed in firmware and can change the configuration of the DRAM PLL outside linux. Mark these CLKs with CLK_GET_RATE_NOCACHE so we always read back the PLL config registers and recalculate rates.
In current DRAM frequency tables on 8mm/8mn only the maximum frequency uses the PLL so it's always configured in the same way. However reading back the PLL configuration is the correct behavior and allows additional setpoints in the future.
--- drivers/clk/imx/clk-imx8mm.c | 2 +- drivers/clk/imx/clk-imx8mn.c | 2 +- drivers/clk/imx/clk-pll14xx.c | 7 +++++++ drivers/clk/imx/clk.h | 1 + 4 files changed, 10 insertions(+), 2 deletions(-)
drivers/clk/imx/clk-imx8mm.c +1 -1
@@ -326,11 +326,11 @@ static int imx8mm_clocks_probe(struct platform_device *pdev) clks[IMX8MM_SYS_PLL3_REF_SEL ] =imx_clk_mux ("sys_pll3_ref_sel" , base +0x114 ,0 ,2 , pll_ref_sels,ARRAY_SIZE (pll_ref_sels)); clks[IMX8MM_AUDIO_PLL1 ] =imx_clk_pll14xx ("audio_pll1" ,"audio_pll1_ref_sel" , base, &imx_1443x_pll); clks[IMX8MM_AUDIO_PLL2 ] =imx_clk_pll14xx ("audio_pll2" ,"audio_pll2_ref_sel" , base +0x14 , &imx_1443x_pll); clks[IMX8MM_VIDEO_PLL1 ] =imx_clk_pll14xx ("video_pll1" ,"video_pll1_ref_sel" , base +0x28 , &imx_1443x_pll); - clks[IMX8MM_DRAM_PLL ] =imx_clk_pll14xx ("dram_pll" ,"dram_pll_ref_sel" , base +0x50 , &imx_1443x_pll); + clks[IMX8MM_DRAM_PLL ] =imx_clk_pll14xx ("dram_pll" ,"dram_pll_ref_sel" , base +0x50 , &imx_1443x_dram_pll); clks[IMX8MM_GPU_PLL ] =imx_clk_pll14xx ("gpu_pll" ,"gpu_pll_ref_sel" , base +0x64 , &imx_1416x_pll); clks[IMX8MM_VPU_PLL ] =imx_clk_pll14xx ("vpu_pll" ,"vpu_pll_ref_sel" , base +0x74 , &imx_1416x_pll); clks[IMX8MM_ARM_PLL ] =imx_clk_pll14xx ("arm_pll" ,"arm_pll_ref_sel" , base +0x84 , &imx_1416x_pll); clks[IMX8MM_SYS_PLL1 ] =imx_clk_fixed ("sys_pll1" ,800000000 ); clks[IMX8MM_SYS_PLL2 ] =imx_clk_fixed ("sys_pll2" ,1000000000 );
drivers/clk/imx/clk-imx8mn.c +1 -1
@@ -323,11 +323,11 @@ static int imx8mn_clocks_probe(struct platform_device *pdev) clks[IMX8MN_SYS_PLL3_REF_SEL ] =imx_clk_mux ("sys_pll3_ref_sel" , base +0x114 ,0 ,2 , pll_ref_sels,ARRAY_SIZE (pll_ref_sels)); clks[IMX8MN_AUDIO_PLL1 ] =imx_clk_pll14xx ("audio_pll1" ,"audio_pll1_ref_sel" , base, &imx_1443x_pll); clks[IMX8MN_AUDIO_PLL2 ] =imx_clk_pll14xx ("audio_pll2" ,"audio_pll2_ref_sel" , base +0x14 , &imx_1443x_pll); clks[IMX8MN_VIDEO_PLL1 ] =imx_clk_pll14xx ("video_pll1" ,"video_pll1_ref_sel" , base +0x28 , &imx_1443x_pll); - clks[IMX8MN_DRAM_PLL ] =imx_clk_pll14xx ("dram_pll" ,"dram_pll_ref_sel" , base +0x50 , &imx_1443x_pll); + clks[IMX8MN_DRAM_PLL ] =imx_clk_pll14xx ("dram_pll" ,"dram_pll_ref_sel" , base +0x50 , &imx_1443x_dram_pll); clks[IMX8MN_GPU_PLL ] =imx_clk_pll14xx ("gpu_pll" ,"gpu_pll_ref_sel" , base +0x64 , &imx_1416x_pll); clks[IMX8MN_VPU_PLL ] =imx_clk_pll14xx ("vpu_pll" ,"vpu_pll_ref_sel" , base +0x74 , &imx_1416x_pll); clks[IMX8MN_ARM_PLL ] =imx_clk_pll14xx ("arm_pll" ,"arm_pll_ref_sel" , base +0x84 , &imx_1416x_pll); clks[IMX8MN_SYS_PLL1 ] =imx_clk_fixed ("sys_pll1" ,800000000 ); clks[IMX8MN_SYS_PLL2 ] =imx_clk_fixed ("sys_pll2" ,1000000000 );
drivers/clk/imx/clk-pll14xx.c +7 -0
@@ -65,10 +65,17 @@ struct imx_pll14xx_clk imx_1443x_pll = { .type = PLL_1443X, .rate_table = imx_pll1443x_tbl, .rate_count = ARRAY_SIZE(imx_pll1443x_tbl), }; +struct imx_pll14xx_clk imx_1443x_dram_pll = { + .type =PLL_1443X , + .rate_table = imx_pll1443x_tbl, + .rate_count =ARRAY_SIZE (imx_pll1443x_tbl), + .flags =CLK_GET_RATE_NOCACHE , +}; +struct imx_pll14xx_clk imx_1416x_pll = { .type =PLL_1416X , .rate_table = imx_pll1416x_tbl, .rate_count =ARRAY_SIZE (imx_pll1416x_tbl), };
drivers/clk/imx/clk.h +1 -0
@@ -50,10 +50,11 @@ struct imx_pll14xx_clk {int flags; };extern struct imx_pll14xx_clk imx_1416x_pll;extern struct imx_pll14xx_clk imx_1443x_pll; +extern struct imx_pll14xx_clk imx_1443x_dram_pll;#define imx_clk_cpu (name, parent_name, div, mux, pll, step) \ imx_clk_hw_cpu(name, parent_name, div, mux, pll, step)->clk #define clk_register_gate2(dev, name, parent_name, flags, reg, bit_idx, \
Signature · 1 line
2.17.1
PATCH v7 3/5 dt-bindings: memory: Add bindings for imx8m ddr controller
In reply to Leonard CrestezAdd devicetree bindings for the i.MX DDR Controller on imx8m series chips. It supports dynamic frequency switching between multiple data rates and this is exposed to Linux via the devfreq subsystem.
--- .../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml new file +72 -0
@@ -0,0 +1,72 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/memory-controllers/fsl/imx8m-ddrc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: i.MX8M DDR Controller + +maintainers: + - Leonard Crestez <[email protected]> + +description: + The DDRC block is integrated in i.MX8M for interfacing with DDR based + memories. + + It supports switching between different frequencies at runtime but during + this process RAM itself becomes briefly inaccessible so actual frequency + switching is implemented by TF-A code which runs from a SRAM area. + + The Linux driver for the DDRC doesn't even map registers (they're included + for the sake of "describing hardware"), it mostly just exposes firmware + capabilities through standard Linux mechanism like devfreq and OPP tables. + +properties: + compatible: + items: + - enum: + - fsl,imx8mn-ddrc + - fsl,imx8mm-ddrc + - fsl,imx8mq-ddrc + - const: fsl,imx8m-ddrc + + reg: + maxItems: 1 + description: + Base address and size of DDRC CTL area. + This is not currently mapped by the imx8m-ddrc driver. + + clocks: + maxItems: 4 + + clock-names: + items: + - const: core + - const: pll + - const: alt + - const: apb + + operating-points-v2: true + opp-table: true + +required: + - reg + - compatible + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx8mm-clock.h> + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MM_CLK_DRAM_CORE>, + <&clk IMX8MM_DRAM_PLL>, + <&clk IMX8MM_CLK_DRAM_ALT>, + <&clk IMX8MM_CLK_DRAM_APB>; + operating-points-v2 = <&ddrc_opp_table>; + };
Signature · 1 line
2.17.1
PATCH v7 4/5 PM / devfreq: Add dynamic scaling for imx8m ddr controller
In reply to Leonard CrestezAdd driver for dynamic scaling the DDR Controller on imx8m chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
The DRAM clocks on imx8m have the following structure (abridged):
+----------+ |\ +------+
| dram_pll |-------|M| dram_core | |
+----------+ |U|---------->| D |
/--|X| | D |
dram_alt_root | |/ | R |
| | C |
+---------+ | |
|FIX DIV/4| | |
+---------+ | |
composite: | | |
+----------+ | | |
| dram_alt |----/ | |
+----------+ | |
| dram_apb |-------------------->| |
+----------+ +------+The dram_pll is used for higher rates and dram_alt is used for lower rates. The dram_alt and dram_apb clocks are "imx composite" and their parent can also be modified.
This driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call clk_set_parent to ensure the parents in clock framework are up-to-date.
The driver relies on dram_pll dram_alt and dram_apb being marked with CLK_GET_RATE_NOCACHE for rate updates.
--- drivers/devfreq/Kconfig | 9 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++ 3 files changed, 475 insertions(+) create mode 100644 drivers/devfreq/imx8m-ddrc.c
drivers/devfreq/Kconfig +9 -0
@@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ Each memory bus group could contain many memoby bus block. It reads PPMU counters of memory controllers by using DEVFREQ-event device and adjusts the operating frequencies and voltages with OPP support. This does not yet operate with optimal voltages. +config ARM_IMX8M_DDRC_DEVFREQ + tristate "i.MX8M DDRC DEVFREQ Driver" + depends on ARCH_MXC && HAVE_ARM_SMCCC + select DEVFREQ_GOV_SIMPLE_ONDEMAND + select DEVFREQ_GOV_USERSPACE + help + This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows + adjusting DRAM frequency. + config ARM_TEGRA_DEVFREQ tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \ ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \ ARCH_TEGRA_210_SOC || \
drivers/devfreq/Makefile +1 -0
@@ -7,10 +7,11 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o # DEVFREQ Drivers obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o +obj-$(CONFIG_ARM_IMX8M_DDRC_DEVFREQ) += imx8m-ddrc.o obj-$(CONFIG_ARM_RK3399_DMC_DEVFREQ) += rk3399_dmc.o obj-$(CONFIG_ARM_TEGRA_DEVFREQ) += tegra30-devfreq.o obj-$(CONFIG_ARM_TEGRA20_DEVFREQ) += tegra20-devfreq.o # DEVFREQ Event Drivers
drivers/devfreq/imx8m-ddrc.c new file +465 -0
465 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v7 5/5 arm64: dts: imx8m: Add ddr controller nodes
In reply to Leonard CrestezThis is used by the imx-ddrc devfreq driver to implement dynamic frequency scaling of DRAM.
Support for proactive scaling via interconnect will come later. The high-performance bus masters which need that (display, vpu, gpu) are mostly not yet enabled in upstream anyway.
--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 ++++++++ .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 ++++++++ arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 +++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 ++++++++ 6 files changed, 90 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +18 -0
@@ -75,10 +75,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-750M { + opp-hz = /bits/ 64 <750000000>; + }; + }; +}; + &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; phy-mode = "rgmii-id"; phy-handle = <ðphy0>;
arch/arm64/boot/dts/freescale/imx8mm.dtsi +10 -0
@@ -856,10 +856,20 @@ #interrupt-cells = <3>; interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MM_CLK_DRAM_CORE>, + <&clk IMX8MM_DRAM_PLL>, + <&clk IMX8MM_CLK_DRAM_ALT>, + <&clk IMX8MM_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +18 -0
@@ -15,10 +15,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-600M { + opp-hz = /bits/ 64 <600000000>; + }; + }; +}; + &i2c1 { pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; pinctrl-0 = <&pinctrl_pmic>;
arch/arm64/boot/dts/freescale/imx8mn.dtsi +10 -0
@@ -757,10 +757,20 @@ #interrupt-cells = <3>; interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mn-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MN_CLK_DRAM_CORE>, + <&clk IMX8MN_DRAM_PLL>, + <&clk IMX8MN_CLK_DRAM_ALT>, + <&clk IMX8MN_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; };
arch/arm64/boot/dts/freescale/imx8mq-evk.dts +24 -0
@@ -103,10 +103,34 @@ &A53_3 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + /* + * On imx8mq B0 PLL can't be bypassed so low bus is 166M + */ + opp-166M { + opp-hz = /bits/ 64 <166935483>; + }; + opp-800M { + opp-hz = /bits/ 64 <800000000>; + }; + }; +}; + &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; phy-mode = "rgmii-id"; phy-handle = <ðphy0>;
arch/arm64/boot/dts/freescale/imx8mq.dtsi +10 -0
@@ -1111,10 +1111,20 @@ interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mq-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MQ_CLK_DRAM_CORE>, + <&clk IMX8MQ_DRAM_PLL_OUT>, + <&clk IMX8MQ_CLK_DRAM_ALT>, + <&clk IMX8MQ_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.17.1
Chanwoo Choi
maintainerHi Leonard,
Quoted 47 lines · Leonard Crestez
Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
The DRAM clocks on imx8m have the following structure (abridged):
+----------+ |\ +------+ | dram_pll |-------|M| dram_core | | +----------+ |U|---------->| D | /--|X| | D | dram_alt_root | |/ | R | | | C | +---------+ | | |FIX DIV/4| | | +---------+ | | composite: | | | +----------+ | | | | dram_alt |----/ | | +----------+ | | | dram_apb |-------------------->| | +----------+ +------+The
dram_pllis used for higher rates anddram_altis used for lower rates. Thedram_altanddram_apbclocks are "imx composite" and their parent can also be modified.This driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call
clk_set_parentto ensure the parents in clock framework are up-to-date.The driver relies on
dram_plldram_altanddram_apbbeing marked withCLK_GET_RATE_NOCACHEfor rate updates.Signed-off-by Leonard Crestez <[email protected]>Acked-by Chanwoo Choi <[email protected]>--- drivers/devfreq/Kconfig | 9 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++ 3 files changed, 475 insertions(+) create mode 100644 drivers/devfreq/imx8m-ddrc.cdrivers/devfreq/Kconfig +0
-0
drivers/devfreq/Kconfig config ARM_EXYNOS_BUS_DEVFREQ · line 96
Quoted 8 lines
drivers/devfreq/Kconfig +3
-0@@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ Each memory bus group could contain many memoby bus block. It reads PPMU counters of memory controllers by using DEVFREQ-event device and adjusts the operating frequencies and voltages with OPP support. This does not yet operate with optimal voltages. +config ARM_IMX8M_DDRC_DEVFREQ + tristate "i.MX8M DDRC DEVFREQ Driver" + depends on ARCH_MXC && HAVE_ARM_SMCCC
I'll edit it as following and applied it.
drivers/devfreq/Kconfig +2 -1
@@ -93,7 +93,8 @@ config ARM_EXYNOS_BUS_DEVFREQ config ARM_IMX8M_DDRC_DEVFREQ tristate "i.MX8M DDRC DEVFREQ Driver" - depends on ARCH_MXC && HAVE_ARM_SMCCC + depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \ + (COMPILE_TEST && HAVE_ARM_SMCCC)
(snip)
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Re: [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
In reply to Leonard CrestezQuoting Leonard Crestez (2019-11-22 13:45:00)
Quoted 5 lines
These clocks are only modified as part of DRAM frequency switches during which DRAM itself is briefly inaccessible. The switch is performed with a SMC call to by TF-A which runs from a SRAM area; upon returning to linux several clocks bits are modified and we need to update them.
Quoted 7 lines
For rate bits an easy solution is to just mark with
CLK_GET_RATE_NOCACHEso that new rates are always read back from registers.Signed-off-by Leonard Crestez <[email protected]>Reviewed-by Abel Vesa <[email protected]>---
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
In reply to Leonard CrestezQuoting Leonard Crestez (2019-11-22 13:45:01)
Quoted 5 lines
DRAM frequency switches are executed in firmware and can change the configuration of the DRAM PLL outside linux. Mark these CLKs with
CLK_GET_RATE_NOCACHEso we always read back the PLL config registers and recalculate rates.
Quoted 8 lines
In current DRAM frequency tables on 8mm/8mn only the maximum frequency uses the PLL so it's always configured in the same way. However reading back the PLL configuration is the correct behavior and allows additional setpoints in the future.
Signed-off-by Leonard Crestez <[email protected]>Reviewed-by Abel Vesa <[email protected]>---
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 56 lines · Chanwoo Choi
Hi Leonard,
Quoted 52 lines · Leonard Crestez
Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
The DRAM clocks on imx8m have the following structure (abridged):
+----------+ |\ +------+ | dram_pll |-------|M| dram_core | | +----------+ |U|---------->| D | /--|X| | D | dram_alt_root | |/ | R | | | C | +---------+ | | |FIX DIV/4| | | +---------+ | | composite: | | | +----------+ | | | | dram_alt |----/ | | +----------+ | | | dram_apb |-------------------->| | +----------+ +------+The
dram_pllis used for higher rates anddram_altis used for lower rates. Thedram_altanddram_apbclocks are "imx composite" and their parent can also be modified.This driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call
clk_set_parentto ensure the parents in clock framework are up-to-date.The driver relies on
dram_plldram_altanddram_apbbeing marked withCLK_GET_RATE_NOCACHEfor rate updates.Signed-off-by Leonard Crestez <[email protected]>Acked-by Chanwoo Choi <[email protected]>--- drivers/devfreq/Kconfig | 9 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++ 3 files changed, 475 insertions(+) create mode 100644 drivers/devfreq/imx8m-ddrc.cdrivers/devfreq/Kconfig +0
-0@@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ Each memory bus group could contain many memoby bus block. It reads PPMU counters of memory controllers by using DEVFREQ-event device and adjusts the operating frequencies and voltages with OPP support. This does not yet operate with optimal voltages.
Quoted 5 lines
drivers/devfreq/Kconfig config ARM_EXYNOS_BUS_DEVFREQ · line 96
Quoted 3 lines
drivers/devfreq/Kconfig +3
-0+config ARM_IMX8M_DDRC_DEVFREQ + tristate "i.MX8M DDRC DEVFREQ Driver" + depends on ARCH_MXC && HAVE_ARM_SMCCCI'll edit it as following and applied it.
You corrupted the URLs in the binding patch when applying the series:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
line 774, in resolve_from_url
document = self.store[url]
File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
line 22, in __getitem__
return self.store[self.normalize(uri)]
KeyError: 'https://protect2.fireeye.com/url?k=b51ff83f-e8cff0d7-b51e7370-000babff32e3-c25c03b8af1b12ee&u=http://devicetree.org/meta-schemas/core.yaml'
Rob
Chanwoo Choi
maintainerQuoted 65 lines · Rob Herring
Quoted 56 lines · Chanwoo Choi
Hi Leonard,
Quoted 52 lines · Leonard Crestez
Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
The DRAM clocks on imx8m have the following structure (abridged):
+----------+ |\ +------+ | dram_pll |-------|M| dram_core | | +----------+ |U|---------->| D | /--|X| | D | dram_alt_root | |/ | R | | | C | +---------+ | | |FIX DIV/4| | | +---------+ | | composite: | | | +----------+ | | | | dram_alt |----/ | | +----------+ | | | dram_apb |-------------------->| | +----------+ +------+The
dram_pllis used for higher rates anddram_altis used for lower rates. Thedram_altanddram_apbclocks are "imx composite" and their parent can also be modified.This driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call
clk_set_parentto ensure the parents in clock framework are up-to-date.The driver relies on
dram_plldram_altanddram_apbbeing marked withCLK_GET_RATE_NOCACHEfor rate updates.Signed-off-by Leonard Crestez <[email protected]>Acked-by Chanwoo Choi <[email protected]>--- drivers/devfreq/Kconfig | 9 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++ 3 files changed, 475 insertions(+) create mode 100644 drivers/devfreq/imx8m-ddrc.cdrivers/devfreq/Kconfig +0
-0@@ -89,10 +89,19 @@ config ARM_EXYNOS_BUS_DEVFREQ Each memory bus group could contain many memoby bus block. It reads PPMU counters of memory controllers by using DEVFREQ-event device and adjusts the operating frequencies and voltages with OPP support. This does not yet operate with optimal voltages.Quoted 5 lines
drivers/devfreq/Kconfig config ARM_EXYNOS_BUS_DEVFREQ · line 96
Quoted 3 lines
drivers/devfreq/Kconfig +3
-0+config ARM_IMX8M_DDRC_DEVFREQ + tristate "i.MX8M DDRC DEVFREQ Driver" + depends on ARCH_MXC && HAVE_ARM_SMCCCI'll edit it as following and applied it.
You corrupted the URLs in the binding patch when applying the series:
Quoted 9 lines
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
line 774, inresolve_from_url
document = self.store[url]
File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
line 22, in__getitem__
return self.store[self.normalize(uri)]
KeyError: 'https://protect2.fireeye.com/url?k=b51ff83f-e8cff0d7-b51e7370-000babff32e3-c25c03b8af1b12ee&u=http://devicetree.org/meta-schemas/core.yaml'
I'm sorry the url was changed when I applied them
because of the internal security system..
I fixed and updated it to devfreq next branch.
Thanks,
Chanwoo Choi
Re: [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
In reply to Leonard CrestezQuoted 35 lines · Leonard Crestez
This is used by the imx-ddrc devfreq driver to implement dynamic frequency scaling of DRAM.
Support for proactive scaling via interconnect will come later. The high-performance bus masters which need that (display, vpu, gpu) are mostly not yet enabled in upstream anyway.
Signed-off-by Leonard Crestez <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 ++++++++ .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 ++++++++ arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 +++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 ++++++++ 6 files changed, 90 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-evk.dts +7
-0@@ -75,10 +75,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M {
arch/arm64/boot/dts/freescale/imx8mm-evk.dts line 96
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +10
-0+ opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-750M { + opp-hz = /bits/ 64 <750000000>; + }; + }; +};
The SoC's device tree has the opp for the SoC. Since the SoC also has the DDR controller, why not put the opp for the DDR into the SoC's device tree set for its maximum rates. If the individual boards need to change them, they can do it on a case-by-case basis.
As more and more people add devices based on imx8m q/m/n, I can imaging a lot of these entries will be duplicated if they base their design on the reference evk for their respective SoC.
Quoted 161 lines
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +1
-0+ &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; phy-mode = "rgmii-id"; phy-handle = <ðphy0>;arch/arm64/boot/dts/freescale/imx8mm.dtsi +10
-0@@ -856,10 +856,20 @@ #interrupt-cells = <3>; interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MM_CLK_DRAM_CORE>, + <&clk IMX8MM_DRAM_PLL>, + <&clk IMX8MM_CLK_DRAM_ALT>, + <&clk IMX8MM_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +18
-0@@ -15,10 +15,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-600M { + opp-hz = /bits/ 64 <600000000>; + }; + }; +}; + &i2c1 { pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; pinctrl-0 = <&pinctrl_pmic>;arch/arm64/boot/dts/freescale/imx8mn.dtsi +10
-0@@ -757,10 +757,20 @@ #interrupt-cells = <3>; interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mn-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MN_CLK_DRAM_CORE>, + <&clk IMX8MN_DRAM_PLL>, + <&clk IMX8MN_CLK_DRAM_ALT>, + <&clk IMX8MN_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; };arch/arm64/boot/dts/freescale/imx8mq-evk.dts +24
-0@@ -103,10 +103,34 @@ &A53_3 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + /* + * On imx8mq B0 PLL can't be bypassed so low bus is 166M + */ + opp-166M { + opp-hz = /bits/ 64 <166935483>; + }; + opp-800M { + opp-hz = /bits/ 64 <800000000>; + }; + }; +}; + &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; phy-mode = "rgmii-id"; phy-handle = <ðphy0>;arch/arm64/boot/dts/freescale/imx8mq.dtsi +10
-1@@ -1111,10 +1111,20 @@ interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mq-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MQ_CLK_DRAM_CORE>, + <&clk IMX8MQ_DRAM_PLL_OUT>, + <&clk IMX8MQ_CLK_DRAM_ALT>, + <&clk IMX8MQ_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; --2.17.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
Quoted 52 lines · Adam Ford
Quoted 35 lines · Leonard Crestez
This is used by the imx-ddrc devfreq driver to implement dynamic frequency scaling of DRAM.
Support for proactive scaling via interconnect will come later. The high-performance bus masters which need that (display, vpu, gpu) are mostly not yet enabled in upstream anyway.
Signed-off-by Leonard Crestez <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 ++++++++ .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 ++++++++ arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 +++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 ++++++++ 6 files changed, 90 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-evk.dts +7
-0@@ -75,10 +75,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M {arch/arm64/boot/dts/freescale/imx8mm-evk.dts line 96
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +10
-0+ opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-750M { + opp-hz = /bits/ 64 <750000000>; + }; + }; +};The SoC's device tree has the opp for the SoC. Since the SoC also has the DDR controller, why not put the opp for the DDR into the SoC's device tree set for its maximum rates. If the individual boards need to change them, they can do it on a case-by-case basis.
Quoted 3 lines
As more and more people add devices based on imx8m q/m/n, I can imaging a lot of these entries will be duplicated if they base their design on the reference evk for their respective SoC.
The OPPs can vary from board to board for the same SoC. For example ddr4 and lpddr4 variants of the NXP evk boards have different setpoints.
If a default set was included in soc dtsi then some boards would end up having to use /delete-node/ and I wanted to avoid that. Last I check that feature wasn't even officially documented for dtc?
Perhaps this could be revisited if it ends up being duplicated on many boards.
--
Regards,
Leonard
Shawn Guo
AppliedRe: [PATCH v7 1/5] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram clocks
In reply to Leonard CrestezQuoted 11 lines · Leonard Crestez
These clocks are only modified as part of DRAM frequency switches during which DRAM itself is briefly inaccessible. The switch is performed with a SMC call to by TF-A which runs from a SRAM area; upon returning to linux several clocks bits are modified and we need to update them.
For rate bits an easy solution is to just mark with
CLK_GET_RATE_NOCACHEso that new rates are always read back from registers.Signed-off-by Leonard Crestez <[email protected]>Reviewed-by Abel Vesa <[email protected]>
Applied, thanks.
Shawn Guo
AppliedRe: [PATCH v7 2/5] clk: imx: Mark dram pll on 8mm and 8mn with CLK_GET_RATE_NOCACHE
In reply to Leonard CrestezQuoted 5 lines · Leonard Crestez
DRAM frequency switches are executed in firmware and can change the configuration of the DRAM PLL outside linux. Mark these CLKs with
CLK_GET_RATE_NOCACHEso we always read back the PLL config registers and recalculate rates.
Quoted 7 lines
In current DRAM frequency tables on 8mm/8mn only the maximum frequency uses the PLL so it's always configured in the same way. However reading back the PLL configuration is the correct behavior and allows additional setpoints in the future.
Signed-off-by Leonard Crestez <[email protected]>Reviewed-by Abel Vesa <[email protected]>
Applied, thanks.
Re: [PATCH v7 5/5] arm64: dts: imx8m: Add ddr controller nodes
In reply to Leonard CrestezQuoted 26 lines · Leonard Crestez
This is used by the imx-ddrc devfreq driver to implement dynamic frequency scaling of DRAM.
Support for proactive scaling via interconnect will come later. The high-performance bus masters which need that (display, vpu, gpu) are mostly not yet enabled in upstream anyway.
Signed-off-by Leonard Crestez <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 ++++++++ .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 ++++++++++++++ arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 ++++++++ arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 +++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 ++++++++ 6 files changed, 90 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-evk.dts +0
-0@@ -75,10 +75,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; };
arch/arm64/boot/dts/freescale/imx8mm-evk.dts line 88
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +9
-0+&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + };
As an idiomatic practice, we have newline between nodes.
I fixed it up and applied the patch.
Shawn
Quoted 164 lines
arch/arm64/boot/dts/freescale/imx8mm-evk.dts +9
-0+ opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-750M { + opp-hz = /bits/ 64 <750000000>; + }; + }; +}; + &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; phy-mode = "rgmii-id"; phy-handle = <ðphy0>;arch/arm64/boot/dts/freescale/imx8mm.dtsi +10
-0@@ -856,10 +856,20 @@ #interrupt-cells = <3>; interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mm-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MM_CLK_DRAM_CORE>, + <&clk IMX8MM_DRAM_PLL>, + <&clk IMX8MM_CLK_DRAM_ALT>, + <&clk IMX8MM_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +18
-0@@ -15,10 +15,28 @@ &A53_0 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + opp-600M { + opp-hz = /bits/ 64 <600000000>; + }; + }; +}; + &i2c1 { pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; pinctrl-0 = <&pinctrl_pmic>;arch/arm64/boot/dts/freescale/imx8mn.dtsi +10
-0@@ -757,10 +757,20 @@ #interrupt-cells = <3>; interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mn-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MN_CLK_DRAM_CORE>, + <&clk IMX8MN_DRAM_PLL>, + <&clk IMX8MN_CLK_DRAM_ALT>, + <&clk IMX8MN_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>; };arch/arm64/boot/dts/freescale/imx8mq-evk.dts +24
-0@@ -103,10 +103,34 @@ &A53_3 { cpu-supply = <&buck2_reg>; }; +&ddrc { + operating-points-v2 = <&ddrc_opp_table>; + + ddrc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-25M { + opp-hz = /bits/ 64 <25000000>; + }; + opp-100M { + opp-hz = /bits/ 64 <100000000>; + }; + /* + * On imx8mq B0 PLL can't be bypassed so low bus is 166M + */ + opp-166M { + opp-hz = /bits/ 64 <166935483>; + }; + opp-800M { + opp-hz = /bits/ 64 <800000000>; + }; + }; +}; + &fec1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; phy-mode = "rgmii-id"; phy-handle = <ðphy0>;arch/arm64/boot/dts/freescale/imx8mq.dtsi +10
-0@@ -1111,10 +1111,20 @@ interrupt-controller; interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; }; + ddrc: memory-controller@3d400000 { + compatible = "fsl,imx8mq-ddrc", "fsl,imx8m-ddrc"; + reg = <0x3d400000 0x400000>; + clock-names = "core", "pll", "alt", "apb"; + clocks = <&clk IMX8MQ_CLK_DRAM_CORE>, + <&clk IMX8MQ_DRAM_PLL_OUT>, + <&clk IMX8MQ_CLK_DRAM_ALT>, + <&clk IMX8MQ_CLK_DRAM_APB>; + }; + ddr-pmu@3d800000 { compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu"; reg = <0x3d800000 0x400000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;Signature · 1 line
2.17.1
Quoted 107 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Changes since v6:
* ReplaceARCH_MXC||COMPILE_TESTwithARCH_MXC&&HAVE_ARM_SMCCC
* Collect reviews
Link to v6: https://patchwork.kernel.org/cover/11244283/I'd rather not fix
COMPILE_TESTwith ifdefs for this driver, if anything that should be fixed in smccc header.ARCH_MXCdoesn't imply SMCCC, it also covers some very old chips which don't have it.Resending full series because that's the standard method.
Changes since v5:
* Fix a dram_apb/dram_alt mixup inimx8m_ddrc_set_freq
* Makeclk_get_parent_by_indexstatic (kbuild robot)
* Adjust messages inimx8m_ddrc_set_freq
* Use a for loop insideimx8m_ddrc_check_oppsinstead of while
* More elaborate description in dt-bindings file. Link to v5: https://patchwork.kernel.org/cover/11240289/Changes since v4:
* Restore empty_get_dev_status: testing shows this is *NOT* optional. If absent then switching tosimple_ondemandgovernor will trigger an Oops.
* Keep clk registration on single-line in clk-imx8m* for consistency with rest of the file.
* Drop explicit "selectPM_OPP"
* Check for NULLnew_dram_core_parent
* Rename "out_dis_" labels to out_disable_*
* Usedev_warnonimx8m_ddrc_set_freqerror paths after SMC call (where operation is not abandoned).
* More elaborate error messages inimx8m_ddrc_target
* More elaborate checks when fetching clks inimx8m_ddrc_set_freq
* Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names Recommendation"
* Defer perf support, it requires perf changes to fetch PMU by DT Link to v4: https://patchwork.kernel.org/cover/11235685/Changes since v3:
* Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm but soc integration is different.
* Move dt bindings to /memory-controllers/fsl/
* Fix dt validation issues
* Fiximx8mm.dtsiddrc referencingddrc_opp_tablewhich is only defined in evk
* Move opps to child of ddrc device node
* Only addimx_ddrc_get_dev_statusin perf patch.
* Adjust print messages
Link to v3: https://patchwork.kernel.org/cover/11221935/Changes since v2:
* Add support for entire imx8m family including imx8mq B0.
* Also mark dram PLLs asCLK_GET_RATE_NO_CACHE(required for imx8mq b0 low OPP)
* Explicitly update dram pll rate at the end ofimx_ddrc_set_freq.
* Usedo_divin imx-ddrc (kbuild robot)
* Improve explanations around addingCLK_GET_RATE_NO_CACHEto dram clks. (Stephen Boyd)
* Handle ddrc devfreq-events earlier for fewer probe defers.
* Validate DDRC opp tables versus firmware: supported OPPs depend on board and SOC revision.
* Move DDRC opp tables to board dts because they can vary based on ram type on board.
* Verify DDRC rate is changed in clk tree and otherwise report an error.
* Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ inimx_ddrc_find_freqinstead.
* Split away from NOC scaling and interconnect support.
Link to v2: https://patchwork.kernel.org/cover/11104113/Changes since v1:
* bindings: Stop using "contains" for "compatible"
* bindings: Set "additionalProperties: false" and document missing stuff.
* Remove (c) from NXP copyright notice
* Fix various checkpatch issues
* Remove unuseddram_alt_rootclk from imx-ddrc
Link to v1: https://patchwork.kernel.org/cover/11090649/Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes
Quoted 13 lines
.../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 +
Since there is a Kconfig change, should there me a defconfig change?
Quoted 5 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yaml create mode 100644 drivers/devfreq/imx8m-ddrc.c
I applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Is there some way to get the dram_core_clk to drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.
thanks,
adam
Quoted 9 lines
--
2.17.1_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 122 lines · Adam Ford
Quoted 107 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Changes since v6:
* ReplaceARCH_MXC||COMPILE_TESTwithARCH_MXC&&HAVE_ARM_SMCCC
* Collect reviews
Link to v6: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11244283%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275120308&sdata=ZEZnG6pijjj4MObC99c6%2BvC8BFEfT1KLVxbJCNocoWw%3D&reserved=0I'd rather not fix
COMPILE_TESTwith ifdefs for this driver, if anything that should be fixed in smccc header.ARCH_MXCdoesn't imply SMCCC, it also covers some very old chips which don't have it.Resending full series because that's the standard method.
Changes since v5:
* Fix a dram_apb/dram_alt mixup inimx8m_ddrc_set_freq
* Makeclk_get_parent_by_indexstatic (kbuild robot)
* Adjust messages inimx8m_ddrc_set_freq
* Use a for loop insideimx8m_ddrc_check_oppsinstead of while
* More elaborate description in dt-bindings file.
Link to v5: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11240289%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=mMqglPQign%2B6NHgmDYoZ74%2FZeThGI6%2FgNkajo1VaHTI%3D&reserved=0Changes since v4:
* Restore empty_get_dev_status: testing shows this is *NOT* optional. If
absent then switching tosimple_ondemandgovernor will trigger an Oops.
* Keep clk registration on single-line in clk-imx8m* for consistency with rest
of the file.
* Drop explicit "selectPM_OPP"
* Check for NULLnew_dram_core_parent
* Rename "out_dis_" labels to out_disable_*
* Usedev_warnonimx8m_ddrc_set_freqerror paths after SMC call (where
operation is not abandoned).
* More elaborate error messages inimx8m_ddrc_target
* More elaborate checks when fetching clks inimx8m_ddrc_set_freq
* Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names
Recommendation"
* Defer perf support, it requires perf changes to fetch PMU by DT
Link to v4: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11235685%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=LXG4bo0l7FOttZIolJE73CK67AAAW72xfx8yq3Vld7o%3D&reserved=0Changes since v3:
* Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm
but soc integration is different.
* Move dt bindings to /memory-controllers/fsl/
* Fix dt validation issues
* Fiximx8mm.dtsiddrc referencingddrc_opp_tablewhich is only defined in evk
* Move opps to child of ddrc device node
* Only addimx_ddrc_get_dev_statusin perf patch.
* Adjust print messages
Link to v3: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11221935%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=%2FFGddgm7jq87j7tz6gNd%2B7V%2BGX4KF5RaPsnXK2kITdQ%3D&reserved=0Changes since v2:
* Add support for entire imx8m family including imx8mq B0.
* Also mark dram PLLs asCLK_GET_RATE_NO_CACHE(required for imx8mq b0 low OPP)
* Explicitly update dram pll rate at the end ofimx_ddrc_set_freq.
* Usedo_divin imx-ddrc (kbuild robot)
* Improve explanations around addingCLK_GET_RATE_NO_CACHEto dram clks.
(Stephen Boyd)
* Handle ddrc devfreq-events earlier for fewer probe defers.
* Validate DDRC opp tables versus firmware: supported OPPs depend on board and
SOC revision.
* Move DDRC opp tables to board dts because they can vary based on ram type on
board.
* Verify DDRC rate is changed in clk tree and otherwise report an error.
* Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ inimx_ddrc_find_freqinstead.
* Split away from NOC scaling and interconnect support.
Link to v2: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11104113%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=3hh0dR1h4Esc6qo79QQKH%2FkUQjrOUgLANR0PcIz1Pss%3D&reserved=0Changes since v1:
* bindings: Stop using "contains" for "compatible"
* bindings: Set "additionalProperties: false" and document missing stuff.
* Remove (c) from NXP copyright notice
* Fix various checkpatch issues
* Remove unuseddram_alt_rootclk from imx-ddrc
Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11090649%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=Hj6NEmoaRHoR%2BQpFoUDdTlybO%2FSTatO2fFo20UGLJf0%3D&reserved=0Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodesQuoted 13 lines
.../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 +
Quoted 1 line
Since there is a
Kconfigchange, should there me a defconfig change?
Yes, you need to enable CONFIG_ARM_IMX8M_DDRC_DEVFREQ in order to test this. Enabling as "m" should work.
Quoted 12 lines
Quoted 5 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-)create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yamlcreate mode 100644drivers/devfreq/imx8m-ddrc.cI applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Quoted 8 lines
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Is there some way to get the
dram_core_clkto drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.
Current upstream driver just keeps current frequency by default. Try the following:
cd /sys/class/devfreq/devices/devfreq0
echo userspace > governor
echo 25000000 > userspace/set_freq
cat /sys/kernel/debug/clk/dram_core_clk/clk_rate
echo 750000000 > userspace/set_freq
cat /sys/kernel/debug/clk/dram_core_clk/clk_rate
--
Regards,
Leonard
Quoted 124 lines · Leonard Crestez
Quoted 122 lines · Adam Ford
Quoted 120 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Changes since v6:
* ReplaceARCH_MXC||COMPILE_TESTwithARCH_MXC&&HAVE_ARM_SMCCC
* Collect reviews
Link to v6: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11244283%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275120308&sdata=ZEZnG6pijjj4MObC99c6%2BvC8BFEfT1KLVxbJCNocoWw%3D&reserved=0I'd rather not fix
COMPILE_TESTwith ifdefs for this driver, if anything that should be fixed in smccc header.ARCH_MXCdoesn't imply SMCCC, it also covers some very old chips which don't have it.Resending full series because that's the standard method.
Changes since v5:
* Fix a dram_apb/dram_alt mixup inimx8m_ddrc_set_freq
* Makeclk_get_parent_by_indexstatic (kbuild robot)
* Adjust messages inimx8m_ddrc_set_freq
* Use a for loop insideimx8m_ddrc_check_oppsinstead of while
* More elaborate description in dt-bindings file.
Link to v5: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11240289%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=mMqglPQign%2B6NHgmDYoZ74%2FZeThGI6%2FgNkajo1VaHTI%3D&reserved=0Changes since v4:
* Restore empty_get_dev_status: testing shows this is *NOT* optional. If
absent then switching tosimple_ondemandgovernor will trigger an Oops.
* Keep clk registration on single-line in clk-imx8m* for consistency with rest
of the file.
* Drop explicit "selectPM_OPP"
* Check for NULLnew_dram_core_parent
* Rename "out_dis_" labels to out_disable_*
* Usedev_warnonimx8m_ddrc_set_freqerror paths after SMC call (where
operation is not abandoned).
* More elaborate error messages inimx8m_ddrc_target
* More elaborate checks when fetching clks inimx8m_ddrc_set_freq
* Rename ddrc nodes to memory-controller@* as per devicetree.org "Generic Names
Recommendation"
* Defer perf support, it requires perf changes to fetch PMU by DT
Link to v4: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11235685%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=LXG4bo0l7FOttZIolJE73CK67AAAW72xfx8yq3Vld7o%3D&reserved=0Changes since v3:
* Rename to imx8m-ddrc. Similar blocks are present on imx7d and imx8qxp/imx8qm
but soc integration is different.
* Move dt bindings to /memory-controllers/fsl/
* Fix dt validation issues
* Fiximx8mm.dtsiddrc referencingddrc_opp_tablewhich is only defined in evk
* Move opps to child of ddrc device node
* Only addimx_ddrc_get_dev_statusin perf patch.
* Adjust print messages
Link to v3: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11221935%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=%2FFGddgm7jq87j7tz6gNd%2B7V%2BGX4KF5RaPsnXK2kITdQ%3D&reserved=0Changes since v2:
* Add support for entire imx8m family including imx8mq B0.
* Also mark dram PLLs asCLK_GET_RATE_NO_CACHE(required for imx8mq b0 low OPP)
* Explicitly update dram pll rate at the end ofimx_ddrc_set_freq.
* Usedo_divin imx-ddrc (kbuild robot)
* Improve explanations around addingCLK_GET_RATE_NO_CACHEto dram clks.
(Stephen Boyd)
* Handle ddrc devfreq-events earlier for fewer probe defers.
* Validate DDRC opp tables versus firmware: supported OPPs depend on board and
SOC revision.
* Move DDRC opp tables to board dts because they can vary based on ram type on
board.
* Verify DDRC rate is changed in clk tree and otherwise report an error.
* Change imx_ddrc_freq.rate to be measure in MT/s and round down from HZ inimx_ddrc_find_freqinstead.
* Split away from NOC scaling and interconnect support.
Link to v2: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11104113%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=3hh0dR1h4Esc6qo79QQKH%2FkUQjrOUgLANR0PcIz1Pss%3D&reserved=0Changes since v1:
* bindings: Stop using "contains" for "compatible"
* bindings: Set "additionalProperties: false" and document missing stuff.
* Remove (c) from NXP copyright notice
* Fix various checkpatch issues
* Remove unuseddram_alt_rootclk from imx-ddrc
Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fcover%2F11090649%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cb7adb366b79f4c564c7908d783bf23ae%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637122729275130306&sdata=Hj6NEmoaRHoR%2BQpFoUDdTlybO%2FSTatO2fFo20UGLJf0%3D&reserved=0Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes.../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 +
Quoted 4 lines
Quoted 1 line
Since there is a
Kconfigchange, should there me a defconfig change?Yes, you need to enable
CONFIG_ARM_IMX8M_DDRC_DEVFREQin order to test this. Enabling as "m" should work.
I enabled it as 'm' but I was more curious to know if we should push this upstream with the rest of the series.
Quoted 18 lines
Quoted 18 lines
Quoted 6 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-)create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yamlcreate mode 100644drivers/devfreq/imx8m-ddrc.cI applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Quoted 8 lines
Quoted 3 lines
Is there some way to get the
dram_core_clkto drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.Current upstream driver just keeps current frequency by default. Try the following:
cd
/sys/class/devfreq/devices/devfreq0
can't cd to /sys/class/devfreq/devices/devfreq0: No such file or directory
I did some checking and I found:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19
Was there some prerequisite patches I needed to apply before your series?
I applied them against 5.5-r1, but if there is a better branch somewhere, I can try that as well.
adam
Quoted 9 lines
echo userspace > governor
echo 25000000 > userspace/set_freq
cat/sys/kernel/debug/clk/dram_core_clk/clk_rate
echo 750000000 > userspace/set_freq
cat/sys/kernel/debug/clk/dram_core_clk/clk_rate--
Regards,
Leonard
Quoted 52 lines · Adam Ford
Quoted 51 lines · Leonard Crestez
Quoted 49 lines · Adam Ford
Quoted 47 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes.../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 +
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Since there is a
Kconfigchange, should there me a defconfig change?Yes, you need to enable
CONFIG_ARM_IMX8M_DDRC_DEVFREQin order to test this. Enabling as "m" should work.I enabled it as 'm' but I was more curious to know if we should push this upstream with the rest of the series.
I skipped enabling because it's very experimental; maybe after imx interconnect is also enabled?
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
Quoted 5 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-)create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yamlcreate mode 100644drivers/devfreq/imx8m-ddrc.cI applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Quoted 8 lines
Quoted 3 lines
Is there some way to get the
dram_core_clkto drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.Current upstream driver just keeps current frequency by default. Try the following:
cd
/sys/class/devfreq/devices/devfreq0
Quoted 7 lines
can't cd to
/sys/class/devfreq/devices/devfreq0: No such file or directoryI did some checking and I found:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19Was there some prerequisite patches I needed to apply before your series?
You need a recent version of TF-A from nxp ( upstream). Try this:
https://source.codeaurora.org/external/imx/imx-atf/log/?h=imx_4.19.35_1.1.0
Or this:
https://github.com/cdleonard/arm-trusted-firmware/commits/imx_2.0.y_busfreq
Support on upstream ATF is not yet available
--
Regards,
Leonard
Quoted 99 lines · Leonard Crestez
Quoted 52 lines · Adam Ford
Quoted 51 lines · Leonard Crestez
Quoted 49 lines · Adam Ford
Quoted 47 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes.../memory-controllers/fsl/imx8m-ddrc.yaml | 72 +++ arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mm.dtsi | 10 + .../boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 + arch/arm64/boot/dts/freescale/imx8mn.dtsi | 10 + arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 10 + drivers/clk/imx/clk-imx8mm.c | 11 +- drivers/clk/imx/clk-imx8mn.c | 12 +- drivers/clk/imx/clk-imx8mq.c | 12 +- drivers/clk/imx/clk-pll14xx.c | 7 + drivers/clk/imx/clk.h | 1 + drivers/devfreq/Kconfig | 9 +Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Since there is a
Kconfigchange, should there me a defconfig change?Yes, you need to enable
CONFIG_ARM_IMX8M_DDRC_DEVFREQin order to test this. Enabling as "m" should work.I enabled it as 'm' but I was more curious to know if we should push this upstream with the rest of the series.
I skipped enabling because it's very experimental; maybe after imx interconnect is also enabled?
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
Quoted 5 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-)create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yamlcreate mode 100644drivers/devfreq/imx8m-ddrc.cI applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Quoted 8 lines
Quoted 3 lines
Is there some way to get the
dram_core_clkto drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.Current upstream driver just keeps current frequency by default. Try the following:
cd
/sys/class/devfreq/devices/devfreq0Quoted 7 lines
can't cd to
/sys/class/devfreq/devices/devfreq0: No such file or directoryI did some checking and I found:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19Was there some prerequisite patches I needed to apply before your series?
Quoted 8 lines
You need a recent version of TF-A from nxp ( upstream). Try this:
https://source.codeaurora.org/external/imx/imx-atf/log/?h=imx_4.19.35_1.1.0
Or this:
https://github.com/cdleonard/arm-trusted-firmware/commits/imx_2.0.y_busfreqSupport on upstream ATF is not yet available
I cloned your github branch and built it per the instructions in the u-boot readme file.
did a make clean on u-boot, copied the bl31.bin to u-boot and rebuild per U-Boot's instructions.
U-Boot booted and Linux booted, but I still get:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19
I am still learning the imx8mm platform, so please forgive my ignorance.
adam
Quoted 4 lines
--
Regards,
Leonard
Quoted 114 lines · Adam Ford
Quoted 99 lines · Leonard Crestez
Quoted 52 lines · Adam Ford
Quoted 51 lines · Leonard Crestez
Quoted 49 lines · Adam Ford
Quoted 47 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes
.../memory-controllers/fsl/imx8m-ddrc.yaml| 72 +++
arch/arm64/boot/dts/freescale/imx8mm-evk.dts| 18 +
arch/arm64/boot/dts/freescale/imx8mm.dtsi| 10 +
.../boot/dts/freescale/imx8mn-ddr4-evk.dts| 18 +
arch/arm64/boot/dts/freescale/imx8mn.dtsi| 10 +
arch/arm64/boot/dts/freescale/imx8mq-evk.dts| 24 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi| 10 +
drivers/clk/imx/clk-imx8mm.c| 11 +-
drivers/clk/imx/clk-imx8mn.c| 12 +-
drivers/clk/imx/clk-imx8mq.c| 12 +-
drivers/clk/imx/clk-pll14xx.c| 7 +
drivers/clk/imx/clk.h| 1 +
drivers/devfreq/Kconfig| 9 +Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Since there is a
Kconfigchange, should there me a defconfig change?Yes, you need to enable
CONFIG_ARM_IMX8M_DDRC_DEVFREQin order to test this. Enabling as "m" should work.I enabled it as 'm' but I was more curious to know if we should push this upstream with the rest of the series.
I skipped enabling because it's very experimental; maybe after imx interconnect is also enabled?
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
Quoted 5 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-)create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yamlcreate mode 100644drivers/devfreq/imx8m-ddrc.cI applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Quoted 8 lines
Quoted 3 lines
Is there some way to get the
dram_core_clkto drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.Current upstream driver just keeps current frequency by default. Try the following:
cd
/sys/class/devfreq/devices/devfreq0Quoted 7 lines
can't cd to
/sys/class/devfreq/devices/devfreq0: No such file or directoryI did some checking and I found:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19Was there some prerequisite patches I needed to apply before your series?
Quoted 8 lines
You need a recent version of TF-A from nxp ( upstream). Try this:
Support on upstream ATF is not yet available
I cloned your github branch and built it per the instructions in the u-boot readme file.
did a make clean on u-boot, copied the bl31.bin to u-boot and rebuild per U-Boot's instructions.
Quoted 4 lines
U-Boot booted and Linux booted, but I still get:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19
Which version of u-boot is that, upstream? I'm subscribed to uboot mailing list and I see that imx8m support has its own separate issues but my familiarity is limited :(
I've only ever tested with NXP uboot and the NXP version of mkimage:
https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
https://source.codeaurora.org/external/imx/imx-mkimage/
My bootloader prints the following BuildInfo:
- ATF 70fa7bc
- U-Boot 2019.04-00019-g4d377539a119
--
Regards,
Leonard
Quoted 116 lines · Leonard Crestez
Quoted 114 lines · Adam Ford
Quoted 99 lines · Leonard Crestez
Quoted 52 lines · Adam Ford
Quoted 51 lines · Leonard Crestez
Quoted 49 lines · Adam Ford
Quoted 47 lines · Leonard Crestez
This adds support for dynamic scaling of the DDR Controller (ddrc) present on i.MX8M series chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
DRAM frequency switching requires clock manipulation but during this operation DRAM itself is briefly inaccessible so this operation is performed a SMC call to by TF-A which runs from a SRAM area. Upon returning to linux the clock tree is updated to correspond to hardware configuration.
This is handled via
CLK_GET_RATE_NO_CACHEfor dividers but muxes are handled
manually: the driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will callclk_set_parentto ensure the parents in clock framework are up-to-date.This series is useful standalone and roughly similar to devfreq drivers for tegra and rockchip.
Running at lower dram rates saves power but can affect the functionality of other blocks in the chip (display, vpu etc). Support for in-kernel constraints will some separately.
This series has no dependencies outside linux-next. The driver depends on features from the NXP branch of TF-A and will cleanly fail to probe on mainline. There are also plans to upstream dram dvfs in TF-A.
Leonard Crestez (5):
clk: imx8m: SetCLK_GET_RATE_NOCACHEon dram clocks
clk: imx: Mark dram pll on 8mm and 8mn withCLK_GET_RATE_NOCACHE
dt-bindings: memory: Add bindings for imx8m ddr controller PM / devfreq: Add dynamic scaling for imx8m ddr controller
arm64: dts: imx8m: Add ddr controller nodes
.../memory-controllers/fsl/imx8m-ddrc.yaml| 72 +++
arch/arm64/boot/dts/freescale/imx8mm-evk.dts| 18 +
arch/arm64/boot/dts/freescale/imx8mm.dtsi| 10 +
.../boot/dts/freescale/imx8mn-ddr4-evk.dts| 18 +
arch/arm64/boot/dts/freescale/imx8mn.dtsi| 10 +
arch/arm64/boot/dts/freescale/imx8mq-evk.dts| 24 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi| 10 +
drivers/clk/imx/clk-imx8mm.c| 11 +-
drivers/clk/imx/clk-imx8mn.c| 12 +-
drivers/clk/imx/clk-imx8mq.c| 12 +-
drivers/clk/imx/clk-pll14xx.c| 7 +
drivers/clk/imx/clk.h| 1 +
drivers/devfreq/Kconfig| 9 +Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Since there is a
Kconfigchange, should there me a defconfig change?Yes, you need to enable
CONFIG_ARM_IMX8M_DDRC_DEVFREQin order to test this. Enabling as "m" should work.I enabled it as 'm' but I was more curious to know if we should push this upstream with the rest of the series.
I skipped enabling because it's very experimental; maybe after imx interconnect is also enabled?
Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
Quoted 5 lines
drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 ++++++++++++++++++ 15 files changed, 670 insertions(+), 10 deletions(-)create mode 100644
Documentation/devicetree/bindings/memory-controllers/fsl/imx8m-ddrc.yamlcreate mode 100644drivers/devfreq/imx8m-ddrc.cI applied the whole series against 5.5-rc1 and I am trying to test it. I know the 4.14 kernel NXP posted on Code Aurora is capable to lowering the DDRC controller to 25MHz on the 8MM when the video is off. Since there is no video support yet for the 8MM, I was expecting to see the DDRC clock to be at or around 25MHz.
Using debug FS, I can see the dram core clock is still running at 750MHz, and measuring power, it shows something consistent with what I see on the Code Aurora kernel with video turned on and the clock at 750MHz.
Quoted 8 lines
Quoted 3 lines
Is there some way to get the
dram_core_clkto drop to 25MHz to see some power reduction? The same commands used in the Yocto build don't apply here since we don't have video.Current upstream driver just keeps current frequency by default. Try the following:
cd
/sys/class/devfreq/devices/devfreq0Quoted 7 lines
can't cd to
/sys/class/devfreq/devices/devfreq0: No such file or directoryI did some checking and I found:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19Was there some prerequisite patches I needed to apply before your series?
Quoted 8 lines
You need a recent version of TF-A from nxp ( upstream). Try this:
Support on upstream ATF is not yet available
I cloned your github branch and built it per the instructions in the u-boot readme file.
did a make clean on u-boot, copied the bl31.bin to u-boot and rebuild per U-Boot's instructions.
Quoted 8 lines
Quoted 4 lines
U-Boot booted and Linux booted, but I still get:
imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
firmware freq info: -19Which version of u-boot is that, upstream? I'm subscribed to uboot mailing list and I see that imx8m support has its own separate issues but my familiarity is limited :(
U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40 -0600)
Quoted 5 lines
I've only ever tested with NXP uboot and the NXP version of mkimage:
https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
https://source.codeaurora.org/external/imx/imx-mkimage/
I will try your versions and see what happens.
Quoted 5 lines
My bootloader prints the following BuildInfo:
- ATF 70fa7bc- U-Boot 2019.04-00019-g4d377539a119
Thanks for your help.
adam
Quoted 3 lines
--
Regards,
Leonard
Chanwoo Choi
maintainerPATCH v8 1/1 PM / devfreq: Add dynamic scaling for imx8m ddr controller
In reply to Leonard CrestezFrom: Leonard Crestez <[email protected]>
Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
The DRAM clocks on imx8m have the following structure (abridged):
+----------+ |\ +------+
| dram_pll |-------|M| dram_core | |
+----------+ |U|---------->| D |
/--|X| | D |
dram_alt_root | |/ | R |
| | C |
+---------+ | |
|FIX DIV/4| | |
+---------+ | |
composite: | | |
+----------+ | | |
| dram_alt |----/ | |
+----------+ | |
| dram_apb |-------------------->| |
+----------+ +------+The dram_pll is used for higher rates and dram_alt is used for lower rates. The dram_alt and dram_apb clocks are "imx composite" and their parent can also be modified.
This driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call clk_set_parent to ensure the parents in clock framework are up-to-date.
The driver relies on dram_pll dram_alt and dram_apb being marked with CLK_GET_RATE_NOCACHE for rate updates.
---
Changes from v7:
- Squash patch[1] to this patch
[1] https://patchwork.kernel.org/patch/11303869/
- [PATCH] PM / devfreq: imx8m-ddrc: Fix argument swap in error print
drivers/devfreq/Kconfig | 10 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx8m-ddrc.c | 465 +++++++++++++++++++++++++++++++++++ 3 files changed, 476 insertions(+) create mode 100644 drivers/devfreq/imx8m-ddrc.c
drivers/devfreq/Kconfig +10 -0
@@ -91,6 +91,16 @@ config ARM_EXYNOS_BUS_DEVFREQ and adjusts the operating frequencies and voltages with OPP support. This does not yet operate with optimal voltages. +config ARM_IMX8M_DDRC_DEVFREQ + tristate "i.MX8M DDRC DEVFREQ Driver" + depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \ + (COMPILE_TEST && HAVE_ARM_SMCCC) + select DEVFREQ_GOV_SIMPLE_ONDEMAND + select DEVFREQ_GOV_USERSPACE + help + This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows + adjusting DRAM frequency. + config ARM_TEGRA_DEVFREQ tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
drivers/devfreq/Makefile +1 -0
@@ -9,6 +9,7 @@ obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o # DEVFREQ Drivers obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o +obj-$(CONFIG_ARM_IMX8M_DDRC_DEVFREQ) += imx8m-ddrc.o obj-$(CONFIG_ARM_RK3399_DMC_DEVFREQ) += rk3399_dmc.o obj-$(CONFIG_ARM_TEGRA_DEVFREQ) += tegra30-devfreq.o obj-$(CONFIG_ARM_TEGRA20_DEVFREQ) += tegra20-devfreq.o
drivers/devfreq/imx8m-ddrc.c new file +465 -0
465 lines not on this page · raw message
Signature · 1 line
2.17.1
Chanwoo Choi
maintainerQuoted 39 lines · Chanwoo Choi
From: Leonard Crestez <[email protected]>
Add driver for dynamic scaling the DDR Controller on imx8m chips. Actual frequency switching is implemented inside TF-A, this driver wraps the SMC calls and synchronizes the clk tree.
The DRAM clocks on imx8m have the following structure (abridged):
+----------+ |\ +------+ | dram_pll |-------|M| dram_core | | +----------+ |U|---------->| D | /--|X| | D | dram_alt_root | |/ | R | | | C | +---------+ | | |FIX DIV/4| | | +---------+ | | composite: | | | +----------+ | | | | dram_alt |----/ | | +----------+ | | | dram_apb |-------------------->| | +----------+ +------+The
dram_pllis used for higher rates anddram_altis used for lower rates. Thedram_altanddram_apbclocks are "imx composite" and their parent can also be modified.This driver will prepare/enable the new parents ahead of switching (so that the expected roots are enabled) and afterwards it will call
clk_set_parentto ensure the parents in clock framework are up-to-date.The driver relies on
dram_plldram_altanddram_apbbeing marked withCLK_GET_RATE_NOCACHEfor rate updates.Signed-off-by Leonard Crestez <[email protected]>Acked-by Chanwoo Choi <[email protected]>[cw00.choi: Edit the COMPILE_TEST module dependency in Kconfig]Signed-off-by Chanwoo Choi <[email protected]>
Quoted 5 lines
---
Changes from v7:
- Squash patch[1] to this patch
[1] https://patchwork.kernel.org/patch/11303869/
- [PATCH] PM / devfreq: imx8m-ddrc: Fix argument swap in error print
Applied it.
(snip)
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Quoted 41 lines · Adam Ford
On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
> > U-Boot booted and Linux booted, but I still get: > > > > imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init > > firmware freq info: -19 > > Which version of u-boot is that, upstream? I'm subscribed to uboot > mailing list and I see that imx8m support has its own separate issues > but my familiarity is limited :( U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40 -0600) > > I've only ever tested with NXP uboot and the NXP version of mkimage: > > https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0 <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0> > https://source.codeaurora.org/external/imx/imx-mkimage/ <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0> I will try your versions and see what happens. > My bootloader prints the following BuildInfo: > - ATF 70fa7bc > > - U-Boot 2019.04-00019-g4d377539a119 > Thanks for your help.I wanted to try again after everything was merged into linux-next.
I am using the U-Boot master (as of 10 Jan 2020), with ATF from 4.19.35_1.1.0 from Code Aurora. I have tried your ATF, but I don't see any change in behavior. I have made the DDRC a module, but I still get the same error message.
Quoted 4 lines
[ 2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init firmware freq info: -19
Is there something else I can try?
Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).
I understand you want to use uboot and atf master, apparently they both need to be patched for this feature to work. It would still be interesting to validate.
--
Regards,
Leonard
Quoted 46 lines · Leonard Crestez
Quoted 44 lines · Adam Ford
On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <[email protected] <mailto:[email protected]>> wrote:
> > U-Boot booted and Linux booted, but I still get: > > > > imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init > > firmware freq info: -19 > > Which version of u-boot is that, upstream? I'm subscribed to uboot > mailing list and I see that imx8m support has its own separate issues > but my familiarity is limited :( U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40 -0600) > > I've only ever tested with NXP uboot and the NXP version of mkimage: > > https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0 <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0> > https://source.codeaurora.org/external/imx/imx-mkimage/ <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0> I will try your versions and see what happens. > My bootloader prints the following BuildInfo: > - ATF 70fa7bc > > - U-Boot 2019.04-00019-g4d377539a119 > Thanks for your help.I wanted to try again after everything was merged into linux-next.
I am using the U-Boot master (as of 10 Jan 2020), with ATF from 4.19.35_1.1.0 from Code Aurora. I have tried your ATF, but I don't see any change in behavior. I have made the DDRC a module, but I still get the same error message.
[ 2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed toinit firmware freq info: -19
Quoted 7 lines
Quoted 1 line
Is there something else I can try?
Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).
I understand you want to use uboot and atf master, apparently they both need to be patched for this feature to work. It would still be interesting to validate.
I was able to get the 8MM to work with this new driver using the uboot branch from Code Aurora. Could you point me to what in U-Boot needs to be pulled forward to the mainline? I'd be willing to help if I can.
Thanks for your help.
adam
Quoted 4 lines
--
Regards,
Leonard