pinctrl: Use the correct style for SPDX License Identifier
Subsystems (8)
cover pinctrl: Use the correct style for SPDX License Identifier
This patch corrects the SPDX License Identifier style in the pinctrl driver related files.
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46
and some manual changes.
Nishad Kamdar (5):
pinctrl: actions: Use the correct style for SPDX License Identifier
pinctrl: mediatek: Use the correct style for SPDX License Identifier
pinctrl: meson-axg: Use the correct style for SPDX License Identifier
pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
pinctrl: stm32: Use the correct style for SPDX License Identifier
drivers/pinctrl/actions/pinctrl-owl.h | 2 +- drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 2 +- drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h | 2 +- drivers/pinctrl/sh-pfc/core.h | 4 ++-- drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++-- drivers/pinctrl/stm32/pinctrl-stm32.h | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/5 pinctrl: actions: Use the correct style for SPDX License Identifier
This patch corrects the SPDX License Identifier style in header file related Actions Semi OWL pinctrl driver. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
--- drivers/pinctrl/actions/pinctrl-owl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/actions/pinctrl-owl.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * OWL SoC's Pinctrl definitions *
Signature · 1 line
2.17.1
PATCH 2/5 pinctrl: mediatek: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarThis patch corrects the SPDX License Identifier style in header file related mediatek mt2712 pinctrl driver. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
--- drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (C) 2018 MediaTek Inc. * Author: Zhiyong Tao <[email protected]>
Signature · 1 line
2.17.1
PATCH 3/5 pinctrl: meson-axg: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarThis patch corrects the SPDX License Identifier style in header file related Meson axg SoC pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
--- drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h +1 -1
@@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ /* * Copyright (c) 2017 Baylibre SAS. * Author: Jerome Brunet <[email protected]>
@@ -5,7 +6,6 @@* Copyright (c) 2017 Amlogic, Inc. All rights reserved. * Author: Xingyu Chen <[email protected]> * -* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ struct meson_pmx_bank {
Signature · 1 line
2.17.1
PATCH 4/5 pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarThis patch corrects the SPDX License Identifier style in header files related to Reneses Soc pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
--- drivers/pinctrl/sh-pfc/core.h | 4 ++-- drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/sh-pfc/core.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* +/* SPDX-License-Identifier: GPL-2.0 */ +/* * SuperH Pin Function Controller support. * * Copyright (C) 2012 Renesas Solutions Corp.
drivers/pinctrl/sh-pfc/sh_pfc.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* +/* SPDX-License-Identifier: GPL-2.0 */ +/* * SuperH Pin Function Controller Support * * Copyright (c) 2008 Magnus Damm
Signature · 1 line
2.17.1
PATCH 5/5 pinctrl: stm32: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarThis patch corrects the SPDX License Identifier style in header file related to STMicroelectronics pinctrl driver. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
--- drivers/pinctrl/stm32/pinctrl-stm32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/stm32/pinctrl-stm32.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (C) Maxime Coquelin 2015 * Copyright (C) STMicroelectronics 2017
Signature · 1 line
2.17.1
Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarHi Nishad,
Quoted 3 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header files related to Reneses Soc pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.
Is it incorrect to not have an explicit block comment? Other recommendations have been to integrate the SPDX comment line into an existing comment header, if it exists....
Quoted 27 lines
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>--- drivers/pinctrl/sh-pfc/core.h | 4 ++-- drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/pinctrl/sh-pfc/core.h +2
-2@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* +/* SPDX-License-Identifier: GPL-2.0 */ +/* * SuperH Pin Function Controller support. * * Copyright (C) 2012 Renesas Solutions Corp. drivers/pinctrl/sh-pfc/sh_pfc.h +0
-0
drivers/pinctrl/sh-pfc/sh_pfc.h line 5
Quoted 7 lines
drivers/pinctrl/sh-pfc/sh_pfc.h +2
-2@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* +/* SPDX-License-Identifier: GPL-2.0 */ +/* * SuperH Pin Function Controller Support * * Copyright (c) 2008 Magnus Damm
Gr{oetje,eeting}s,
Geert
Signature · 10 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Andreas Färber
maintainerRe: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Hi Geert,
Am 27.11.19 um 21:37 schrieb Geert Uytterhoeven:
Quoted 6 lines · Nishad Kamdar
Quoted 3 lines
This patch corrects the SPDX License Identifier style in header files related to Reneses Soc pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.Is it incorrect to not have an explicit block comment?
Yes, Greg said so to me. He suggested I provide a patch against the documentation if the docs are not clear enough, but I didn't get around to it (and it's not my rule in the first place, so I'd appreciate the person making that rule to take care of documenting it).
However, if we're touching these lines anyway, shouldn't we be updating the SPDX Identifier to GPL-2.0-only while at it?
Cheers,
Andreas
Signature · 9 lines
SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Quoted 2 lines · Andreas Färber
However, if we're touching these lines anyway, shouldn't we be updating the SPDX Identifier to GPL-2.0-only while at it?
Probably better to do that with a treewide script one day.
https://lkml.org/lkml/2018/8/16/487
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Andreas Färber
maintainerRe: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarAm 27.11.19 um 17:40 schrieb Nishad Kamdar:
Quoted 2 lines
This patch corrects the SPDX License Identifier style in header file related Actions Semi OWL pinctrl driver.
Owl
Quoted 18 lines
For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used).Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>--- drivers/pinctrl/actions/pinctrl-owl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/actions/pinctrl-owl.h +0
-0
drivers/pinctrl/actions/pinctrl-owl.h line 1
Quoted 2 lines
drivers/pinctrl/actions/pinctrl-owl.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */
This is not a uapi or asm header, which that /* */ rule was later added for, I thought?
drivers/pinctrl/actions/pinctrl-owl.h line 4
Quoted 3 lines
drivers/pinctrl/actions/pinctrl-owl.h +0
-0/* * OWL SoC's Pinctrl definitions *
Not objecting, just making sure we're not blindly refactoring code.
If doing this, I suggest updating to GPL-2.0-or-later.
Regards,
Andreas
Signature · 4 lines
SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
In reply to Joe PerchesQuoted 5 lines · Joe Perches
Quoted 2 lines · Andreas Färber
However, if we're touching these lines anyway, shouldn't we be updating the SPDX Identifier to GPL-2.0-only while at it?
Probably better to do that with a treewide script one day.
Yeah... But it's already more than one year after
Quoted 1 line
and Documentation/process/license-rules.rst (which is the authoritive rule?) still hasn't been updated...
Gr{oetje,eeting}s,
Geert
Signature · 10 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Quoted 5 lines · Geert Uytterhoeven
Quoted 4 lines · Joe Perches
Quoted 2 lines · Andreas Färber
However, if we're touching these lines anyway, shouldn't we be updating the SPDX Identifier to GPL-2.0-only while at it?
Quoted 8 lines
Quoted 1 line
Probably better to do that with a treewide script one day.
Yeah... But it's already more than one year after
Quoted 1 line
and
Documentation/process/license-rules.rst(which is the authoritive rule?) still hasn't been updated...
The patch still applies today...
Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier
In reply to Andreas FärberQuoted 6 lines · Andreas Färber
Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
Quoted 2 lines
This patch corrects the SPDX License Identifier style in header file related Actions Semi OWL pinctrl driver.
Owl
I used the same format mentioned below, which also says OWL. Meybe we can change both of them in a separate patch.
Quoted 13 lines
Quoted 13 lines
For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used).Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>--- drivers/pinctrl/actions/pinctrl-owl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
drivers/pinctrl/actions/pinctrl-owl.h line 1
Quoted 7 lines
drivers/pinctrl/actions/pinctrl-owl.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ This is not a uapi or asm header, which that /* */ rule was later added for, I thought?
I might be wrong but I think it applies to this file too as there as there is a SPDX identifier in the first place.
Quoted 6 lines
drivers/pinctrl/actions/pinctrl-owl.h line 4
Quoted 3 lines
drivers/pinctrl/actions/pinctrl-owl.h +0
-0/* * OWL SoC's Pinctrl definitions * Not objecting, just making sure we're not blindly refactoring code.
I am not sure what you are trying to say here, but the SPDX identifier requires an independent block comment. Hence placed the obove code in a separate block comment. Everything else is as it is.
Quoted 2 lines
If doing this, I suggest updating to GPL-2.0-or-later.
We can do this in a separate patch as this patch only talks about the style.
Quoted 8 lines
Regards,
AndreasSignature · 4 lines
SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
Thanks very much for your time and review.
Regards,
Nishad
Re: [PATCH 2/5] pinctrl: mediatek: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarQuoted 11 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header file related mediatek mt2712 pinctrl driver. For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used).Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>
Patch applied.
Yours,
Linus Walleij
Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarQuoted 9 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header files related to Reneses Soc pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>
I leave it to Geert to decide if he wants to pick this up for sh-pfc or not.
Yours,
Linus Walleij
Re: [PATCH 3/5] pinctrl: meson-axg: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarQuoted 9 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header file related Meson axg SoC pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>
Patch applied.
Yours,
Linus Walleij
Re: [PATCH 5/5] pinctrl: stm32: Use the correct style for SPDX License Identifier
In reply to Nishad KamdarQuoted 11 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header file related to STMicroelectronics pinctrl driver. For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used).Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>
Patch applied.
Yours,
Linus Walleij