Skip to contentSkip to conversation

pinctrl: pinctrl-v5.5-2: Fix linker error

PATCH In review Rahul Tanwar 3 participants 4 messages Dec 5, 2019 – Dec 13, 2019

Subsystems (3)
Linux-next tree GPIO Pin control
lore
Share & tools
lore

Rahul Tanwar

author
#0 lore raw

cover pinctrl: pinctrl-v5.5-2: Fix linker error

Fix linker error seen with 5.5 linux-next tree caused by below commit 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC").

Patch is based on 'pinctrl-v5.5-2' tag of linux-pinctrl.git tree.

Rahul Tanwar (1):
pinctrl: Modify Kconfig to fix linker error

 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 1/1 pinctrl: Modify Kconfig to fix linker error

Fix below linker error

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-equilibrium.c:(.text+0xb): undefined reference to `pinconf_generic_dt_node_to_map'

Caused by below commit

1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")

by adding 'depends on OF' in Kconfig driver entry.

Reported-by Randy Dunlap <[email protected]>>
Signed-off-by Rahul Tanwar <[email protected]>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index 3bfbf2ff6e2b..ba0cad4bd072 100644
@@ -422,6 +422,7 @@ config PINCTRL_TB10X
 
 config PINCTRL_EQUILIBRIUM
 	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+	depends on OF
 	select PINMUX
 	select PINCONF
 	select GPIOLIB
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

Quoted 7 lines · Rahul Tanwar

Fix below linker error

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-equilibrium.c:(.text+0xb): undefined reference to `pinconf_generic_dt_node_to_map'

Quoted 8 lines

Caused by below commit

1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")

by adding 'depends on OF' in Kconfig driver entry.

Reported-by Randy Dunlap <[email protected]>>
Signed-off-by Rahul Tanwar <[email protected]>
Acked-by Randy Dunlap <[email protected]> # build-tested

Thanks.

Quoted 17 lines
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index 3bfbf2ff6e2b..ba0cad4bd072 100644
@@ -422,6 +422,7 @@ config PINCTRL_TB10X
 
 config PINCTRL_EQUILIBRIUM
 	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+	depends on OF
 	select PINMUX
 	select PINCONF
 	select GPIOLIB
Signature · 1 line
~Randy
#3 lore raw

Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

In reply to Rahul Tanwar
Quoted 7 lines · Rahul Tanwar

Fix below linker error

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `pinconf_generic_dt_node_to_map_all':
pinctrl-equilibrium.c:(.text+0xb): undefined reference to `pinconf_generic_dt_node_to_map'

Quoted 8 lines

Caused by below commit

1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")

by adding 'depends on OF' in Kconfig driver entry.

Reported-by Randy Dunlap <[email protected]>>
Signed-off-by Rahul Tanwar <[email protected]>

Patch applied for fixes, thanks!

Linus Walleij