Skip to contentSkip to conversation

pahole: fix maybe-uninitialized and rpm build

PATCH Applied Yulia Kartseva 2 participants 5 messages Jan 17, 2020 3 messages not in the archive

lore
Share & tools
lore
#0 lore raw

cover pahole: fix maybe-uninitialized and rpm build

From: Julia Kartseva <[email protected]>

Fix issues encountered while builing RPM w/ v1.16:
- maybe uninitialized variable in ‘pahole_stealer' function
- malformed date in dwarves.spec changelog causing rpm build failure

Arnaldo, I wonder if we can have v1.16 package bump in the distros sooner? Thanks!

Julia Kartseva (2):
pahole: fix compiler warning
pahole: fix changelog date in dwarves.spec

 pahole.c               | 2 +-
 rpm/SPECS/dwarves.spec | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/2 pahole: fix compiler warning

In reply to a message not in the archive

From: Julia Kartseva <[email protected]>

---
 pahole.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
pahole.c +1 -1
index 829c9ab..7ac49c2 100644
@@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
 	uint32_t id;
 
 	cu__for_each_struct_or_union(cu, id, pos) {
+		struct structure *str = NULL;
 		bool looked = false;
-		struct structure *str;
 
 		if (pos->type.namespace.name == 0)
 			continue;
Signature · 1 line
2.17.1
#5 lore raw

PATCH 2/2 pahole: fix changelog date in dwarves.spec

In reply to a message not in the archive

From: Julia Kartseva <[email protected]>

---
 rpm/SPECS/dwarves.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rpm/SPECS/dwarves.spec +1 -1
index 82cb971..6155608 100644
@@ -127,7 +127,7 @@ make install DESTDIR=%{buildroot}
 %{_libdir}/%{libname}_reorganize.so
 
 %changelog
-* Mon 16 Dec 2019 Arnaldo Carvalho de Melo <[email protected]> - 1.16-1
+* Mon Dec 16 2019 Arnaldo Carvalho de Melo <[email protected]> - 1.16-1
 - New release: 1.16
 - BTF encoder: Preserve and encode exported functions as BTF_KIND_FUNC.
 - BTF loader: Add support for BTF_KIND_FUNC
Signature · 1 line
2.17.1
#4 lore raw

Re: [PATCH 1/2] pahole: fix compiler warning

In reply to a message not in the archive

Em Thu, Jan 16, 2020 at 04:59:12PM -0800, Yulia Kartseva escreveu:

Quoted 12 lines

From: Julia Kartseva <[email protected]>

---
 pahole.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
pahole.c +0 -0
index 829c9ab..7ac49c2 100644

pahole.c static void print_structs_with_pointer_to(struct cu *cu, uint32_t type) · line 688

Quoted 6 lines
pahole.c +1 -1
@@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
 	uint32_t id;
 
 	cu__for_each_struct_or_union(cu, id, pos) {
+		struct structure *str = NULL;
 		bool looked = false;
-		struct structure *str;

I just fixed this one after trying to build it on RHEL7, thanks!

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=9b09f578b7d1e75cf168e9b3098d4fb17504f26e

- Arnaldo

Quoted 5 lines
pahole.c +0 -0
 		if (pos->type.namespace.name == 0)
 			continue;
Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo
#7 lore raw

Re: [PATCH 2/2] pahole: fix changelog date in dwarves.spec

In reply to a message not in the archive

Em Thu, Jan 16, 2020 at 04:59:13PM -0800, Yulia Kartseva escreveu:

Quoted 6 lines

From: Julia Kartseva <[email protected]>

---
 rpm/SPECS/dwarves.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied, my bad :-\

- Arnaldo

Quoted 16 lines
rpm/SPECS/dwarves.spec +1 -1
index 82cb971..6155608 100644
@@ -127,7 +127,7 @@ make install DESTDIR=%{buildroot}
 %{_libdir}/%{libname}_reorganize.so
 
 %changelog
-* Mon 16 Dec 2019 Arnaldo Carvalho de Melo <[email protected]> - 1.16-1
+* Mon Dec 16 2019 Arnaldo Carvalho de Melo <[email protected]> - 1.16-1
 - New release: 1.16
 - BTF encoder: Preserve and encode exported functions as BTF_KIND_FUNC.
 - BTF loader: Add support for BTF_KIND_FUNC
Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo