recipe updates, testing fixes
cover recipe updates, testing fixes
- Update gdb to 9.1 and musl to latest
- Fix packages busybox, ltp to build with musl exposed 64bit time_t problems
- rest of all fixes are found testing core-image-sato-sdk on qemuarm/qemux86_64
- Add a check for gold being used on rv32/rv64
The following changes since commit 34535f3e0ca6f6e37e6457fc800dfbfff64d9298:
bitbake: doc: minor tweaks to ch 1 of BB user manual (2020-02-08 17:41:17 +0000)
are available in the Git repository at:
git://git.yoctoproject.org/poky-contrib kraj/pu
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=kraj/pu
Khem Raj (9):
qemuarm: Disable highmem when QB_MACHINE is virt
oeqa: Use --disable-maintainer-mode configure option
libsolv: Enable rpm packageconfig by default only if rpm O_P_M is
enabled
dnf,libdnf: Ignore if PACKAGE_CLASSES does not have rpm
musl: Update to latest tip
gdb: Upgrade to 9.1 release
busybox: Backport patches to support removal of __NR_clock_gettime
binutils: Bail out if gold is used on 32/64 bit RISC-V
ltp: Fix tescases with 64bit time_t using 32bit arches
meta/conf/distro/include/tcmode-default.inc | 2 +-
meta/conf/machine/qemuarm.conf | 2 +-
meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
meta/lib/oeqa/sdk/cases/buildcpio.py | 2 +-
...rappers-around-clock_gettime-closes-.patch | 113 +++++++++++++++
...-Use-64-prefix-syscall-if-we-have-to.patch | 53 +++++++
...-Use-64-prefix-syscall-if-we-have-to.patch | 43 ++++++
meta/recipes-core/busybox/busybox_1.31.1.bb | 3 +
meta/recipes-core/musl/musl_git.bb | 2 +-
meta/recipes-devtools/binutils/binutils.inc | 7 +
meta/recipes-devtools/dnf/dnf_4.2.2.bb | 2 +
meta/recipes-devtools/gdb/gdb-8.3.1.inc | 22 ---
meta/recipes-devtools/gdb/gdb-9.1.inc | 21 +++
...ian_8.3.1.bb => gdb-cross-canadian_9.1.bb} | 0
.../{gdb-cross_8.3.1.bb => gdb-cross_9.1.bb} | 0
...ake-man-install-relative-to-DESTDIR.patch} | 9 +-
...x-nat-Define-_ABIO32-if-not-defined.patch} | 9 +-
...-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch} | 7 +-
...ort-for-Renesas-SH-sh4-architecture.patch} | 41 +++---
...eadline.a-when-using-disable-static.patch} | 13 +-
...s.h.patch => 0006-use-asm-sgidefs.h.patch} | 9 +-
...Use-exorted-definitions-of-SIGRTMIN.patch} | 11 +-
...atch => 0008-Change-order-of-CFLAGS.patch} | 13 +-
...9-resolve-restrict-keyword-conflict.patch} | 17 +--
...> 0010-Fix-invalid-sigprocmask-call.patch} | 23 ++-
...h => 0011-gdbserver-ctrl-c-handling.patch} | 31 ++--
.../gdb/gdb/CVE-2019-1010180.patch | 132 ------------------
.../gdb/{gdb_8.3.1.bb => gdb_9.1.bb} | 0
meta/recipes-devtools/libdnf/libdnf_0.28.1.bb | 1 +
.../libsolv/libsolv_0.7.10.bb | 2 +-
...or-time64-unsafe-syscalls-before-usi.patch | 81 +++++++++++
meta/recipes-extended/ltp/ltp_20190930.bb | 1 +
32 files changed, 416 insertions(+), 258 deletions(-)
create mode 100644 meta/recipes-core/busybox/busybox/0001-Remove-syscall-wrappers-around-clock_gettime-closes-.patch
create mode 100644 meta/recipes-core/busybox/busybox/0001-date-Use-64-prefix-syscall-if-we-have-to.patch
create mode 100644 meta/recipes-core/busybox/busybox/0001-time-Use-64-prefix-syscall-if-we-have-to.patch
delete mode 100644 meta/recipes-devtools/gdb/gdb-8.3.1.inc
create mode 100644 meta/recipes-devtools/gdb/gdb-9.1.inc
rename meta/recipes-devtools/gdb/{gdb-cross-canadian_8.3.1.bb => gdb-cross-canadian_9.1.bb} (100%)
rename meta/recipes-devtools/gdb/{gdb-cross_8.3.1.bb => gdb-cross_9.1.bb} (100%)
rename meta/recipes-devtools/gdb/gdb/{0002-make-man-install-relative-to-DESTDIR.patch => 0001-make-man-install-relative-to-DESTDIR.patch} (77%)
rename meta/recipes-devtools/gdb/gdb/{0003-mips-linux-nat-Define-_ABIO32-if-not-defined.patch => 0002-mips-linux-nat-Define-_ABIO32-if-not-defined.patch} (82%)
rename meta/recipes-devtools/gdb/gdb/{0004-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch => 0003-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch} (89%)
rename meta/recipes-devtools/gdb/gdb/{0005-Add-support-for-Renesas-SH-sh4-architecture.patch => 0004-Add-support-for-Renesas-SH-sh4-architecture.patch} (96%)
rename meta/recipes-devtools/gdb/gdb/{0006-Dont-disable-libreadline.a-when-using-disable-static.patch => 0005-Dont-disable-libreadline.a-when-using-disable-static.patch} (83%)
rename meta/recipes-devtools/gdb/gdb/{0007-use-asm-sgidefs.h.patch => 0006-use-asm-sgidefs.h.patch} (84%)
rename meta/recipes-devtools/gdb/gdb/{0008-Use-exorted-definitions-of-SIGRTMIN.patch => 0007-Use-exorted-definitions-of-SIGRTMIN.patch} (81%)
rename meta/recipes-devtools/gdb/gdb/{0009-Change-order-of-CFLAGS.patch => 0008-Change-order-of-CFLAGS.patch} (75%)
rename meta/recipes-devtools/gdb/gdb/{0010-resolve-restrict-keyword-conflict.patch => 0009-resolve-restrict-keyword-conflict.patch} (80%)
rename meta/recipes-devtools/gdb/gdb/{0011-Fix-invalid-sigprocmask-call.patch => 0010-Fix-invalid-sigprocmask-call.patch} (65%)
rename meta/recipes-devtools/gdb/gdb/{0001-gdbserver-ctrl-c-handling.patch => 0011-gdbserver-ctrl-c-handling.patch} (45%)
delete mode 100644 meta/recipes-devtools/gdb/gdb/CVE-2019-1010180.patch
rename meta/recipes-devtools/gdb/{gdb_8.3.1.bb => gdb_9.1.bb} (100%)
create mode 100644 meta/recipes-extended/ltp/ltp/0001-syscalls-Check-for-time64-unsafe-syscalls-before-usi.patchSignature · 1 line
2.25.0
PATCH 1/9 qemuarm: Disable highmem when QB_MACHINE is virt
running ptests on qemuarm returns fails since it finds errors in kernel logs like below
***********************
Central error: [ 4.338465] pci-host-generic 4010000000.pcie: ECAM ioremap failed
***********************
Since its a 32bit kernel 4010000000 address is truncated to 10000000 and ends up in conflicts with VIRT_PCIE_MMIO, which ranges from 0x10000000 to 0x3efeffff
This is happening because the linux-yocto kernel is not compiled with LPAE support, however, virt machine for qemuarm assumes that by default
Should LPAE be enabled by default in kernel config is a separate question
--- meta/conf/machine/qemuarm.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/machine/qemuarm.conf +1 -1
@@ -11,7 +11,7 @@ SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0" # For runqemu QB_SYSTEM_NAME = "qemu-system-arm" -QB_MACHINE = "-machine virt" +QB_MACHINE = "-machine virt,highmem=off" QB_CPU = "-cpu cortex-a15" # Standard Serial console QB_KERNEL_CMDLINE_APPEND = "console=ttyAMA0"
Signature · 1 line
2.25.0
PATCH 2/9 oeqa: Use --disable-maintainer-mode configure option
In reply to Khem Rajsince the versions of autotools might differ on target and build host, plus difference in timestamps for configure and system can result in reconfigure lets avoid that by disabling maintainer mode
Avoids
error: newly created file is older than distributed files!
[YOCTO #13779]
--- meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +- meta/lib/oeqa/sdk/cases/buildcpio.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
meta/lib/oeqa/runtime/cases/buildcpio.py +1 -1
@@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase): @OEHasPackage(['autoconf']) def test_cpio(self): self.project.download_archive() - self.project.run_configure() + self.project.run_configure('--disable-maintainer-mode','') self.project.run_make() self.project.run_install()
meta/lib/oeqa/sdk/cases/buildcpio.py +1 -1
@@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase): self.assertTrue(os.path.isdir(dirs["source"])) os.makedirs(dirs["build"]) - self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs)) + self._run("cd {build} && {source}/configure --disable-maintainer-mode $CONFIGURE_FLAGS".format(**dirs)) self._run("cd {build} && make -j".format(**dirs)) self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
Signature · 1 line
2.25.0
PATCH 3/9 libsolv: Enable rpm packageconfig by default only if rpm O_P_M is enabled
In reply to Khem Rajopkg also depends on libsolv and can needlessly pull in rpm even if the O_P_M does not desire to use rpm
--- meta/recipes-extended/libsolv/libsolv_0.7.10.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/libsolv/libsolv_0.7.10.bb +1 -1
@@ -18,7 +18,7 @@ S = "${WORKDIR}/git" inherit cmake -PACKAGECONFIG ??= "rpm" +PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGE_CLASSES','package_rpm','rpm','',d)}" PACKAGECONFIG[rpm] = "-DENABLE_RPMMD=ON -DENABLE_RPMDB=ON,,rpm" EXTRA_OECMAKE = "-DMULTI_SEMANTICS=ON -DENABLE_COMPLEX_DEPS=ON"
Signature · 1 line
2.25.0
PATCH 4/9 dnf, libdnf: Ignore if PACKAGE_CLASSES does not have rpm
In reply to Khem Rajdnf does not work with opkg or dpkg/apt anyway
--- meta/recipes-devtools/dnf/dnf_4.2.2.bb | 2 ++ meta/recipes-devtools/libdnf/libdnf_0.28.1.bb | 1 + 2 files changed, 3 insertions(+)
meta/recipes-devtools/dnf/dnf_4.2.2.bb +2 -0
@@ -84,3 +84,5 @@ SYSTEMD_SERVICE_${PN} = "dnf-makecache.service dnf-makecache.timer \ dnf-automatic-notifyonly.service dnf-automatic-notifyonly.timer \ " SYSTEMD_AUTO_ENABLE ?= "disable" + +PNBLACKLIST[dnf] ?= "${@bb.utils.contains('PACKAGE_CLASSES', 'package_rpm', '', 'does not build correctly without package_rpm in PACKAGE_CLASSES', d)}"
meta/recipes-devtools/libdnf/libdnf_0.28.1.bb +1 -0
@@ -26,4 +26,5 @@ EXTRA_OECMAKE_append_class-native = " -DWITH_GIR=OFF" EXTRA_OECMAKE_append_class-nativesdk = " -DWITH_GIR=OFF" BBCLASSEXTEND = "native nativesdk" +PNBLACKLIST[libdnf] ?= "${@bb.utils.contains('PACKAGE_CLASSES', 'package_rpm', '', 'does not build correctly without package_rpm in PACKAGE_CLASSES', d)}"
Signature · 1 line
2.25.0
PATCH 5/9 musl: Update to latest tip
In reply to Khem RajDetailed changelog is here [1]
--- meta/recipes-core/musl/musl_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/musl/musl_git.bb +1 -1
@@ -4,7 +4,7 @@ require musl.inc inherit linuxloader -SRCREV = "e6093b5a870a38ebfb3e54382acd48c698bde15d" +SRCREV = "a662220df547e5c2446518e74440a7d834f9ebe6" BASEVER = "1.1.24"
Signature · 1 line
2.25.0
PATCH 6/9 gdb: Upgrade to 9.1 release
In reply to Khem RajDrop security patches which are now in 9.1 already Forward port rest of patches to 9.1 Detailed changes [1]
[1] https://lists.gnu.org/archive/html/info-gnu/2020-02/msg00008.html
---
meta/conf/distro/include/tcmode-default.inc | 2 +-
meta/recipes-devtools/gdb/gdb-8.3.1.inc | 22 ---
meta/recipes-devtools/gdb/gdb-9.1.inc | 21 +++
...ian_8.3.1.bb => gdb-cross-canadian_9.1.bb} | 0
.../{gdb-cross_8.3.1.bb => gdb-cross_9.1.bb} | 0
...ake-man-install-relative-to-DESTDIR.patch} | 9 +-
...x-nat-Define-_ABIO32-if-not-defined.patch} | 9 +-
...-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch} | 7 +-
...ort-for-Renesas-SH-sh4-architecture.patch} | 41 +++---
...eadline.a-when-using-disable-static.patch} | 13 +-
...s.h.patch => 0006-use-asm-sgidefs.h.patch} | 9 +-
...Use-exorted-definitions-of-SIGRTMIN.patch} | 11 +-
...atch => 0008-Change-order-of-CFLAGS.patch} | 13 +-
...9-resolve-restrict-keyword-conflict.patch} | 17 +--
...> 0010-Fix-invalid-sigprocmask-call.patch} | 23 ++-
...h => 0011-gdbserver-ctrl-c-handling.patch} | 31 ++--
.../gdb/gdb/CVE-2019-1010180.patch | 132 ------------------
.../gdb/{gdb_8.3.1.bb => gdb_9.1.bb} | 0
18 files changed, 107 insertions(+), 253 deletions(-)
delete mode 100644 meta/recipes-devtools/gdb/gdb-8.3.1.inc
create mode 100644 meta/recipes-devtools/gdb/gdb-9.1.inc
rename meta/recipes-devtools/gdb/{gdb-cross-canadian_8.3.1.bb => gdb-cross-canadian_9.1.bb} (100%)
rename meta/recipes-devtools/gdb/{gdb-cross_8.3.1.bb => gdb-cross_9.1.bb} (100%)
rename meta/recipes-devtools/gdb/gdb/{0002-make-man-install-relative-to-DESTDIR.patch => 0001-make-man-install-relative-to-DESTDIR.patch} (77%)
rename meta/recipes-devtools/gdb/gdb/{0003-mips-linux-nat-Define-_ABIO32-if-not-defined.patch => 0002-mips-linux-nat-Define-_ABIO32-if-not-defined.patch} (82%)
rename meta/recipes-devtools/gdb/gdb/{0004-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch => 0003-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch} (89%)
rename meta/recipes-devtools/gdb/gdb/{0005-Add-support-for-Renesas-SH-sh4-architecture.patch => 0004-Add-support-for-Renesas-SH-sh4-architecture.patch} (96%)
rename meta/recipes-devtools/gdb/gdb/{0006-Dont-disable-libreadline.a-when-using-disable-static.patch => 0005-Dont-disable-libreadline.a-when-using-disable-static.patch} (83%)
rename meta/recipes-devtools/gdb/gdb/{0007-use-asm-sgidefs.h.patch => 0006-use-asm-sgidefs.h.patch} (84%)
rename meta/recipes-devtools/gdb/gdb/{0008-Use-exorted-definitions-of-SIGRTMIN.patch => 0007-Use-exorted-definitions-of-SIGRTMIN.patch} (81%)
rename meta/recipes-devtools/gdb/gdb/{0009-Change-order-of-CFLAGS.patch => 0008-Change-order-of-CFLAGS.patch} (75%)
rename meta/recipes-devtools/gdb/gdb/{0010-resolve-restrict-keyword-conflict.patch => 0009-resolve-restrict-keyword-conflict.patch} (80%)
rename meta/recipes-devtools/gdb/gdb/{0011-Fix-invalid-sigprocmask-call.patch => 0010-Fix-invalid-sigprocmask-call.patch} (65%)
rename meta/recipes-devtools/gdb/gdb/{0001-gdbserver-ctrl-c-handling.patch => 0011-gdbserver-ctrl-c-handling.patch} (45%)
delete mode 100644 meta/recipes-devtools/gdb/gdb/CVE-2019-1010180.patch
rename meta/recipes-devtools/gdb/{gdb_8.3.1.bb => gdb_9.1.bb} (100%)meta/conf/distro/include/tcmode-default.inc +1 -1
@@ -19,7 +19,7 @@ PREFERRED_PROVIDER_virtual/gettext ??= "gettext" GCCVERSION ?= "9.%" SDKGCCVERSION ?= "${GCCVERSION}" BINUVERSION ?= "2.33%" -GDBVERSION ?= "8.3%" +GDBVERSION ?= "9.%" GLIBCVERSION ?= "2.31" LINUXLIBCVERSION ?= "5.4%" QEMUVERSION ?= "4.1%"
meta/recipes-devtools/gdb/gdb-8.3.1.inc deleted +0 -22
@@ -1,22 +0,0 @@ -LICENSE = "GPLv2 & GPLv3 & LGPLv2 & LGPLv3" -LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ - file://COPYING3;md5=d32239bcb673463ab874e80d47fae504 \ - file://COPYING3.LIB;md5=6a6a8e020838b23406c81b19c1d46df6 \ - file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674" - -SRC_URI = "${GNU_MIRROR}/gdb/gdb-${PV}.tar.xz \ - file://0001-gdbserver-ctrl-c-handling.patch \ - file://0002-make-man-install-relative-to-DESTDIR.patch \ - file://0003-mips-linux-nat-Define-_ABIO32-if-not-defined.patch \ - file://0004-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch \ - file://0005-Add-support-for-Renesas-SH-sh4-architecture.patch \ - file://0006-Dont-disable-libreadline.a-when-using-disable-static.patch \ - file://0007-use-asm-sgidefs.h.patch \ - file://0008-Use-exorted-definitions-of-SIGRTMIN.patch \ - file://0009-Change-order-of-CFLAGS.patch \ - file://0010-resolve-restrict-keyword-conflict.patch \ - file://0011-Fix-invalid-sigprocmask-call.patch \ - file://CVE-2019-1010180.patch \ - " -SRC_URI[md5sum] = "73b6a5d8141672c62bf851cd34c4aa83" -SRC_URI[sha256sum] = "1e55b4d7cdca7b34be12f4ceae651623aa73b2fd640152313f9f66a7149757c4"
meta/recipes-devtools/gdb/gdb-9.1.inc new file +21 -0
@@ -0,0 +1,21 @@ +LICENSE = "GPLv2 & GPLv3 & LGPLv2 & LGPLv3" +LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ + file://COPYING3;md5=d32239bcb673463ab874e80d47fae504 \ + file://COPYING3.LIB;md5=6a6a8e020838b23406c81b19c1d46df6 \ + file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674" + +SRC_URI = "${GNU_MIRROR}/gdb/gdb-${PV}.tar.xz \ + file://0001-make-man-install-relative-to-DESTDIR.patch \ + file://0002-mips-linux-nat-Define-_ABIO32-if-not-defined.patch \ + file://0003-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch \ + file://0004-Add-support-for-Renesas-SH-sh4-architecture.patch \ + file://0005-Dont-disable-libreadline.a-when-using-disable-static.patch \ + file://0006-use-asm-sgidefs.h.patch \ + file://0007-Use-exorted-definitions-of-SIGRTMIN.patch \ + file://0008-Change-order-of-CFLAGS.patch \ + file://0009-resolve-restrict-keyword-conflict.patch \ + file://0010-Fix-invalid-sigprocmask-call.patch \ + file://0011-gdbserver-ctrl-c-handling.patch \ + " +SRC_URI[md5sum] = "f7e9f6236c425097d9e5f18a6ac40655" +SRC_URI[sha256sum] = "699e0ec832fdd2f21c8266171ea5bf44024bd05164fdf064e4d10cc4cf0d1737"
meta/recipes-devtools/gdb/gdb-cross-canadian_9.1.bb renamed from meta/recipes-devtools/gdb/gdb-cross-canadian_8.3.1.bb +0 -0
meta/recipes-devtools/gdb/gdb-cross_9.1.bb renamed from meta/recipes-devtools/gdb/gdb-cross_8.3.1.bb +0 -0
meta/recipes-devtools/gdb/gdb/0001-make-man-install-relative-to-DESTDIR.patch renamed from meta/recipes-devtools/gdb/gdb/0002-make-man-install-relative-to-DESTDIR.patch +3 -6
@@ -1,7 +1,7 @@ -From b0209f282716bed2c230c7b496fbcc7af503d0cc Mon Sep 17 00:00:00 2001 +From 036f8e1d387f65e52cb021dbb1bd28e8b75cf017 Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Mon, 2 Mar 2015 02:27:55 +0000 -Subject: [PATCH 02/11] make man install relative to DESTDIR +Subject: [PATCH] make man install relative to DESTDIR Upstream-Status: Pending
@@ -11,7 +11,7 @@ Signed-off-by: Khem Raj <[email protected]> 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/common/Makefile.in b/sim/common/Makefile.in -index 227e4cfbc2..8c3457e0bd 100644 +index c6de14122c..c4b1214946 100644 --- a/sim/common/Makefile.in +++ b/sim/common/Makefile.in @@ -35,7 +35,7 @@ tooldir = $(libdir)/$(target_alias)
@@ -23,6 +23,3 @@ index 227e4cfbc2..8c3457e0bd 100644 infodir = @infodir@ includedir = @includedir@ --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0002-mips-linux-nat-Define-_ABIO32-if-not-defined.patch renamed from meta/recipes-devtools/gdb/gdb/0003-mips-linux-nat-Define-_ABIO32-if-not-defined.patch +3 -6
@@ -1,7 +1,7 @@ -From b14a57d90e1cdd8144cda4c8882bd1db44d26dab Mon Sep 17 00:00:00 2001 +From 6bff2862f9597f324a9385eb2f828e838e51a8a1 Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Wed, 23 Mar 2016 06:30:09 +0000 -Subject: [PATCH 03/11] mips-linux-nat: Define _ABIO32 if not defined +Subject: [PATCH] mips-linux-nat: Define _ABIO32 if not defined This helps building gdb on mips64 on musl, since musl does not provide sgidefs.h this define is
@@ -16,7 +16,7 @@ Signed-off-by: Khem Raj <[email protected]> 1 file changed, 4 insertions(+) diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c -index 32835c16b2..68a7587af2 100644 +index 104c972f24..7f575b3363 100644 --- a/gdb/mips-linux-nat.c +++ b/gdb/mips-linux-nat.c @@ -41,6 +41,10 @@
@@ -30,6 +30,3 @@ index 32835c16b2..68a7587af2 100644 class mips_linux_nat_target final : public linux_nat_trad_target { --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0003-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch renamed from meta/recipes-devtools/gdb/gdb/0004-ppc-ptrace-Define-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch +3 -4
@@ -1,4 +1,4 @@ -From da30370c1e3ff7728a857e119e0529a9f097086e Mon Sep 17 00:00:00 2001 +From d5817bcf2f7313699bfa85b41220d862db327664 Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Sat, 30 Apr 2016 18:32:14 -0700 Subject: [PATCH] ppc/ptrace: Define pt_regs uapi_pt_regs on !GLIBC systems
@@ -6,14 +6,13 @@ Subject: [PATCH] ppc/ptrace: Define pt_regs uapi_pt_regs on !GLIBC systems Upstream-Status: Pending Signed-off-by: Khem Raj <[email protected]> - --- gdb/gdbserver/linux-ppc-low.c | 6 ++++++ gdb/nat/ppc-linux.h | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/gdb/gdbserver/linux-ppc-low.c b/gdb/gdbserver/linux-ppc-low.c -index 1b695e53..1978347c 100644 +index 5d8d67bec2..ffcf65ab58 100644 --- a/gdb/gdbserver/linux-ppc-low.c +++ b/gdb/gdbserver/linux-ppc-low.c @@ -23,7 +23,13 @@
@@ -31,7 +30,7 @@ index 1b695e53..1978347c 100644 #include "arch/ppc-linux-common.h" #include "arch/ppc-linux-tdesc.h" diff --git a/gdb/nat/ppc-linux.h b/gdb/nat/ppc-linux.h -index f1561b3b..40399361 100644 +index d937a65b69..1fd54b4a0e 100644 --- a/gdb/nat/ppc-linux.h +++ b/gdb/nat/ppc-linux.h @@ -18,7 +18,13 @@
meta/recipes-devtools/gdb/gdb/0004-Add-support-for-Renesas-SH-sh4-architecture.patch renamed from meta/recipes-devtools/gdb/gdb/0005-Add-support-for-Renesas-SH-sh4-architecture.patch +19 -22
138 lines not on this page · raw message
meta/recipes-devtools/gdb/gdb/0005-Dont-disable-libreadline.a-when-using-disable-static.patch renamed from meta/recipes-devtools/gdb/gdb/0006-Dont-disable-libreadline.a-when-using-disable-static.patch +5 -8
@@ -1,7 +1,7 @@ -From 5fdd42acaa965be7c420a3f2ba12b77ea503c59b Mon Sep 17 00:00:00 2001 +From d132f21d89157e980574da7d0c949f6dd17df8c3 Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Sat, 30 Apr 2016 15:25:03 -0700 -Subject: [PATCH 06/11] Dont disable libreadline.a when using --disable-static +Subject: [PATCH] Dont disable libreadline.a when using --disable-static If gdb is configured with --disable-static then this is dutifully passed to readline which then disables libreadline.a, which causes a problem when gdb
@@ -19,7 +19,7 @@ Signed-off-by: Khem Raj <[email protected]> 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.def b/Makefile.def -index 75063b6d12..c27bbe4d28 100644 +index 311feb9de3..24c0685d48 100644 --- a/Makefile.def +++ b/Makefile.def @@ -105,7 +105,8 @@ host_modules= { module= libiconv;
@@ -33,10 +33,10 @@ index 75063b6d12..c27bbe4d28 100644 host_modules= { module= sim; }; host_modules= { module= texinfo; no_install= true; }; diff --git a/Makefile.in b/Makefile.in -index 7814fe745f..3b0dc7cbb0 100644 +index 1aabf6ede4..d957efde81 100644 --- a/Makefile.in +++ b/Makefile.in -@@ -25470,7 +25470,7 @@ configure-readline: +@@ -25510,7 +25510,7 @@ configure-readline: $$s/$$module_srcdir/configure \ --srcdir=$${topdir}/$$module_srcdir \ $(HOST_CONFIGARGS) --build=${build_alias} --host=${host_alias} \
@@ -45,6 +45,3 @@ index 7814fe745f..3b0dc7cbb0 100644 || exit 1 @endif readline --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0006-use-asm-sgidefs.h.patch renamed from meta/recipes-devtools/gdb/gdb/0007-use-asm-sgidefs.h.patch +3 -6
@@ -1,7 +1,7 @@ -From d6e12d52f9cef7f5e6315003ceaa236f6cc7723b Mon Sep 17 00:00:00 2001 +From 329e5bf29e934ba99622372a9660865864bb0298 Mon Sep 17 00:00:00 2001 From: Andre McCurdy <[email protected]> Date: Sat, 30 Apr 2016 15:29:06 -0700 -Subject: [PATCH 07/11] use <asm/sgidefs.h> +Subject: [PATCH] use <asm/sgidefs.h> Build fix for MIPS with musl libc
@@ -19,7 +19,7 @@ Signed-off-by: Khem Raj <[email protected]> 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c -index 68a7587af2..2b77221372 100644 +index 7f575b3363..dc93a64a93 100644 --- a/gdb/mips-linux-nat.c +++ b/gdb/mips-linux-nat.c @@ -31,7 +31,7 @@
@@ -31,6 +31,3 @@ index 68a7587af2..2b77221372 100644 #include "nat/gdb_ptrace.h" #include <asm/ptrace.h> #include "inf-ptrace.h" --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0007-Use-exorted-definitions-of-SIGRTMIN.patch renamed from meta/recipes-devtools/gdb/gdb/0008-Use-exorted-definitions-of-SIGRTMIN.patch +5 -6
@@ -1,4 +1,4 @@ -From bab0b34672727c50313eb98b8522355cbe1bde36 Mon Sep 17 00:00:00 2001 +From 782bb2ab9b104dad4bbaed1d9ac769ce7e5b9f4d Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Sat, 30 Apr 2016 15:31:40 -0700 Subject: [PATCH] Use exorted definitions of SIGRTMIN
@@ -14,17 +14,16 @@ https://sourceware.org/bugzilla/show_bug.cgi?id=13012 Upstream-Status: Submitted Signed-off-by: Khem Raj <[email protected]> - --- gdb/linux-nat.c | 4 ++-- gdb/nat/linux-nat.h | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c -index 063afe26..fb1d2d5d 100644 +index 4484fa5c87..3bb0ee7a49 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c -@@ -4713,6 +4713,6 @@ lin_thread_get_thread_signals (sigset_t *set) +@@ -4588,6 +4588,6 @@ lin_thread_get_thread_signals (sigset_t *set) /* NPTL reserves the first two RT signals, but does not provide any way for the debugger to query the signal numbers - fortunately they don't change. */
@@ -34,10 +33,10 @@ index 063afe26..fb1d2d5d 100644 + sigaddset (set, SIGRTMIN + 1); } diff --git a/gdb/nat/linux-nat.h b/gdb/nat/linux-nat.h -index 1e32dd9e..b886305d 100644 +index 44dcbb7758..975d7276f6 100644 --- a/gdb/nat/linux-nat.h +++ b/gdb/nat/linux-nat.h -@@ -90,4 +90,8 @@ extern void linux_stop_lwp (struct lwp_info *lwp); +@@ -91,4 +91,8 @@ extern void linux_stop_lwp (struct lwp_info *lwp); extern int lwp_is_stepping (struct lwp_info *lwp);
meta/recipes-devtools/gdb/gdb/0008-Change-order-of-CFLAGS.patch renamed from meta/recipes-devtools/gdb/gdb/0009-Change-order-of-CFLAGS.patch +5 -8
@@ -1,7 +1,7 @@ -From ba6ffa461fe781d44d6dcbc0fbd569237b450fdc Mon Sep 17 00:00:00 2001 +From 40c9c174590ce6fdc873b453285249fe957f376d Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Sat, 30 Apr 2016 15:35:39 -0700 -Subject: [PATCH 09/11] Change order of CFLAGS +Subject: [PATCH] Change order of CFLAGS Lets us override Werror if need be
@@ -13,18 +13,15 @@ Signed-off-by: Khem Raj <[email protected]> 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in -index f2f8a084bd..9528db1364 100644 +index 16a9f2fd38..b9c8cd9c41 100644 --- a/gdb/gdbserver/Makefile.in +++ b/gdb/gdbserver/Makefile.in -@@ -143,7 +143,7 @@ CPPFLAGS = @CPPFLAGS@ +@@ -146,7 +146,7 @@ PTHREAD_LIBS = @PTHREAD_LIBS@ INTERNAL_CFLAGS_BASE = ${CXXFLAGS} ${GLOBAL_CFLAGS} \ - ${PROFILE_CFLAGS} ${INCLUDE_CFLAGS} ${CPPFLAGS} + ${PROFILE_CFLAGS} ${INCLUDE_CFLAGS} ${CPPFLAGS} $(PTHREAD_CFLAGS) INTERNAL_WARN_CFLAGS = ${INTERNAL_CFLAGS_BASE} $(WARN_CFLAGS) -INTERNAL_CFLAGS = ${INTERNAL_WARN_CFLAGS} $(WERROR_CFLAGS) -DGDBSERVER +INTERNAL_CFLAGS = ${INTERNAL_WARN_CFLAGS} $(WERROR_CFLAGS) ${COMPILER_CFLAGS} -DGDBSERVER # LDFLAGS is specifically reserved for setting from the command line # when running make. --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0009-resolve-restrict-keyword-conflict.patch renamed from meta/recipes-devtools/gdb/gdb/0010-resolve-restrict-keyword-conflict.patch +7 -10
@@ -1,7 +1,7 @@ -From 19b581056c1709f7d2872cd76b977542a0fe6142 Mon Sep 17 00:00:00 2001 +From 5b69a98f6bb7363a1f79f29bac2b25b7df6d2fdd Mon Sep 17 00:00:00 2001 From: Khem Raj <[email protected]> Date: Tue, 10 May 2016 08:47:05 -0700 -Subject: [PATCH 10/11] resolve restrict keyword conflict +Subject: [PATCH] resolve restrict keyword conflict GCC detects that we call 'restrict' as param name in function signatures and complains since both params are called 'restrict'
@@ -11,13 +11,13 @@ Upstream-Status: Pending Signed-off-by: Khem Raj <[email protected]> --- - gdb/gnulib/import/sys_time.in.h | 8 ++++---- + gnulib/import/sys_time.in.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -diff --git a/gdb/gnulib/import/sys_time.in.h b/gdb/gnulib/import/sys_time.in.h -index b4a0e49c50..d22cea9aaf 100644 ---- a/gdb/gnulib/import/sys_time.in.h -+++ b/gdb/gnulib/import/sys_time.in.h +diff --git a/gnulib/import/sys_time.in.h b/gnulib/import/sys_time.in.h +index d535a6a48b..7c34d5a1aa 100644 +--- a/gnulib/import/sys_time.in.h ++++ b/gnulib/import/sys_time.in.h @@ -93,20 +93,20 @@ struct timeval # define gettimeofday rpl_gettimeofday # endif
@@ -43,6 +43,3 @@ index b4a0e49c50..d22cea9aaf 100644 # endif _GL_CXXALIASWARN (gettimeofday); # if defined __cplusplus && defined GNULIB_NAMESPACE --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0010-Fix-invalid-sigprocmask-call.patch renamed from meta/recipes-devtools/gdb/gdb/0011-Fix-invalid-sigprocmask-call.patch +10 -13
@@ -1,7 +1,7 @@ -From b1985595e46721bb168ac38f4c841a915cc2f799 Mon Sep 17 00:00:00 2001 +From bc1f01ff5e524f7777083024bce348a9b0017a7a Mon Sep 17 00:00:00 2001 From: Yousong Zhou <[email protected]> Date: Fri, 24 Mar 2017 10:36:03 +0800 -Subject: [PATCH 11/11] Fix invalid sigprocmask call +Subject: [PATCH] Fix invalid sigprocmask call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
@@ -28,22 +28,19 @@ Upstream-Status: Pending [not author, cherry-picked from LEDE https://bugs.lede- Signed-off-by: André Draszik <[email protected]> Signed-off-by: Khem Raj <[email protected]> --- - gdb/common/signals-state-save-restore.c | 2 +- + gdb/gdbsupport/signals-state-save-restore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c -index 5bb66321bb..6597decbc6 100644 ---- a/gdb/common/signals-state-save-restore.c -+++ b/gdb/common/signals-state-save-restore.c -@@ -41,7 +41,7 @@ save_original_signals_state (bool quiet) +diff --git a/gdb/gdbsupport/signals-state-save-restore.c b/gdb/gdbsupport/signals-state-save-restore.c +index c292d498da..af9dcaeb08 100644 +--- a/gdb/gdbsupport/signals-state-save-restore.c ++++ b/gdb/gdbsupport/signals-state-save-restore.c +@@ -38,7 +38,7 @@ save_original_signals_state (bool quiet) int i; int res; -- res = sigprocmask (0, NULL, &original_signal_mask); -+ res = sigprocmask (SIG_BLOCK, NULL, &original_signal_mask); +- res = gdb_sigmask (0, NULL, &original_signal_mask); ++ res = gdb_sigmask (SIG_BLOCK, NULL, &original_signal_mask); if (res == -1) perror_with_name (("sigprocmask")); --- -2.18.0 -
meta/recipes-devtools/gdb/gdb/0011-gdbserver-ctrl-c-handling.patch renamed from meta/recipes-devtools/gdb/gdb/0001-gdbserver-ctrl-c-handling.patch +22 -9
@@ -1,19 +1,32 @@ +From 3d6700d38153a0ec8e0800de703a5089a8cd3d2d Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Thu, 29 Nov 2018 18:00:23 -0800 +Subject: [PATCH] gdbserver ctrl-c handling + This problem was created by the upstream commit 78708b7c8c -After applying the commit, it will send SIGINT to the process group(-signal_pid). -But if we use gdbserver send SIGINT, and the attached process is not a process -group leader, then the "kill (-signal_pid, SIGINT)" returns error and fails to +After applying the commit, it will send SIGINT to the process +group(-signal_pid). +But if we use gdbserver send SIGINT, and the attached process is not a +process +group leader, then the "kill (-signal_pid, SIGINT)" returns error and +fails to interrupt the attached process. -Upstream-Status: Submitted [https://sourceware.org/bugzilla/show_bug.cgi?id=18945] +Upstream-Status: Submitted +[https://sourceware.org/bugzilla/show_bug.cgi?id=18945] Author: Josh Gao Signed-off-by: Zhixiong Chi <[email protected]> +Signed-off-by: Khem Raj <[email protected]> +--- + gdb/gdbserver/linux-low.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) -Index: gdb-8.2/gdb/gdbserver/linux-low.c -=================================================================== ---- gdb-8.2.orig/gdb/gdbserver/linux-low.c -+++ gdb-8.2/gdb/gdbserver/linux-low.c -@@ -5940,9 +5940,7 @@ linux_look_up_symbols (void) +diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c +index 4255795ea6..762f8bafb6 100644 +--- a/gdb/gdbserver/linux-low.c ++++ b/gdb/gdbserver/linux-low.c +@@ -5904,9 +5904,7 @@ linux_look_up_symbols (void) static void linux_request_interrupt (void) {
meta/recipes-devtools/gdb/gdb/CVE-2019-1010180.patch deleted +0 -132
132 lines not on this page · raw message
meta/recipes-devtools/gdb/gdb_9.1.bb renamed from meta/recipes-devtools/gdb/gdb_8.3.1.bb +0 -0
Signature · 1 line
2.25.0
PATCH 7/9 busybox: Backport patches to support removal of __NR_clock_gettime
In reply to Khem RajThis helps compiling with musl on 32bit arches now that musl has switched to 64bit time_t
--- ...rappers-around-clock_gettime-closes-.patch | 113 ++++++++++++++++++ ...-Use-64-prefix-syscall-if-we-have-to.patch | 53 ++++++++ ...-Use-64-prefix-syscall-if-we-have-to.patch | 43 +++++++ meta/recipes-core/busybox/busybox_1.31.1.bb | 3 + 4 files changed, 212 insertions(+) create mode 100644 meta/recipes-core/busybox/busybox/0001-Remove-syscall-wrappers-around-clock_gettime-closes-.patch create mode 100644 meta/recipes-core/busybox/busybox/0001-date-Use-64-prefix-syscall-if-we-have-to.patch create mode 100644 meta/recipes-core/busybox/busybox/0001-time-Use-64-prefix-syscall-if-we-have-to.patch
meta/recipes-core/busybox/busybox/0001-Remove-syscall-wrappers-around-clock_gettime-closes-.patch new file +113 -0
@@ -0,0 +1,113 @@ +From be5a505d771a77c640acc35ceaa470c80e62f954 Mon Sep 17 00:00:00 2001 +From: Denys Vlasenko <[email protected]> +Date: Thu, 24 Oct 2019 16:26:55 +0200 +Subject: [PATCH] Remove syscall wrappers around clock_gettime, closes 12091 + +12091 "Direct use of __NR_clock_gettime is not time64-safe". + +function old new delta +runsv_main 1698 1712 +14 +startservice 378 383 +5 +get_mono 31 25 -6 +date_main 932 926 -6 +gettimeofday_ns 17 - -17 +------------------------------------------------------------------------------ +(add/remove: 0/1 grow/shrink: 2/2 up/down: 19/-29) Total: -10 bytes + +Signed-off-by: Denys Vlasenko <[email protected]> +--- +Upstream-Status: Backport [https://git.busybox.net/busybox/commit/?id=be5a505d771a77c640acc35ceaa470c80e62f954] + Makefile.flags | 6 ++++-- + coreutils/date.c | 16 +++------------- + libbb/time.c | 11 +---------- + runit/runsv.c | 11 +---------- + 4 files changed, 9 insertions(+), 35 deletions(-) + +--- a/Makefile.flags ++++ b/Makefile.flags +@@ -129,10 +129,12 @@ endif + # fall back to using a temp file: + CRYPT_AVAILABLE := $(shell echo 'int main(void){return 0;}' >crypttest.c; $(CC) $(CFLAGS) -lcrypt -o /dev/null crypttest.c >/dev/null 2>&1 && echo "y"; rm crypttest.c) + ifeq ($(CRYPT_AVAILABLE),y) +-LDLIBS += m crypt ++LDLIBS += m rt crypt + else +-LDLIBS += m ++LDLIBS += m rt + endif ++# libm may be needed for dc, awk, ntpd ++# librt may be needed for clock_gettime() + + # libpam may use libpthread, libdl and/or libaudit. + # On some platforms that requires an explicit -lpthread, -ldl, -laudit. +--- a/coreutils/date.c ++++ b/coreutils/date.c +@@ -33,10 +33,9 @@ + //config: Enable option (-I) to output an ISO-8601 compliant + //config: date/time string. + //config: +-//config:# defaults to "no": stat's nanosecond field is a bit non-portable + //config:config FEATURE_DATE_NANO + //config: bool "Support %[num]N nanosecond format specifier" +-//config: default n # syscall(__NR_clock_gettime) or syscall(__NR_clock_gettime64) ++//config: default n # stat's nanosecond field is a bit non-portable + //config: depends on DATE + //config: select PLATFORM_LINUX + //config: help +@@ -271,17 +270,8 @@ int date_main(int argc UNUSED_PARAM, cha + */ + #endif + } else { +-#if ENABLE_FEATURE_DATE_NANO && defined(__NR_clock_gettime) +- /* libc has incredibly messy way of doing this, +- * typically requiring -lrt. We just skip all this mess */ +- syscall(__NR_clock_gettime, CLOCK_REALTIME, &ts); +-#elif ENABLE_FEATURE_DATE_NANO && __TIMESIZE == 64 +- /* Let's only suppor the 64 suffix syscalls for 64-bit time_t. +- * This simplifies the code for us as we don't need to convert +- * between 64-bit and 32-bit. We also don't have a way to +- * report overflow errors here. +- */ +- syscall(__NR_clock_gettime64, CLOCK_REALTIME, &ts); ++#if ENABLE_FEATURE_DATE_NANO ++ clock_gettime(CLOCK_REALTIME, &ts); + #else + time(&ts.tv_sec); + #endif +--- a/libbb/time.c ++++ b/libbb/time.c +@@ -253,18 +253,9 @@ char* FAST_FUNC strftime_YYYYMMDDHHMMSS( + #define CLOCK_MONOTONIC 1 + #endif + +-/* libc has incredibly messy way of doing this, +- * typically requiring -lrt. We just skip all this mess */ + static void get_mono(struct timespec *ts) + { +-#if defined(__NR_clock_gettime) +- if (syscall(__NR_clock_gettime, CLOCK_MONOTONIC, ts)) +-#elif __TIMESIZE == 64 +- if (syscall(__NR_clock_gettime64, CLOCK_MONOTONIC, ts)) +-#else +-# error "We currently don't support architectures without " \ +- "the __NR_clock_gettime syscall and 32-bit time_t" +-#endif ++ if (clock_gettime(CLOCK_MONOTONIC, ts)) + bb_error_msg_and_die("clock_gettime(MONOTONIC) failed"); + } + unsigned long long FAST_FUNC monotonic_ns(void) +--- a/runit/runsv.c ++++ b/runit/runsv.c +@@ -51,11 +51,9 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAG + #if ENABLE_MONOTONIC_SYSCALL + #include <sys/syscall.h> + +-/* libc has incredibly messy way of doing this, +- * typically requiring -lrt. We just skip all this mess */ + static void gettimeofday_ns(struct timespec *ts) + { +- syscall(__NR_clock_gettime, CLOCK_REALTIME, ts); ++ clock_gettime(CLOCK_REALTIME, ts); + } + #else + static void gettimeofday_ns(struct timespec *ts)
meta/recipes-core/busybox/busybox/0001-date-Use-64-prefix-syscall-if-we-have-to.patch new file +53 -0
53 lines not on this page · raw message
meta/recipes-core/busybox/busybox/0001-time-Use-64-prefix-syscall-if-we-have-to.patch new file +43 -0
43 lines not on this page · raw message
meta/recipes-core/busybox/busybox_1.31.1.bb +3 -0
@@ -43,6 +43,9 @@ SRC_URI = "https://busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \ file://0001-testsuite-use-www.example.org-for-wget-test-cases.patch \ file://0001-du-l-works-fix-to-use-145-instead-of-144.patch \ file://0001-Remove-stime-function-calls.patch \ + file://0001-date-Use-64-prefix-syscall-if-we-have-to.patch \ + file://0001-time-Use-64-prefix-syscall-if-we-have-to.patch \ + file://0001-Remove-syscall-wrappers-around-clock_gettime-closes-.patch \ " SRC_URI_append_libc-musl = " file://musl.cfg "
Signature · 1 line
2.25.0
PATCH 8/9 binutils: Bail out if gold is used on 32/64 bit RISC-V
In reply to Khem Rajgold is not supporting risc-v yet and, this will cause subltle errors during build e.g. autoconf not finding certain features like visibility and it could take a while to unwind the problem. Its better to error out early
Remove dwp and ld.gold for rv32 as well
--- meta/recipes-devtools/binutils/binutils.inc | 7 +++++++ 1 file changed, 7 insertions(+)
meta/recipes-devtools/binutils/binutils.inc +7 -0
@@ -40,6 +40,7 @@ FILES_${PN}-dev = " \ LDGOLD_ALTS ?= "ld.gold dwp" LDGOLD_ALTS_riscv64 = "" +LDGOLD_ALTS_riscv32 = "" USE_ALTERNATIVES_FOR = " \ addr2line \
@@ -83,6 +84,7 @@ LDGOLD_class-native = "" LDGOLD_class-crosssdk = "" LDGOLD ?= "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default --enable-threads', '--enable-gold --enable-ld=default --enable-threads', d)}" + # This is necessary due to a bug in the binutils Makefiles # EXTRA_OEMAKE = "configure-build-libiberty all"
@@ -163,3 +165,8 @@ inherit update-alternatives ALTERNATIVE_PRIORITY = "100" ALTERNATIVE_${PN}_class-target = "${USE_ALTERNATIVES_FOR}" + +python () { + if bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', True, False, d): + bb.fatal("Gold linker does not _yet_ support RISC-V architecture please remove ld-is-gold from DISTRO_FEATURES") +}
Signature · 1 line
2.25.0
PATCH 9/9 ltp: Fix tescases with 64bit time_t using 32bit arches
In reply to Khem RajThis helps it compile on musl
Fixes
| tst_clocks.c:31:17: error: 'SYS_clock_getres' undeclared (first use in this function); did you mean 'tst_clock_getres
--- ...or-time64-unsafe-syscalls-before-usi.patch | 81 +++++++++++++++++++ meta/recipes-extended/ltp/ltp_20190930.bb | 1 + 2 files changed, 82 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-syscalls-Check-for-time64-unsafe-syscalls-before-usi.patch
meta/recipes-extended/ltp/ltp/0001-syscalls-Check-for-time64-unsafe-syscalls-before-usi.patch new file +81 -0
@@ -0,0 +1,81 @@ +From 09e631419d9763a4ff08b32d9801c12b475d8ec5 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Wed, 12 Feb 2020 22:22:17 -0800 +Subject: [PATCH] syscalls: Check for time64 unsafe syscalls before using them + +musl is using 64bit time_t now on 32bit architectures and these syscalls +no longer exist, therefore its better to check for them being available +before using them + +Upstream-Status: Submitted [http://lists.linux.it/pipermail/ltp/2020-February/015400.html] +Signed-off-by: Khem Raj <[email protected]> +--- + lib/tst_clocks.c | 9 +++++++++ + testcases/kernel/syscalls/gettimeofday/gettimeofday01.c | 4 ++++ + testcases/kernel/syscalls/gettimeofday/gettimeofday02.c | 4 ++++ + 3 files changed, 17 insertions(+) + +diff --git a/lib/tst_clocks.c b/lib/tst_clocks.c +index 35798a4aaf..6a5b05c4ea 100644 +--- a/lib/tst_clocks.c ++++ b/lib/tst_clocks.c +@@ -28,15 +28,24 @@ + + int tst_clock_getres(clockid_t clk_id, struct timespec *res) + { ++#if defined(__NR_clock_getres) + return syscall(SYS_clock_getres, clk_id, res); ++#endif ++ return -1; + } + + int tst_clock_gettime(clockid_t clk_id, struct timespec *ts) + { ++#if defined(__NR_clock_gettime) + return syscall(SYS_clock_gettime, clk_id, ts); ++#endif ++ return -1; + } + + int tst_clock_settime(clockid_t clk_id, struct timespec *ts) + { ++#if defined(__NR_clock_settime) + return syscall(SYS_clock_settime, clk_id, ts); ++#endif ++ return -1; + } +diff --git a/testcases/kernel/syscalls/gettimeofday/gettimeofday01.c b/testcases/kernel/syscalls/gettimeofday/gettimeofday01.c +index 583d8f7b9b..b498de5b68 100644 +--- a/testcases/kernel/syscalls/gettimeofday/gettimeofday01.c ++++ b/testcases/kernel/syscalls/gettimeofday/gettimeofday01.c +@@ -41,7 +41,11 @@ + #include <sys/syscall.h> + #include <unistd.h> + ++#ifdef __NR_gettimeofday + #define gettimeofday(a,b) syscall(__NR_gettimeofday,a,b) ++#else ++#define gettimeofday(a,b) (-1) ++#endif + + char *TCID = "gettimeofday01"; + int TST_TOTAL = 1; +diff --git a/testcases/kernel/syscalls/gettimeofday/gettimeofday02.c b/testcases/kernel/syscalls/gettimeofday/gettimeofday02.c +index 1d60f448e8..218e017df8 100644 +--- a/testcases/kernel/syscalls/gettimeofday/gettimeofday02.c ++++ b/testcases/kernel/syscalls/gettimeofday/gettimeofday02.c +@@ -23,7 +23,11 @@ + + #include "tst_test.h" + ++#ifdef __NR_gettimeofday + #define gettimeofday(a,b) syscall(__NR_gettimeofday,a,b) ++#else ++#define gettimeofday(a,b) (-1) ++#endif + + static volatile sig_atomic_t done; + static char *str_rtime; +-- +2.25.0 +
meta/recipes-extended/ltp/ltp_20190930.bb +1 -0
@@ -42,6 +42,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0001-testcases-fix-an-absent-format-string-issue.patch \ file://0001-Add-more-musl-exclusions.patch \ file://0001-nm01-Remove-prefix-zeros-of-the-addresses-output-by-.patch \ + file://0001-syscalls-Check-for-time64-unsafe-syscalls-before-usi.patch \ " S = "${WORKDIR}/git"
Signature · 1 line
2.25.0
Re: [PATCH 8/9] binutils: Bail out if gold is used on 32/64 bit RISC-V
In reply to Khem RajQuoted 6 lines · Khem Raj
gold is not supporting risc-v yet and, this will cause subltle errors during build e.g. autoconf not finding certain features like visibility and it could take a while to unwind the problem. Its better to error out early
...
meta/recipes-devtools/binutils/binutils.inc inherit update-alternatives · line 172
Quoted 8 lines
meta/recipes-devtools/binutils/binutils.inc +5
-0@@ -163,3 +165,8 @@ inherit update-alternatives ALTERNATIVE_PRIORITY = "100" ALTERNATIVE_${PN}_class-target = "${USE_ALTERNATIVES_FOR}" + +python () { + if bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', True, False, d): + bb.fatal("Gold linker does not _yet_ support RISC-V architecture please remove ld-is-gold from DISTRO_FEATURES") +}
This lacks some check for RISC-V,
currently it errors for all architectures.
cu
Adrian
Quoted 4 lines · Khem Raj
libsolv: Enable rpm packageconfig by default only if rpm
O_P_Mis
enabled
dnf,libdnf: Ignore ifPACKAGE_CLASSESdoes not have rpm
I'd like to request that these two are held back until we figure out what is going wrong with the rpm test (see separate thread).
Alex
Quoted 10 lines · Alexander Kanavin
Quoted 4 lines · Khem Raj
libsolv: Enable rpm packageconfig by default only if rpm
O_P_Mis
enabled
dnf,libdnf: Ignore ifPACKAGE_CLASSESdoes not have rpmI'd like to request that these two are held back until we figure out what is going wrong with the rpm test (see separate thread).
We already know what’s going on what more
Do you want to know ?
Quoted 2 lines
Alex
Re: [PATCH 8/9] binutils: Bail out if gold is used on 32/64 bit RISC-V
In reply to Adrian BunkQuoted 14 lines · Adrian Bunk
meta/recipes-devtools/binutils/binutils.inc inherit update-alternatives · line 170
Quoted 12 lines · Khem Raj
gold is not supporting risc-v yet and, this will cause subltle errors during build e.g. autoconf not finding certain features like visibility and it could take a while to unwind the problem. Its better to error out early
...meta/recipes-devtools/binutils/binutils.inc +3
-0@@ -163,3 +165,8 @@ inherit update-alternatives ALTERNATIVE_PRIORITY = "100" ALTERNATIVE_${PN}_class-target = "${USE_ALTERNATIVES_FOR}" + +python () { + if bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', True, False,d):
Quoted 6 lines
Review inherit update-alternatives · line 171
Quoted 1 line
(quoted diff) +1
-0+ bb.fatal("Gold linker does not _yet_ support RISC-Varchitecture please remove ld-is-gold from
DISTRO_FEATURES")meta/recipes-devtools/binutils/binutils.inc inherit update-alternatives · line 172
Quoted 1 line
meta/recipes-devtools/binutils/binutils.inc +1
-0+}This lacks some check for RISC-V,
currently it errors for all architectures.
Yes this in itself was not enough please try the v2 series
Quoted 4 lines
cu
Adrian
Quoted 8 lines · Khem Raj
Quoted 4 lines
I'd like to request that these two are held back until we figure out what is going wrong with the rpm test (see separate thread).
We already know what’s going on what more
Do you want to know ?
As the rpm maintainer, yes I do. The test is not being skipped when it
should be, and I'd like to know why.
Alex
Quoted 7 lines · Alexander Kanavin
Quoted 5 lines · Khem Raj
Quoted 4 lines
I'd like to request that these two are held back until we figure out what is going wrong with the rpm test (see separate thread).
Quoted 7 lines
Quoted 3 lines
We already know what’s going on what more
Do you want to know ?As the rpm maintainer, yes I do. The test is not being skipped when it
should be, and I'd like to know why.
I see that as separate issue orthogonal to these patches
Quoted 2 lines
Alex
Quoted 8 lines · Khem Raj
I'd like to request that these two are held back until we figure out what
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
is going wrong with the rpm test (see separate thread).
We already know what’s going on what more
Do you want to know ?
Quoted 6 lines
Quoted 3 lines
As the rpm maintainer, yes I do. The test is not being skipped when it
should be, and I'd like to know why.I see that as separate issue orthogonal to these patches
Merging these patches will exclude rpm from images, and so will mask the issue, so it's not orthogonal.
Alex
Quoted 14 lines · Alexander Kanavin
Quoted 12 lines · Khem Raj
I'd like to request that these two are held back until we figure out what
Quoted 10 lines
Quoted 6 lines
Quoted 2 lines
is going wrong with the rpm test (see separate thread).
We already know what’s going on what more
Do you want to know ?As the rpm maintainer, yes I do. The test is not being skipped when it
should be, and I'd like to know why.
Quoted 6 lines
Quoted 2 lines
I see that as separate issue orthogonal to these patches
Merging these patches will exclude rpm from images, and so will mask the issue, so it's not orthogonal.
are you actively working to fix the test case ?
In that case it would be justified to hold them
Quoted 2 lines
Alex
Quoted 8 lines · Khem Raj
Quoted 4 lines
Merging these patches will exclude rpm from images, and so will mask the issue, so it's not orthogonal.
are you actively working to fix the test case ?
In that case it would be justified to hold them
The test case that is failing for you (with ipk/opkg and core-image-sato-sdk) is passing just fine on the autobuilder [1], so I am missing information on how to reproduce. I have requested this information from you here [2] and got no answer so far. Or is it some other test that is failing? That isn't entirely clear.
[1]
https://autobuilder.yoctoproject.org/typhoon/#/builders/76/builds/1554/steps/8/logs/step1c
[2]
http://lists.openembedded.org/pipermail/openembedded-core/2020-February/292774.html
Alex
Re: [PATCH 6/9] gdb: Upgrade to 9.1 release
In reply to Khem RajQuoted 7 lines · Khem Raj
Drop security patches which are now in 9.1 already Forward port rest of patches to 9.1 Detailed changes [1]
[1] https://lists.gnu.org/archive/html/info-gnu/2020-02/msg00008.html
Signed-off-by Khem Raj <[email protected]>
Something odd is going on as another patch failure:
https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1551
Cheers,
Richard
Re: [PATCH 6/9] gdb: Upgrade to 9.1 release
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Khem Raj
Drop security patches which are now in 9.1 already Forward port rest of patches to 9.1 Detailed changes [1]
Quoted 8 lines
Quoted 3 lines
[1] https://lists.gnu.org/archive/html/info-gnu/2020-02/msg00008.html
Signed-off-by Khem Raj <[email protected]>Something odd is going on as another patch failure:
https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1551
perhaps pick from pull branch
https://git.yoctoproject.org/clean/cgit.cgi/poky-contrib/log/?h=kraj/pu
Quoted 4 lines
Cheers,
Richard
Quoted 4 lines · Alexander Kanavin
Quoted 2 lines · Khem Raj
Quoted 2 lines
Quoted 9 lines
Quoted 5 lines
Quoted 1 line
Merging these patches will exclude rpm from images, and so will mask the issue, so it's not orthogonal.
are you actively working to fix the test case ?
In that case it would be justified to hold themThe test case that is failing for you (with ipk/opkg and core-image-sato-sdk) is passing just fine on the autobuilder [1], so I am missing information on how to reproduce. I have requested this information from you here [2] and got no answer so far. Or is it some other test that is failing? That isn't entirely clear.
autobuilder runs poky, to reproduce this you will need to use oe-core+bitbake checkout
and then for qemux86-64
bitbake -ctestimage core-image-sato-sdk-ptest
it might also work in poky setup if you removePACKAGE_CLASSES ?= "package_rpm"
from local.conf
Quoted 8 lines · Khem Raj
autobuilder runs poky, to reproduce this you will need to use oe-core+bitbake checkout
and then for qemux86-64
bitbake -ctestimage core-image-sato-sdk-ptest
If I set up a nodistro build, ptest packages are no longer available and build doesn't start:
akanavin@ubuntu1804-ty:~/poky/build-nodistro$ bitbake core-image-sato-sdk-ptest ... ERROR: Nothing RPROVIDES 'acl-ptest' (but /home/akanavin/poky/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb RDEPENDS on or otherwise requires it)
Can you share the config (local.conf) I need to use? Or maybe you can show the failure you're getting. The tests should be skipped if /var/lib/rpm is absent on the target image, so I would like to find out why it is there (presumably).
Quoted 4 lines
it might also work in poky setup if you remove
PACKAGE_CLASSES?= "package_rpm"
from local.conf
That's what the autobuilder test does, and then it passes, so I don't think this will help.
Alex
Quoted 9 lines · Alexander Kanavin
Quoted 7 lines · Khem Raj
autobuilder runs poky, to reproduce this you will need to use oe-core+bitbake checkout
and then for qemux86-64
Quoted 9 lines
Quoted 1 line
bitbake -ctestimage core-image-sato-sdk-ptest
If I set up a nodistro build, ptest packages are no longer available and build doesn't start:
akanavin@ubuntu1804-ty:~/poky/build-nodistro$ bitbake core-image-sato-sdk-ptest ... ERROR: Nothing RPROVIDES 'acl-ptest' (but /home/akanavin/poky/meta/recipes-sato/images/core-image-sato-sdk-ptest.bb RDEPENDS on or otherwise requires it)
local.conf I have
DISTRO_FEATURES_append = " largefile opengl ptest multiarch wayland pam polkit " IMAGE_CLASSES += "testimage testsdk"
Quoted 11 lines
Can you share the config (local.conf) I need to use? Or maybe you can show the failure you're getting. The tests should be skipped if
/var/lib/rpmis absent on the target image, so I would like to find out why it is there (presumably).Quoted 4 lines
it might also work in poky setup if you remove
PACKAGE_CLASSES?= "package_rpm"
from local.confThat's what the autobuilder test does, and then it passes, so I don't think this will help.
Alex
Quoted 6 lines · Khem Raj
local.conf I have
DISTRO_FEATURES_append= " largefile opengl ptest multiarch wayland pam polkit "IMAGE_CLASSES+= "testimage testsdk"
Right, I'm running this now, it's a bit tricky because I have to do it on the Yocto AB. Big company's bureaucracy is causing delays in getting me a build machine :(
Alex
I got to it finally. Normally /var/lib/rpm is absent when opkg is in use, but when /usr/bin/rpm is present, python3's ptest involves distutils test creating rpm packages (and presumably installing them too), which creates a database in /var/lib/rpm, which then triggers rpm tests to run and fail. So a check for /var/lib/rpm in rpm tests isn't always sufficient to determine which packaging system is in use, and there should be a stronger one.
I'm fine with adjusting libsolv to not pull in rpm, but please use EXCLUDE_FROM_WORLD instead of PNBLACKLIST, so that just that specific problem is solved, rather than banning libdnf/dnf altogether from builds.
Making libdnf to not require rpm-enabled libsolv is not feasible sadly, it's basically built around that assumption.
Alex
Quoted 15 lines · Alexander Kanavin
Quoted 6 lines · Khem Raj
local.conf I have
DISTRO_FEATURES_append= " largefile opengl ptest multiarch wayland pam polkit "IMAGE_CLASSES+= "testimage testsdk"Right, I'm running this now, it's a bit tricky because I have to do it on the Yocto AB. Big company's bureaucracy is causing delays in getting me a build machine :(
Alex
Quoted 11 lines · Alexander Kanavin
I got to it finally. Normally
/var/lib/rpmis absent when opkg is in use, but when/usr/bin/rpmis present, python3's ptest involves distutils test creating rpm packages (and presumably installing them too), which creates a database in/var/lib/rpm, which then triggers rpm tests to run and fail. So a check for/var/lib/rpmin rpm tests isn't always sufficient to determine which packaging system is in use, and there should be a stronger one.I'm fine with adjusting libsolv to not pull in rpm, but please use
EXCLUDE_FROM_WORLDinstead of PNBLACKLIST, so that just that specific problem is solved, rather than banning libdnf/dnf altogether from builds.
Blacklisting is superior since this will also catch accidental inclusion of these packages when not using rpm backend where as EXCLUDE_FROM_WORLD will only be effective on word target
Quoted 3 lines
Making libdnf to not require rpm-enabled libsolv is not feasible sadly, it's basically built around that assumption.
Exactly
Quoted 22 lines
Alex
Quoted 15 lines · Alexander Kanavin
Quoted 6 lines · Khem Raj
local.conf I have
DISTRO_FEATURES_append= " largefile opengl ptest multiarch wayland pam polkit "IMAGE_CLASSES+= "testimage testsdk"Right, I'm running this now, it's a bit tricky because I have to do it on the Yocto AB. Big company's bureaucracy is causing delays in getting me a build machine :(
Alex