qlge.h cleanup - first pass
Subsystems (2)
cover qlge.h cleanup - first pass
This patchset cleans up some warnings and checks issued by checkpatch.pl for staging: qlge: qlge.h as an effort to eventually bring the qlge TODO count to zero.
There are still many CHECKs and WARNINGs for qlge.h, of which some are false-positives or odd instances which I plan on returning to after getting some more experience with the driver.
Jarrett Knauer (10):
staging: qlge: removed leading spaces identified by checkpatch.pl
staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around /
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around %
staging: qlge: checkpatch.pl CHECK - removed blank line following
brace
staging: qlge: checkpatch.pl CHECK - removed blank line after brace
staging: qlge: checkpatch.pl WARNING - removed function pointer space
staging: qlge: checkpatch.pl WARNING - missing blank line
drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 22 deletions(-)
Signature · 1 line
2.17.1
Quoted 8 lines · Jarrett Knauer
This patchset cleans up some warnings and checks issued by checkpatch.pl for staging: qlge:
qlge.has an effort to eventually bring the qlge TODO count to zero.There are still many CHECKs and WARNINGs for
qlge.h, of which some are false-positives or odd instances which I plan on returning to after getting some more experience with the driver.
Quoted 12 lines
Jarrett Knauer (10):
staging: qlge: removed leading spaces identified by checkpatch.pl
staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around /
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around %
staging: qlge: checkpatch.pl CHECK - removed blank line following
brace
staging: qlge: checkpatch.pl CHECK - removed blank line after brace
staging: qlge: checkpatch.pl WARNING - removed function pointer space
staging: qlge: checkpatch.pl WARNING - missing blank line
It seems like this cover letter made it to the netdev mailing list but not the actual patches. Please double check and resend.
Quoted 3 lines
drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 22 deletions(-)
Also, as discussed earlier and looking at the diffstat now, a single patch would be fine I think.
Quoted 21 lines · Jarrett Knauer
This patchset cleans up some warnings and checks issued by checkpatch.pl for staging: qlge:
qlge.has an effort to eventually bring the qlge TODO count to zero.There are still many CHECKs and WARNINGs for
qlge.h, of which some are false-positives or odd instances which I plan on returning to after getting some more experience with the driver.Jarrett Knauer (10):
staging: qlge: removed leading spaces identified by checkpatch.pl
staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around /
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around %
staging: qlge: checkpatch.pl CHECK - removed blank line following
brace
staging: qlge: checkpatch.pl CHECK - removed blank line after brace
staging: qlge: checkpatch.pl WARNING - removed function pointer space
staging: qlge: checkpatch.pl WARNING - missing blank line
Quoted 2 lines
drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 22 deletions(-)
I only received 8 of these patches :(
Can you please fix up and resend all of them?
thanks,
greg k-h