Skip to contentSkip to conversation

staging: qlge: remove unneeded variables

PATCH Superseded Payal Kshirsagar 3 participants 17 messages Mar 11, 2020 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover staging: qlge: remove unneeded variables

Remove unneeded temporary local variables from the files of drivers/staging/qlge directory.

Payal Kshirsagar (4):
[Outreachy kernel] staging: qlge: qlge_main.c: remove an unneeded
variable
[Outreachy kernel] staging: qlge: qlge_mpi.c: remove an unneeded
variable
[Outreachy kernel] staging: qlge: qlge_dbg.c: remove an unneeded
variable
[Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded
variable

 drivers/staging/qlge/qlge_dbg.c     | 5 +----
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 drivers/staging/qlge/qlge_main.c    | 5 +----
 drivers/staging/qlge/qlge_mpi.c     | 4 +---
 4 files changed, 4 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/4 staging: qlge: qlge_main.c: remove an unneeded variable

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

---
 drivers/staging/qlge/qlge_main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/qlge/qlge_main.c +1 -4
index c712e1af90de..057034319e4e 100644
@@ -3905,14 +3905,11 @@ static void ql_release_adapter_resources(struct ql_adapter *qdev)
 
 static int ql_get_adapter_resources(struct ql_adapter *qdev)
 {
-	int status = 0;
-
 	if (ql_alloc_mem_resources(qdev)) {
 		netif_err(qdev, ifup, qdev->ndev, "Unable to  allocate memory.\n");
 		return -ENOMEM;
 	}
-	status = ql_request_irq(qdev);
-	return status;
+	return ql_request_irq(qdev);
 }
 
 static int qlge_close(struct net_device *ndev)
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/4 staging: qlge: qlge_mpi.c: remove an unneeded variable

In reply to Payal Kshirsagar

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

---
 drivers/staging/qlge/qlge_mpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/qlge/qlge_mpi.c +1 -3
index bb03b2fa7233..eae168e94b82 100644
@@ -90,9 +90,7 @@ int ql_write_mpi_reg(struct ql_adapter *qdev, u32 reg, u32 data)
 
 int ql_soft_reset_mpi_risc(struct ql_adapter *qdev)
 {
-	int status;
-	status = ql_write_mpi_reg(qdev, 0x00001010, 1);
-	return status;
+	return ql_write_mpi_reg(qdev, 0x00001010, 1);
 }
 
 /* Determine if we are in charge of the firwmare. If
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/4 staging: qlge: qlge_dbg.c: remove an unneeded variable

In reply to Payal Kshirsagar

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

---
 drivers/staging/qlge/qlge_dbg.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/qlge/qlge_dbg.c +1 -4
index 670361873d1d..f1a6157fb7e1 100644
@@ -29,15 +29,12 @@ static int ql_write_other_func_reg(struct ql_adapter *qdev,
 				   u32 reg, u32 reg_val)
 {
 	u32 register_to_read;
-	int status = 0;
 
 	register_to_read = MPI_NIC_REG_BLOCK
 				| MPI_NIC_READ
 				| (qdev->alt_func << MPI_NIC_FUNCTION_SHIFT)
 				| reg;
-	status = ql_write_mpi_reg(qdev, register_to_read, reg_val);
-
-	return status;
+	return ql_write_mpi_reg(qdev, register_to_read, reg_val);
 }
 
 static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg,
Signature · 1 line
2.17.1
#4 lore raw

PATCH 4/4 staging: qlge: qlge_ethtool.c: remove an unneeded variable

In reply to Payal Kshirsagar

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

---
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/qlge/qlge_ethtool.c +1 -4
index 592ca7edfc44..e15f9723b5c0 100644
@@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
 			     struct ethtool_pauseparam *pause)
 {
 	struct ql_adapter *qdev = netdev_priv(netdev);
-	int status = 0;
 
 	if ((pause->rx_pause) && (pause->tx_pause))
 		qdev->link_config |= CFG_PAUSE_STD;
@@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device *netdev,
 		qdev->link_config &= ~CFG_PAUSE_STD;
 	else
 		return -EINVAL;
-
-	status = ql_mb_set_port_cfg(qdev);
-	return status;
+	return ql_mb_set_port_cfg(qdev);
 }
 
 static u32 ql_get_msglevel(struct net_device *ndev)
Signature · 1 line
2.17.1
#5 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 20 lines · On Wed, 11 Mar 2020 14:58:15 +0530 Payal Kshirsagar…

Remove unneeded temporary local variable, cleanup suggested by coccinelle.

---
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/qlge/qlge_ethtool.c +0 -1
index 592ca7edfc44..e15f9723b5c0 100644
@@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
 			     struct ethtool_pauseparam *pause)
 {
 	struct ql_adapter *qdev = netdev_priv(netdev);
-	int status = 0;
 
 	if ((pause->rx_pause) && (pause->tx_pause))
 		qdev->link_config |= CFG_PAUSE_STD;

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device *netdev, · line 702

Quoted 7 lines
drivers/staging/qlge/qlge_ethtool.c +1 -3
@@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device *netdev,
 		qdev->link_config &= ~CFG_PAUSE_STD;
 	else
 		return -EINVAL;
-
-	status = ql_mb_set_port_cfg(qdev);
-	return status;
+	return ql_mb_set_port_cfg(qdev);

Here, you're also removing a newline that is typically inserted before a second return (or the last one in a function) for readability, or whenever there are two logically distinct branches, same in 3/4.

And in 1/4, you might want to add one. In 2/4, there's no need.

Signature · 1 line
Stefano
#6 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 35 lines · Stefano Brivio
Quoted 1 line · On Wed, 11 Mar 2020 14:58:15 +0530 Payal Kshirsagar…

Remove unneeded temporary local variable, cleanup suggested by

coccinelle.

Review

Quoted 7 lines
---
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/qlge/qlge_ethtool.c

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device

Quoted 4 lines

index 592ca7edfc44..e15f9723b5c0 100644

drivers/staging/qlge/qlge_ethtool.c +0 -0
@@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device

*netdev,

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device

Quoted 8 lines
drivers/staging/qlge/qlge_ethtool.c +0 -1
                           struct ethtool_pauseparam *pause)
 {
      struct ql_adapter *qdev = netdev_priv(netdev);
-     int status = 0;
 
      if ((pause->rx_pause) && (pause->tx_pause))
              qdev->link_config |= CFG_PAUSE_STD;
@@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device

*netdev,

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device *netdev, · line 702

Quoted 7 lines
drivers/staging/qlge/qlge_ethtool.c +1 -3
              qdev->link_config &= ~CFG_PAUSE_STD;
      else
              return -EINVAL;
-
-     status = ql_mb_set_port_cfg(qdev);
-     return status;
+     return ql_mb_set_port_cfg(qdev);
Quoted 4 lines

Here, you're also removing a newline that is typically inserted before a second return (or the last one in a function) for readability, or whenever there are two logically distinct branches, same in 3/4.

Thanks for the suggestion.
I thought there is no need to keep the newline as is:D
But I did not understand what do you want me to do, patch is okay or need to be resend by adding a newline for readability:)

payal

And in 1/4, you might want to add one. In 2/4, there's no need.

Quoted 4 lines

--
Stefano

#7 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 37 lines · On Wed, 11 Mar 2020 17:50:35 +0530 Payal Kshirsagar…
Quoted 35 lines · Stefano Brivio
Quoted 1 line · On Wed, 11 Mar 2020 14:58:15 +0530 Payal Kshirsagar…

Remove unneeded temporary local variable, cleanup suggested by

coccinelle.

Review

Quoted 7 lines
---
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/qlge/qlge_ethtool.c

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device

Quoted 4 lines

index 592ca7edfc44..e15f9723b5c0 100644

drivers/staging/qlge/qlge_ethtool.c +0 -0
@@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device  

*netdev,

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device

Quoted 8 lines
drivers/staging/qlge/qlge_ethtool.c +0 -1
                           struct ethtool_pauseparam *pause)
 {
      struct ql_adapter *qdev = netdev_priv(netdev);
-     int status = 0;
 
      if ((pause->rx_pause) && (pause->tx_pause))
              qdev->link_config |= CFG_PAUSE_STD;
@@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device  

*netdev,

Quoted 7 lines
drivers/staging/qlge/qlge_ethtool.c +1 -3
              qdev->link_config &= ~CFG_PAUSE_STD;
      else
              return -EINVAL;
-
-     status = ql_mb_set_port_cfg(qdev);
-     return status;
+     return ql_mb_set_port_cfg(qdev);  
Quoted 7 lines
Quoted 4 lines

Here, you're also removing a newline that is typically inserted before a second return (or the last one in a function) for readability, or whenever there are two logically distinct branches, same in 3/4.

Thanks for the suggestion.
I thought there is no need to keep the newline as is:D

Have a look at some "sane" examples (especially outside of drivers/staging), maybe that helps getting a picture...

Quoted 2 lines

But I did not understand what do you want me to do, patch is okay or need to be resend by adding a newline for readability:)

I would say you need to re-send the series, because 3/4 and 4/4 actually impair readability in their current form.

Note that I gave my Reviewed-by: on another patch of yours, not on this series.

Another note: from the cover letter, it's apparent that "[Outreachy kernel]" is part of commit titles. It shouldn't be, that's only a prefix (git format-patch --subject-prefix) for email.

Quoted 8 lines

payal

And in 1/4, you might want to add one. In 2/4, there's no need.

Quoted 4 lines

--
Stefano

One note about quoting: read above. Who wrote what?

I see you're using GMail, which is fine, by all means, but:

- you shouldn't send HTML emails to kernel lists. Especially with projects using patchwork
(example: https://patchwork.ozlabs.org/project/netdev/list/) this has a big potential to mess things up

- you should fix your quoting: a sentence I wrote needs a "> >" prefix there, otherwise it seems to come from you, and I'll get confused.

That is, I suggest that you set up an email client as also covered by the tutorial. The GMail web interface is probably not ideal. The tutorial suggests 'mutt', but it's not mandatory. I'm using claws-mail to send you this e-mail and for my work in general.

There are other graphical or text-based clients (Evolution, pine, sylpheed, KMail, many others) that can also be used for this purpose. I would suggest that you look at screenshots, maybe play with some of them, find one you're comfortable with, and set it up.

Signature · 1 line
Stefano
#8 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 112 lines · Stefano Brivio
Quoted 37 lines · On Wed, 11 Mar 2020 17:50:35 +0530 Payal Kshirsagar…
Quoted 35 lines · Stefano Brivio
Quoted 1 line · On Wed, 11 Mar 2020 14:58:15 +0530 Payal Kshirsagar…

Remove unneeded temporary local variable, cleanup suggested by

coccinelle.

Review

Quoted 7 lines
---
 drivers/staging/qlge/qlge_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/qlge/qlge_ethtool.c

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device

Quoted 4 lines

index 592ca7edfc44..e15f9723b5c0 100644

drivers/staging/qlge/qlge_ethtool.c +0 -0
@@ -692,7 +692,6 @@ static int ql_set_pauseparam(struct net_device

*netdev,

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device

Quoted 8 lines
drivers/staging/qlge/qlge_ethtool.c +0 -1
                           struct ethtool_pauseparam *pause)
 {
      struct ql_adapter *qdev = netdev_priv(netdev);
-     int status = 0;
 
      if ((pause->rx_pause) && (pause->tx_pause))
              qdev->link_config |= CFG_PAUSE_STD;
@@ -700,9 +699,7 @@ static int ql_set_pauseparam(struct net_device

*netdev,

Quoted 7 lines
drivers/staging/qlge/qlge_ethtool.c +1 -3
              qdev->link_config &= ~CFG_PAUSE_STD;
      else
              return -EINVAL;
-
-     status = ql_mb_set_port_cfg(qdev);
-     return status;
+     return ql_mb_set_port_cfg(qdev);
Quoted 7 lines
Quoted 4 lines

Here, you're also removing a newline that is typically inserted before a second return (or the last one in a function) for readability, or whenever there are two logically distinct branches, same in 3/4.

Thanks for the suggestion.
I thought there is no need to keep the newline as is:D

Have a look at some "sane" examples (especially outside of drivers/staging), maybe that helps getting a picture...

Quoted 2 lines

But I did not understand what do you want me to do, patch is okay or need to be resend by adding a newline for readability:)

I would say you need to re-send the series, because 3/4 and 4/4 actually impair readability in their current form.

Note that I gave my Reviewed-by: on another patch of yours, not on this series.

Another note: from the cover letter, it's apparent that "[Outreachy kernel]" is part of commit titles. It shouldn't be, that's only a prefix (git format-patch --subject-prefix) for email.
If I run git format-patch --subject-prefix="Outreachy Kernel" HEAD^, it only adds [Outreachy Kernel] prefix to the subject not [PATCH]. I am only able to add either [Outreachy Kernel] or [PATCH]. Please guide me regarding the same.

Quoted 7 lines

payal

And in 1/4, you might want to add one. In 2/4, there's no need.

Quoted 4 lines

--
Stefano

One note about quoting: read above. Who wrote what?

I see you're using GMail, which is fine, by all means, but:

- you shouldn't send HTML emails to kernel lists. Especially with projects using patchwork
(example: https://patchwork.ozlabs.org/project/netdev/list/) this has a big potential to mess things up

- you should fix your quoting: a sentence I wrote needs a "> >" prefix there, otherwise it seems to come from you, and I'll get confused.

That is, I suggest that you set up an email client as also covered by the tutorial. The GMail web interface is probably not ideal. The tutorial suggests 'mutt', but it's not mandatory. I'm using claws-mail to send you this e-mail and for my work in general.

There are other graphical or text-based clients (Evolution, pine, sylpheed, KMail, many others) that can also be used for this purpose. I would suggest that you look at screenshots, maybe play with some of them, find one you're comfortable with, and set it up.
I followed every step of setting up the gmail as mentioned in tutorial, I don't know why this is happening;(
--
Stefano

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20200311134418.468f571a%40elisabeth
.

#9 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Payal,

Quoted 8 lines · On Wed, 11 Mar 2020 19:16:21 +0530 Payal Kshirsagar…
Quoted 6 lines · Stefano Brivio

There are other graphical or text-based clients (Evolution, pine, sylpheed, KMail, many others) that can also be used for this purpose. I would suggest that you look at screenshots, maybe play with some of them, find one you're comfortable with, and set it up.
I followed every step of setting up the gmail as mentioned in tutorial, I don't know why this is happening;(

I guess you set up git to play along with GMail, and that's fine to send patches -- I see it's working properly.

But, for this discussion, are you sure you are using an actual email client (and not a browser connected to gmail.com)? That is, are you using one of those programs I mentioned below?

Signature · 1 line
Stefano
#10 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 28 lines · Stefano Brivio

Payal,

Quoted 1 line · On Wed, 11 Mar 2020 19:16:21 +0530 Payal Kshirsagar…

On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio <[email protected]>

Quoted 6 lines · wrote:
Quoted 6 lines

There are other graphical or text-based clients (Evolution, pine, sylpheed, KMail, many others) that can also be used for this purpose. I would suggest that you look at screenshots, maybe play with some of them, find one you're comfortable with, and set it up.
I followed every step of setting up the gmail as mentioned in

tutorial, I

Quoted 1 line
Quoted 1 line

don't know why this is happening;(

I guess you set up git to play along with GMail, and that's fine to send patches -- I see it's working properly.

But, for this discussion, are you sure you are using an actual email client (and not a browser connected to gmail.com)? That is, are you using one of those programs I mentioned below?

Yes I am using the Gmail not in a browser.

Sir I am having trouble with adding [Outreachy Kernel] [PATCH]
prefix to the subject, I am not able to add these two at the same time.
Please suggest me something.

Quoted 3 lines

Stefano

#11 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 26 lines · Payal Kshirsagar

On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <[email protected]> wrote:
Payal,

On Wed, 11 Mar 2020 19:16:21 +0530
Payal Kshirsagar <[email protected]> wrote:

> On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio <[email protected]> wrote:
>
> > There are other graphical or text-based clients (Evolution, pine,
> > sylpheed, KMail, many others) that can also be used for this purpose. I
> > would suggest that you look at screenshots, maybe play with some of
> > them, find one you're comfortable with, and set it up. > > I followed every step of setting up the gmail as mentioned in tutorial, I
> > don't know why this is happening;(

I guess you set up git to play along with GMail, and that's fine to
send patches -- I see it's working properly.

Quoted 11 lines

But, for this discussion, are you sure you are using an actual email
client (and not a browser connected to gmail.com)? That is, are you
using one of those programs I mentioned below?

Yes I am using the Gmail not in a browser.

                                Sir I am having trouble with adding [Outreachy Kernel] [PATCH] prefix to the subject, I am not able to add these two at the same time.

You should never add [Outreachy Kernel] to anything. When you send messages to the mailing list, that will get added.

I agree with Stefano that your way of responding to messages causes problems. If you look above, there is no way to see what you wrote and what Stefano wrote.

What program do you use to read and respond to your mail?

julia

Quoted 14 lines

          Please suggest me something.

--
Stefano

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BDPbQWR CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.

#12 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 42 lines · Julia Lawall
Quoted 32 lines · Payal Kshirsagar

On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <[email protected]> wrote:
Payal,

On Wed, 11 Mar 2020 19:16:21 +0530
Payal Kshirsagar <[email protected]> wrote:

> On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio <[email protected]> wrote:
>
> > There are other graphical or text-based clients (Evolution, pine,
> > sylpheed, KMail, many others) that can also be used for this purpose. I
> > would suggest that you look at screenshots, maybe play with some of
> > them, find one you're comfortable with, and set it up. > > I followed every step of setting up the gmail as mentioned in tutorial, I
> > don't know why this is happening;(

I guess you set up git to play along with GMail, and that's fine to
send patches -- I see it's working properly.

But, for this discussion, are you sure you are using an actual email
client (and not a browser connected to gmail.com)? That is, are you
using one of those programs I mentioned below?

Quoted 5 lines

Yes I am using the Gmail not in a browser.

Sir I am having trouble with
adding [Outreachy Kernel] [PATCH] prefix to the subject, I am not able to add these two at the same time.

Quoted 9 lines

You should never add [Outreachy Kernel] to anything. When you send messages to the mailing list, that will get added.

I agree with Stefano that your way of responding to messages causes problems. If you look above, there is no way to see what you wrote and what Stefano wrote.

What program do you use to read and respond to your mail?

An android app Gmail.

julia

Quoted 17 lines
Quoted 7 lines

Please suggest me something.

--
Stefano

Quoted 6 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BDPbQWR

Quoted 3 lines

CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.

#13 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

[Dropping some probably uninterested Cc's]

Quoted 8 lines · On Wed, 11 Mar 2020 21:22:54 +0530 Payal Kshirsagar…
Quoted 2 lines · Julia Lawall

What program do you use to read and respond to your mail?

An android app Gmail.

julia

Payal-impersonating-julia, :)

If an Android device is what you plan to using for development, it might be challenging, but I don't exclude it's doable. We'll have to figure out a way to get your quoting right.

By the way, K-9 Mail is what I use on my smartphone in case of emergency (laptop/PC not available), with a bit of care it can be used to contribute as well.

If, on the other hand, you plan on using a regular Linux distribution for development, I would suggest that you use that system and that you take some time to set up an e-mail client there.

Signature · 1 line
Stefano
#14 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

In reply to Payal Kshirsagar

It does not adding [Outreachy Kernel] automatically in my system :(

Quoted 86 lines · Payal Kshirsagar
Quoted 7 lines · Julia Lawall
Quoted 3 lines · Payal Kshirsagar

On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <[email protected]>

Quoted 9 lines · wrote:
Quoted 9 lines
      Payal,

      On Wed, 11 Mar 2020 19:16:21 +0530
      Payal Kshirsagar <[email protected]> wrote:

      > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio
      <[email protected]> wrote:
      >
      > > There are other graphical or text-based clients

(Evolution,

Quoted 2 lines
Quoted 2 lines

pine,
> > sylpheed, KMail, many others) that can also be used for

this

Quoted 2 lines
Quoted 2 lines

purpose. I
> > would suggest that you look at screenshots, maybe play

with

Quoted 3 lines
Quoted 3 lines

some of
> > them, find one you're comfortable with, and set it up. > > I followed every step of setting up the gmail as

mentioned

Quoted 4 lines
Quoted 4 lines

in tutorial, I
> > don't know why this is happening;(

I guess you set up git to play along with GMail, and that's

fine

Quoted 4 lines
Quoted 4 lines

to
send patches -- I see it's working properly.

But, for this discussion, are you sure you are using an

actual

Quoted 2 lines
Quoted 2 lines

email
client (and not a browser connected to gmail.com)? That is,

are

Quoted 9 lines
Quoted 8 lines

you
using one of those programs I mentioned below?

Yes I am using the Gmail not in a browser.

Sir I am having trouble with
adding [Outreachy Kernel] [PATCH] prefix to the subject, I am not able to add these two at the same time.

Quoted 5 lines

You should never add [Outreachy Kernel] to anything. When you send messages to the mailing list, that will get added.

I agree with Stefano that your way of responding to messages causes problems. If you look above, there is no way to see what you wrote

and

Quoted 4 lines

what Stefano wrote.

What program do you use to read and respond to your mail?

An android app Gmail.

julia

Quoted 9 lines
Quoted 9 lines

Please suggest me something.

--
Stefano

--
You received this message because you are subscribed to the Google

Groups

Quoted 2 lines
Quoted 2 lines

"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it,

send an

Quoted 6 lines
Quoted 2 lines

email to [email protected]. To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BDPbQWR

Quoted 3 lines

CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.

Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.
#15 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 1 line · Payal Kshirsagar

It does not adding [Outreachy Kernel] automatically in my system :(

I don't understand what you mean by "in my system". [Outreachy kernel] appears when other people receive your messages via the mailing list. It has nothing to do with you.

julia

Quoted 106 lines

On March 11, 2020 9:22:54 PM GMT+05:30, Payal Kshirsagar <[email protected]> wrote:

On Wed, Mar 11, 2020, 8:37 PM Julia Lawall
<[email protected]> wrote:

On Wed, 11 Mar 2020, Payal Kshirsagar wrote:

>
>
> On Wed, Mar 11, 2020, 8:02 PM Stefano Brivio <[email protected]> wrote:
>       Payal,
>
>       On Wed, 11 Mar 2020 19:16:21 +0530
>       Payal Kshirsagar <[email protected]> wrote:
>
>       > On Wed, Mar 11, 2020 at 6:14 PM Stefano Brivio >       <[email protected]> wrote:
>       >
>       > > There are other graphical or text-based clients (Evolution,
>       pine,
>       > > sylpheed, KMail, many others) that can also be used for this
>       purpose. I
>       > > would suggest that you look at screenshots, maybe play with
>       some of
>       > > them, find one you're comfortable with, and set it up.
>       > > I followed every step of setting up the gmail as mentioned
>       in tutorial, I
>       > > don't know why this is happening;(
>
>       I guess you set up git to play along with GMail, and that's fine
>       to
>       send patches -- I see it's working properly. >
>       But, for this discussion, are you sure you are using an actual
>       email
>       client (and not a browser connected to gmail.com)? That is, are
>       you
>       using one of those programs I mentioned below?

>
>       Yes I am using the Gmail not in a browser.

>

>                                       Sir I am having trouble with
>       adding [Outreachy Kernel] [PATCH] prefix to the subject, I am
>       not able to add these two at the same time.

You should never add [Outreachy Kernel] to anything.  When you send
messages to the mailing list, that will get added.

I agree with Stefano that your way of responding to messages causes
problems.  If you look above, there is no way to see what you wrote and
what Stefano wrote.

What program do you use to read and respond to your mail?

An android app Gmail.

julia

>                 Please suggest me something.

>
>       --
>       Stefano
>
> --
> You received this message because you are subscribed to
the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails
from it, send an
> email to [email protected].
> To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CAJyzNhkd%2BeBh%2BD PbQWR
> CLushYFRTRWKNF%3DkrY5AJG25U56%3DhDQ%40mail.gmail.com.
>
>

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

#16 lore raw

Re: [PATCH 4/4] [Outreachy kernel] staging: qlge: qlge_ethtool.c: remove an unneeded variable

Quoted 7 lines · On Wed, 11 Mar 2020 21:31:30 +0100 (CET) Julia Lawall <[email protected]>…
Quoted 1 line · Payal Kshirsagar

It does not adding [Outreachy Kernel] automatically in my system :(

I don't understand what you mean by "in my system". [Outreachy kernel] appears when other people receive your messages via the mailing list. It has nothing to do with you.

I think what happened to Payal here is that K-9 Mail detects the email as "sent" even when shown in a folder, and shows the copy as sent, which doesn't then carry the tag added to the subject. Should be fixed by switching to Evolution :)

Signature · 1 line
Stefano