Skip to contentSkip to conversation

staging: qlge: simple formatting cleanup

PATCH In review Lourdes Pedrajas 2 participants 6 messages Mar 14, 2020 – Mar 17, 2020 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: qlge: simple formatting cleanup

Patchset that performs simple code cleanup in qlge driver. Some issues found with checkpatch.

Lourdes Pedrajas (2):
staging: qlge: qlge_dbg: remove unneeded spaces
staging: qlge: qlge_main: remove unused code

 drivers/staging/qlge/qlge_dbg.c  | 22 +++++++++++-----------
 drivers/staging/qlge/qlge_main.c |  4 ----
 2 files changed, 11 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 staging: qlge: qlge_dbg: remove unneeded spaces

Remove spaces after type casting operators in order to comply codding standards.
Issue found with checkpatch.

---
 drivers/staging/qlge/qlge_dbg.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/qlge/qlge_dbg.c +11 -11
index 670361873d1d..e2fa2a907d0d 100644
@@ -1620,9 +1620,9 @@ void ql_dump_wqicb(struct wqicb *wqicb)
 	       le16_to_cpu(wqicb->cq_id_rss));
 	pr_err("wqicb->rid = 0x%x\n", le16_to_cpu(wqicb->rid));
 	pr_err("wqicb->wq_addr = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(wqicb->addr));
+	       (unsigned long long)le64_to_cpu(wqicb->addr));
 	pr_err("wqicb->wq_cnsmr_idx_addr = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(wqicb->cnsmr_idx_addr));
+	       (unsigned long long)le64_to_cpu(wqicb->cnsmr_idx_addr));
 }
 
 void ql_dump_tx_ring(struct tx_ring *tx_ring)
@@ -1633,7 +1633,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)
 	       tx_ring->wq_id);
 	pr_err("tx_ring->base = %p\n", tx_ring->wq_base);
 	pr_err("tx_ring->base_dma = 0x%llx\n",
-	       (unsigned long long) tx_ring->wq_base_dma);
+	       (unsigned long long)tx_ring->wq_base_dma);
 	pr_err("tx_ring->cnsmr_idx_sh_reg, addr = 0x%p, value = %d\n",
 	       tx_ring->cnsmr_idx_sh_reg,
 	       tx_ring->cnsmr_idx_sh_reg
@@ -1686,21 +1686,21 @@ void ql_dump_cqicb(struct cqicb *cqicb)
 	pr_err("cqicb->flags = %x\n", cqicb->flags);
 	pr_err("cqicb->len = %d\n", le16_to_cpu(cqicb->len));
 	pr_err("cqicb->addr = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(cqicb->addr));
+	       (unsigned long long)le64_to_cpu(cqicb->addr));
 	pr_err("cqicb->prod_idx_addr = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(cqicb->prod_idx_addr));
+	       (unsigned long long)le64_to_cpu(cqicb->prod_idx_addr));
 	pr_err("cqicb->pkt_delay = 0x%.04x\n",
 	       le16_to_cpu(cqicb->pkt_delay));
 	pr_err("cqicb->irq_delay = 0x%.04x\n",
 	       le16_to_cpu(cqicb->irq_delay));
 	pr_err("cqicb->lbq_addr = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(cqicb->lbq_addr));
+	       (unsigned long long)le64_to_cpu(cqicb->lbq_addr));
 	pr_err("cqicb->lbq_buf_size = 0x%.04x\n",
 	       le16_to_cpu(cqicb->lbq_buf_size));
 	pr_err("cqicb->lbq_len = 0x%.04x\n",
 	       le16_to_cpu(cqicb->lbq_len));
 	pr_err("cqicb->sbq_addr = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(cqicb->sbq_addr));
+	       (unsigned long long)le64_to_cpu(cqicb->sbq_addr));
 	pr_err("cqicb->sbq_buf_size = 0x%.04x\n",
 	       le16_to_cpu(cqicb->sbq_buf_size));
 	pr_err("cqicb->sbq_len = 0x%.04x\n",
@@ -1728,7 +1728,7 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring)
 	pr_err("rx_ring->cqicb = %p\n", &rx_ring->cqicb);
 	pr_err("rx_ring->cq_base = %p\n", rx_ring->cq_base);
 	pr_err("rx_ring->cq_base_dma = %llx\n",
-	       (unsigned long long) rx_ring->cq_base_dma);
+	       (unsigned long long)rx_ring->cq_base_dma);
 	pr_err("rx_ring->cq_size = %d\n", rx_ring->cq_size);
 	pr_err("rx_ring->cq_len = %d\n", rx_ring->cq_len);
 	pr_err("rx_ring->prod_idx_sh_reg, addr = 0x%p, value = %d\n",
@@ -1736,7 +1736,7 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring)
 	       rx_ring->prod_idx_sh_reg
 			? ql_read_sh_reg(rx_ring->prod_idx_sh_reg) : 0);
 	pr_err("rx_ring->prod_idx_sh_reg_dma = %llx\n",
-	       (unsigned long long) rx_ring->prod_idx_sh_reg_dma);
+	       (unsigned long long)rx_ring->prod_idx_sh_reg_dma);
 	pr_err("rx_ring->cnsmr_idx_db_reg = %p\n",
 	       rx_ring->cnsmr_idx_db_reg);
 	pr_err("rx_ring->cnsmr_idx = %d\n", rx_ring->cnsmr_idx);
@@ -1959,7 +1959,7 @@ void ql_dump_ib_mac_rsp(struct ib_mac_iocb_rsp *ib_mac_rsp)
 	pr_err("data_len	= %d\n",
 	       le32_to_cpu(ib_mac_rsp->data_len));
 	pr_err("data_addr    = 0x%llx\n",
-	       (unsigned long long) le64_to_cpu(ib_mac_rsp->data_addr));
+	       (unsigned long long)le64_to_cpu(ib_mac_rsp->data_addr));
 	if (ib_mac_rsp->flags3 & IB_MAC_IOCB_RSP_RSS_MASK)
 		pr_err("rss    = %x\n",
 		       le32_to_cpu(ib_mac_rsp->rss));
@@ -1976,7 +1976,7 @@ void ql_dump_ib_mac_rsp(struct ib_mac_iocb_rsp *ib_mac_rsp)
 		pr_err("hdr length	= %d\n",
 		       le32_to_cpu(ib_mac_rsp->hdr_len));
 		pr_err("hdr addr    = 0x%llx\n",
-		       (unsigned long long) le64_to_cpu(ib_mac_rsp->hdr_addr));
+		       (unsigned long long)le64_to_cpu(ib_mac_rsp->hdr_addr));
 	}
 }
 #endif
Signature · 1 line
2.17.1
#4 lore raw

PATCH 2/2 staging: qlge: qlge_main: remove unused code

In reply to Lourdes Pedrajas

Remove commented out lines. They are not used since 2009.

---
 drivers/staging/qlge/qlge_main.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/qlge/qlge_main.c +0 -4
index c712e1af90de..f997993f3c26 100644
@@ -53,14 +53,10 @@ MODULE_VERSION(DRV_VERSION);
 
 static const u32 default_msg =
 	NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK |
-/* NETIF_MSG_TIMER |	*/
 	NETIF_MSG_IFDOWN |
 	NETIF_MSG_IFUP |
 	NETIF_MSG_RX_ERR |
 	NETIF_MSG_TX_ERR |
-/*  NETIF_MSG_TX_QUEUED | */
-/*  NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */
-/* NETIF_MSG_PKTDATA | */
 	NETIF_MSG_HW | NETIF_MSG_WOL | 0;
 
 static int debug = -1;	/* defaults above */
Signature · 1 line
2.17.1
#2 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces

In reply to Lourdes Pedrajas
Quoted 1 line · On Sun, 15 Mar 2020 00:46:07 +0100 Lourdes Pedrajas <[email protected]> wrote:

Remove spaces after type casting operators in order to comply codding

with coding?

Quoted 1 line

standards.

I personally don't care about typos in commit messages unless it's changes that fix typos, though.

Signature · 1 line
Stefano
Reviewed-by on the v1 series
#5 lore raw
In reply to Lourdes Pedrajas
Quoted 6 lines · On Sun, 15 Mar 2020 00:46:06 +0100 Lourdes Pedrajas <[email protected]> wrote:

Patchset that performs simple code cleanup in qlge driver. Some issues found with checkpatch.

Lourdes Pedrajas (2):
staging: qlge: qlge_dbg: remove unneeded spaces
staging: qlge: qlge_main: remove unused code

For the series,

Signature · 1 line
Stefano
#3 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces

In reply to Stefano Brivio
Quoted 15 lines · Stefano Brivio
Quoted 1 line · On Sun, 15 Mar 2020 00:46:07 +0100 Lourdes Pedrajas <[email protected]> wrote:

Remove spaces after type casting operators in order to comply codding

with coding?

Quoted 1 line

standards.

I personally don't care about typos in commit messages unless it's changes that fix typos, though.

Signature · 1 line
Stefano

Agreed, that was funny. I will take more care the next time! :)

Thank you,
Lourdes