Skip to contentSkip to conversation

Correction of typos in comments

PATCH In review R Veera Kumar 2 participants 8 messages Mar 19, 2020 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover Correction of typos in comments

Correct typos in comments.
Misspellings found using checkpatch.pl

---
R Veera Kumar (4):
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typo in comment
staging: rtl8723bs: os_dep: Correct typo in comment

 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c   | 4 ++--
 drivers/staging/rtl8723bs/os_dep/os_intfs.c      | 4 ++--
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 2 +-
 drivers/staging/rtl8723bs/os_dep/recv_linux.c    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/4 staging: rtl8723bs: os_dep: Correct typos in comments

Correct typos in comments.
Misspelling found using checkpatch.pl.

---
Changes in v2:
- Remove word "Fix" from subject line
- Change "C comments" to "comments" in subject line
- Change "C comments" to "comments" in body

---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +2 -2
index 29f36cca3972..5059b874080e 100644
@@ -1093,7 +1093,7 @@ static int rtw_wx_get_range(struct net_device *dev,
 /*  Commented by Albert 2009/10/13 */
 /*  The following code will proivde the security capability to network manager. */
 /*  If the driver doesn't provide this capability to network manager, */
-/*  the WPA/WPA2 routers can't be choosen in the network manager. */
+/*  the WPA/WPA2 routers can't be chosen in the network manager. */
 
 /*
 #define IW_SCAN_CAPA_NONE		0x00
@@ -1391,7 +1391,7 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a,
 
 		}
 
-		/* jeff: it has still some scan paramater to parse, we only do this now... */
+		/* jeff: it has still some scan parameter to parse, we only do this now... */
 		_status = rtw_set_802_11_bssid_list_scan(padapter, ssid, RTW_SSID_SCAN_AMOUNT);
 
 	} else {
Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 2/4 staging: rtl8723bs: os_dep: Correct typos in comments

In reply to R Veera Kumar

Correct typos in comments.
Misspelling found using checkpatch.pl.

---
Changes in v2:
- Remove word "Fix" from subject line
- Change "C comments" to "comments" in subject line
- Change "C comments" to "comments" in body

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/os_intfs.c +2 -2
index 17e65934fb5b..d29f59bbb613 100644
@@ -1274,7 +1274,7 @@ void rtw_suspend_wow(struct adapter *padapter)
 			padapter->intf_stop(padapter);
 		}
 
-		/*  2.1 clean interupt */
+		/*  2.1 clean interrupt */
 		if (padapter->HalFunc.clear_interrupt)
 			padapter->HalFunc.clear_interrupt(padapter);
 
@@ -1348,7 +1348,7 @@ void rtw_suspend_ap_wow(struct adapter *padapter)
 	/*  2. disable interrupt */
 	rtw_hal_disable_interrupt(padapter); /*  It need wait for leaving 32K. */
 
-	/*  2.1 clean interupt */
+	/*  2.1 clean interrupt */
 	if (padapter->HalFunc.clear_interrupt)
 		padapter->HalFunc.clear_interrupt(padapter);
 
Signature · 1 line
2.20.1
#3 lore raw

PATCH v2 3/4 staging: rtl8723bs: os_dep: Correct typo in comment

In reply to R Veera Kumar

Correct typos in comment.
Misspelling found using checkpatch.pl.

---
Changes in v2:
- Remove word "Fix" from subject line
- Change "C comments" to "comments" in subject line
- Change "C comments" to "comments" in body

---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/osdep_service.c +1 -1
index f5614e56371e..4238209ec175 100644
@@ -289,7 +289,7 @@ void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
 }
 
 /**
- * rtw_cbuf_alloc - allocte a rtw_cbuf with given size and do initialization
+ * rtw_cbuf_alloc - allocate a rtw_cbuf with given size and do initialization
  * @size: size of pointer
  *
  * Returns: pointer of srtuct rtw_cbuf, NULL for allocation failure
Signature · 1 line
2.20.1
#4 lore raw

PATCH v2 4/4 staging: rtl8723bs: os_dep: Correct typo in comment

In reply to R Veera Kumar

Correct typos in comment.
Misspelling found using checkpatch.pl.

---
Changes in v2:
- Remove word "Fix" from subject line
- Change "C comments" to "comments" in subject line
- Change "C comments" to "comments" in body

---
 drivers/staging/rtl8723bs/os_dep/recv_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/recv_linux.c +1 -1
index 22059bbbed9d..a6491f163272 100644
@@ -101,7 +101,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
 	struct mlme_priv*pmlmepriv = &padapter->mlmepriv;
 	int ret;
 
-	/* Indicat the packets to upper layer */
+	/* Indicate the packets to upper layer */
 	if (pkt) {
 		if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true) {
 			_pkt *pskb2 = NULL;
Signature · 1 line
2.20.1
#5 lore raw
In reply to R Veera Kumar
Quoted 9 lines · R Veera Kumar

Correct typos in comments.
Misspellings found using checkpatch.pl

---
R Veera Kumar (4):
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typo in comment
staging: rtl8723bs: os_dep: Correct typo in comment

You need unique subject lines, please.

#6 lore raw
Quoted 4 lines · Greg Kroah-Hartman
Quoted 3 lines · R Veera Kumar

Correct typos in comments.
Misspellings found using checkpatch.pl

Quoted 9 lines
Quoted 6 lines

---
R Veera Kumar (4):
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typo in comment
staging: rtl8723bs: os_dep: Correct typo in comment

You need unique subject lines, please.

I do not know what to put.
Should I put the file names in subject. Someone told not to do so. All the four patches correct one or two single letter misspellings in one or two comments.

Can you give me a suggestion.

Veera

#7 lore raw
Quoted 15 lines · R Veera Kumar
Quoted 4 lines · Greg Kroah-Hartman
Quoted 3 lines · R Veera Kumar

Correct typos in comments.
Misspellings found using checkpatch.pl

Quoted 9 lines
Quoted 6 lines

---
R Veera Kumar (4):
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typos in comments
staging: rtl8723bs: os_dep: Correct typo in comment
staging: rtl8723bs: os_dep: Correct typo in comment

You need unique subject lines, please.

Quoted 6 lines

I do not know what to put.
Should I put the file names in subject. Someone told not to do so. All the four patches correct one or two single letter misspellings in one or two comments.

Can you give me a suggestion.

That is up to you. If you are not doing something unique in each individual patch, then why did you think to break them up? If they are not doing the same exact thing, then you should be able to describe them in a unique way.

good luck!

greg k-h