Skip to contentSkip to conversation

Avoid multiple line dereference

PATCH In review Gokce Kuler 3 participants 6 messages Mar 20, 2020

Subsystems (2)
USB Staging
lore
Share & tools
lore

Gokce Kuler

author
#0 lore raw

cover Avoid multiple line dereference

merge a line -> with a line ending with a sign

merge a line -> with a line ending with a sign

Gokce Kuler (2):
staging: rtl8712: Avoid multiple line dereference
staging: rtl8712: Avoid multiple line dereference

 drivers/staging/rtl8712/rtl871x_mlme.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/2 staging: rtl8712: Avoid multiple line dereference

merge a line -> with a line ending with a sign

Signed-off-by Gokce Kuler <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +1 -2
index cabdb35..74dac74 100644
@@ -944,8 +944,7 @@ void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf)
 			pdev_network = &(adapter->registrypriv.dev_network);
 			pibss = adapter->registrypriv.dev_network.MacAddress;
 			memcpy(pdev_network, &tgt_network->network,
-				r8712_get_wlan_bssid_ex_sz(&tgt_network->
-							network));
+				r8712_get_wlan_bssid_ex_sz(&tgt_network->network));
 			memcpy(&pdev_network->Ssid,
 				&pmlmepriv->assoc_ssid,
 				sizeof(struct ndis_802_11_ssid));
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH 1/2] staging: rtl8712: Avoid multiple line dereference

Hello!

Quoted 1 line · Gokce Kuler

merge a line -> with a line ending with a sign

What sign?

Quoted 10 lines
Signed-off-by Gokce Kuler <[email protected]>
---
  drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +0 -0
index cabdb35..74dac74 100644

drivers/staging/rtl8712/rtl871x_mlme.c void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf) · line 950

Quoted 9 lines
drivers/staging/rtl8712/rtl871x_mlme.c +1 -2
@@ -944,8 +944,7 @@ void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf)
  			pdev_network = &(adapter->registrypriv.dev_network);
  			pibss = adapter->registrypriv.dev_network.MacAddress;
  			memcpy(pdev_network, &tgt_network->network,
-				r8712_get_wlan_bssid_ex_sz(&tgt_network->
-							network));
+				r8712_get_wlan_bssid_ex_sz(&tgt_network->network));
  			memcpy(&pdev_network->Ssid,
  				&pmlmepriv->assoc_ssid,
  				sizeof(struct ndis_802_11_ssid));

MBR, Sergei

author
#3 lore raw

PATCH 2/2 staging: rtl8712: Avoid multiple line dereference

In reply to Gokce Kuler

merge a line -> with a line ending with a sign

Signed-off-by Gokce Kuler <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +1 -2
index 74dac74..7d5a50a 100644
@@ -1094,8 +1094,7 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
 			src_ssid = pmlmepriv->assoc_bssid;
 			if (!memcmp(dst_ssid, src_ssid, ETH_ALEN)) {
 				if (check_fwstate(pmlmepriv, _FW_LINKED)) {
-					if (is_same_network(&pmlmepriv->
-					    cur_network.network,
+					if (is_same_network(&pmlmepriv->cur_network.network,
 					    &pnetwork->network)) {
 						_clr_fwstate_(pmlmepriv,
 							_FW_UNDER_LINKING);
Signature · 1 line
2.7.4
maintainer
#4 lore raw
In reply to Gokce Kuler
Quoted 7 lines · Gokce Kuler

merge a line -> with a line ending with a sign

merge a line -> with a line ending with a sign

Gokce Kuler (2):
staging: rtl8712: Avoid multiple line dereference
staging: rtl8712: Avoid multiple line dereference

You should put the subsystem and driver in this 0/2 email subject as well.

But the big problem of this (have you been reading other patch submissions here?) is that you sent 2 patches that did different things, yet had the same subject line, which is not ok.

Please make them unique.

thanks,

greg k-h

maintainer
#5 lore raw
Quoted 9 lines · Greg KH
Quoted 7 lines · Gokce Kuler

merge a line -> with a line ending with a sign

merge a line -> with a line ending with a sign

Gokce Kuler (2):
staging: rtl8712: Avoid multiple line dereference
staging: rtl8712: Avoid multiple line dereference

Quoted 8 lines

You should put the subsystem and driver in this 0/2 email subject as well.

But the big problem of this (have you been reading other patch submissions here?) is that you sent 2 patches that did different things, yet had the same subject line, which is not ok.

Please make them unique.

And why is this 2 patches anyway? SHouldn't it just be 1 patch as you are doing 1 logical thing to the file?

Do not make multiple patches were a single one is all that is needed.

thanks,

greg k-h