ov5647 driver improvement
cover ov5647 driver improvement
Driver for ov5647 camera sensor lacks some important functionality, such as ability to query device format and resolution or operations with power down mode. Patches from Raspberry kernel source tree[1] fixes those issues and improves quality of mentioned driver.
[1] - https://github.com/raspberrypi/linux
Dave Stevenson (4):
media: ov5647: Add set_fmt and get_fmt calls.
media: ov5647: Add support for PWDN GPIO.
media: ov5647: Add support for non-continuous clock mode
media: ov5647: Use gpiod_set_value_cansleep
drivers/media/i2c/ov5647.c | 67 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 64 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/4 media: ov5647: Add set_fmt and get_fmt calls.
From: Dave Stevenson <[email protected]>
There's no way to query the subdevice for the supported resolutions. Add set_fmt and get_fmt implementations. Since there's only one format supported set_fmt does nothing and get returns single format.
--- drivers/media/i2c/ov5647.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
drivers/media/i2c/ov5647.c +22 -0
@@ -463,8 +463,30 @@ static int ov5647_enum_mbus_code(struct v4l2_subdev *sd,return 0 ; } +static int ov5647_set_get_fmt (struct v4l2_subdev *sd, +struct v4l2_subdev_pad_config *cfg, +struct v4l2_subdev_format *format) +{ +struct v4l2_mbus_framefmt *fmt = &format->format; + +if (format->pad !=0 ) +return -EINVAL ; + +/* Only one format is supported, so return that */ +memset (fmt,0 ,sizeof (*fmt)); + fmt->code =MEDIA_BUS_FMT_SBGGR8_1X8 ; + fmt->colorspace =V4L2_COLORSPACE_SRGB ; + fmt->field =V4L2_FIELD_NONE ; + fmt->width =640 ; + fmt->height =480 ; + +return 0 ; +} +static const struct v4l2_subdev_pad_ops ov5647_subdev_pad_ops = { .enum_mbus_code = ov5647_enum_mbus_code, + .set_fmt = ov5647_set_get_fmt, + .get_fmt = ov5647_set_get_fmt, };static const struct v4l2_subdev_ops ov5647_subdev_ops = {
Signature · 1 line
2.17.1
Re: [PATCH 1/4] media: ov5647: Add set_fmt and get_fmt calls.
Hello Roman,
Quoted 9 lines · Roman Kovalivskyi
From: Dave Stevenson <[email protected]>
There's no way to query the subdevice for the supported resolutions. Add
set_fmtandget_fmtimplementations. Since there's only one format supportedset_fmtdoes nothing and get returns single format.Signed-off-by Dave Stevenson <[email protected]>Signed-off-by Roman Kovalivskyi <[email protected]>
Looks good to me
Thanks
j
Quoted 42 lines
--- drivers/media/i2c/ov5647.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/media/i2c/ov5647.c +22
-1@@ -463,8 +463,30 @@ static int ov5647_enum_mbus_code(struct v4l2_subdev *sd,return 0 ; } +static int ov5647_set_get_fmt (struct v4l2_subdev *sd, +struct v4l2_subdev_pad_config *cfg, +struct v4l2_subdev_format *format) +{ +struct v4l2_mbus_framefmt *fmt = &format->format; + +if (format->pad !=0 ) +return -EINVAL ; + +/* Only one format is supported, so return that */ +memset (fmt,0 ,sizeof (*fmt)); + fmt->code =MEDIA_BUS_FMT_SBGGR8_1X8 ; + fmt->colorspace =V4L2_COLORSPACE_SRGB ; + fmt->field =V4L2_FIELD_NONE ; + fmt->width =640 ; + fmt->height =480 ; + +return 0 ; +} +static const struct v4l2_subdev_pad_ops ov5647_subdev_pad_ops = { .enum_mbus_code = ov5647_enum_mbus_code, + .set_fmt = ov5647_set_get_fmt, + .get_fmt = ov5647_set_get_fmt, };static const struct v4l2_subdev_ops ov5647_subdev_ops = { --2.17.1
PATCH 2/4 media: ov5647: Add support for PWDN GPIO.
In reply to Roman KovalivskyiFrom: Dave Stevenson <[email protected]>
Add support for an optional GPIO connected to PWDN on the sensor. This allows the use of hardware standby mode where internal device clock and circuit activities are halted.
Please nothe that power is off when PWDN is high.
--- drivers/media/i2c/ov5647.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
drivers/media/i2c/ov5647.c +28 -0
@@ -21,6 +21,7 @@#include <linux/clk.h> #include <linux/delay.h> +#include <linux/gpio/consumer.h> #include <linux/i2c.h> #include <linux/init.h> #include <linux/io.h>
@@ -35,6 +36,13 @@#define SENSOR_NAME "ov5647" +/* +* From the datasheet, "20ms after PWDN goes low or 20ms after RESETB goes +* high if reset is inserted after PWDN goes high, host can access sensor's +* SCCB to initialize sensor." +*/ +#define PWDN_ACTIVE_DELAY_MS 20 +#define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5)#define MIPI_CTRL00_BUS_IDLE BIT(2)#define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)
@@ -86,6 +94,7 @@ struct ov5647 {unsigned int height;int power_count;struct clk *xclk; +struct gpio_desc *pwdn; };static inline struct ov5647 *to_state (struct v4l2_subdev *sd)
@@ -355,6 +364,11 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)if (on && !ov5647->power_count) {dev_dbg (&client->dev,"OV5647 power on\n" ); +if (ov5647->pwdn) { +gpiod_set_value (ov5647->pwdn,0 ); +msleep (PWDN_ACTIVE_DELAY_MS ); + } + ret =clk_prepare_enable (ov5647->xclk);if (ret <0 ) {dev_err (&client->dev,"clk prepare enable failed\n" );
@@ -392,6 +406,8 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)dev_dbg (&client->dev,"soft stby failed\n" );clk_disable_unprepare (ov5647->xclk); + +gpiod_set_value (ov5647->pwdn,1 ); }/* Update the power count. */
@@ -603,6 +619,10 @@ static int ov5647_probe(struct i2c_client *client)return -EINVAL ; } +/* Request the power down GPIO asserted */ + sensor->pwdn =devm_gpiod_get_optional (&client->dev,"pwdn" , +GPIOD_OUT_HIGH ); +mutex_init (&sensor->lock); sd = &sensor->sd;
@@ -616,7 +636,15 @@ static int ov5647_probe(struct i2c_client *client)if (ret <0 ) goto mutex_remove; +if (sensor->pwdn) { +gpiod_set_value (sensor->pwdn,0 ); +msleep (PWDN_ACTIVE_DELAY_MS ); + } + ret =ov5647_detect (sd); + +gpiod_set_value (sensor->pwdn,1 ); +if (ret <0 ) goto error;
Signature · 1 line
2.17.1
Jacopo Mondi
maintainerRe: [PATCH 2/4] media: ov5647: Add support for PWDN GPIO.
Hi Roman,
this patch requires the device bindings document to be updated
to report an optional 'powerdown-gpios' property is available and that it's active HIGH.
Quoted 49 lines · Roman Kovalivskyi
From: Dave Stevenson <[email protected]>
Add support for an optional GPIO connected to PWDN on the sensor. This allows the use of hardware standby mode where internal device clock and circuit activities are halted.
Please nothe that power is off when PWDN is high.
Signed-off-by Dave Stevenson <[email protected]>Signed-off-by Roman Kovalivskyi <[email protected]>--- drivers/media/i2c/ov5647.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)drivers/media/i2c/ov5647.c +9
-0@@ -21,6 +21,7 @@#include <linux/clk.h> #include <linux/delay.h> +#include <linux/gpio/consumer.h> #include <linux/i2c.h> #include <linux/init.h> #include <linux/io.h> @@ -35,6 +36,13 @@#define SENSOR_NAME "ov5647" +/* +* From the datasheet, "20ms after PWDN goes low or 20ms after RESETB goes +* high if reset is inserted after PWDN goes high, host can access sensor's +* SCCB to initialize sensor." +*/ +#define PWDN_ACTIVE_DELAY_MS 20 +#define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5)#define MIPI_CTRL00_BUS_IDLE BIT(2)#define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)@@ -86,6 +94,7 @@ struct ov5647 {unsigned int height;int power_count;struct clk *xclk; +struct gpio_desc *pwdn; };static inline struct ov5647 *to_state (struct v4l2_subdev *sd)
drivers/media/i2c/ov5647.c static int ov5647_sensor_power(struct v4l2_subdev *sd, int on) · line 369
Quoted 6 lines
drivers/media/i2c/ov5647.c +3
-0@@ -355,6 +364,11 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)if (on && !ov5647->power_count) {dev_dbg (&client->dev,"OV5647 power on\n" ); +if (ov5647->pwdn) { +gpiod_set_value (ov5647->pwdn,0 ); +msleep (PWDN_ACTIVE_DELAY_MS );
please use usleep_range() according to Documentation/timers/timers-howto.rst
Thanks
j
Quoted 44 lines
drivers/media/i2c/ov5647.c +16
-1+ } + ret =clk_prepare_enable (ov5647->xclk);if (ret <0 ) {dev_err (&client->dev,"clk prepare enable failed\n" );@@ -392,6 +406,8 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)dev_dbg (&client->dev,"soft stby failed\n" );clk_disable_unprepare (ov5647->xclk); + +gpiod_set_value (ov5647->pwdn,1 ); }/* Update the power count. */ @@ -603,6 +619,10 @@ static int ov5647_probe(struct i2c_client *client)return -EINVAL ; } +/* Request the power down GPIO asserted */ + sensor->pwdn =devm_gpiod_get_optional (&client->dev,"pwdn" , +GPIOD_OUT_HIGH ); +mutex_init (&sensor->lock); sd = &sensor->sd;@@ -616,7 +636,15 @@ static int ov5647_probe(struct i2c_client *client)if (ret <0 ) goto mutex_remove; +if (sensor->pwdn) { +gpiod_set_value (sensor->pwdn,0 ); +msleep (PWDN_ACTIVE_DELAY_MS ); + } + ret =ov5647_detect (sd); + +gpiod_set_value (sensor->pwdn,1 ); +if (ret <0 ) goto error; --2.17.1
PATCH 3/4 media: ov5647: Add support for non-continuous clock mode
In reply to Roman KovalivskyiFrom: Dave Stevenson <[email protected]>
The driver was only supporting continuous clock mode although this was not stated anywhere. Non-continuous clock saves a small amount of power and on some SoCs is easier to interface with.
--- drivers/media/i2c/ov5647.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
drivers/media/i2c/ov5647.c +14 -3
@@ -44,6 +44,7 @@#define PWDN_ACTIVE_DELAY_MS 20#define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5) +#define MIPI_CTRL00_LINE_SYNC_ENABLE BIT(4)#define MIPI_CTRL00_BUS_IDLE BIT(2)#define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)
@@ -95,6 +96,7 @@ struct ov5647 {int power_count;struct clk *xclk;struct gpio_desc *pwdn; +unsigned int flags; };static inline struct ov5647 *to_state (struct v4l2_subdev *sd)
@@ -269,9 +271,15 @@ static int ov5647_set_virtual_channel(struct v4l2_subdev *sd, int channel)static int ov5647_stream_on (struct v4l2_subdev *sd) { +struct ov5647 *ov5647 =to_state (sd); +u8 val =MIPI_CTRL00_BUS_IDLE ;int ret; - ret =ov5647_write (sd,OV5647_REG_MIPI_CTRL00 ,MIPI_CTRL00_BUS_IDLE ); +if (ov5647->flags &V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ) + val |=MIPI_CTRL00_CLOCK_LANE_GATE | +MIPI_CTRL00_LINE_SYNC_ENABLE ; + + ret =ov5647_write (sd,OV5647_REG_MIPI_CTRL00 , val);if (ret <0 )return ret;
@@ -568,7 +576,7 @@ static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = { .open = ov5647_open, }; -static int ov5647_parse_dt (struct device_node *np) +static int ov5647_parse_dt (struct device_node *np,struct ov5647 *sensor) {struct v4l2_fwnode_endpoint bus_cfg = { .bus_type =0 };struct device_node *ep;
@@ -581,6 +589,9 @@ static int ov5647_parse_dt(struct device_node *np) ret =v4l2_fwnode_endpoint_parse (of_fwnode_handle (ep), &bus_cfg); +if (!ret) + sensor->flags = bus_cfg.bus.mipi_csi2.flags; +of_node_put (ep);return ret; }
@@ -599,7 +610,7 @@ static int ov5647_probe(struct i2c_client *client)return -ENOMEM ;if (IS_ENABLED (CONFIG_OF ) && np) { - ret =ov5647_parse_dt (np); + ret =ov5647_parse_dt (np, sensor);if (ret) {dev_err (dev,"DT parsing error: %d\n" , ret);return ret;
Signature · 1 line
2.17.1
Jacopo Mondi
maintainerRe: [PATCH 3/4] media: ov5647: Add support for non-continuous clock mode
Hi Roman,
Quoted 6 lines · Roman Kovalivskyi
From: Dave Stevenson <[email protected]>
The driver was only supporting continuous clock mode although this was not stated anywhere. Non-continuous clock saves a small amount of power and on some SoCs is easier to interface with.
As per the previous patch, you should update bindings reporting this property is now optionally supported
Quoted 45 lines
Signed-off-by Dave Stevenson <[email protected]>Signed-off-by Roman Kovalivskyi <[email protected]>--- drivers/media/i2c/ov5647.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)drivers/media/i2c/ov5647.c +9
-1@@ -44,6 +44,7 @@#define PWDN_ACTIVE_DELAY_MS 20#define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5) +#define MIPI_CTRL00_LINE_SYNC_ENABLE BIT(4)#define MIPI_CTRL00_BUS_IDLE BIT(2)#define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)@@ -95,6 +96,7 @@ struct ov5647 {int power_count;struct clk *xclk;struct gpio_desc *pwdn; +unsigned int flags; };static inline struct ov5647 *to_state (struct v4l2_subdev *sd)@@ -269,9 +271,15 @@ static int ov5647_set_virtual_channel(struct v4l2_subdev *sd, int channel)static int ov5647_stream_on (struct v4l2_subdev *sd) { +struct ov5647 *ov5647 =to_state (sd); +u8 val =MIPI_CTRL00_BUS_IDLE ;int ret; - ret =ov5647_write (sd,OV5647_REG_MIPI_CTRL00 ,MIPI_CTRL00_BUS_IDLE ); +if (ov5647->flags &V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ) + val |=MIPI_CTRL00_CLOCK_LANE_GATE | +MIPI_CTRL00_LINE_SYNC_ENABLE ; + + ret =ov5647_write (sd,OV5647_REG_MIPI_CTRL00 , val);if (ret <0 )return ret;
drivers/media/i2c/ov5647.c static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = { · line 579
Quoted 5 lines
drivers/media/i2c/ov5647.c +1
-1@@ -568,7 +576,7 @@ static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = { .open = ov5647_open, }; -static int ov5647_parse_dt (struct device_node *np) +static int ov5647_parse_dt (struct device_node *np,struct ov5647 *sensor)
nit: I would provide the driver structure first
drivers/media/i2c/ov5647.c static int ov5647_parse_dt(struct device_node *np) · line 594
Quoted 10 lines
drivers/media/i2c/ov5647.c +3
-0{struct v4l2_fwnode_endpoint bus_cfg = { .bus_type =0 };struct device_node *ep;@@ -581,6 +589,9 @@ static int ov5647_parse_dt(struct device_node *np) ret =v4l2_fwnode_endpoint_parse (of_fwnode_handle (ep), &bus_cfg); +if (!ret) + sensor->flags = bus_cfg.bus.mipi_csi2.flags; +
There is a huge space for improvements here, this function didn't do anything before this.
I would:
check the v4l2_fwnode_endpoint_parse() return value, and put(np) and fail loudly
make sure the detected bus type is CSI-2
cache the flags as you're doing here. As you're only interested in clock continuous you could store only that information in your driver structure.
Quoted 15 lines
drivers/media/i2c/ov5647.c +1
-2of_node_put (ep);return ret; }@@ -599,7 +610,7 @@ static int ov5647_probe(struct i2c_client *client)return -ENOMEM ;if (IS_ENABLED (CONFIG_OF ) && np) { - ret =ov5647_parse_dt (np); + ret =ov5647_parse_dt (np, sensor);if (ret) {dev_err (dev,"DT parsing error: %d\n" , ret);return ret; --2.17.1
Sakari Ailus
maintainerRe: [PATCH 3/4] media: ov5647: Add support for non-continuous clock mode
In reply to Roman KovalivskyiHi Roman,
Quoted 51 lines · Roman Kovalivskyi
From: Dave Stevenson <[email protected]>
The driver was only supporting continuous clock mode although this was not stated anywhere. Non-continuous clock saves a small amount of power and on some SoCs is easier to interface with.
Signed-off-by Dave Stevenson <[email protected]>Signed-off-by Roman Kovalivskyi <[email protected]>--- drivers/media/i2c/ov5647.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)drivers/media/i2c/ov5647.c +9
-1@@ -44,6 +44,7 @@#define PWDN_ACTIVE_DELAY_MS 20#define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5) +#define MIPI_CTRL00_LINE_SYNC_ENABLE BIT(4)#define MIPI_CTRL00_BUS_IDLE BIT(2)#define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)@@ -95,6 +96,7 @@ struct ov5647 {int power_count;struct clk *xclk;struct gpio_desc *pwdn; +unsigned int flags; };static inline struct ov5647 *to_state (struct v4l2_subdev *sd)@@ -269,9 +271,15 @@ static int ov5647_set_virtual_channel(struct v4l2_subdev *sd, int channel)static int ov5647_stream_on (struct v4l2_subdev *sd) { +struct ov5647 *ov5647 =to_state (sd); +u8 val =MIPI_CTRL00_BUS_IDLE ;int ret; - ret =ov5647_write (sd,OV5647_REG_MIPI_CTRL00 ,MIPI_CTRL00_BUS_IDLE ); +if (ov5647->flags &V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ) + val |=MIPI_CTRL00_CLOCK_LANE_GATE | +MIPI_CTRL00_LINE_SYNC_ENABLE ; + + ret =ov5647_write (sd,OV5647_REG_MIPI_CTRL00 , val);if (ret <0 )return ret;
drivers/media/i2c/ov5647.c static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = { · line 581
Quoted 7 lines
drivers/media/i2c/ov5647.c +1
-1@@ -568,7 +576,7 @@ static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = { .open = ov5647_open, }; -static int ov5647_parse_dt (struct device_node *np) +static int ov5647_parse_dt (struct device_node *np,struct ov5647 *sensor) {struct v4l2_fwnode_endpoint bus_cfg = { .bus_type =0 };
The bus type should be set to V4L2_MBUS_CSI2_DPHY here; 0 is just for compatibility with the old heuristics.
Quoted 20 lines
drivers/media/i2c/ov5647.c +4
-1struct device_node *ep;@@ -581,6 +589,9 @@ static int ov5647_parse_dt(struct device_node *np) ret =v4l2_fwnode_endpoint_parse (of_fwnode_handle (ep), &bus_cfg); +if (!ret) + sensor->flags = bus_cfg.bus.mipi_csi2.flags; +of_node_put (ep);return ret; }@@ -599,7 +610,7 @@ static int ov5647_probe(struct i2c_client *client)return -ENOMEM ;if (IS_ENABLED (CONFIG_OF ) && np) { - ret =ov5647_parse_dt (np); + ret =ov5647_parse_dt (np, sensor);if (ret) {dev_err (dev,"DT parsing error: %d\n" , ret);return ret;
Signature · 3 lines
Kind regards, Sakari Ailus
PATCH 4/4 media: ov5647: Use gpiod_set_value_cansleep
In reply to Roman KovalivskyiFrom: Dave Stevenson <[email protected]>
All calls to the gpio library are in contexts that can sleep, therefore there is no issue with having those GPIOs controlled by controllers which require sleeping (eg I2C GPIO expanders).
Switch to using gpiod_set_value_cansleep instead of gpiod_set_value to avoid triggering the warning in gpiolib should the GPIO controller need to sleep.
--- drivers/media/i2c/ov5647.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/i2c/ov5647.c +4 -4
@@ -373,7 +373,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)dev_dbg (&client->dev,"OV5647 power on\n" );if (ov5647->pwdn) { -gpiod_set_value (ov5647->pwdn,0 ); +gpiod_set_value_cansleep (ov5647->pwdn,0 );msleep (PWDN_ACTIVE_DELAY_MS ); }
@@ -415,7 +415,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)clk_disable_unprepare (ov5647->xclk); -gpiod_set_value (ov5647->pwdn,1 ); +gpiod_set_value_cansleep (ov5647->pwdn,1 ); }/* Update the power count. */
@@ -648,13 +648,13 @@ static int ov5647_probe(struct i2c_client *client) goto mutex_remove;if (sensor->pwdn) { -gpiod_set_value (sensor->pwdn,0 ); +gpiod_set_value_cansleep (sensor->pwdn,0 );msleep (PWDN_ACTIVE_DELAY_MS ); } ret =ov5647_detect (sd); -gpiod_set_value (sensor->pwdn,1 ); +gpiod_set_value_cansleep (sensor->pwdn,1 );if (ret <0 ) goto error;
Signature · 1 line
2.17.1
Sakari Ailus
maintainerRe: [PATCH 4/4] media: ov5647: Use gpiod_set_value_cansleep
Hi Roman,
Quoted 6 lines · Roman Kovalivskyi
From: Dave Stevenson <[email protected]>
All calls to the gpio library are in contexts that can sleep, therefore there is no issue with having those GPIOs controlled by controllers which require sleeping (eg I2C GPIO expanders).
Quoted 6 lines
Switch to using
gpiod_set_value_cansleepinstead ofgpiod_set_valueto avoid triggering the warning in gpiolib should the GPIO controller need to sleep.Signed-off-by Dave Stevenson <[email protected]>Signed-off-by Roman Kovalivskyi <[email protected]>
This should be merged with the second patch.
Quoted 45 lines
--- drivers/media/i2c/ov5647.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/media/i2c/ov5647.c +4
-4@@ -373,7 +373,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)dev_dbg (&client->dev,"OV5647 power on\n" );if (ov5647->pwdn) { -gpiod_set_value (ov5647->pwdn,0 ); +gpiod_set_value_cansleep (ov5647->pwdn,0 );msleep (PWDN_ACTIVE_DELAY_MS ); }@@ -415,7 +415,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)clk_disable_unprepare (ov5647->xclk); -gpiod_set_value (ov5647->pwdn,1 ); +gpiod_set_value_cansleep (ov5647->pwdn,1 ); }/* Update the power count. */ @@ -648,13 +648,13 @@ static int ov5647_probe(struct i2c_client *client) goto mutex_remove;if (sensor->pwdn) { -gpiod_set_value (sensor->pwdn,0 ); +gpiod_set_value_cansleep (sensor->pwdn,0 );msleep (PWDN_ACTIVE_DELAY_MS ); } ret =ov5647_detect (sd); -gpiod_set_value (sensor->pwdn,1 ); +gpiod_set_value_cansleep (sensor->pwdn,1 );if (ret <0 ) goto error;Signature · 1 line
2.17.1
Signature · 1 line
Sakari Ailus