Skip to contentSkip to conversation

fix TSO problem

PATCH Applied Xiaoyun wang 2 participants 3 messages May 20, 2020 – May 21, 2020 Network drivers

lore
Share & tools
lore

Xiaoyun wang

author
#0 lore raw

cover fix TSO problem

This patch fixes TSO problem, when TSO mss is smaller than 80, and the sum length of continus sge num is larger than a mss, which may cause hardware failed, so in this scenarios pmd driver should adjust the tso_segsz with the same with the value of hardware supported.

--
v1:
- fix TSO problem

Xiaoyun wang (1):
net/hinic: fix TSO problem

 drivers/net/hinic/hinic_pmd_tx.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.3.1
author
#1 lore raw

PATCH 1/1 net/hinic: fix TSO problem

When TSO mss is smaller than 80, and the sum length of continus sge num is larger than a mss, which may cause hardware failed, so in this scenarios pmd driver should adjust the tso_segsz with the same with the value of hardware supported.

Fixes 076221c8fe1d ("net/hinic: add Rx/Tx")
Cc [email protected]
Signed-off-by Xiaoyun wang <[email protected]>
---
 drivers/net/hinic/hinic_pmd_tx.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/hinic/hinic_pmd_tx.c +5 -3
index bd39f93..4d99967 100644
@@ -455,7 +455,7 @@ static inline bool hinic_is_tso_sge_valid(struct rte_mbuf *mbuf,
 					  *poff_info,
 					  struct hinic_wqe_info *sqe_info)
 {
-	u32 total_len, limit_len, checked_len, left_len;
+	u32 total_len, limit_len, checked_len, left_len, adjust_mss;
 	u32 i, first_mss_sges, left_sges;
 	struct rte_mbuf *mbuf_head, *mbuf_pre;
 

@@ -465,7 +465,9 @@ static inline bool hinic_is_tso_sge_valid(struct rte_mbuf *mbuf,
 	/* tso sge number validation */
 	if (unlikely(left_sges >= HINIC_NONTSO_PKT_MAX_SGE)) {
 		checked_len = 0;
-		limit_len = mbuf->tso_segsz + poff_info->payload_offset;
+		adjust_mss = mbuf->tso_segsz >= TX_MSS_MIN ?
+				mbuf->tso_segsz : TX_MSS_MIN;
+		limit_len = adjust_mss + poff_info->payload_offset;
 		first_mss_sges = HINIC_NONTSO_PKT_MAX_SGE;
 
 		/* each continues 17 mbufs segmust do one check */

@@ -479,7 +481,7 @@ static inline bool hinic_is_tso_sge_valid(struct rte_mbuf *mbuf,
 				mbuf_pre = mbuf;
 				mbuf = mbuf->next;
 				if (total_len >= limit_len) {
-					limit_len = mbuf_head->tso_segsz;
+					limit_len = adjust_mss;
 					break;
 				}
 			}
Signature · 1 line
1.8.3.1
Applied
#2 lore raw

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic: fix TSO problem

Quoted 9 lines · Xiaoyun wang

When TSO mss is smaller than 80, and the sum length of continus sge num is larger than a mss, which may cause hardware failed, so in this scenarios pmd driver should adjust the tso_segsz with the same with the value of hardware supported.

Fixes 076221c8fe1d ("net/hinic: add Rx/Tx")
Cc [email protected]
Signed-off-by Xiaoyun wang <[email protected]>

Applied to dpdk-next-net/master, thanks.