Support for tft displays based on ilitek,ili9488
Subsystems (4)
cover Support for tft displays based on ilitek,ili9488
The goal of this series is to get the displays based on ilitek,ili9488 working.
Eastrising,er-tft035-6 is a display based on ilitek,ili9488
Kamlesh Gurudasani (3):
dt-bindings: add vendor prefix for EastRising Technology Co.,Ltd
dt-bindings: add binding for Ilitek ili9488 based display panels drm/tiny: add support for tft displays based on ilitek,ili9488
.../bindings/display/ilitek,ili9488.yaml | 71 ++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 7 + drivers/gpu/drm/tiny/Kconfig | 13 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9488.c | 446 +++++++++++++++++++++ 6 files changed, 540 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9488.yaml create mode 100644 drivers/gpu/drm/tiny/ili9488.c
Signature · 1 line
2.7.4
PATCH 1/3 dt-bindings: add vendor prefix for EastRising Technology Co., Ltd
Add vendor prefix for display manufacturer company EastRising Technology Co.,Ltd
[1]https://eastrising.en.ec21.com/
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -279,6 +279,8 @@ patternProperties: description: Dyna-Image "^ea,.*": description: Embedded Artists AB + "^eastrising,.*": + description: EastRising Technology Co.,Ltd "^ebs-systart,.*": description: EBS-SYSTART GmbH "^ebv,.*":
Signature · 1 line
2.7.4
PATCH 2/3 dt-bindings: add binding for Ilitek ili9488 based display panels
In reply to Kamlesh GurudasaniThis adds binding for ilitek,ili9488 based display panels
--- .../bindings/display/ilitek,ili9488.yaml | 71 ++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9488.yaml
Documentation/devicetree/bindings/display/ilitek,ili9488.yaml new file +71 -0
@@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/ilitek,ili9488.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ilitek ILI9488 display panels device tree bindings + +maintainers: + - Kamlesh Gurudasani <[email protected]> + +description: + This binding is for display panels using an Ilitek ILI9488 controller in SPI + mode. + +allOf: + - $ref: panel/panel-common.yaml# + +properties: + compatible: + items: + - enum: + # Eastrising 3.5" 320x480 Color TFT LCD + - eastrising,er-tft035-6 + - const: ilitek,ili9488 + + spi-max-frequency: + maximum: 32000000 + + dc-gpios: + maxItems: 1 + description: Display data/command selection (D/CX) + + backlight: true + reg: true + reset-gpios: true + rotation: true + +required: + - compatible + - reg + - dc-gpios + - reset-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; + }; + spi { + #address-cells = <1>; + #size-cells = <0>; + + + display@0{ + compatible = "eastrising,er-tft035-6", "ilitek,ili9488"; + reg = <0>; + spi-max-frequency = <32000000>; + dc-gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>; + rotation = <90>; + backlight = <&backlight>; + }; + }; + +...
Signature · 1 line
2.7.4
PATCH 3/3 drm/tiny: add support for tft displays based on ilitek, ili9488
In reply to Kamlesh GurudasaniThis adds support fot ilitek,ili9488 based displays with 4 wire spi interface. In 4 wire spi mode, ili9488 only supports 18 bit per pixel.
Eastrising,er-tft035-6 is a display based on ilitek,ili9488 with 4 wire spi interface.
--- MAINTAINERS | 7 + drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9488.c | 446 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 467 insertions(+) create mode 100644 drivers/gpu/drm/tiny/ili9488.c
MAINTAINERS +7 -0
@@ -5329,6 +5329,13 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/ilitek,ili9486.yaml F: drivers/gpu/drm/tiny/ili9486.c +DRM DRIVER FOR ILITEK ILI9488 PANELS +M: Kamlesh Gurudasani <[email protected]> +S: Maintained +T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/ilitek,ili9488.yaml +F: drivers/gpu/drm/tiny/ili9488.c + DRM DRIVER FOR INTEL I810 VIDEO CARDS S: Orphan / Obsolete F: drivers/gpu/drm/i810/
drivers/gpu/drm/tiny/Kconfig +13 -0
@@ -80,6 +80,19 @@ config TINYDRM_ILI9486 If M is selected the module will be called ili9486. +config TINYDRM_ILI9488 + tristate "DRM support for ILI9488 display panels" + depends on DRM && SPI + select DRM_KMS_HELPER + select DRM_KMS_CMA_HELPER + select DRM_MIPI_DBI + select BACKLIGHT_CLASS_DEVICE + help + DRM driver for the following Ilitek ILI9488 panels: + * ER-TFT035-6 3.5" 320x480 TFT (EastRising 3.5") + + If M is selected the module will be called ili9488. + config TINYDRM_MI0283QT tristate "DRM support for MI0283QT" depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +1 -0
@@ -6,6 +6,7 @@ obj-$(CONFIG_TINYDRM_HX8357D) += hx8357d.o obj-$(CONFIG_TINYDRM_ILI9225) += ili9225.o obj-$(CONFIG_TINYDRM_ILI9341) += ili9341.o obj-$(CONFIG_TINYDRM_ILI9486) += ili9486.o +obj-$(CONFIG_TINYDRM_ILI9488) += ili9488.o obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o obj-$(CONFIG_TINYDRM_REPAPER) += repaper.o obj-$(CONFIG_TINYDRM_ST7586) += st7586.o
drivers/gpu/drm/tiny/ili9488.c new file +446 -0
446 lines not on this page · raw message
Signature · 1 line
2.7.4
kernel test robot
build botRe: [PATCH 3/3] drm/tiny: add support for tft displays based on ilitek,ili9488
I love your patch! Yet something to improve:
Hi Kamlesh,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on drm-intel/for-linux-next linus/master v5.7 next-20200613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kamlesh-Gurudasani/Support-for-tft-displays-based-on-ilitek-ili9488/20200613-221019 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/gpu/drm/tiny/ili9488.c:322:2: error: 'DRM_GEM_CMA_DRIVER_OPS_VMAP' undeclared here (not in a function) 322 | DRM_GEM_CMA_DRIVER_OPS_VMAP, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/tiny/ili9488.c: In function 'ili9488_probe': >> drivers/gpu/drm/tiny/ili9488.c:354:11: error: implicit declaration of function 'devm_drm_dev_alloc'; did you mean 'drm_dev_alloc'? [-Werror=implicit-function-declaration] 354 | dbidev = devm_drm_dev_alloc(dev, &ili9488_driver, | ^~~~~~~~~~~~~~~~~~ | drm_dev_alloc >> drivers/gpu/drm/tiny/ili9488.c:355:9: error: expected expression before 'struct'
355 | struct mipi_dbi_dev, drm);
| ^~~~~~
cc1: some warnings being treated as errors
vim +/DRM_GEM_CMA_DRIVER_OPS_VMAP +322 drivers/gpu/drm/tiny/ili9488.c
318
319 static struct drm_driver ili9488_driver = {
320 .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
321 .fops = &ili9488_fops,
> 322 DRM_GEM_CMA_DRIVER_OPS_VMAP,
323 .debugfs_init = mipi_dbi_debugfs_init,
324 .name = "ili9488",
325 .desc = "Ilitek ILI9488",
326 .date = "20200607",
327 .major = 1,
328 .minor = 0,
329 };
330
331 static const struct of_device_id ili9488_of_match[] = {
332 { .compatible = "eastrising,er-tft035-6" },
333 { }
334 };
335 MODULE_DEVICE_TABLE(of, ili9488_of_match);
336
337 static const struct spi_device_id ili9488_id[] = {
338 { "er-tft035-6", 0 },
339 { }
340 };
341 MODULE_DEVICE_TABLE(spi, ili9488_id);
342
343 static int ili9488_probe(struct spi_device *spi)
344 {
345 struct device *dev = &spi->dev;
346 struct mipi_dbi_dev *dbidev;
347 struct drm_device *drm;
348 struct mipi_dbi *dbi;
349 struct gpio_desc *dc;
350 u32 rotation = 0;
351 size_t bufsize;
352 int ret;
353
> 354 dbidev = devm_drm_dev_alloc(dev, &ili9488_driver,
> 355 struct mipi_dbi_dev, drm);
356 if (IS_ERR(dbidev))
357 return PTR_ERR(dbidev);
358
359 dbi = &dbidev->dbi;
360 drm = &dbidev->drm;
361
362 ret = devm_drm_dev_init(dev, drm, &ili9488_driver);
363 if (ret) {
364 kfree(dbidev);
365 return ret;
366 }
367
368 drm_mode_config_init(drm);
369
370 bufsize = ili9488_mode.vdisplay * ili9488_mode.hdisplay * 3;
371
372 dbi->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
373 if (IS_ERR(dbi->reset)) {
374 DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n");
375 return PTR_ERR(dbi->reset);
376 }
377
378 dc = devm_gpiod_get(dev, "dc", GPIOD_OUT_LOW);
379 if (IS_ERR(dc)) {
380 DRM_DEV_ERROR(dev, "Failed to get gpio 'dc'\n");
381 return PTR_ERR(dc);
382 }
383
384 dbidev->backlight = devm_of_find_backlight(dev);
385 if (IS_ERR(dbidev->backlight))
386 return PTR_ERR(dbidev->backlight);
387
388 device_property_read_u32(dev, "rotation", &rotation);
389
390 ret = mipi_dbi_spi_init(spi, dbi, dc);
391 if (ret)
392 return ret;
393
394 dbidev->drm.mode_config.preferred_depth = 16;
395
396 ret = mipi_dbi_dev_init_with_formats(dbidev, &ili9488_pipe_funcs,
397 ili9488_formats,
398 ARRAY_SIZE(ili9488_formats),
399 &ili9488_mode, rotation, bufsize); 400 if (ret)
401 return ret;
402
403 drm_mode_config_reset(drm);
404
405 ret = drm_dev_register(drm, 0);
406 if (ret)
407 return ret;
408
409 spi_set_drvdata(spi, drm);
410
411 drm_fbdev_generic_setup(drm, 0);
412
413 return 0;
414 }
415
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Re: [PATCH 1/3] dt-bindings: add vendor prefix for EastRising Technology Co., Ltd
In reply to Kamlesh GurudasaniQuoted 10 lines · Kamlesh Gurudasani
Add vendor prefix for display manufacturer company EastRising Technology Co.,Ltd
[1]https://eastrising.en.ec21.com/
Signed-off-by Kamlesh Gurudasani <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/3] dt-bindings: add binding for Ilitek ili9488 based display panels
In reply to Kamlesh GurudasaniQuoted 8 lines · Kamlesh Gurudasani
This adds binding for ilitek,ili9488 based display panels
Signed-off-by Kamlesh Gurudasani <[email protected]>--- .../bindings/display/ilitek,ili9488.yaml | 71 ++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9488.yaml
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel