Skip to contentSkip to conversation

gpio: Add support for the PCAL9535

PATCH In review Jan Kiszka 3 participants 6 messages Jun 15, 2020 – Jun 16, 2020

Subsystems (2)
Device tree bindings GPIO
lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

v3 cover gpio: Add support for the PCAL9535

Changes in v3:
- extend also I2C table
- tag "Datasheet:" in commit log

Changes in v2:
- add dt binding update

Jan

Jan Kiszka (2):
dt-bindings: gpio: pca953x: add nxp,pcal9535
gpio: pca953x: Add support for the PCAL9535

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 drivers/gpio/gpio-pca953x.c                             | 2 ++
 2 files changed, 3 insertions(+)
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH v3 1/2 dt-bindings: gpio: pca953x: add nxp,pcal9535

From: Jan Kiszka <[email protected]>

The NXP PCAL9535 is an extended variant of the PCA9535.

Signed-off-by Jan Kiszka <[email protected]>
---
 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca953x.txt +1 -0
index dab537c20def..3126c3817e2a 100644
@@ -19,6 +19,7 @@ Required properties:
 	nxp,pca9698
 	nxp,pcal6416
 	nxp,pcal6524
+	nxp,pcal9535
 	nxp,pcal9555a
 	maxim,max7310
 	maxim,max7312
Signature · 1 line
2.26.2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535

pon., 15 cze 2020 o 15:22 Jan Kiszka <[email protected]> napisał(a):

Quoted 23 lines

From: Jan Kiszka <[email protected]>

The NXP PCAL9535 is an extended variant of the PCA9535.

Signed-off-by Jan Kiszka <[email protected]>
---
 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca953x.txt +1 -1
index dab537c20def..3126c3817e2a 100644
@@ -19,6 +19,7 @@ Required properties:
        nxp,pca9698
        nxp,pcal6416
        nxp,pcal6524
+       nxp,pcal9535
        nxp,pcal9555a
        maxim,max7310
        maxim,max7312
--
Quoted 2 lines

2.26.2

Patch applied with Andy's review tag.

Bart

author
#3 lore raw

PATCH v3 2/2 gpio: pca953x: Add support for the PCAL9535

In reply to Jan Kiszka

From: Jan Kiszka <[email protected]>

The PCAL9535 is compatible to the PCA9535. Additionally, it comes with interrupt support and input latching. Other features are not supported by the GPIO subsystem.

Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Signed-off-by Jan Kiszka <[email protected]>
---
 drivers/gpio/gpio-pca953x.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/gpio-pca953x.c +2 -0
index 1fca8dd7824f..cd5fb522563e 100644
@@ -89,6 +89,7 @@ static const struct i2c_device_id pca953x_id[] = {
 
 	{ "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
+	{ "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 
 	{ "max7310", 8  | PCA953X_TYPE, },

@@ -1145,6 +1146,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 
 	{ .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
+	{ .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },
 
 	{ .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
Signature · 1 line
2.26.2
#4 lore raw

Re: [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535

pon., 15 cze 2020 o 15:22 Jan Kiszka <[email protected]> napisał(a):

Quoted 35 lines

From: Jan Kiszka <[email protected]>

The PCAL9535 is compatible to the PCA9535. Additionally, it comes with interrupt support and input latching. Other features are not supported by the GPIO subsystem.

Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Signed-off-by Jan Kiszka <[email protected]>
---
 drivers/gpio/gpio-pca953x.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/gpio-pca953x.c +2 -1
index 1fca8dd7824f..cd5fb522563e 100644
@@ -89,6 +89,7 @@ static const struct i2c_device_id pca953x_id[] = {
 
        { "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
        { "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
+       { "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
        { "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 
        { "max7310", 8  | PCA953X_TYPE, },

@@ -1145,6 +1146,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 
        { .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
        { .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
+       { .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
        { .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },
 
        { .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
--
Quoted 2 lines

2.26.2

Patch applied with Andy's review tag.

Bart

Reviewed-by on the v3 series
#5 lore raw
In reply to Jan Kiszka
Quoted 4 lines · Jan Kiszka

Changes in v3:
- extend also I2C table
- tag "Datasheet:" in commit log

Reviewed-by Andy Shevchenko <[email protected]>

Thanks!

Quoted 17 lines

Changes in v2:
- add dt binding update

Jan

Jan Kiszka (2):
dt-bindings: gpio: pca953x: add nxp,pcal9535
gpio: pca953x: Add support for the PCAL9535

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 drivers/gpio/gpio-pca953x.c                             | 2 ++
 2 files changed, 3 insertions(+)

--
2.26.2

Signature · 2 lines
With Best Regards,
Andy Shevchenko